I've put the ones I think are more important in the next fix version
warp
12 sounds like a lot of work.
the others shouldn't be.
nikki
and 17 XD
I think that was everything...
now to upload stuff! :D
warp
I'm leaving 12 and 17 unassigned
nikki nods
the other's I will try to fix tomorrow.
nikki
great :)
warp
s/'//
warp runs off to get some dinner
nikki
and thanks :D
nikki is super excite
d
warp
:)
nikki
warp: assigned 18 to you too
bitmap
ianmcorvidae: (in case you don't see the chatlog) there's two postgres queries on rika that need killing (9212, 9359)
ianmcorvidae: although it'd be nice to figure out why they're stalled, because this is a common occurrence :/
aaaand now there's three. they seem to be spawned whenever I try to load a release group page (the query is from load_for_release_groups in lib/MusicBrainz/Server/Data/Artwork.pm)
no slowdown error when I try it now, so I guess I missed it :(
nikki tries again
nikki
is there a way I can find out what it's returning when it gets stuck?
(I mean, so you know what it should be looking for)
warp
I'd like to know what headers and status code it is returning
you'd have to open the developer tools of your browser (before the request) and go to the network tab.
nikki
the status code should be 503
warp
ah, indeed.
but the question is whether that 503 makes it to the javascript. if the slowdown doesn't have CORS headers then it will be difficult to deal with it properly.
but I should just fake a 503 tomorrow with and without CORS headers and check if it deals with either of them properly.
kepstin-work
there should be some event fired due to the request failure...
nikki
I seem to have found the network stuff
I'll keep an eye out
warp
kepstin-work: if the request is denied because of CORS the browser gives you no information at all. it wouldn't surprise me if no event fired.
but anyway, I'll simulate it tomorrow.
right now I'm going back to the big blue room.
kepstin-work
hmm. the cors check is supposed to be done via a HEAD request prior to doing the real request tho
isn't it?
so the upload won't run unless the cors check already passed
kepstin-work could be wrong :)
warp
kepstin-work: if the response to the HEAD request had CORS headers that doesn't mean the slowdown response also has CORS headers.
any response without CORS headers is something the browser will stay silent about, it will not inform javascript of those response because javascript does not have permission to know.
kepstin-work
hmm, you're right, it is supposed to revalidate the access control headers on the response to the real request
according to the cors spec, failing a cors check is supposed to act in the same way as if a network error occurred and the server couldn't be contacted. i think.
(it would probably be worth testing the ajax uploader with an unreachable/offline server too, since that theoretically should use the same error path, I think...)
so instead of having a huge text_strings.tt that we have to manually edit, we could extract the strings directly from the javascript and convert the .po files to json
which I imagine could be cached the same way text_strings.tt is, if we wanted
ianmcorvidae
ocharles: lolo can connect to rika, is what I'd meant, reading the conversation -- reverse tunnel lolo -> rika and then nikki can do a normal forward tunnel to rika
nikki
we just used /etc/hosts
ianmcorvidae
it looks like it's set, yeah
but for everyone's future reference, the way it works is that non-rika stuff can connect to rika but not the other way around
e.g. the way I get data dumps onto it is I log into scooby and scp them from scooby -- can't do it from rika, since it can't connect that direction