#musicbrainz-devel

/

      • Ben\Sput joined the channel
      • ocharles
        just waiting for it to start
      • Freso
        Where is the script that replaces e-mail addresses in .po files with "email address hidden"? `git grep`'ing for that string only returns the .po files. :/
      • ocharles
        warp: astro done
      • warp
        ocharles: astro back, asterix out.
      • ocharles
        warp: asterix done
      • warp
        ok, all back!
      • warp clicks around.
      • seems to be working :)
      • ocharles
        goodo
      • time to nuke a load of cover art
      • CatCat
        [21:21] FresoMy TTS works just fine, thank you.
      • CatCat read that first as "my tits works fine"
      • :P
      • ocharles
        warp: you didn't answer my question (to luks) about where I'm meant to be reviewing oauth
      • Freso
        ocharles: If you want to be conventional, review on review board. If you want to play with the reviewing process on GitHub, review on GitHub.
      • ocharles: Though I think GitHub has the newer code.
      • So probably GitHub.
      • ocharles
        Freso: obviously, I'd like to know what I'm meant to be doing though
      • Freso
        ocharles: ^
      • :)
      • zas
        ocharles: are you original author of the cover art plugin that was integrated in Picard recently ?
      • ocharles
        zas: not quite original, i did some work right at the start of it though I think
      • zas
        ocharles: ok, i'm currently working on this part
      • well, on covert art + Picard
      • i'm experimenting a disk cache to prevent useless downloads from cover art providers
      • ocharles
        sounds like a good idea
      • zas
        https://github.com/zas/picard/tree/image_cache
      • it needs a lot of review, i'm a python newbie
      • reosarevok sees a *very* interesting-looking mail in info@
      • reosarevok
        Think Rob will like it too :)
      • luks
        zas: what's the purpose of the disk cache?
      • it seems like a feature that is useful for developers, but not so much for normal users
      • zas
        to prevent downloads of images that were already downloaded recently
      • ocharles
        reosarevok: interesting indeed :)
      • luks
        zas: if I'm loading my files to picard again, I do it for the purpose of updating them
      • it doesn't make much sense to use cache in that case
      • Freso
        luks: +1
      • zas
        luks: yes, but do you need to re-download same files ?
      • imho you are missing the point
      • Freso
        zas: He's asking about the point because he doesn't see it.
      • luks
        zas: how do you cache the files? use a fixed timeout, or using something like etag?
      • Freso
        zas: Stating that he's missing it... is rather obvious. :)
      • zas
        for now fixed time, but the best would be to simply honor http cache control
      • the thing is that picard is just ignoring all this stuff
      • ie. CAA set 21600 (6 hours) ttl on images
      • luks
        zas: if you want to use cache, enable caching on QNetworkManager level
      • zas
        how ?
      • luks
        http://doc.qt.digia.com/qt/qnetworkaccessmanage...
      • zas
        hmm interesting
      • nikki
        Freso: btw https://github.com/96187/musicbrainz-server/blo...
      • luks
        but I don't consider somebody who loads already tagged files to picard within 6 hours a normal user
      • Freso
        nikki: Thank you!
      • luks
        I can't really see the use case for doing that
      • Freso
        If I load already tagged files in Picard within 6 hours, it's because I've updated the data - and possibly the cover art - and want to refresh it.
      • zas
        Freso: in this case, images will be refreshed
      • it just prevents to download same image more than once
      • nikki
        I could see the people who attempt to drop their entire library into picard loading stuff within 6 hours (after picard crashed :P)
      • Freso
        zas: But if I already saved the cover art, it will already be on disc as cover.jpg. No need to store it twice, surely?
      • zas
        afk, bbsoon
      • Freso
        (I do want to get rid ov "cover (N).jpg" though. :))
      • luks
        I also don't like this being an option
      • it's either useful or it's not
      • yes, I hate GNOME3 for not having enough options, but this doesn't really look like something people need to enable to make it work
      • Freso
        :)
      • ianmcorvidae: https://github.com/zhangsen/supybot-jira
      • zas
        back
      • about caching, i'm just looking for a way to prevent useless downloads, when dev/testing and as user when ie. Picard crashed or i just exit/resume
      • currently, if a release has CAA images, and you have set options to download them all, Picard will just download them again even if it did it 10 mins ago
      • this is annoying when releases have ie. 100Mb of images
      • Freso
        Oi warp, are you done with the release?
      • reosarevok
        Freso: yes
      • Freso
        If so, I was to rmeind you to merge stuff.
      • ;D
      • nikki
        hmm... doesn't one of the IA files have md5s or whatever?
      • Freso
        *remind
      • luks
        zas: my main objection is that the feature is indeed intended for developers when testing something
      • which is also the reason why you added it as an option
      • I have no problem adding QNetworkAccessManager-level cache for development/testing purposes
      • but I don't think normal users will benefit from that
      • if anything, I'd like to change Picard so that loading your entire collection is harder, not easier
      • zas
        i'm currently looking at QNetworkAccessManager-level cache
      • nikki would like picard to have some sort of library so it knows what she already has (and can then conditionally include things like disambiguation comments only when necessary)
      • luks
        I'd like if it was not called picard and picard was simplified :)
      • nikki
        oh?
      • luks
        we don't have anybody to maintain even picard :)
      • af9210 joined the channel
      • MBJenkins
        * ollie: Use the pre-NES schema for the 'editor' table
      • * ollie: Bump dependencies to use latest version of `semigroups`
      • ocharles
        Crowd sourcing time!
      • https://trello.com/board/musicbrainz-nes/50f408... -- I have created a Trello board for NES
      • If people can think of places where NES impacts musicbrainz-server, please feel free to add tasks
      • I think it's public
      • nikki
        what about things like deleting releases, editing/removing relationships?
      • nikki is not clear just how much you're trying to split it up
      • ocharles
        Those should be tasks
      • I'm looking for sort of 'isolated thingies' for now, which is intentionally vague
      • just trying to collect as many to-do's, as possible to get a clear idea of the battlefield
      • Freso
        "To use Trello, please enable JavaScript."
      • What's up with everybody *requiring* JS these days. :(
      • ocharles
        Because it makes the web significantly better?
      • alastairp
        warp: when seeding RE, you use a code for language
      • which converts it to a number. is there a code that can be used for [multiple languages] ?
      • nikki
        Freso: probably because most people don't give a shit about accessibility, they just want shiny stuff
      • multiple languages is mul
      • alastairp
        ok
      • thx
      • Freso
        ocharles: I lean more towards what nikki said.
      • ijabz joined the channel
      • nikki
        ocharles: add a disc id, import from freedb, view cd stub, import cd stub
      • ocharles
        nikki: you don't have editing rights, or you'd prefer I enter them?
      • nikki
        both, I think
      • ocharles
        ok :)
      • Freso
        ocharles: Watching labels, (watching collections)
      • ocharles
        The CD stub stuff is outside NES so that should just work
      • Freso
        ocharles: Watching editors
      • ocharles
        oh, i think you've misunderstood me a bit, Freso
      • Freso
        ocharles: Possibly.
      • ocharles
        this is to get us feature matching against pre-NES
      • not what we'd like for NES :)
      • Freso
        Oh.
      • ocharles
        let me make a separate list
      • Freso
        Yes.
      • ocharles
        they're worth having written down anyway
      • Freso
        It's already possible to watch labels and editors.
      • ocharles
        oh, subscriptions?
      • Freso
        Isn't that what you mean? :)
      • If not, I have no idea what "Watching artists" is.
      • ocharles
        we have a feature called 'watching', which means you get emails about new releases
      • it never got finished/turned on
      • Freso
        Ah.
      • Anyway, I can't find subscriptions mentioned anywhere either. :)
      • ocharles
        musicbrainz-data
      • 2nd task
      • Freso
        Right.
      • Freso blind
      • ocharles
        the search works quite nicely :)
      • Freso
        What search? The one at the top doesn't seem to be for this board(?) specifically?
      • Freso has never used Trello before a few minutes ago
      • Found it.
      • ocharles: You've nothing about aliases?
      • ocharles
        nope!
      • ocharles adds that
      • Freso
        Works, Artists, Labels
      • ocharles
        we have it in the data bindings though
      • Freso
        Is i18n anything that should be mentioned?
      • ocharles
        Hmm, that's all templates
      • For the most part
      • so I think we should be ok
      • unless there's anything specific, I'll leave it out for now