geordi was basically undefined given how many things the eighty different people who had come up with "sort of ingestion" ideas had come up with, so I went for solving needs I understood
2013-02-28 05907, 2013
nikki
presumably because you want to know what's already matched?
2013-02-28 05920, 2013
ianmcorvidae
which in this case was the two I mentioned, for editors and for data providers
2013-02-28 05933, 2013
nikki
I dunno... I guess I'm not sure how you thought it'd work (and/or I'm too tired to understand what you've said)
2013-02-28 05921, 2013
luks
I'm not good at explaining things, I know that :)
2013-02-28 05902, 2013
luks
the ultimate goal I saw was adding things to MB automatically
2013-02-28 05930, 2013
luks
and the rest being just tools to help with that
2013-02-28 05954, 2013
hawke_1
luks: why would you need an external database to keep track of it, if geordi knows what it has matched?
2013-02-28 05905, 2013
ianmcorvidae
ah, yeah, that was not in the goals, and is a much harder thing to do right
2013-02-28 05909, 2013
kepstin-work
we weren't sure we wanted to add stuff "automatically"; geordi is just a tool to make it easier to import/match large external data sources manually
2013-02-28 05915, 2013
ianmcorvidae
versus making editing easier, which is the editor perspective on geordi
2013-02-28 05922, 2013
luks
hawke_1: I need a database to know what's processed, possible not matched
2013-02-28 05935, 2013
kepstin-work
but a bot could certainly ask geordi for unmatched releases, then either import or match them, then tell geordi that it's matched
2013-02-28 05945, 2013
kepstin-work
and rinse, repeat
2013-02-28 05950, 2013
luks
hawke_1: and I need to have a different app to be able to confirm "candidate" matches I'm not completely sure about
2013-02-28 05952, 2013
hawke_1
luks: Isn’t everything unmatched a candidate for matching?
2013-02-28 05904, 2013
ianmcorvidae
I see what luks is saying, that doesn't let you keep track of things that you haven't successfully matched, yeah
2013-02-28 05916, 2013
luks
hawke_1: possibly, but after some time
2013-02-28 05926, 2013
ianmcorvidae
there's nothing in geordi for "I tried, but it didn't work, so don't try again for a bit"
2013-02-28 05934, 2013
kepstin-work
adding support to geordi for storing 'potential' or 'possible' matches might be interesting
2013-02-28 05944, 2013
kepstin-work
but yeah, failed matches would be an issue :/
2013-02-28 05947, 2013
ianmcorvidae
yeah, indeed
2013-02-28 05914, 2013
hawke_1
I don‘t quite get what would be the “I” in “I tried but it didn’t work”
2013-02-28 05915, 2013
ianmcorvidae
automatic matches are already displayed differently than human-done ones, but adding more levels may be a good idea
2013-02-28 05921, 2013
kepstin-work
if geordi lets an app add arbitrary extra metadata fields, that might be interesting.
2013-02-28 05922, 2013
hawke_1
that would be any bot/algorithm wouldn’t it?
2013-02-28 05924, 2013
ianmcorvidae
hawke_1: whatever script
2013-02-28 05925, 2013
ianmcorvidae
yes
2013-02-28 05933, 2013
hawke_1
each one would need its own 'tried' flag
2013-02-28 05944, 2013
kepstin-work
the app could add an 'x-luks-script-match: failed' tag or whatever
2013-02-28 05957, 2013
kepstin-work
and do a search for things without that field?
2013-02-28 05907, 2013
ianmcorvidae
well, geordi does let you keep track of who or what did the match, so
2013-02-28 05935, 2013
ianmcorvidae
there's just no way to attach data to an item other than having direct elasticsearch access or submitting a match, which is what the potential-match thing would be for
2013-02-28 05950, 2013
ianmcorvidae
also: apparently that pep8 test *did* in fact pass
2013-02-28 05953, 2013
ianmcorvidae
which has me mystified.
2013-02-28 05913, 2013
kepstin-work
ianmcorvidae: does it fail on your box?
2013-02-28 05924, 2013
ianmcorvidae
kepstin-work: yes, rather dramatically
2013-02-28 05928, 2013
kepstin-work
It might be an issue with the test code itself, then
2013-02-28 05939, 2013
kepstin-work
failing to detect a failure :)
2013-02-28 05942, 2013
ianmcorvidae
lol
2013-02-28 05950, 2013
kepstin-work
(e.g. counting an 'unable to find executable' as a pass)
2013-02-28 05915, 2013
ianmcorvidae
hah
2013-02-28 05919, 2013
ianmcorvidae
I'm silly :P
2013-02-28 05945, 2013
kepstin-work
hmm. by any chance, is jenkins running the tests from outside of the 'geordi' directory?
Ian McEwen: Use the right directory for the pep8 test.
2013-02-28 05912, 2013
kepstin-work
there you go, now it's failing properly :)
2013-02-28 05915, 2013
ianmcorvidae
yup
2013-02-28 05922, 2013
ruaok joined the channel
2013-02-28 05952, 2013
Freso
FAILURE, Ian. It's a FAILURE!
2013-02-28 05908, 2013
ianmcorvidae
yeah
2013-02-28 05916, 2013
Freso
(MBo failed too, when I added a PEP8 test. >_>)
2013-02-28 05929, 2013
ianmcorvidae
I need to figure out which things it's yelling about I care about and which rules I should decree aren't part of geordi's style guide :P
2013-02-28 05949, 2013
ianmcorvidae
(already removed one, for expecting two line breaks before classes (or maybe after imports? I wasn't really sure -- but double linebreaks are gross :P)
2013-02-28 05959, 2013
Leftmost
I agree.
2013-02-28 05902, 2013
Freso
Heh.
2013-02-28 05910, 2013
Leftmost
Excess whitespace makes me sad.
2013-02-28 05919, 2013
Freso
I want to adhere to Pocoo's style guide, so I'm keeping them.
2013-02-28 05927, 2013
ianmcorvidae
hehe
2013-02-28 05931, 2013
Freso
Even as I generally disapprove of excessive whitespace.
2013-02-28 05950, 2013
ianmcorvidae
I'm of two minds about maybe increasing the line length
2013-02-28 05906, 2013
Freso
I still think a consistent coding style is > removing whitespace.
2013-02-28 05927, 2013
Freso
ianmcorvidae: I've so far managed to keep all Python files under 80 characters long.
2013-02-28 05931, 2013
Freso
...
2013-02-28 05933, 2013
ianmcorvidae
yeah, but as pep8 itself says, it's more important within a given project or file
2013-02-28 05933, 2013
Freso
>_>
2013-02-28 05938, 2013
ianmcorvidae
hah
2013-02-28 05940, 2013
Freso
All *lines* in Python files.
2013-02-28 05901, 2013
ianmcorvidae
insert joke here about writing python like APL? ;)
2013-02-28 05905, 2013
Freso
:)
2013-02-28 05939, 2013
Freso
Python forcing whitespace indentation is a pretty silly language to make small-yes-extensive one liner scripts in...
2013-02-28 05956, 2013
Freso
...
2013-02-28 05958, 2013
Freso
Ugh.
2013-02-28 05902, 2013
Freso
I'm too tired for this.
2013-02-28 05905, 2013
Freso
I should go to bed.
2013-02-28 05955, 2013
ianmcorvidae
heh semicolons
2013-02-28 05902, 2013
ianmcorvidae was clearly writing too much perl before I worked on this
2013-02-28 05951, 2013
Leftmost
Freso, consistent coding style is good. If I were working on a project that specified extra whitespace, I would probably do it. But for projects I start, I won't.
