JonnyJD: probably. you can look at lib/MusicBrainz/Server/Test/HTML5.pm to see which things we ignore and why
JonnyJD: a lot of them are because our RDFa output is still 1.0, not 1.1.
JonnyJD
Ah, okay. So that is fine. Not sure though why validator.nu is down and html5.validator.nu is not.
Mineo wonders if https://musicbrainz.org/doc/Development/XML_Web_Service/Version_2/Search is one of the pages that need a transclusion editor to update and, if so, if anyone could do that :)
warp
Mineo: that looks like the current version. (unless someone secretly transcluded it just now).
Mineo
it *is* the current version, but I've updated the included pages
reosarevok
Mineo: included pages aren't transcluded
(unless I remember this bit wrong)
Mineo
I don't know, that's why I'm asking :)
nikki
did it change now?
reosarevok
Well, does it show your changes?
nikki just told it to transclude the same version and doesn't know if that works
warp
included pages?
Mineo
that's a no for both of you
nikki
I have no idea if it's just cached or actually transcluded :(
reosarevok
I think it was just cached
warp
nikki: can you transclude an older version? (and then put it back to this afterward).
reosarevok
warp: look at the code ;)
nikki
warp: I guess it'd work, but it's not really a proper solution :P
warp
nikki: sure
nikki
it's also annoying to do
warp
I assume that will reset the cache.
Prophet5 joined the channel
reosarevok
warp: and thus we still won't know if it's just cached or actually transcluded somehow
Just wait until cache expires and check again :p
warp
I don't understand what the problem is yet, so cannot say much else on the topic.
JonnyJD
Is there anything I need to set up on the VM additionally to make digest auth working? The digest auth tests fail for me (401, rather than 200)
ijabz joined the channel
reosarevok
warp: that page is including the content of other pages that aren't in the transclusion table
warp: those are the pages that changed, not the main one
Mineo
JonnyJD: the passwords are probably 'mb' not the real ones
JonnyJD
No, I mean in the tests
Mineo
ah
JonnyJD
When I read the code correctly users are created in the tests, but the access fails anyways.
warp
reosarevok: ah, nasty.
Mineo
JonnyJD: I didn't say anything then :)
warp
JonnyJD: no, I don't remember any of that code needing anything special. I wonder why those tests fail.
ok, and are you sure you have that editor in your database?
JonnyJD
the user (my use) exists. I can login at the normal login page
ocharles
hm
what branch are you running?
JonnyJD
master d3238e5
ocharles
hm
nikki
nikki has changed the topic to: 🌅 SUNRISE week | http://musicbrainz.org/#devel | note about meeting time in the US: http://bit.ly/Ym40ql | Agenda: reviews, MBS-5933 (ocharles), code reviewing non-MBS projects (ocharles/warp), MBS-2411 (ocharles)
JonnyJD
updated from the latest VM, changed RT_STANDALONE, update scripts were all executed
Nor does he, hence the "can't reproduce it locally"
at least, that was my understanding
nikki
because that character isn't in the list of things it removes. I'm guessing it's one of the other functions that removes unprintable stuff
ocharles
I know that
but maybe the Perl that is running on production is doing something weird
nikki
it's probably just older than the version he has locally
ocharles
yes
and so there is more chance it is buggy
that machine is also not configured how ian's machine is configured
nikki
not buggy. just knows about an older version of unicode :P
ocharles
how do you know Perl's regular expressions on 5.10 aren't buggy?
All I'd like him to do is take a look at it
or say "i dunno ocharles, you look"
nikki
I don't know anything for sure, I just think the problem is that we're removing unprintable characters in some other function and those characters are so new that they're being seen as unprintable
ocharles
yep, that sounds possible
ocharles goes home
warp
bye!
nikki
perl -C -e 'for $char ("a", "\x{732B}", "\x{20B9}", "\x{20BA}") { print "$char\n" if $char =~ /[[:print:]]/; }' prints the first two for me but not the last two (added in 6.0 and 6.1 respectively)
(that's with 5.10.1 in three places and 5.12 in another)
I guess I run stuff that's too old to have the latest stuff :P
ocharles: when you reappear, can you rerun failed events please?
ianmcorvidae
ocharles: the ticket I linked, I realized after, wasn't actually shipped to production when that was filed
ocharles: I think it's because of :print: actually, because we're using an older perl before those characters were added
nikki
which is what I said :P
ianmcorvidae: can you try that line I pasted?
nikki is curious how many work
ianmcorvidae
nikki: all three print for me
nikki
there's four :P
ianmcorvidae
yeah
Freso
I see two + the a.
ianmcorvidae
I get a 猫 ₹
nikki
(the letter a, the kanji for cat, indian rupee sign, turkish lira sign)
ah, so you have 6.0 but not 6.1
Freso
v5.16.2
ianmcorvidae
5.16.2 here as well
Freso
a
猫
₹
^ is what I get.
JonnyJD
Do the tests need edits? I get tests 20 and 31 failing, last error:
Failed query:
'UPDATE edit SET status = ?, close_time = NOW() WHERE id = ?'
(2 11)
ianmcorvidae
it should tell you *why* that failed, but no -- you should need the edit table, but not edits
JonnyJD
Well I have that afterwards: DBD::Pg::st execute failed: ERROR: current transaction is aborted, commands ignored until end of transaction block at lib/Sql.pm line 107, <FILE> line 35.
and that before:
# Failed test 'all'
# at /usr/share/perl/5.14/Test/Builder.pm line 239.
I also have an error where the test gets 403 http code but excpects 401. As I understand these are 2 different failing tests (20 and 31)
ianmcorvidae
current transaction is aborted should mean that's not the first failed query
CatCat nominates ❄ RANDOM SNOW IN MARCH for the next "freeze" theme
CatCat
well amybe to long but i was definitely peeved to see the sudden onslaught of snow again.
warp
CatCat: feel free to change the topic.
JonnyJD
Hm, "Child (all) exited without calling finalize()" might be the actual problem. That is the last meaningfull I get after test 29 (so that should be the failur in test 31)
warp
freeze should have started around 6 hours ago.
CatCat
warp: :O
ianmcorvidae
that's because of the query failure
CatCat
CatCat has changed the topic to: ❄ RANDOM SNOW IN MARCH week | http://musicbrainz.org/#devel | note about meeting time in the US: http://bit.ly/Ym40ql | Agenda: reviews, MBS-5933 (ocharles), code reviewing non-MBS projects (ocharles/warp), MBS-2411 (ocharles)
nikki
that's not a unicode character name :(
CatCat
oh it went by that?
snowflake then :/
or haang on
nikki
yeah, the capitals are a convention for unicode character names
CatCat
❅ TIGHT TRIFOLIATE SNOWFLAKE
nikki
sure XD
JonnyJD
"select count(*) from edit;" -> 0 (so the table exists and is empty, for TEST and READWRITE)
CatCat
CatCat has changed the topic to: ❅ TIGHT TRIFOLIATE SNOWFLAKE week | http://musicbrainz.org/#devel | note about meeting time in the US: http://bit.ly/Ym40ql | Agenda: reviews, MBS-5933 (ocharles), code reviewing non-MBS projects (ocharles/warp), MBS-2411 (ocharles)
nikki
:D
Freso
CatCat: :D
"❄ Random Snow in March week" would have worked though.