#musicbrainz-devel

/

      • ijabz
        oops, my misunderstanding
      • Okay, I see no good reason to restrict to one date per country at the database level
      • Leftmost
        I'll give a weak +.5. It's not something I deal with, but I feel like people would misuse it.
      • Or maybe I misunderstood.
      • ocharles
        Burrito time
      • warp
        hello!
      • ocharles
        ahoi warp
      • djce joined the channel
      • djce joined the channel
      • warp
        bitbucket shippits are pretty.
      • reosarevok
        Did search just die?
      • warp
        reosarevok: hm, nothing obvious in nagios.
      • Leftmost
        Speaking of nagios, any object to me copying over the check_last_replication_date update to freedb?
      • warp
        what is "copying over" ?
      • Leftmost
        scp
      • warp
        and with freedb you mean freedb.musicbrainz.org?
      • Leftmost
        Yes.
      • warp
        ok, I don't object to you copying that file to that server. but it is a strange question to ask :)
      • do you want to get that check in nagios?
      • Leftmost
        Well, it will mean git will need a bit more prodding the next time freedb needs an update to musicbrainz-server.
      • warp
        Leftmost: sorry, I just don't have enough context to know what you're talking about.
      • Leftmost
        Oh, sorry.
      • So there's a check_last_replication_date script in bin/ in the musicbrainz-server repo. It's not working in its current state, but I updated it and it's got a couple approves in review. However, rather than merging it and pulling master on freedb.musicbrainz.org immediately, I was just going to copy the updated script to the appropriate place and get the check running.
      • I'm not really sure of the procedure for updating freedb's MBS instance, though, so I'm not sure what's best.
      • warp
        oh in that case I would just checkout the branch with that script on freedb.musicbrainz.org
      • then someone doing "git status" knows immediatly what's going on.
      • I've never logged into freedb.musicbrainz.org, and my usual passwords don't work. so I don't anything about that server either.
      • Leftmost
        Well, I imagine it will get merged into master any time now. Two approvals means it's ready to ship, right? I could even do it myself. I'm just a little afraid of pulling MBS on a production server with no real clue of what will happen. Especially since it looks like it hasn't been pulled since October.
      • I guess I should wait for ianmcorvidae to wake up and poke him.
      • warp
        Leftmost: shipits should normally go in beta, not master.
      • (and it's not a freeze week, so you can do that now if you want)
      • Leftmost
        Yeah. I'm also not sure of the procedure there. There should be absolutely nothing using it, especially since it's in an utterly unusable state, but I also don't want to subvert process without knowing what I'm doing.
      • warp
        sure, probably nothing will break if you merge it into master now. but _I_ don't know that.
      • but it a hot sunny merge everything with shippits into beta week. if you have shippits, the process is to merge those into beta this week :)
      • +is
      • Leftmost
        Okay. Well, I don't have access to push to github, so I'll probably just let others do that.
      • warp
        ok, which branch is this? then I'll merge it into beta.
      • Leftmost
        mbs-6009
      • mb-chat-logger
      • Leftmost
        Thanks.
      • ocharles
        warp: it looks like scrypt can be used for encryption, not just one way hashing
      • so it would appear that we could actually store encrypted passwords and still use digest
      • warp
        ocharles: for what purpose?
      • ocharles
        what for what purpose?
      • warp
        what are you trying to accomplish by storing encrypted passwords instead of plaintext passwords?
      • ocharles
        you know what we're trying to accomplish, not having plain text passwords leaked if the database is compromised
      • warp
        hashes are good because you cannot get the password back
      • ocharles
        i know
      • warp
        encrypted passwords are equivalent to plaintext because you can get the password back.
      • ocharles
        not equivilent, because you need the key
      • encrypted means we don't have to have plain text or a weak md5 in the db.
      • but it does mean that yes, there is a key security issue
      • warp
        sure, and the servers need the key.
      • ocharles
        bcrypt is probably the way to go then, because the scrypt on CPAN is for encryption and decryption
      • warp
        if our security is compromised enough for an attacker to grab the user table it is likely compromised enough to grab the key as well. especially because reading the key is done by open source code, so following the trail to where the key is stored should be easy.
      • ocharles
        right
      • ruaok joined the channel
      • JonnyJD
        encrypted passwords are better than plaintext in terms of "we don't have to be that careful about the DB, only about the key"
      • ocharles
        that and not accidently dumping passwords in the website too
      • JonnyJD
        Not really against an attacking situation, but in terms of "I don't want others to see my password by chance"
      • ocharles
        Dumper.dump(edit.editor) in /edits is all it takes to leak a lot of passwords
      • JonnyJD
        yes
      • warp
        if edit.editor has a password in it that already seems dodgy :)
      • ocharles
        yes, I think all that auth stuff should be very separate
      • but that's another story
      • warp
        I don't think it is another story
      • ocharles
        bcrypt needs a salt - are you meant to use a constant salt?
      • ruaok love the smell of bickering in the morning
      • warp
        buenos dias señor ruaok
      • kepstin-work
        ocharles: salt should be random per-user, and is stored with the password hash
      • ocharles
        oh wait, bcrypt stores the salt
      • kepstin-work: thanks
      • ruaok
        buenos tardes, warp!
      • kepstin-work
        purpose of salt is to make it so rainbow tables are less feasible
      • ocharles
        I know what salts are for :)
      • kepstin-work
        so constant would be bad, since then you can just generate a rainbow table with constant salt :)
      • ocharles
        generally you don't generate rainbow tables though, you download them
      • but yes, point taken
      • ruaok runs off to the dentist
      • ruaok
        bbaib
      • MBJenkins
        Project musicbrainz-server_beta build #373: SUCCESS in 29 min: http://ci.musicbrainz.org/job/musicbrainz-serve...
      • * leftmostcat: Use correct lib location
      • Leftmost
        I was briefly confused why my name was coming up...
      • I need sleep.
      • ocharles
        "See Crypt::Eksblowfish::Bcrypt for a detailed description of cost in the context of the bcrypt algorithm." *goes to that module "Non-negative integer controlling the cost of the hash function"
      • ಠ_ಠ
      • CPAN, we have different definitions of 'detailed'
      • Leftmost
        What, you wanted the detailed description to include details?
      • warp
        ocharles: can you clarify for navap how he should rewrite the entity_exists() macro? https://bitbucket.org/metabrainz/musicbrainz-se...
      • Freso_laptop joined the channel
      • MBJenkins
        themineo: Fix a typo: debuging -> debugging
      • ijabz_ joined the channel
      • Freso_laptop
        I should start using "The_Freso" the few times Freso is taken...
      • Leftmost
        The Fresta
      • Freso_laptop
        El Fresio
      • ocharles
        Hmm, is it intentional that musicbrainz.org SSL certificates don't provide ownership information?
      • Leftmost
        Bous Fresanoumenos
      • reosarevok
        We have a tweet saying "@MusicBrainz Why you keep giving 502 and 500 errors?"
      • (from 10 min ago...)
      • luks_
        ocharles: I guess cost is the only reason
      • Freso_laptop
        Was it Mineo talking about Shiva yesterday?
      • ocharles
        luks: ah, they are more expensive then?
      • Freso_laptop
        Looking at it a bit more, I think it's *definitely* something that could use some MusicBrainz juice.
      • luks
        ocharles: the CA needs to verify way more information that way, so yes, they are more expensive
      • ocharles
        ah
      • makes sense
      • bandtrace joined the channel
      • djce joined the channel
      • MBJenkins
        Project musicbrainz-server_beta build #375: SUCCESS in 29 min: http://ci.musicbrainz.org/job/musicbrainz-serve...
      • alastair.porter: fix browsing works by artist if artist id doesn't exist
      • Leftmost
        alastairp, sometime in the next couple months I'd like to talk with you about community-managed collections for October, as it seems you have a stake in that.
      • alastairp
        hmm, sure. we could probably come up with some ideas about that
      • Leftmost
        Might be worth creating a wiki page to hack on some ideas about what it should look like.
      • I'll create one and ping you.
      • For now, I really ought to try to get some sleep.
      • reosarevok
        ocharles, warp: 500 and 502 again...
      • ocharles - warp? Or can anyone else look into it? Having people in twitter telling us about 500 errors in the homepage doesn't look very good :p
      • ocharles
        I have to leave in a few minutes to drop something off at the post office but I can look after... warp is a better person to prod
      • djce joined the channel
      • ruaok joined the channel
      • ijabz_ joined the channel
      • ruaok joined the channel
      • voiceinsideyou1 joined the channel
      • warp
        reosarevok: did it resolve itself?
      • reosarevok: the home page loads fine for me now
      • voiceinsideyou2 joined the channel
      • reosarevok
        warp, probbaly
      • But we can't really keep having several periods of 500/502 per day, whether they solve themselves or don't
      • :(
      • *probably even
      • warp
        I agree.
      • ianmcorvidae awakes
      • ianmcorvidae
        ocharles: what did I screw up, heh?
      • Leftmost: what did you need?
      • reosarevok
        ianmcorvidae: apparently the upgrade.sh isn't the same in github and bitbucket
      • (for the schema change stuff)
      • warp
        goodmorning mr McEwen!
      • ianmcorvidae
        that is odd, I should have pushed it both places :/ unless I pushed the wrong branch to one or the other at some point
      • reosarevok
        Yeah, we know you should have :)
      • ianmcorvidae
        :P
      • oh, it's your fault, that's right
      • you asked me to update the bitbucket one by pulling in master :P
      • reosarevok
        hahaha
      • Ok
      • Can we fix it? :)
      • ianmcorvidae
        yes, it is now
      • reosarevok
        ianmcorvidae: hmm. Should I merge the branch agan then?
      • ianmcorvidae
        I'd recommend it
      • reosarevok
        That commit history will look very silly :)
      • But ok