have red pending edits colour for destructive edits, green for add and current colour for modify ?
2013-06-13 16440, 2013
nikki
unsure
2013-06-13 16431, 2013
jesus2099
wouldn’t that rule big times ?
2013-06-13 16447, 2013
Leftmost joined the channel
2013-06-13 16448, 2013
Leftmost joined the channel
2013-06-13 16449, 2013
nikki
not for me
2013-06-13 16432, 2013
jesus2099
really ?
2013-06-13 16420, 2013
reosarevok
I doubt she's lying to you :p
2013-06-13 16428, 2013
reosarevok thinks it'd probably be OK?
2013-06-13 16429, 2013
jesus2099
that’s just strange…
2013-06-13 16438, 2013
reosarevok
Not that I usually need it much, bu
2013-06-13 16439, 2013
reosarevok
t
2013-06-13 16442, 2013
nikki
most of the time the highlighting is far too vague to mean anything useful to me
2013-06-13 16455, 2013
jesus2099
nikki: that’s the point of this ticket
2013-06-13 16400, 2013
nikki
it doesn't fix it though
2013-06-13 16411, 2013
jesus2099
now you would know if there is destructive pending
2013-06-13 16413, 2013
nikki
it just adds more colours that still means "click the open edits button to find out what's being changed"
2013-06-13 16435, 2013
nikki
not really
2013-06-13 16435, 2013
jesus2099
think of the alias list for instance…
2013-06-13 16453, 2013
jesus2099
many places like that you wouldn’t need to click to know if it’s being removed, edited or added
2013-06-13 16412, 2013
nikki
you can edit a relationship to change both endpoints and the relationship type. that's effectively removing the old relationship but wouldn't show up like that
2013-06-13 16413, 2013
jesus2099
same for all AR on releases works etc.
2013-06-13 16439, 2013
jesus2099
knowing that it’s an add with no further modify is interesting without clicking
2013-06-13 16450, 2013
jesus2099
instead of now you can imaghin someone is editing or removing it
2013-06-13 16457, 2013
nikki
and then you can have both add and edit at the same time
2013-06-13 16459, 2013
jesus2099
and so you have to check for nothing
2013-06-13 16404, 2013
jesus2099
add+edit → edit
2013-06-13 16411, 2013
nikki
and presumably adding an alias is editing the artist, not adding the artist
2013-06-13 16414, 2013
jesus2099
because what you see is not what the future will be
2013-06-13 16440, 2013
jesus2099
nikki: when you ad an alias, this alias gets mp today, great, it would be mpadd better
2013-06-13 16450, 2013
nikki
I have no idea what that means.
2013-06-13 16404, 2013
jesus2099
you said adding alias today would display as edit artist.
2013-06-13 16414, 2013
jesus2099
but no, see the alias list, the added alias gets the mp marking
2013-06-13 16421, 2013
jesus2099
if it had the mpadd marking (green) better
2013-06-13 16431, 2013
nikki
but the artist itself gets highlighted (iirc)
2013-06-13 16435, 2013
reosarevok
it does
2013-06-13 16439, 2013
reosarevok
Which makes no sense IMO
2013-06-13 16443, 2013
nikki
it would be wrong to highlight it green, because then it looks like you're adding the artist
2013-06-13 16402, 2013
nikki
that's exactly what I mean - the highlighting is too vague to mean anything to me
2013-06-13 16429, 2013
jesus2099
nikki: of course we wouldn’t mark the artist green
2013-06-13 16433, 2013
reosarevok
Why do we even highlight the artist for that anyway?
2013-06-13 16441, 2013
nikki
because it's an open edit for the artist :P
2013-06-13 16442, 2013
jesus2099
i’m talking of the specific alias marking, not the bugs around it
2013-06-13 16456, 2013
jesus2099
anyway it’s ok if the artist is marked as edited, np really
2013-06-13 16457, 2013
reosarevok
nikki: so is adding an URL to it, but there we don't
2013-06-13 16410, 2013
nikki would probably just get rid of all the highlighting and have something saying there are pending edits
2013-06-13 16412, 2013
jesus2099
better if not marked as edit yes
2013-06-13 16413, 2013
reosarevok
(and it seems a similarly minor edit)
2013-06-13 16426, 2013
jesus2099
nikki: terrible idea
2013-06-13 16446, 2013
jesus2099
;)
2013-06-13 16449, 2013
nikki
I wouldn't mind something that lets you compare before/after (which would presumably be doable with NES) but right now the highlighting is meaningless to most people, from what I've seen
2013-06-13 16403, 2013
jesus2099
it’s very useful to me
2013-06-13 16411, 2013
nikki
I mean, what *does* colouring something yellow mean? it's not like we even tell anyone it means there are pending edits
2013-06-13 16413, 2013
jesus2099
but would be even more useful with this colour distinguisj
2013-06-13 16428, 2013
jesus2099
nikki: again it’s the point of the improvement ticket
2013-06-13 16440, 2013
jesus2099
have three colours
2013-06-13 16447, 2013
nikki
more colours still doesn't tell you what it means
2013-06-13 16457, 2013
jesus2099
i said what it means
2013-06-13 16418, 2013
jesus2099
it’s highlit orange when what you see is about to change
2013-06-13 16425, 2013
nikki
but how do you know that?
2013-06-13 16433, 2013
jesus2099
it’s highlit green when what you see will remain but is new and could be no voted
2013-06-13 16438, 2013
nikki
you've just arrived at the site, make some edits, some colours change... wtf does it mean?
2013-06-13 16444, 2013
jesus2099
it’s highlit red when what you see is about to disappear
2013-06-13 16446, 2013
reosarevok
nikki: Well, it's the same as in the relationship editor
2013-06-13 16458, 2013
reosarevok
nikki: so at least it wouldn't be *added* complexity
2013-06-13 16402, 2013
reosarevok
(it's there already)
2013-06-13 16423, 2013
reosarevok
We should probably document that stuff somewhere though...
2013-06-13 16425, 2013
nikki
reosarevok: which is even more confusing because we're not distinguishing between edits that haven't been entered from edits which have. it's no wonder people keep resubmitting edits when they don't show up
2013-06-13 16443, 2013
jesus2099
this is another problem
2013-06-13 16446, 2013
jesus2099
abnd another ticket i opened
2013-06-13 16454, 2013
jesus2099
make the change seeable at once with the marked mp
2013-06-13 16459, 2013
jesus2099
like the PUID edits were
2013-06-13 16459, 2013
nikki
that's why I don't like highlighting stuff like you're in some editor
2013-06-13 16430, 2013
jesus2099 would find it extremely disturbing not to have an alternate colour for things that are pending
2013-06-13 16400, 2013
jesus2099
you can user css out the background-color ;p
2013-06-13 16421, 2013
jesus2099
you’re bored with this colour because your edits are autoedits anyway
2013-06-13 16425, 2013
nikki
I'm not a newbie who doesn't understand what all this arbitrary highlighting means
2013-06-13 16429, 2013
jesus2099
you don’t need to know if you already did this or that
2013-06-13 16439, 2013
nikki
so no, I can't just get rid of it using user css
2013-06-13 16449, 2013
jesus2099
if it wasn’t highlit i would re-edit multiple times because forgot i already did it
2013-06-13 16454, 2013
reosarevok
nikki: it's a marking at least... I can't think of any way of making it newbie-friendly :/
2013-06-13 16437, 2013
jesus2099
we can add a title="there are pending edits" if it’s really that hard to understand for newbie
2013-06-13 16453, 2013
jesus2099
(i understood it right away whern i was new to mb, it seemed obvious)
2013-06-13 16415, 2013
jesus2099
BUT I AM SO CLEVER IT FRIGHTENS ME
2013-06-13 16421, 2013
nikki
well with the current edit system, yes, it all sucks. but since NES stores the entire thing you could in theory make it show the edit as it would appear with the edits applied
2013-06-13 16450, 2013
reosarevok
ruaok: heh, should we tell them "get your own servers up already and you'll be safe from this"? :p
2013-06-13 16452, 2013
reosarevok
oh, lol
2013-06-13 16455, 2013
reosarevok
you just did :p
2013-06-13 16457, 2013
jesus2099
but it should still be marked as mp (like PUID edits)otherwise we would take it for granted
2013-06-13 16410, 2013
ruaok
:-)
2013-06-13 16400, 2013
nikki
reosarevok: kepstin-work had the idea of having a "pending edits" tag sort of thing instead of highlighting, I tried it out at some point, seemed reasonable and far more obvious what it means
2013-06-13 16416, 2013
ianmcorvidae
tag sort of thing?
2013-06-13 16418, 2013
reosarevok
nikki: how does that work?
2013-06-13 16422, 2013
reosarevok
yeah, unsure what that means
2013-06-13 16438, 2013
nikki
like with the compilation, live, etc thing after release group names on the artist overview
2013-06-13 16450, 2013
nikki
I wonder if he has an example anywhere
2013-06-13 16454, 2013
ianmcorvidae
hm
2013-06-13 16458, 2013
jesus2099
let’s take the examples of alias list for instance
2013-06-13 16410, 2013
ianmcorvidae
I guess to *me* that seems like using extra space up to avoid the color
2013-06-13 16414, 2013
jesus2099
you have a pending new alias, a modified alias and a being removed alias
2013-06-13 16417, 2013
ianmcorvidae
but I'm far from a typical user :P
2013-06-13 16428, 2013
jesus2099 has a small screen too
2013-06-13 16430, 2013
jesus2099
:)
2013-06-13 16443, 2013
nikki
ianmcorvidae: the alternative seems to be using extra space to explain the colour :P
2013-06-13 16450, 2013
jesus2099
tooltip
2013-06-13 16406, 2013
nikki
the tooltips are already being used for other stuff
2013-06-13 16434, 2013
ianmcorvidae
I'd prefer we made it more clear edits aren't applied immediately and otherwise keep it the same
