#musicbrainz-devel

/

      • ruaok joined the channel
      • 2014-01-07 00726, 2014

      • samgtr
        what do i fill the SQLALCHEMY_DATABASE_URI as ?
      • 2014-01-07 00733, 2014

      • misterswag joined the channel
      • 2014-01-07 00728, 2014

      • ruaok joined the channel
      • 2014-01-07 00747, 2014

      • zas__
        xlotlu: does this mean https://github.com/musicbrainz/picard/pull/206 need more work ? or does it create another issue ?
      • 2014-01-07 00718, 2014

      • xlotlu
        zas__: it's fine, i just made a PR with tests updated
      • 2014-01-07 00745, 2014

      • xlotlu
        i panicked when i ran the tests :)
      • 2014-01-07 00725, 2014

      • zas__
        k
      • 2014-01-07 00725, 2014

      • ruaok
        samgtr: SQLALCHEMY_DATABASE_URI = "postgresql://mjjc [at 127.0.0.1]/mjjc"
      • 2014-01-07 00749, 2014

      • samgtr
        alright
      • 2014-01-07 00753, 2014

      • xlotlu
        but. I do remember I made the decision conciously for that function to return the full path. I hope it was simply because of style (like, that code deals with filenaming, everything should be contained there)
      • 2014-01-07 00751, 2014

      • zas__
        is there a reason for travis ci to not run picard tests ?
      • 2014-01-07 00701, 2014

      • hawke joined the channel
      • 2014-01-07 00722, 2014

      • zas__
        tests do not pass since xlotlu changed the code (without updating tests) and travis don't report any issue, or is this normal ? it would be convenient to run tests at least on one platform
      • 2014-01-07 00756, 2014

      • zas__
        xlotlu: merged
      • 2014-01-07 00749, 2014

      • travis-ci has left the channel
      • 2014-01-07 00744, 2014

      • ruaok joined the channel
      • 2014-01-07 00730, 2014

      • xlotlu
        thanks
      • 2014-01-07 00729, 2014

      • rvedotrc joined the channel
      • 2014-01-07 00748, 2014

      • samgtr
        i got an error. no module called musicbrainzngs found
      • 2014-01-07 00715, 2014

      • voiceinsideyou joined the channel
      • 2014-01-07 00718, 2014

      • voiceinsideyou1 joined the channel
      • 2014-01-07 00754, 2014

      • jesus2099 joined the channel
      • 2014-01-07 00733, 2014

      • jesus2099
        bitmap: hi Bitmap ! do you have an idea why mouseover and mouseout events are not fired on release editor’s TD ? it’s fired OK in relationship editor…
      • 2014-01-07 00753, 2014

      • rvedotrc joined the channel
      • 2014-01-07 00729, 2014

      • ruaok joined the channel
      • 2014-01-07 00749, 2014

      • jesus2099
        never mind bitmap, it was my fault, it’s ok :)
      • 2014-01-07 00710, 2014

      • zas__
        samgtr: can you give more info (system, and what you are trying to do). Basically musicbrainzngs is a python module (https://github.com/alastair/python-musicbrainzngs)
      • 2014-01-07 00745, 2014

      • samgtr
        im using ubuntu 13.10
      • 2014-01-07 00758, 2014

      • jesus2099 joined the channel
      • 2014-01-07 00704, 2014

      • samgtr
        basically, when i run python manage.py create_db
      • 2014-01-07 00733, 2014

      • samgtr
        i was getting error musicbrainzngs named module missing
      • 2014-01-07 00700, 2014

      • Leftmost` joined the channel
      • 2014-01-07 00713, 2014

      • zas__
        samgtr: ubuntu corresponding module is named "python-musicbrainzngs"
      • 2014-01-07 00747, 2014

      • samgtr
        thanks zas__ for the link, i will run the setup.py now
      • 2014-01-07 00750, 2014

      • MightyJay_ joined the channel
      • 2014-01-07 00728, 2014

      • MightyJay__ joined the channel
      • 2014-01-07 00746, 2014

      • sampsyo_ joined the channel
      • 2014-01-07 00716, 2014

      • alastairp_ joined the channel
      • 2014-01-07 00709, 2014

      • flamingspinach_ joined the channel
      • 2014-01-07 00706, 2014

      • misterswag joined the channel
      • 2014-01-07 00724, 2014

      • samgtr
        zas__: im getting many import errors the most recent being flask_oauthlib.client module not found
      • 2014-01-07 00744, 2014

      • Mineo
        you need to install all the dependencies listed at https://github.com/mjjc/critiquebrainz/blob/fbone…
      • 2014-01-07 00703, 2014

      • xlotlu_ joined the channel
      • 2014-01-07 00737, 2014

      • Leftmost joined the channel
      • 2014-01-07 00733, 2014

      • samgtr
        Error: pg_config executable not found.
      • 2014-01-07 00751, 2014

      • zas__
        samgtr: it should be in package "libpq-dev" or smt like that
      • 2014-01-07 00755, 2014

      • kepstin-work joined the channel
      • 2014-01-07 00702, 2014

      • kepstin-work has left the channel
      • 2014-01-07 00716, 2014

      • kepstin-laptop_ joined the channel
      • 2014-01-07 00731, 2014

      • misterswag joined the channel
      • 2014-01-07 00715, 2014

      • Wixy joined the channel
      • 2014-01-07 00724, 2014

      • Wixy
        Hi
      • 2014-01-07 00728, 2014

      • Wixy
        one quesrtion. what is the order in which artists are listed here? http://musicbrainz.org/ws/2/artist?query=type:per…
      • 2014-01-07 00759, 2014

      • warp
        Wixy: there is no order.
      • 2014-01-07 00708, 2014

      • Wixy
        cool!
      • 2014-01-07 00712, 2014

      • Wixy
        really?
      • 2014-01-07 00727, 2014

      • Wixy
        I mean, what's the meaning of limit and offset if there's not order at all?
      • 2014-01-07 00731, 2014

      • Wixy
        warp, you know what I mean? you could get artist A1 in offset 0 and in offset 300000 easily
      • 2014-01-07 00745, 2014

      • Wixy
        in fact, it's not even guaranteed that you'll get all the artists
      • 2014-01-07 00752, 2014

      • warp
        Wixy: ?query= is a search to the search server, I think the order will be consistent between index runs.
      • 2014-01-07 00716, 2014

      • Wixy
        the doc says "Linked entities are always ordered alphabetically by gid."
      • 2014-01-07 00732, 2014

      • Wixy
        and I believe the link I pasted is considered that
      • 2014-01-07 00746, 2014

      • Wixy
        the question now is, this gid is not the id, is it?
      • 2014-01-07 00702, 2014

      • warp
        no, that result doesn't have any linked entities, I don't think search server responses ever have linked entities.
      • 2014-01-07 00715, 2014

      • Wixy
        there must be an order
      • 2014-01-07 00718, 2014

      • Wixy
        it wouldn't make sense otherwise
      • 2014-01-07 00740, 2014

      • warp
        yes, the id is that json response is what we usually call the mbid, which is the same is gid.
      • 2014-01-07 00706, 2014

      • Wixy
        ok, it's not oreder by mbid
      • 2014-01-07 00737, 2014

      • Wixy
        I'm looking for a complete list of artists
      • 2014-01-07 00741, 2014

      • Wixy
        what should I do?
      • 2014-01-07 00758, 2014

      • warp
        I don't think getting that through the webservice is a good idea, it's just too much data.
      • 2014-01-07 00726, 2014

      • warp
        it would be better to get a copy of the database.
      • 2014-01-07 00739, 2014

      • Wixy
        it's not actually, how many artists are there? 400k?
      • 2014-01-07 00751, 2014

      • Wixy
        it would require -just- 4k requests :P
      • 2014-01-07 00753, 2014

      • warp
        we have virtual machine images with a full database you can download, we have database exports you can import using the musicbrainz server or using "mbslave".
      • 2014-01-07 00719, 2014

      • warp
        and there are somewhat experimental RDF dumps, in case you're working with RDF / Linked data.
      • 2014-01-07 00756, 2014

      • warp
        Wixy: twice as much :) http://musicbrainz.org/statistics
      • 2014-01-07 00759, 2014

      • larsen joined the channel
      • 2014-01-07 00700, 2014

      • Wixy
        let me see
      • 2014-01-07 00714, 2014

      • Wixy
        it says "count: 385596," in the ULR I pasted
      • 2014-01-07 00723, 2014

      • Wixy
        I thought it was the number of artsts
      • 2014-01-07 00742, 2014

      • warp
        yes, type:person.
      • 2014-01-07 00752, 2014

      • Wixy
        oh, sure, there are artists that are not person
      • 2014-01-07 00700, 2014

      • warp
        there's also groups and artists with no type set, so the total artists in the database is 800k.
      • 2014-01-07 00710, 2014

      • Wixy
        ok, you're right, I should download the DB :P
      • 2014-01-07 00758, 2014

      • zas__
        those copyright year and person in Picard licence header (in each file) are a pain to maintain, can't we simplify this ? ie. (c) oldest_year-latest_year Picard Team ? and define Picard Team somewhere as all contributors ?
      • 2014-01-07 00702, 2014

      • ruaok joined the channel
      • 2014-01-07 00715, 2014

      • Wixy
        ok, thank you guys!
      • 2014-01-07 00740, 2014

      • zas__
        bitmap, luks_ ?
      • 2014-01-07 00717, 2014

      • reosarevok joined the channel
      • 2014-01-07 00704, 2014

      • misterswag joined the channel
      • 2014-01-07 00741, 2014

      • bitmap
        zas__: if you'd like to update AUTHORS.txt (probably ordered by date of first contribution), I'd be happy with that
      • 2014-01-07 00702, 2014

      • bitmap
        Copyright 2014 Picard contributors (see AUTHORS.txt) or something
      • 2014-01-07 00747, 2014

      • zas__
        we can generate contributors list (and date) from git history i think
      • 2014-01-07 00705, 2014

      • reosarevok
        Heh
      • 2014-01-07 00739, 2014

      • reosarevok
        From what I've seen in git contributor list generation stuff, that's generally crap
      • 2014-01-07 00740, 2014

      • reosarevok
        But maybe it'll work for Picard
      • 2014-01-07 00745, 2014

      • reosarevok
        (I know it doesn't for mbserver)
      • 2014-01-07 00756, 2014

      • zas__
        for sure, picard headers are far from up-to-date
      • 2014-01-07 00739, 2014

      • zas__
        Having Copyright 2014 Picard contributors (see AUTHORS.txt) in each file, and AUTHORS.txt updated would be much better
      • 2014-01-07 00753, 2014

      • zas__
        we can gather existing copyrights notice, and use something like (untested) http://0pointer.de/blog/projects/copyright.html
      • 2014-01-07 00732, 2014

      • zas__
        Copyright (c) 2009 Carlin Mangar
      • 2014-01-07 00733, 2014

      • zas__
        Copyright (c) 2010 Andrew Barnert
      • 2014-01-07 00734, 2014

      • zas__
        Copyright (c) 2011-2013 Michael Wiencek
      • 2014-01-07 00736, 2014

      • zas__
        Copyright (c) 2012-2013 Wieland Hoffmann
      • 2014-01-07 00738, 2014

      • zas__
        Copyright (c) 2012 Chad Wilson
      • 2014-01-07 00740, 2014

      • zas__
        Copyright (c) 2013 Sophist
      • 2014-01-07 00742, 2014

      • zas__
        Copyright (c) 2013 Calvin Walton
      • 2014-01-07 00744, 2014

      • zas__
        Copyright (c) 2013-2014 Laurent Monin
      • 2014-01-07 00748, 2014

      • zas__
        Copyright (c) 2013 brainz34
      • 2014-01-07 00750, 2014

      • zas__
        from this script
      • 2014-01-07 00756, 2014

      • zas__
        # Copyright (C) 2006 Luk�� Lalinsk�
      • 2014-01-07 00700, 2014

      • zas__
        in the header ...;
      • 2014-01-07 00721, 2014

      • warp
        zas__: what is wrong with those copyright headers?
      • 2014-01-07 00727, 2014

      • derwin
        please paste multi line pastes to a pastebin?
      • 2014-01-07 00737, 2014

      • zas__
        derwin: yup, sorry
      • 2014-01-07 00756, 2014

      • zas__
        warp: there are unmaintained
      • 2014-01-07 00715, 2014

      • kepstin-laptop_ joined the channel
      • 2014-01-07 00719, 2014

      • warp
        zas__: what kind of maintaining do they need?
      • 2014-01-07 00729, 2014

      • reosarevok
        warp, nothing specifically wrong with the copyright headers themselves IMO, but I hate how MBS includes the whole license info with every single file
      • 2014-01-07 00736, 2014

      • zas__
        each contributor is supposed to be added
      • 2014-01-07 00740, 2014

      • reosarevok
        We have files where that's bigger than the actual code :p
      • 2014-01-07 00756, 2014

      • reosarevok
        And yeah, I certainly don't add myself every time I touch a file, heh
      • 2014-01-07 00707, 2014

      • zas__
        we could use a central licence imho -> LICENSE.txt
      • 2014-01-07 00712, 2014

      • zas__
        or COPYING
      • 2014-01-07 00717, 2014

      • warp
        the copyright year is supposed to be the year of first publication, so that doesn't need to change when the new year rolls around.
      • 2014-01-07 00734, 2014

      • zas__
        warp: i don't think, wait
      • 2014-01-07 00735, 2014

      • warp
        if a developer makes significant changes to a file, that developer should add their name + current year to the file.
      • 2014-01-07 00753, 2014

      • warp
        (or update the year if they're already there)
      • 2014-01-07 00746, 2014

      • warp
        reosarevok: I think it is important that the license of each file is clear, and therefore license information should be included in each sourcefile.
      • 2014-01-07 00706, 2014

      • warp
        reosarevok: this is especially useful when files from a project are cherry-picked into some other unrelated project.
      • 2014-01-07 00740, 2014

      • CallerNo6
        warp, regarding the ws2 ordering (above), is the order related to lucene scoring?
      • 2014-01-07 00746, 2014

      • warp
        reosarevok: I do think "License: GPLv2 or later" would be sufficient though, it doesn't have to be that big GPL blurb recommended by the FSF.
      • 2014-01-07 00719, 2014

      • reosarevok
        warp: yeah, I could live with two lines, copyright whatever and license whatever (see LICENSE for details)
      • 2014-01-07 00723, 2014

      • bitmap
        when I wrote https://github.com/metabrainz/musicbrainz-server/… I snuck in a smaller license header at the top :)
      • 2014-01-07 00752, 2014

      • warp
        bitmap: is that v2 only intentional?
      • 2014-01-07 00719, 2014

      • warp
        bitmap: otherwise please make it GPLv2 or later, so people can use it in GPLv3 projects.
      • 2014-01-07 00747, 2014

      • bitmap
        no, and it should probably reference our COPYING
      • 2014-01-07 00758, 2014

      • zas__
        Such 2-3 lines in headers, with 'see LICENSE/COPYING/AUTHORS' is good enough imho
      • 2014-01-07 00758, 2014

      • warp
        that gnu.org link is quite stable, so I think that part is fine. referencing our own COPYING file instead is also fine.
      • 2014-01-07 00733, 2014

      • derwin
        v2 or later? what does that mean? it's either v2 or 3?
      • 2014-01-07 00747, 2014

      • zas__
        or 7 ...
      • 2014-01-07 00752, 2014

      • bitmap
        warp: isn't the text of the license itself saying any later version is fine, though?
      • 2014-01-07 00738, 2014

      • warp
        derwin: it is commonly used shorthand for "This program is free software: you can redistribute it and/or modify
      • 2014-01-07 00742, 2014

      • warp
        it under the terms of the GNU General Public License as published by
      • 2014-01-07 00743, 2014

      • warp
        the Free Software Foundation, either version 3 of the License, or
      • 2014-01-07 00755, 2014

      • warp
        (at your option) any later version."
      • 2014-01-07 00756, 2014

      • warp
        derwin: er, but with version 2.
      • 2014-01-07 00723, 2014

      • warp
        bitmap: that's the problem, GPL by default does NOT allow any later version.