ruaok: ah. looking at my feed from github, it looks like a subsequent push ended up deleting it
2012-10-17 29118, 2012
ruaok
I moved the tag.
2012-10-17 29106, 2012
ruaok
and then I remember using it. someplace else.
2012-10-17 29111, 2012
ianmcorvidae
there's several 'mayhem created tag v-2012-10-15-schema-change' followed by 'musicbrainz deleted tag v-2012-10-15-schema-change', but the latter is the most recent
2012-10-17 29132, 2012
ianmcorvidae
I suspect you used it before one of the deletions
2012-10-17 29152, 2012
ruaok
odd.
2012-10-17 29105, 2012
ianmcorvidae
point stands, at present it's neither place
2012-10-17 29120, 2012
ianmcorvidae
I think the thing to do is push it to git.mb and let it get automatically mirrored to github
or it made it when it was first tagged, which was about then, later deletions notwithstanding
2012-10-17 29130, 2012
ianmcorvidae
git.mb definitely didn't have it before a couple minutes ago when I pushed it there :)
2012-10-17 29153, 2012
ianmcorvidae
ah, I think it's using the tag creation time, which is independent of when it was pushed
2012-10-17 29122, 2012
ianmcorvidae
the discrepancy is probably that github may have used the original incorrect tag
2012-10-17 29112, 2012
ijabz joined the channel
2012-10-17 29117, 2012
warp
hello!
2012-10-17 29143, 2012
ianmcorvidae
moin moin
2012-10-17 29146, 2012
warp
time for some fixing of things
2012-10-17 29110, 2012
warp
ianmcorvidae: have you done anything related to these broken edits?
2012-10-17 29114, 2012
ianmcorvidae
I have note
2012-10-17 29117, 2012
ianmcorvidae
not*
2012-10-17 29120, 2012
ianmcorvidae
other than vaguely thinking about them
2012-10-17 29126, 2012
warp
haha
2012-10-17 29158, 2012
ianmcorvidae
I think for the comment == null situation changing the edit class is the way to go: we've essentially established that null and '' are the same thing, and that '' is the one we want to store, so it makes sense to turn null into it in our perl code
2012-10-17 29104, 2012
ianmcorvidae
for the whitespace I'm still not sure
2012-10-17 29130, 2012
warp
the whitespace one only concerns a few edits, so either I manually edit those or I script whatever I would do manually.
2012-10-17 29144, 2012
ianmcorvidae
especially as our big problem there is on artist_credit.name, which is a result of join phrases, which are harder to futz with
2012-10-17 29105, 2012
ianmcorvidae
what's hard is properly defining where such editing should happen, I think :)
2012-10-17 29113, 2012
warp
no, not really.
2012-10-17 29145, 2012
warp
well, it's hard to define in a sql query, but it's easy if you can parse the json.
2012-10-17 29157, 2012
ianmcorvidae
well, any one case is easy, I think
2012-10-17 29113, 2012
warp
it's just non-empty join phrase at the end of an artist credit.
2012-10-17 29121, 2012
ianmcorvidae
e.g. "if the last join phrase of a given artist credit matches \s+ turn it into ''"
2012-10-17 29137, 2012
ianmcorvidae
I suppose if that's the only one we're having trouble with
2012-10-17 29154, 2012
ianmcorvidae
incidentally, we may need to fix the artist credit editor(s) to stop doing that, as well
2012-10-17 29121, 2012
warp
select * from edit where status = 1 and data like '%join_phrase":" "%'; reports 9 results. ofcourse " " may not catch all of them.
2012-10-17 29101, 2012
ianmcorvidae
that also catches cases where that's not the last join phrase, potentially
2012-10-17 29116, 2012
warp
sure, but that just means even less edits are affected.
2012-10-17 29133, 2012
warp
I'm going try and script some queries.
2012-10-17 29144, 2012
ianmcorvidae
k
2012-10-17 29111, 2012
ianmcorvidae
but of course don't do any updates yet :)
2012-10-17 29125, 2012
warp
no, I can do that here on my dev machine.
2012-10-17 29143, 2012
warp
I have 10 edits here matching the sql query above.
2012-10-17 29133, 2012
warp
ianmcorvidae: do you know if there is a ticket for this specific issue?
2012-10-17 29149, 2012
ianmcorvidae
I don't think there is
2012-10-17 29119, 2012
ianmcorvidae
because the only people who could have filed it are people who get modbot emails, and none of us have :)
2012-10-17 29116, 2012
warp
that and people anxiously awaiting for their edit to apply, frantically hitting F5 on the edit page
2012-10-17 29159, 2012
thresh joined the channel
2012-10-17 29156, 2012
luks
did somebody test upgrade from the last schema change release?
2012-10-17 29101, 2012
luks
because I don't think it works
2012-10-17 29122, 2012
luks
ERROR: function controlled_for_whitespace(character varying) does not exist
2012-10-17 29122, 2012
ianmcorvidae
luks: ostensibly it was tested; I did not personally
2012-10-17 29116, 2012
luks
from what I can see, it's only created in sql/updates/20120731-constrain-catno-whitespace.sql and CreateFunctions.sql
2012-10-17 29122, 2012
luks
none of which are used in the upgrade script
2012-10-17 29151, 2012
ianmcorvidae
yeah, that does sound correct
2012-10-17 29117, 2012
ianmcorvidae
I guess ruaok's testing wasn't started from the v-2012-05-15-import-fix tag :/
2012-10-17 29114, 2012
luks
oh, that was the actual release tag?
2012-10-17 29122, 2012
luks
ah, misunderstood
2012-10-17 29140, 2012
ianmcorvidae
v-2102-05-15-schema-change was the original release tag but 2012-05-15-import-fix is where you can actually run imports on the may schema change
2012-10-17 29122, 2012
ianmcorvidae
what I mean is the testing for that should have been: check out v-2012-05-15-import-fix, import the 20121013 dump using that, then run the migration
ERROR: duplicate key value violates unique constraint "artist_name_pkey"
2012-10-17 29148, 2012
luks
now it's getting more interesting :/
2012-10-17 29155, 2012
ianmcorvidae
luks: which sha1 are you migrating from?
2012-10-17 29107, 2012
ianmcorvidae
we fixed a bug with that and updated the tag, it wasn't calling SetSequences
2012-10-17 29130, 2012
luks
I'm using mbslave, not mbserver
2012-10-17 29142, 2012
luks
mbserver is only used for inspiration
2012-10-17 29142, 2012
ianmcorvidae
ah
2012-10-17 29148, 2012
luks
and I'm using the latest master
2012-10-17 29107, 2012
ianmcorvidae
well, we updated upgrade.sh to call SetSequences; I don't know if you've updated mbslave accordingly
2012-10-17 29127, 2012
warp
grrr, unicode and perl :(
2012-10-17 29129, 2012
luks
oh, I didn't notice that
2012-10-17 29149, 2012
ianmcorvidae
(the artist_name pkey issue is that one script does inserts to artist_name but replication doesn't update the sequence for artist_name.id, so it tries to insert with IDs that are too small)
2012-10-17 29100, 2012
nikki joined the channel
2012-10-17 29102, 2012
ianmcorvidae
(solution: set the sequences that replication didn't)
2012-10-17 29119, 2012
luks
thanks, that helped, but I think now I'm done, postgresql 8.4 is no longer supported :(
2012-10-17 29133, 2012
luks
I'll have to drop and reimport
2012-10-17 29125, 2012
ianmcorvidae
ijabz: not sure what's up there, looking into it now
2012-10-17 29144, 2012
ianmcorvidae
ijabz: seems to only happen in the RE, which is odd :/
2012-10-17 29108, 2012
adhawkins
ianmcorvidae: I think I did a fetch while the wrong tag was in place.
2012-10-17 29112, 2012
adhawkins
How do I get the appropriate one?
2012-10-17 29117, 2012
adhawkins
git tag delete and then fetch again?
2012-10-17 29127, 2012
ianmcorvidae
adhawkins: a new fetch should do it, I'd expect, but if not delete the tag first
2012-10-17 29115, 2012
adhawkins
Still seems to point to b3b9ed2e25d53499a7dad1b81cc4e36026703e1f
2012-10-17 29122, 2012
adhawkins
Blog says it should be 5bd71d211dceb25a7a0d545a14cb3273e3e89f19
2012-10-17 29132, 2012
adhawkins
I'm doing this from github.
2012-10-17 29136, 2012
ianmcorvidae
yeah, it's definitely 5bd7etc.
2012-10-17 29153, 2012
ianmcorvidae checks github
2012-10-17 29155, 2012
adhawkins
What's the git:// URL for git.mb.org?
2012-10-17 29110, 2012
adhawkins
I'll switch back, just read that's still the 'official' repo
2012-10-17 29149, 2012
ianmcorvidae
hm, I forget, I have the ssh URL at this point
2012-10-17 29156, 2012
adhawkins
Ok, I'll go digging.
2012-10-17 29127, 2012
nikki
luks: where is 8.4 not supported?
2012-10-17 29101, 2012
adhawkins
Doh.
2012-10-17 29105, 2012
adhawkins needs a slap
2012-10-17 29108, 2012
reosarevok joined the channel
2012-10-17 29103, 2012
djce joined the channel
2012-10-17 29101, 2012
adhawkins
For future reference, 'git tag delete tagname' doesn't delete the tag, it creates a new tag called 'delete' that points at tagname :)
LINE 6: SELECT array_agg(artist_credit ORDER BY artist_credit AS...
2012-10-17 29105, 2012
nikki
:(
2012-10-17 29156, 2012
luks
so reimport is the only way to go
2012-10-17 29117, 2012
nikki wonders what would happen if someone reported it as a bug, given that our install file says 8.4 minimum and our upgrade scripts apparently don't work for it
2012-10-17 29149, 2012
reosarevok
Well, that's obviously a bug then
2012-10-17 29157, 2012
reosarevok
So what would happen is that it would be the right report :p
2012-10-17 29156, 2012
nikki
it seems like it would be possible, given that debian stable and ubuntu up to 11.04 have 8.4 by default
2012-10-17 29139, 2012
nikki
I mean as the default version for postgres, I suppose they might have multiple versions available if you specify a specific one
2012-10-17 29146, 2012
reosarevok
I mean, if we say it works and it does not, it's a bug
2012-10-17 29102, 2012
reosarevok
And the answer is probably either fix it or stop saying it works
2012-10-17 29130, 2012
nikki
we should at least warn customers if we're suddenly going to stop claiming to support 8.4
2012-10-17 29105, 2012
reosarevok
Well, yeah, I just didn't want to say fix it or fix it :p
2012-10-17 29146, 2012
ianmcorvidae
we should get our shit done earlier than three days before release, and then do more testing than the bare minimum we did
2012-10-17 29124, 2012
ianmcorvidae
(heh, three days before release, I say like that was actually when things were done)
2012-10-17 29115, 2012
nikki
we should get our shit done earlier than the day we planned to release :P
2012-10-17 29154, 2012
adhawkins
So is there any point me trying an upgrade on 8.4?
2012-10-17 29158, 2012
stefans joined the channel
2012-10-17 29106, 2012
reosarevok
adhawkins: well, you could then report the bug? :p
2012-10-17 29107, 2012
reosarevok
Dunno
2012-10-17 29107, 2012
adhawkins
reosarevok: I also have the issue that I might not have enough disk space to do an in place upgrade anyway.
2012-10-17 29113, 2012
adhawkins
I'll give it a go and see what happens.
2012-10-17 29159, 2012
adhawkins
If the carton deployment ever finishes...
2012-10-17 29106, 2012
ianmcorvidae
heh
2012-10-17 29143, 2012
reosarevok
warp / ocharles / ianmcorvidae: could we try to get this released soon? hopefully in the next release, people keep having issues with this stuff http://codereview.musicbrainz.org/r/2199/
2012-10-17 29157, 2012
warp
ianmcorvidae: I think I have a fix for the joinphrases. I'm going to try it locally now.
2012-10-17 29112, 2012
ianmcorvidae
warp: k, then stick it on gist or such for review?
2012-10-17 29122, 2012
warp
sure
2012-10-17 29118, 2012
warp
ianmcorvidae: success in my test. approving edit 19206591 fails before the patch, succeeds after the patch.
