ianmcorvidae: It's a long time since I wrote the discid generation code in flactag, so I couldn't remember exactly how it's derived :)
I'd forgotten there was an sha1 in there.
ianmcorvidae
libdiscid is the recommended method anyway
so if you used that you wouldn't have seen that anyway
adhawkins
I might actually be using that thinking about it!
So are you saying that (for example) flactag should be passing in the toc as well when it does the discid lookup?
ianmcorvidae
yes!
adhawkins
Aha, that's new. I'd better add that to my TODO list :)
ianmcorvidae
I don't know when that was added; it's certainly not well-advertised
but you will get better results if you do, for things that don't have discids already
so you should do it :)
adhawkins
Do I know that there's been a fuzzy match in the response? (As opposed to a 'definite' match on the discid)?
ianmcorvidae
bonus: it means we know someone who's using that feature, and provides a route for bug fixes on that feature to end up on our plate :P
not sure
I'm about to go look at the code
adhawkins
Because it'd probably be a good idea for flactag to say "I've found these matches, but they weren't on discid, you might still want to submit the discid"
ianmcorvidae
hm, I don't see anything that would disambiguate
adhawkins
There was talk of putting in a percentage match or something?
I think there was a ticket for it somewhere...
ianmcorvidae
currently it uses a hardcoded value of 10000
the significance of which I don't totally understand because it's passed to the postgresql cube extension
ocharles
good morning
ianmcorvidae: iirc, that means 10 seconds leeway
ianmcorvidae
yeah
the create_bounding_cube function is rather long
I was working through it slowly :)
adhawkins: one hack, though, is that the discids are returned in the result
adhawkins: so you can assume it's a fuzzy match if the discid you passed in isn't one of the ones in the release
was a rather subtle thing involving postgresql's user-space spinlocks and kernel logic for balancing processes between processor cores but trying to keep processes on shared cache if possible.
which ended up bouncing the postgresql threads between cores too much
CatBuss joined the channel
ocharles
kepstin-work: yea, I saw that
kepstin-work joined the channel
hawke_1 joined the channel
hawke joined the channel
nikki joined the channel
djce joined the channel
Freso joined the channel
ijabz joined the channel
MBJenkins
ollie: Various schema change process improvements: