bah, I wish codereview was smarter about the diffs between diffs :/
2012-09-05 24941, 2012
ianmcorvidae
(as in I wish I could exclude the things that happen as a result of people pulling in master/beta)
2012-09-05 24950, 2012
noobie joined the channel
2012-09-05 24934, 2012
bitmap
ianmcorvidae: huh…make pot on rika blows up with *** glibc detected *** xgettext: double free or corruption (fasttop): 0x000000000079da90 ***
2012-09-05 24959, 2012
ianmcorvidae
yeah
2012-09-05 24910, 2012
ianmcorvidae
gettext is borked as hell on rika :/
2012-09-05 24931, 2012
ianmcorvidae
I guess the thing to do in that case would be to just run the command for the templates that it's running (that doesn't actually use xgettext, that's just for perl code)
2012-09-05 24954, 2012
ianmcorvidae
which would be find ../root -path ../root/statistics -prune -o -type f -name \*.tt -print | sort | ./extract_pot_templates | msguniq -s > mb_server.pot;
2012-09-05 24908, 2012
ianmcorvidae
or direct it into whatever, since you're just testing to make sure the strings end up in there :)
2012-09-05 24935, 2012
ianmcorvidae
err
2012-09-05 24948, 2012
ianmcorvidae
yeah that's right, that's *pruning* root/statistics, as it should
2012-09-05 24901, 2012
bitmap
yay, that works (after installing a bunch of missing perl modules)
2012-09-05 24909, 2012
ianmcorvidae
oh, heh
2012-09-05 24944, 2012
bitmap
and the <!-- [% %] --> thing works too (but I guess you already knew that or you wouldn't have suggested it :P)
2012-09-05 24920, 2012
ianmcorvidae
haha
2012-09-05 24933, 2012
ianmcorvidae
well, I didn't actually try it, but I figured as much :)
2012-09-05 24944, 2012
ianmcorvidae
hey, the rel editor actually keeps the header intact
2012-09-05 24945, 2012
ianmcorvidae
:D
2012-09-05 24947, 2012
ianmcorvidae approves
2012-09-05 24906, 2012
ianmcorvidae
I guess it doesn't have the problem the release editor does where sometimes it doesn't know the title :P
2012-09-05 24903, 2012
bitmap
thanks to my strategy of "avoid templatetoolkit as much as possible," I did something right then :)
2012-09-05 24915, 2012
ianmcorvidae
heh
2012-09-05 24952, 2012
ianmcorvidae
bah, carton plus the po makefile is sort of a terrible combination
2012-09-05 24903, 2012
ianmcorvidae
have to manually PERL5OPT=-Mlocal::lib in the carton directory to make it work
2012-09-05 24919, 2012
ianmcorvidae
(or install a second copy of the dependencies outside of carton, which is silly)
2012-09-05 24958, 2012
lfranchi joined the channel
2012-09-05 24941, 2012
ianmcorvidae
heh, wow, that's a twiddly formatting bug in codereview/my browser
2012-09-05 24912, 2012
ianmcorvidae
the highlighting for the highlighted-because-removed 'n' in 'unnaccent' is covering up part of the 'u'
ocharles: at least, that's what my testing suggests. if I remove my email address on mb.org (emulating someone who's already removed theirs), I can still edit on beta
2012-09-05 24900, 2012
nikki
ocharles: also if I (as an admin) remove someone else's email address on beta, they can still edit on beta
2012-09-05 24948, 2012
ijabz joined the channel
2012-09-05 24953, 2012
jesus2099 joined the channel
2012-09-05 24924, 2012
jesus2099
ianmcorvidae: I never remember how we start this "private" channel in IRC…
2012-09-05 24935, 2012
ianmcorvidae
jesus2099: /msg ianmcorvidae should do it :)
2012-09-05 24906, 2012
jesus2099
ah thanks (’-_-`)
2012-09-05 24959, 2012
hawke_1 joined the channel
2012-09-05 24937, 2012
Prophet5 joined the channel
2012-09-05 24930, 2012
reosarevok_ joined the channel
2012-09-05 24933, 2012
stefans joined the channel
2012-09-05 24910, 2012
djce joined the channel
2012-09-05 24922, 2012
warp
hello internet
2012-09-05 24942, 2012
Leftmost joined the channel
2012-09-05 24943, 2012
Leftmost joined the channel
2012-09-05 24954, 2012
ocharles
good morning
2012-09-05 24900, 2012
Freso joined the channel
2012-09-05 24926, 2012
ocharles
nikki: I believe that's a bug fixed by another ticket
2012-09-05 24936, 2012
ocharles
(that clearing your email address doesn't clear the confirmation date)
2012-09-05 24938, 2012
ocharles
i'll look into that
2012-09-05 24912, 2012
ocharles
hm, no, maybe not
2012-09-05 24952, 2012
ocharles
nikki: with your first scenario, did you have to re-login to beta?
2012-09-05 24949, 2012
djce joined the channel
2012-09-05 24952, 2012
nikki
no
2012-09-05 24954, 2012
ocharles
ok, so that bug would be fixed with shipping it to production
2012-09-05 24900, 2012
nikki
how?
2012-09-05 24917, 2012
ocharles
because when you clear your email address on musicbrainz.org it sets your email details in the session
2012-09-05 24928, 2012
ocharles
but currently it doesn't set the confirmation date, so beta doesn't pick it up
2012-09-05 24942, 2012
ocharles
but the general problem is that we store stuff in the session and that leads to duplicate state that we forget to update, so I may just improve that patch to stop doing that
2012-09-05 24959, 2012
ocharles
your second bug with the admin stuff is certainly still going to happen with this patch
2012-09-05 24939, 2012
nikki
so you're saying once this ships to master, everyone who's still logged in after removing their email address at some point in the past will suddenly not be able to edit any more, even if they don't touch their profile?#
2012-09-05 24945, 2012
ocharles
no, they would still have to log out and back in
2012-09-05 24958, 2012
nikki
then the bug is not fixed
2012-09-05 24900, 2012
ocharles
well, not quite that explicitly
2012-09-05 24905, 2012
ocharles
their session needs to expire
2012-09-05 24914, 2012
ocharles
they will 'log in' with a cookie too
2012-09-05 24921, 2012
ocharles
i don't know how long sessions last at the monte
2012-09-05 24924, 2012
ocharles
moment*...
2012-09-05 24934, 2012
ocharles
but I agree, fixing this more robustly is a good idea
2012-09-05 24936, 2012
reosarevok
Pretty much forever
2012-09-05 24946, 2012
reosarevok
I haven't had to log in in aaaages
2012-09-05 24910, 2012
ocharles
do you have 'remember me' checked?
2012-09-05 24914, 2012
reosarevok
Sure
2012-09-05 24919, 2012
ocharles
that'd be why then
2012-09-05 24921, 2012
reosarevok
Doesn't everyone?
2012-09-05 24932, 2012
ocharles
your session can expire, but the site will still automatically log you in
2012-09-05 24935, 2012
reosarevok
Oh
2012-09-05 24947, 2012
reosarevok
But it wouldn't let them edit if they have this
2012-09-05 24949, 2012
reosarevok
I see
2012-09-05 24916, 2012
ocharles
when their session expires, the site would log them back in, but pick up the cleared email address. i imagine this much already happens though
2012-09-05 24943, 2012
nikki
on beta or on the main site?
2012-09-05 24914, 2012
reosarevok
I have a guy whose mail address we removed years ago, yet he is still doing the same shit edits we removed the mail for to begin with
2012-09-05 24918, 2012
reosarevok
So certainly not on the main site
2012-09-05 24944, 2012
plaintext joined the channel
2012-09-05 24916, 2012
djce joined the channel
2012-09-05 24951, 2012
jesus2099 joined the channel
2012-09-05 24909, 2012
jesus2099
ianmcorvidae: hey I found another WOWMG REGRESSION again ! (not)
heh ocharles you seem to have asked some of my questions for me on Web Service Moticvation Doc
2012-09-05 24908, 2012
ocharles
ijabz: :)
2012-09-05 24957, 2012
ocharles
ok, I'm off now - it's Last.fm sports day :)
2012-09-05 24922, 2012
voiceinsideyou joined the channel
2012-09-05 24954, 2012
jesus2099 joined the channel
2012-09-05 24919, 2012
djce joined the channel
2012-09-05 24921, 2012
jesus2099
ping ianmcorvidae
2012-09-05 24932, 2012
kurtjx joined the channel
2012-09-05 24957, 2012
kurtjx joined the channel
2012-09-05 24912, 2012
CallerNo6 joined the channel
2012-09-05 24959, 2012
Freso joined the channel
2012-09-05 24953, 2012
ijabz joined the channel
2012-09-05 24927, 2012
kepstin-work
lol @ ocharles
2012-09-05 24934, 2012
kepstin-work
chatting through google docs is kind of silly :)
2012-09-05 24957, 2012
kepstin-work
er, I guess that's ijabz. Silly cursor colours.
2012-09-05 24908, 2012
kepstin-work
I guess that's why we all picked text colours ;)
2012-09-05 24912, 2012
ijabz
kepstin-work chatting through doc mesa things get recorded in the right place
2012-09-05 24913, 2012
ijabz joined the channel
2012-09-05 24958, 2012
kepstin-work
hmm. if you want to show up in the viewers list by name, you can share the document with yourself, apparently.
2012-09-05 24929, 2012
djce joined the channel
2012-09-05 24907, 2012
hawke joined the channel
2012-09-05 24937, 2012
hawke_1 joined the channel
2012-09-05 24947, 2012
ijabz joined the channel
2012-09-05 24901, 2012
avilla joined the channel
2012-09-05 24906, 2012
avilla
hello
2012-09-05 24956, 2012
avilla
in the web service, is it possible that a recording has a global artist-credit, and then a different one (maybe with a "feat." added) in one of its track-lists?
2012-09-05 24907, 2012
avilla
i need to know this as i'm writing a massive update to amarok tagger
2012-09-05 24934, 2012
avilla
so far i'm fetching artist information from the global tag (while searching for a recording, the main <artist-credit/>)
2012-09-05 24903, 2012
avilla
but i've seen that in certain cases there are also <artist-credit/> tags defined inside the <track-list/> tags (i.e., per release)
2012-09-05 24935, 2012
avilla
but, so far, nothing changed (mostly nothing... not the artist ids nor the "joinphrase" attributes)
2012-09-05 24937, 2012
avilla
ideas?
2012-09-05 24938, 2012
CallerNo6
avilla, if I understand your question, yes. An artist credit on a specific tracklist may not match the artist credit on the associated recording.
2012-09-05 24950, 2012
avilla
ok
2012-09-05 24902, 2012
CallerNo6
That will be true especially in classical.
2012-09-05 24916, 2012
avilla
can it be that it features different artist IDs, or the difference can only be, for example, in the language of the "joinphrase" attr or in the order of the artists?
2012-09-05 24920, 2012
avilla
ah
2012-09-05 24958, 2012
CallerNo6
in classical, for instance, the track artist will generally be the composer, while the recording artist will be a list of performers.
2012-09-05 24910, 2012
avilla
uhm
2012-09-05 24912, 2012
avilla
not the opposite?
2012-09-05 24916, 2012
avilla
track is per release
2012-09-05 24918, 2012
avilla
recording is general
2012-09-05 24950, 2012
reosarevok
Sure, but the performer for a recording will always be the same
2012-09-05 24954, 2012
hawke joined the channel
2012-09-05 24903, 2012
reosarevok
(works are more general, and have an actual composer credit)
2012-09-05 24911, 2012
avilla
so there will be multiple "symphony n. 5", one per performer
