Ian McEwen: Use cmp_bag in Controller::RelationshipEditor test, since attribute order is not consistent across machines.
2014-05-13 13359, 2014
MBJenkins
Yippee, build fixed!
2014-05-13 13300, 2014
MBJenkins
Ian McEwen: Re-add improperly-removed space in a qw() for import
2014-05-13 13308, 2014
ianmcorvidae
yay :D
2014-05-13 13341, 2014
misterswag joined the channel
2014-05-13 13321, 2014
chirlu` has left the channel
2014-05-13 13349, 2014
Gentlecat joined the channel
2014-05-13 13307, 2014
itshim joined the channel
2014-05-13 13322, 2014
rvedotrc joined the channel
2014-05-13 13318, 2014
zas joined the channel
2014-05-13 13328, 2014
reosarevok joined the channel
2014-05-13 13346, 2014
ijabz1 joined the channel
2014-05-13 13303, 2014
bandtrace joined the channel
2014-05-13 13320, 2014
Freso
Gentlecat ianmcorvidae: I'm not a fan of the "karma" of a review resetting when the review is altered. That could be one way to "game" the system: if a review gets more negative feedback then positive, go in and change a comma and whoosh, karma is reset.
2014-05-13 13340, 2014
ianmcorvidae
nobody thus far has proposed that as an option, so I imagine that's good news :P
2014-05-13 13348, 2014
Gentlecat
:)
2014-05-13 13307, 2014
rvedotrc joined the channel
2014-05-13 13316, 2014
nikki
not reseting it is also a way to game it, write a positive review then when you have enough positive feedback, edit it to say it sucks :P
2014-05-13 13346, 2014
Gentlecat
I guess that's more about community
2014-05-13 13302, 2014
ianmcorvidae
mostly I'd like it to be possible to say something to the effect of "this review has been edited since some votes were cast, go look at the differences"
2014-05-13 13323, 2014
ianmcorvidae
and/or be able to alert people that something they've voted on has been revised
2014-05-13 13357, 2014
ianmcorvidae
whether you hated a review or loved it, you're likely to be interested in the changes!
2014-05-13 13327, 2014
ijabz1 joined the channel
2014-05-13 13300, 2014
ijabz1
hi bitmap im looking for this chnage to sql re ordering attribute
2014-05-13 13333, 2014
ijabz1
ianmcorvidae coudnt get stabke internet conection last night
2014-05-13 13335, 2014
ianmcorvidae
ijabz1: there's little to no actual change, it's just fewer things being inserted to various tables, such that all series are marked as the same ordering attribute
2014-05-13 13358, 2014
ianmcorvidae
things went well after they started working, I have a PR up for the MBS changes that need to happen
2014-05-13 13315, 2014
ijabz1
Hi, as you say instrument description is missing I'll add that
2014-05-13 13331, 2014
ianmcorvidae
yeah, that's the main thing
2014-05-13 13355, 2014
ijabz1
ordering attribute is missing from output but should be searchable, so do we want that
2014-05-13 13301, 2014
ianmcorvidae
I'm not sure re: ordering type, since ordering attribute will in the newest version always be the same that shouldn't be needed (and we can change it later if we reinstate the situation with several attributes)
2014-05-13 13344, 2014
ijabz1
ordering type is also missing (was never requested in 1st place) so I'll leave that
2014-05-13 13345, 2014
ianmcorvidae
I'd say ordering attribute isn't useful to put in. I'm not sure about ordering type (which is a value determining if a series is automatically edited by way of the 'number' ordering attribute, or if it's ordered manually by users)
2014-05-13 13358, 2014
bitmap
I didn't change the schema for ordering_attribute at all, but I did remove it from the /ws/2 output since it's no longer meaningful
2014-05-13 13303, 2014
ianmcorvidae
ah, if it was left out initially then I'd say it's fine
2014-05-13 13334, 2014
ijabz1
ah, that was probably why I didnt add it to output
2014-05-13 13337, 2014
ianmcorvidae
do we have series type? that's actually useful, though I guess I didn't see it displayed in the search
2014-05-13 13341, 2014
bitmap
and I didn't request ordering_type because I couldn't think of a scenario where it'd be useful
2014-05-13 13354, 2014
ijabz1
yes that should be there
2014-05-13 13357, 2014
ianmcorvidae
yeah, I couldn't really think of one either, hence being unsure
2014-05-13 13306, 2014
ianmcorvidae
ah, yeah, it is there
2014-05-13 13321, 2014
ianmcorvidae
we need to fix the MBS template to not list ordering attribute/ordering type for display then, probably, but that's not a hard fix
2014-05-13 13347, 2014
ianmcorvidae
I can put that in my branch
2014-05-13 13327, 2014
bitmap
which MBS template?
2014-05-13 13338, 2014
ianmcorvidae
results-series.tt
2014-05-13 13350, 2014
bitmap
ah, right
2014-05-13 13319, 2014
ianmcorvidae
you approved that PR anyway though, so I should merge it
2014-05-13 13324, 2014
ianmcorvidae
but those are removed, anyway
2014-05-13 13335, 2014
chirlu` joined the channel
2014-05-13 13348, 2014
rvedotrc1 joined the channel
2014-05-13 13342, 2014
MBJenkins
* Ian McEwen: Search fixes: /search/editor doesn't exist
2014-05-13 13343, 2014
MBJenkins
* Ian McEwen: Don't force direct search for editor/instrument
2014-05-13 13344, 2014
MBJenkins
* Ian McEwen: Fix release-group to release_group before calling type_to_model.
2014-05-13 13345, 2014
MBJenkins
* Ian McEwen: Don't show ordering attribute/ordering type in series search, since they aren't useful
Also added missing Instrument comment and Xml tests
2014-05-13 13349, 2014
MBJenkins
* Paul Taylor: SEARCH-265:Editor search remove filtering if confirm date null
2014-05-13 13308, 2014
rvedotrc joined the channel
2014-05-13 13351, 2014
bandtrace joined the channel
2014-05-13 13358, 2014
ijabz1 joined the channel
2014-05-13 13325, 2014
ijabz1 joined the channel
2014-05-13 13336, 2014
JonnyJD_ joined the channel
2014-05-13 13333, 2014
bandtrace joined the channel
2014-05-13 13346, 2014
ijabz1 joined the channel
2014-05-13 13341, 2014
Nyanko-sensei joined the channel
2014-05-13 13324, 2014
bandtrace joined the channel
2014-05-13 13335, 2014
ruaok joined the channel
2014-05-13 13350, 2014
bandtrace joined the channel
2014-05-13 13343, 2014
outsidecontext joined the channel
2014-05-13 13332, 2014
outsidecontext
hi. does anybody know if the first track in a CD TOC actually can have a number other than 1?
2014-05-13 13310, 2014
sampsyo joined the channel
2014-05-13 13313, 2014
alastairp
hi all
2014-05-13 13320, 2014
alastairp
hi sampsyo
2014-05-13 13315, 2014
ruaok
outsidecontext: no, its always 1
2014-05-13 13316, 2014
ruaok
hi alastairp
2014-05-13 13319, 2014
Freso
outsidecontext: Though there can be audio before track 1. ("HTOA" (Hidden Track One Audio))
2014-05-13 13354, 2014
outsidecontext
ruaok: thanks. i just wondered because the method discid_put in libdiscid requires one to sepcify the first track no. and I wondered if that can make sense
2014-05-13 13336, 2014
JonnyJD_
outsidecontext: from what I remember it doesn't
2014-05-13 13357, 2014
outsidecontext
actually libdiscid currently does not deal well when you set this to anything else than 1, but I will submit a patch
2014-05-13 13317, 2014
JonnyJD_
a patch to check that this is 1?
2014-05-13 13323, 2014
outsidecontext
JonnyJD_, sure, it does. the signature is int discid_put(DiscId *d, int first, int last, int *offsets)
2014-05-13 13301, 2014
outsidecontext
JonnyJD_: that's why I asked. either a patch to make sure it is one or to allow values other than 1
2014-05-13 13349, 2014
JonnyJD_
from what I remember only 1 makes sense. Maybe you find an old ticket about that
2014-05-13 13336, 2014
outsidecontext
thanks. I will have a look.
2014-05-13 13333, 2014
outsidecontext
I found this issue because I have a test in ruby-discid that actually checks if values > 1 lead to plausible results, but this fails with latest libdiscid due to the input checking
2014-05-13 13335, 2014
JonnyJD_
either way, there are different reasons why you would think the first track might not be 1, but even with a data track up front, lots of pregap etc. it is always 1
JonnyJD_, interesting, but that indicates that there can be discs with the first no. > 1
2014-05-13 13320, 2014
zas joined the channel
2014-05-13 13358, 2014
JonnyJD_
but not necessarily that they are "valid"
2014-05-13 13311, 2014
JonnyJD_
in term of standards
2014-05-13 13302, 2014
outsidecontext
not sure if this matters. but at least we should be consistent how those discs are handled.
2014-05-13 13348, 2014
outsidecontext
make things a bit more complicated. i thought just fixing discid_put would be sufficient
2014-05-13 13323, 2014
JonnyJD_
outsidecontext: "The track numbering shall start with the value 01 and shall increment by one"
2014-05-13 13326, 2014
outsidecontext
JonnyJD_, where have you found that statement?
2014-05-13 13350, 2014
Freso casts his vote-of-no-special-significance on making libdiscid conform "strictly" to the standard for now, until someone complains about a disc with first track !=1, and then keeping that disc's TOC around for testing purposes in the future.
2014-05-13 13301, 2014
JonnyJD_
BS EN 609008 1999 british standard does it say in the PDF
2014-05-13 13339, 2014
JonnyJD_
that is the closest I found to a standard (difficult to come by.. old.. cost money.. etc.)
2014-05-13 13354, 2014
outsidecontext
yep
2014-05-13 13304, 2014
outsidecontext
at least we should make sure that reading the TOC with an external tool and using discid_put should get the same results as directly using discid_read
2014-05-13 13333, 2014
JonnyJD_
yep
2014-05-13 13335, 2014
outsidecontext
not sure how discid_read currently would react on such a disc
2014-05-13 13318, 2014
JonnyJD_
and as it goes for copy protected CDs that don't follow any standard: these are difficult either way. I tried my best to make some of these work, but some are just plain broken.
2014-05-13 13313, 2014
bandtrace joined the channel
2014-05-13 13338, 2014
Mineo
JonnyJD_: aren't you still a student? we have access to some standards databases over here
2014-05-13 13326, 2014
JonnyJD_
Mineo: we also have access to *some* standards. I didn't try for this one.
2014-05-13 13358, 2014
JonnyJD_
anyways, what I found is good enough. From what I understand this is some version of that "red book", though not the most current one
2014-05-13 13303, 2014
travis-ci has left the channel
2014-05-13 13301, 2014
JonnyJD_
actually, it might even still be the current standard
