#musicbrainz-devel

/

      • spinza joined the channel
      • 2014-05-16 13642, 2014

      • chirlu` joined the channel
      • 2014-05-16 13607, 2014

      • mr_alias joined the channel
      • 2014-05-16 13602, 2014

      • chirlu` has left the channel
      • 2014-05-16 13602, 2014

      • d4rkie joined the channel
      • 2014-05-16 13632, 2014

      • mr_alias joined the channel
      • 2014-05-16 13625, 2014

      • JHartig_ joined the channel
      • 2014-05-16 13656, 2014

      • JHartig_
        hey guys, i just updated to the latest schema changes and now I'm getting "file error - components/rdfa-macros.tt: not found" on my mirror
      • 2014-05-16 13614, 2014

      • JHartig_
        is there a newer branch I should checkout besides the v-2014-05-14-schema-change
      • 2014-05-16 13606, 2014

      • JHartig
        Found out that plackup failed to restart correctly after the upgrade and left a perl-fcgi worker around which was still trying to serve the old site I guess, fixed it by killing all perl and starting up plackup
      • 2014-05-16 13654, 2014

      • ianmcorvidae
        yeah, that sounds right, rdfa-macros was removed some months ago
      • 2014-05-16 13640, 2014

      • Nyanko-sensei joined the channel
      • 2014-05-16 13609, 2014

      • MBJenkins
        * Ulrich Klauer: Fix tests for "ended" flag in relationship edits
      • 2014-05-16 13610, 2014

      • MBJenkins
        * Ulrich Klauer: Add missing begin_date/end_date to a test
      • 2014-05-16 13611, 2014

      • MBJenkins
        * Ulrich Klauer: Allow removing dates from the mini rel. editor
      • 2014-05-16 13612, 2014

      • MBJenkins
        * Michael Wiencek: MBS-7559: Sort name guess case is missing from series alias pages
      • 2014-05-16 13613, 2014

      • MBJenkins
        * Ian McEwen: MBS-7559: Sort name guess case is missing from series alias pages
      • 2014-05-16 13614, 2014

      • MBJenkins
        * Ian McEwen: MBS-7539: Changing the ordering type is always an autoedit
      • 2014-05-16 13609, 2014

      • JHartig_ joined the channel
      • 2014-05-16 13616, 2014

      • JHartig_ has left the channel
      • 2014-05-16 13651, 2014

      • spinza joined the channel
      • 2014-05-16 13617, 2014

      • ianmcorvidae
        chirlu, bitmap: ^ see errors, I think they're related to the date-related patches, but unsure
      • 2014-05-16 13648, 2014

      • ianmcorvidae
        the Artist::EditRelationships one I can't reproduce locally, which is annoying, but anyway
      • 2014-05-16 13627, 2014

      • ianmcorvidae
        the Series one is about creating relationships, and is adding { year => undef, month => undef, day => undef } hashes for the dates, which I'm not 100% sure is correct
      • 2014-05-16 13639, 2014

      • MBJenkins
        * nikki: Add more series relationships to the URL matching
      • 2014-05-16 13640, 2014

      • MBJenkins
        * Michael Wiencek: Make sure you can't select grouping link types in the RE
      • 2014-05-16 13641, 2014

      • MBJenkins
        * Ulrich Klauer: Fix tests for "ended" flag in relationship edits
      • 2014-05-16 13642, 2014

      • MBJenkins
        * Ulrich Klauer: Add tests for removing dates from a relationship
      • 2014-05-16 13643, 2014

      • MBJenkins
        * Michael Wiencek: MBS-7543: "Cancel" does not revert instrument changes
      • 2014-05-16 13644, 2014

      • MBJenkins
        * Michael Wiencek: MBS-7532: Ignore pasted MBIDs that don't match the entity type of any selectable link type
      • 2014-05-16 13645, 2014

      • MBJenkins
        * Ian McEwen: push(, ...) is not in 5.10
      • 2014-05-16 13646, 2014

      • MBJenkins
        * Michael Wiencek: Acquire a dependency when reading an attribute value, but not when writing
      • 2014-05-16 13647, 2014

      • MBJenkins
        * Ian McEwen: Missing comma
      • 2014-05-16 13617, 2014

      • MBJenkins
        Project musicbrainz-server_beta build #87: STILL FAILING in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13649, 2014

      • Lotheric has left the channel
      • 2014-05-16 13633, 2014

      • spinza joined the channel
      • 2014-05-16 13650, 2014

      • rvedotrc joined the channel
      • 2014-05-16 13620, 2014

      • rvedotrc joined the channel
      • 2014-05-16 13651, 2014

      • spinza joined the channel
      • 2014-05-16 13622, 2014

      • zas joined the channel
      • 2014-05-16 13657, 2014

      • ianmcorvidae
        chirlu: hopefully you read logs :) but anyway just FYI, we're thinking the Artist::EditRelationships test failure has to do with perl 5.18 adding hash randomization, if you look at the 'remove begin date and ended flag' test it's changing attributes to the same value, which should be wrong, we're thinking that's because it's changing it between [1, 4] and [4, 1] due to keys() or values() not returning things in a consistent
      • 2014-05-16 13659, 2014

      • bitmap
        chirlu: would also appreciate if you could review https://bitbucket.org/metabrainz/musicbrainz-serv… since it's related to your stuff
      • 2014-05-16 13625, 2014

      • JesseW joined the channel
      • 2014-05-16 13622, 2014

      • bandtrace joined the channel
      • 2014-05-16 13630, 2014

      • bandtrace joined the channel
      • 2014-05-16 13630, 2014

      • JesseW
        It looks like the list of public collections isn't included in the dumps (because it's in editor_collection, which isn't included). Is this right?
      • 2014-05-16 13649, 2014

      • ijabz1 joined the channel
      • 2014-05-16 13653, 2014

      • D4RK-PH0ENiX joined the channel
      • 2014-05-16 13632, 2014

      • spinza joined the channel
      • 2014-05-16 13601, 2014

      • ianmcorvidae
        JesseW, in case you read the logs, yes, that's correct, I just made a ticket
      • 2014-05-16 13615, 2014

      • ianmcorvidae
        (earlier today, unprompted, so clearly we're on the same channel :P)
      • 2014-05-16 13659, 2014

      • d4rkie joined the channel
      • 2014-05-16 13609, 2014

      • MBJenkins
        Project musicbrainz-server_beta build #88: STILL FAILING in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13610, 2014

      • MBJenkins
        * Ian McEwen: Revert to previous behavior of not including empty partial date hashes in Edit::Relationship::Create data
      • 2014-05-16 13631, 2014

      • ianmcorvidae
        it seems we added one while removing one, good job us :P
      • 2014-05-16 13602, 2014

      • bandtrace joined the channel
      • 2014-05-16 13619, 2014

      • MBJenkins
        Project musicbrainz-server_master build #36: ABORTED in 3 min 10 sec: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13620, 2014

      • MBJenkins
        Ian McEwen: Revert to previous behavior of not including empty partial date hashes in Edit::Relationship::Create data
      • 2014-05-16 13658, 2014

      • MBJenkins
        Ian McEwen: Remove begin_date/end_date from Artist::EditExternalLinks test, where they're also now inaccurate
      • 2014-05-16 13643, 2014

      • spinza joined the channel
      • 2014-05-16 13628, 2014

      • MBJenkins
        Project musicbrainz-server_master build #37: STILL FAILING in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13629, 2014

      • MBJenkins
        Ian McEwen: Remove begin_date/end_date from Artist::EditExternalLinks test, where they're also now inaccurate
      • 2014-05-16 13639, 2014

      • spinza joined the channel
      • 2014-05-16 13650, 2014

      • MBJenkins
        Project musicbrainz-server_master build #38: FIXED in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13651, 2014

      • MBJenkins
        Ian McEwen: Fix Artist::EditRelationships test, and ensure it still works in 5.18
      • 2014-05-16 13611, 2014

      • MBJenkins
        Project musicbrainz-server_beta build #90: FIXED in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13612, 2014

      • MBJenkins
        Ian McEwen: Fix Artist::EditRelationships test, and ensure it still works in 5.18
      • 2014-05-16 13639, 2014

      • ianmcorvidae
        bitmap, nikki, others it may concern: I've hotfixed a subset of things; log at https://github.com/metabrainz/musicbrainz-server/…
      • 2014-05-16 13649, 2014

      • Nyanko-sensei joined the channel
      • 2014-05-16 13645, 2014

      • bandtrace joined the channel
      • 2014-05-16 13653, 2014

      • xram joined the channel
      • 2014-05-16 13627, 2014

      • ijabz1 joined the channel
      • 2014-05-16 13646, 2014

      • UmkaDK joined the channel
      • 2014-05-16 13656, 2014

      • reosarevok joined the channel
      • 2014-05-16 13633, 2014

      • Nyanko-sensei joined the channel
      • 2014-05-16 13659, 2014

      • JonnyJD joined the channel
      • 2014-05-16 13643, 2014

      • MBJenkins
        Project musicbrainz-server_beta build #91: SUCCESS in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13644, 2014

      • MBJenkins
        * Ian McEwen: Revive deleted users (digest) test
      • 2014-05-16 13621, 2014

      • Gentlecat
        any ideas on how to handle wide block with tabs on small devices? http://gentlecat.mbsandbox.org/artist/9c9f1380-25…
      • 2014-05-16 13647, 2014

      • nikki
        luks: updating last_updated for that range seems to have worked :D
      • 2014-05-16 13651, 2014

      • nikki
        thanks :D
      • 2014-05-16 13621, 2014

      • nikki
        (also thanks for updating mbslave so quickly too!)
      • 2014-05-16 13625, 2014

      • chirlu` joined the channel
      • 2014-05-16 13635, 2014

      • chirlu` wonders why MBS-7563 doesn’t affect series as much.
      • 2014-05-16 13635, 2014

      • mb-chat-logger
      • 2014-05-16 13647, 2014

      • chirlu`
        When will a JS type error prevent other code from running?
      • 2014-05-16 13609, 2014

      • warp
        chirlu`: a javascript error will cancel the current thread. any event handlers which had already been registered will continue to work.
      • 2014-05-16 13633, 2014

      • chirlu`
        Thanks. So it’s more or less random, I guess (seen from the outside of Knockout).
      • 2014-05-16 13658, 2014

      • MBJenkins
        Project musicbrainz-server_master build #39: FAILURE in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13659, 2014

      • MBJenkins
        Ian McEwen: A few missing pieces for series subscriptions.
      • 2014-05-16 13638, 2014

      • ianmcorvidae
        meh
      • 2014-05-16 13632, 2014

      • MBJenkins
        Yippee, build fixed!
      • 2014-05-16 13633, 2014

      • MBJenkins
        Ian McEwen: Properly import SeriesSubscription.
      • 2014-05-16 13636, 2014

      • chirlu` joined the channel
      • 2014-05-16 13633, 2014

      • bandtrace joined the channel
      • 2014-05-16 13622, 2014

      • jesus2099 joined the channel
      • 2014-05-16 13629, 2014

      • jesus2099
        bitmap: hello :)
      • 2014-05-16 13625, 2014

      • jesus2099
        i was thinking about my JASRAC work importer… now i see we have relationships in the work edit/create page… so i think i will be able to drop tons of tons of my code in that script, thankfully ! but is it possible to seed that part of the page ?
      • 2014-05-16 13656, 2014

      • ijabz1 joined the channel
      • 2014-05-16 13653, 2014

      • zas joined the channel
      • 2014-05-16 13610, 2014

      • flamingspinach joined the channel
      • 2014-05-16 13643, 2014

      • MBJenkins
        * Ian McEwen: A few missing pieces for series subscriptions.
      • 2014-05-16 13644, 2014

      • MBJenkins
        * Ian McEwen: Properly import SeriesSubscription.
      • 2014-05-16 13623, 2014

      • MBJenkins
        Project musicbrainz-server_beta build #93: SUCCESS in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_…
      • 2014-05-16 13624, 2014

      • MBJenkins
        * Ulrich Klauer: Remove unused function import
      • 2014-05-16 13625, 2014

      • MBJenkins
        * Ulrich Klauer: MBS-7517: Don't call a deleted user "limited user"
      • 2014-05-16 13626, 2014

      • MBJenkins
        * Ian McEwen: Update pot files using current code and production database.
      • 2014-05-16 13627, 2014

      • MBJenkins
        * Ian McEwen: Update translations from transifex.
      • 2014-05-16 13609, 2014

      • kepstin-laptop__ joined the channel
      • 2014-05-16 13629, 2014

      • chirlu`
        ianmcorvidae: The hotfixed tickets should be closed, I think. (They are “In Beta Testing” now.)
      • 2014-05-16 13605, 2014

      • nikki
        chirlu`: btw there's already a ticket for work aliases at http://tickets.musicbrainz.org/browse/MBS-6988
      • 2014-05-16 13654, 2014

      • chirlu`
        Ah. Can I close it as a duplicate, because the new ticket has a broader scope?
      • 2014-05-16 13633, 2014

      • nikki
        I guess :)
      • 2014-05-16 13625, 2014

      • JesseW joined the channel
      • 2014-05-16 13626, 2014

      • ianmcorvidae
        chirlu`: I'm not worrying too much about it for now, re: beta/fixed
      • 2014-05-16 13633, 2014

      • MBJenkins
        Ian McEwen: s/[%-? MACRO/[%~ MACRO/g in common-macros, i.e., kill some more generated newlines
      • 2014-05-16 13627, 2014

      • CallerNo6 joined the channel
      • 2014-05-16 13640, 2014

      • hawke joined the channel
      • 2014-05-16 13622, 2014

      • Nyanko-sensei joined the channel
      • 2014-05-16 13608, 2014

      • UmkaDK joined the channel
      • 2014-05-16 13650, 2014

      • UmkaDK
        Guys, I'm still getting trouble config MB to run without a Redis server any chance somebody could give me a hand?
      • 2014-05-16 13622, 2014

      • UmkaDK
        So far the server is building ok, with no errors.
      • 2014-05-16 13631, 2014

      • UmkaDK
        ... but this is what I get when testing access to the frontpage: Redis installed, home page load time: 268.823 ms, Redis not installed, home page load time: 60302.063ms. (Each test was preceded by the server restart)
      • 2014-05-16 13630, 2014

      • ianmcorvidae
        oh, hm, Controller::Root does probably care about it, since it uses it for the alert banner
      • 2014-05-16 13647, 2014

      • UmkaDK
        Thanks ianmcorvidae, I'm looking at it right now... but I was thinking that may be I can side step the entire issue by setting redis time out to 0?
      • 2014-05-16 13657, 2014

      • ianmcorvidae
        that might work, yeah
      • 2014-05-16 13656, 2014

      • UmkaDK
        Ok, now all I have to do is to find where to configure that time out! :)
      • 2014-05-16 13625, 2014

      • ianmcorvidae
        I think you can do it in DATASTORE_REDIS_ARGS, under redis_new_args->cnx_timeout
      • 2014-05-16 13638, 2014

      • ianmcorvidae
        ah, or possibly 'reconnect'
      • 2014-05-16 13645, 2014

      • ianmcorvidae
        probably that, since our defaults set that to 60s
      • 2014-05-16 13651, 2014

      • UmkaDK
        Awesome!!
      • 2014-05-16 13604, 2014

      • UmkaDK is giving it a go
      • 2014-05-16 13619, 2014

      • ianmcorvidae
        dunno what it'll do if you set it to 0, though that might be the same as removing it, and you might still want to add a cnx_timout
      • 2014-05-16 13630, 2014

      • ianmcorvidae
        ( https://metacpan.org/pod/Redis ) for all of these options
      • 2014-05-16 13640, 2014

      • UmkaDK
        Thanks a lot ianmcorvidae!! Let me just give all of that a go and I'll get back to you how it went...
      • 2014-05-16 13614, 2014

      • spinza joined the channel
      • 2014-05-16 13600, 2014

      • hawke
        uhhh…it’s not possible to have the same thing multiple times in one series?
      • 2014-05-16 13652, 2014

      • ianmcorvidae
        if it's not possible I don't think that's deliberate
      • 2014-05-16 13623, 2014

      • ianmcorvidae
        our code might not do the right thing with identical relationships other than link_order/other than text attributes
      • 2014-05-16 13640, 2014

      • hawke
        It seems to try to update the existing relationship…
      • 2014-05-16 13648, 2014

      • demosdemon joined the channel
      • 2014-05-16 13657, 2014

      • bitmap
        it should work if they have different text attributes, but without any attributes I think it may not check the link orders
      • 2014-05-16 13659, 2014

      • kepstin-laptop
        hawke: what case do you have where it makes to have something in a series more than once, anyways?
      • 2014-05-16 13616, 2014

      • hawke
        https://beta.musicbrainz.org/series/dbf802a4-f5fc… — “ Festmarsch in D major for piano quartet” is apparently in the catalog twice.
      • 2014-05-16 13657, 2014

      • ianmcorvidae
        hm
      • 2014-05-16 13603, 2014

      • ianmcorvidae
        seems like an error in the javascript, yeah
      • 2014-05-16 13618, 2014

      • ianmcorvidae
        I suspect the backend would do the right thing if you could get the interface into the right state (which is of course not helpful, but :P)
      • 2014-05-16 13608, 2014

      • kepstin-laptop suspects that most of the series ISEs that he's seen were because the JS didn't submit a valid state :/
      • 2014-05-16 13618, 2014

      • hawke
        heh…
      • 2014-05-16 13619, 2014

      • hawke
        Incorrect entity type for part of series relationship at lib/MusicBrainz/Server/Data/Relationship.pm line 423, <$fh> line 1.