#musicbrainz-devel

serving as part of the app itself should be easiest, methink.

+s

can you create a googledoc with requirements?

Gentlecat: we have an existing doc, right?

oh, right

thx

* dufferzafar0: Don't check review length when it's being saved as a draft

* dufferzafar0: Fix import path of manage module in fabfile

mind if clear out in the inline questions?

yeah

most of this stuff is implemented anyway

yeah.

Wrote some tests for the /reviews/ view: https://bitbucket.org/metabrainz/critiquebrainz...

login working ok?

yes it is. it's the same snippet i showed you

nice

turns out I was using it wrong

i really wish there were a way we could ACTUALLY TEST the login

(not hack our way through it)

I don't know what python provides, but if I was doing it in perl I'd use an LWP::UserAgent::Mockable, record what a "correct" response from MusicBrainz is in the case of both correct and incorrect logins, and then use that

(i.e., mock the responses from MB, ensure the CB code does the right thing in the appropriate cases)

ianmcorvidae: so we just hard code a response from MB?

basically. I mean, that's what mocking is, in general

see https://github.com/metabrainz/critiquebrainz/bl...

you'd want to mock out several different states -- successful login, didn't permit you access, invalid oauth key/secret, etc.

and then you're writing tests to make sure it does the right thing in each of those cases

since obviously you're not going to write tests of MB in it, those belong in MBS :)

it doesn't seem that hard now, will definitely look into this later today.

Gentlecat: document updated. please have a look and see what I need to flesh out.

ruaok: how does this "polling mechanism" work? just looking if n+1 item shows up?

it knows that the replication packets get put onto the ftp site roughly 10 minutes after the hour.

so, 15 minutes after the hour they can check.

it doesn’t always work out that way, so some client check every 15 minutes.

document looks good

great.

to goal is to have all of this in place well before may 15.

I ideally April 15th, so that people have a month to sign up for their keys.

what's on may 15?

next schema change I guess

our next schema change.

ah

yeah, the idea is to do it then we our customers need to concern themselves with MB related issues in the first place

alright, I'll aim for that then

got a couple of other things going on as well (prototyping that dataset thing for AB and project at the uni)

perfect.

need to poke alastairp to take a look at that login thing again to put up a pull request with dataset stuff and start getting some feedback

or maybe I can just merge these

since login stuff on its own is kind of useless

I think its a good idea to merge and now show the login link.

that way the branch doesn’t have a chance to rot

show it?

s/now/not/

ok

ruaok: there's a sticky note on my screen that says "review ab login"

unfortunately there's 10 other sticky notes surrounding it

a physical note?

yes

I have physical sticky notes surrounding my screens

oh, I wrote it

just assuming that's what you were poking me about

oh, I get it. ok.

yeah.

alastairp: no rush

I've got some other stuff going anyway

ok

loads of other stuff. :)

reosarevok: did you answer Federico Moscogiuri?

alastairp: is mark fletcher the groups.io guy you worked with?

yep

sweet, I’ll do some name dropping then. :)

sure thing

speaking of groups.io, I'm kinda confused

if it's for email, what exactly do you want us to look at on the site?

anything that might make you object.

site design notwithstanding.

I object to that. :)

I'm not sure why the site design is relevant anyway, I don't read email in a browser :P

put it this way, if there was something wrong with the site and I *didn’t* ask for feedback, everyone would be jumping all over me.

I’m just CYA

ruaok: no, but I will

Now that you reminded me :p

reosarevok: thx

I would still like to see how it displays a somewhat heavy traffic list with nested threads.

And preferably nested threads that change topic during conversation.

And where the e-mail client botches the "In-Reply-To:" header and only had the subject line to identify the thread.

it can't display it much worse than mailman

Add it to the agenda? :)

apparently in november, december, january and this month we got a grand total of... one post... and even that was a gsoc one that should've been on -devel :P

(And perhaps write to -users notifying the list about upcoming discussion?)

it looks like -commits is also useless these days too, now that we're using git

meh, pass :P

reosarevok has changed the topic to: Icing week | Agenda: reviews/general discussion, mailing lists (ruaok) and closing the -users one (nikki/reotab)

I know. :)

Nothing to notify to the list, nobody is using it, let it stay like that until it closes :p

We don't want to remind them it exists so that they'll actually miss it later!

we don't have itunes id by song

i'll look into that

ruaok: speaking of groups.io, get my email? I had some probably-non-blocking concerns, playing my usual role as nitpicker :P

Hey, I was going through the Picard-website repo and issues. Most of the issues created are really old. Should I work on them or should I start looking somewhere else?

They can't be that old, if they're for the Picard site, since that site was created a year ago

(if they're older than that, maybe you're looking at issues for the Picard tagger itself?)