#musicbrainz-devel

oh, speaking of taco

there is a taco bell here in BCN. Jusy sayin...

though, that’s an awesome idea

the taco shell

it’s our interface to tacos!

:-D

alastairp: I was thinking about how we use terminology in AB

maybe we should be consistent with MusicBrainz?

where possible that is good.

where?

because I keep seeing track and recording

are these considered the same?

no.

is this actually a track or recording http://acousticbrainz.org/770cc467-8dde-4d22-bc...

man, I need to remember all of these dam MBIDs for that song.

title links to recording

a recording is the more canonical portion of the data.

a track is a specific instance of a recording.

if say, a recording in a different country has a different title, we'd use a track for that.

but contents are the same?

all acousticbrainz mbids are recordings

note that because of historical cddb usage, id3 tags for recordings are called “musicbrainz tracks"

which made things really fun when we started saving track ids in id3 tags as well ;)

ugh, don't remind me.

alastairp: anyway, something to keep in mind

yeah, in code we should be completely in line with musicbrainz

the header on the detail page… I don’t know

changing Track to Recording doesn’t bother me

alastairp: I pushed changes to test modules and .data

ok

I still haven’t got through 108, but from our discussions I don’t think there’ll be anything

what do you want to know?

my only not-quite-a-concern is the postgres exceptions

I mean, now I understand what the changes were

in principle I agree with everything

not sure if there are any code that could be changed

Yippee, build fixed!

Michael Wiencek: Ensure test doesn't match git commit hash

the only change from user-facing side is that there's another HTTP status returned if database errors happen (but they shouldn't)

was Bad Request or Service Unavailable, now it's ISE

right

+ there was no logging there

it’d be nice if it was handled somehow

I actually want to look into that some more after that

I mean, can we have a flask hook?

hook for what?

which does specific logging/error message on psycopg2 errors

flask has an exception handler, right?

if exception occurs it is logged and user sees ISE

ah, that’s basically what I mean

cool

and before that I don't think we even got any info about postgres errors

unless there's some kind of monitoring stuff attached that I don't know about

nope

OK. I’m done with 108. all good

sigh. 109 tomorrow then...

yup

I'll deploy that on test server as well

ok.

goodnight then

Project musicbrainz-server_master build #159: SUCCESS in 17 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

* jesse: Add a minimal test of find_by_collection

* jesse: Add description for Collate tests

* jesse: Standardize indentation at 4 spaces, in Alias.pm

* jesse: Apply some minor review comments

* jesse: Rearrange tests to take advantage of subtests

* nikki: Remove/replace broken wikidocs links

* Michael Wiencek: Update lodash to 3.9.3

* Michael Wiencek: Tweaks to MBS-4145 based on PR feedback

* Michael Wiencek: Move json glue to reusable MB::S attribute

* nikki: Remove alter_edit_pending, initialize, insert and reject from historic edits

* nikki: Update historic edit template classes to match new edit type names

* nikki: Mark change track artist edits as historic

* Michael Wiencek: MBS-8430: rejected create edits should be applied if the entity can't be deleted

* Ian McEwen: MBS-8004: Place collections

* Michael Wiencek: Simplify sort with nsort_by

* Michael Wiencek: Use correct series type_id

* Ian McEwen: No sense ordering at an intermediate stage by something that won't matter

* Ian McEwen: Use correct template for historic Add PUIDs

* Michael Wiencek: Fix another wrong series type_id

* Ian McEwen: Guard against missing/deleted recordings in Edit::Recording::AddISRCs

* Michael Wiencek: Move knockout to package.json

* Ian McEwen: Add consistent ordering for edits for subscriptions in Data::Edit and tests.

* Michael Wiencek: Fix small typo

:o

release day :)

haha

I was wondering what that was

I assumed it was something like that though and just decided to figure it'd fix itself XD

Project musicbrainz-server_beta build #565: SUCCESS in 16 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

Michael Wiencek: Fix small typo

New post: blog: Server update, 2015-06-29 <http://blog.musicbrainz.org/2015/06/29/server-u...;