-
Gentlecat
oh, speaking of taco
2015-06-29 18037, 2015
-
ruaok
there is a taco bell here in BCN. Jusy sayin...
2015-06-29 18045, 2015
-
alastairp
though, that’s an awesome idea
2015-06-29 18048, 2015
-
alastairp
the taco shell
2015-06-29 18053, 2015
-
alastairp
it’s our interface to tacos!
2015-06-29 18058, 2015
-
ruaok
:-D
2015-06-29 18014, 2015
-
Gentlecat
alastairp: I was thinking about how we use terminology in AB
2015-06-29 18027, 2015
-
Gentlecat
maybe we should be consistent with MusicBrainz?
2015-06-29 18047, 2015
-
ruaok
where possible that is good.
2015-06-29 18057, 2015
-
Gentlecat
unless there's a reason for it
2015-06-29 18015, 2015
-
alastairp
where?
2015-06-29 18034, 2015
-
Gentlecat
because I keep seeing track and recording
2015-06-29 18042, 2015
-
Gentlecat
are these considered the same?
2015-06-29 18004, 2015
-
ruaok
no.
2015-06-29 18045, 2015
-
Gentlecat
2015-06-29 18034, 2015
-
ruaok
man, I need to remember all of these dam MBIDs for that song.
2015-06-29 18037, 2015
-
Gentlecat
title links to recording
2015-06-29 18052, 2015
-
ruaok
a recording is the more canonical portion of the data.
2015-06-29 18004, 2015
-
ruaok
a track is a specific instance of a recording.
2015-06-29 18027, 2015
-
ruaok
if say, a recording in a different country has a different title, we'd use a track for that.
2015-06-29 18048, 2015
-
Gentlecat
but contents are the same?
2015-06-29 18053, 2015
-
alastairp
all acousticbrainz mbids are recordings
2015-06-29 18029, 2015
-
alastairp
note that because of historical cddb usage, id3 tags for recordings are called “musicbrainz tracks"
2015-06-29 18009, 2015
-
kepstin-laptop
which made things really fun when we started saving track ids in id3 tags as well ;)
2015-06-29 18020, 2015
-
ruaok
ugh, don't remind me.
2015-06-29 18034, 2015
-
Gentlecat
alastairp: anyway, something to keep in mind
2015-06-29 18058, 2015
-
alastairp
yeah, in code we should be completely in line with musicbrainz
2015-06-29 18007, 2015
-
alastairp
the header on the detail page… I don’t know
2015-06-29 18018, 2015
-
alastairp
changing Track to Recording doesn’t bother me
2015-06-29 18040, 2015
-
Gentlecat
alastairp: I pushed changes to test modules and .data
2015-06-29 18049, 2015
-
alastairp
ok
2015-06-29 18008, 2015
-
alastairp
I still haven’t got through 108, but from our discussions I don’t think there’ll be anything
2015-06-29 18028, 2015
-
Gentlecat
what do you want to know?
2015-06-29 18032, 2015
-
alastairp
my only not-quite-a-concern is the postgres exceptions
2015-06-29 18038, 2015
-
alastairp
I mean, now I understand what the changes were
2015-06-29 18044, 2015
-
alastairp
in principle I agree with everything
2015-06-29 18058, 2015
-
alastairp
not sure if there are any code that could be changed
2015-06-29 18058, 2015
-
MBJenkins
Yippee, build fixed!
2015-06-29 18059, 2015
-
MBJenkins
Michael Wiencek: Ensure test doesn't match git commit hash
2015-06-29 18012, 2015
-
Gentlecat
the only change from user-facing side is that there's another HTTP status returned if database errors happen (but they shouldn't)
2015-06-29 18055, 2015
-
Gentlecat
was Bad Request or Service Unavailable, now it's ISE
2015-06-29 18007, 2015
-
alastairp
right
2015-06-29 18008, 2015
-
Gentlecat
+ there was no logging there
2015-06-29 18023, 2015
-
alastairp
it’d be nice if it was handled somehow
2015-06-29 18025, 2015
-
Gentlecat
I actually want to look into that some more after that
2015-06-29 18030, 2015
-
alastairp
I mean, can we have a flask hook?
2015-06-29 18041, 2015
-
Gentlecat
hook for what?
2015-06-29 18047, 2015
-
alastairp
which does specific logging/error message on psycopg2 errors
2015-06-29 18058, 2015
-
alastairp
flask has an exception handler, right?
2015-06-29 18031, 2015
-
Gentlecat
if exception occurs it is logged and user sees ISE
2015-06-29 18050, 2015
-
Gentlecat
2015-06-29 18006, 2015
-
alastairp
ah, that’s basically what I mean
2015-06-29 18007, 2015
-
alastairp
cool
2015-06-29 18021, 2015
-
Gentlecat
2015-06-29 18053, 2015
-
Gentlecat
and before that I don't think we even got any info about postgres errors
2015-06-29 18012, 2015
-
Gentlecat
unless there's some kind of monitoring stuff attached that I don't know about
2015-06-29 18021, 2015
-
alastairp
nope
2015-06-29 18030, 2015
-
alastairp
OK. I’m done with 108. all good
2015-06-29 18036, 2015
-
alastairp
sigh. 109 tomorrow then...
2015-06-29 18053, 2015
-
Gentlecat
yup
2015-06-29 18043, 2015
-
Gentlecat
I'll deploy that on test server as well
2015-06-29 18016, 2015
-
alastairp
ok.
2015-06-29 18018, 2015
-
alastairp
goodnight then
2015-06-29 18006, 2015
-
ianmcorvidae|alt joined the channel
2015-06-29 18043, 2015
-
MBJenkins
2015-06-29 18044, 2015
-
MBJenkins
* jesse: Add a minimal test of find_by_collection
2015-06-29 18045, 2015
-
MBJenkins
* jesse: Add description for Collate tests
2015-06-29 18046, 2015
-
MBJenkins
* jesse: Standardize indentation at 4 spaces, in Alias.pm
2015-06-29 18047, 2015
-
MBJenkins
* jesse: Apply some minor review comments
2015-06-29 18048, 2015
-
MBJenkins
* jesse: Rearrange tests to take advantage of subtests
2015-06-29 18049, 2015
-
MBJenkins
* nikki: Remove/replace broken wikidocs links
2015-06-29 18050, 2015
-
MBJenkins
* Michael Wiencek: Update lodash to 3.9.3
2015-06-29 18051, 2015
-
MBJenkins
* Michael Wiencek: Tweaks to MBS-4145 based on PR feedback
2015-06-29 18052, 2015
-
MBJenkins
* Michael Wiencek: Move json glue to reusable MB::S attribute
2015-06-29 18003, 2015
-
MBJenkins
* nikki: Remove alter_edit_pending, initialize, insert and reject from historic edits
2015-06-29 18004, 2015
-
MBJenkins
* nikki: Update historic edit template classes to match new edit type names
2015-06-29 18005, 2015
-
MBJenkins
* nikki: Mark change track artist edits as historic
2015-06-29 18006, 2015
-
MBJenkins
* Michael Wiencek: MBS-8430: rejected create edits should be applied if the entity can't be deleted
2015-06-29 18007, 2015
-
MBJenkins
* Ian McEwen: MBS-8004: Place collections
2015-06-29 18008, 2015
-
MBJenkins
* Michael Wiencek: Simplify sort with nsort_by
2015-06-29 18009, 2015
-
MBJenkins
* Michael Wiencek: Use correct series type_id
2015-06-29 18010, 2015
-
MBJenkins
* Ian McEwen: No sense ordering at an intermediate stage by something that won't matter
2015-06-29 18011, 2015
-
MBJenkins
* Ian McEwen: Use correct template for historic Add PUIDs
2015-06-29 18012, 2015
-
MBJenkins
* Michael Wiencek: Fix another wrong series type_id
2015-06-29 18023, 2015
-
MBJenkins
* Ian McEwen: Guard against missing/deleted recordings in Edit::Recording::AddISRCs
2015-06-29 18024, 2015
-
MBJenkins
* Michael Wiencek: Move knockout to package.json
2015-06-29 18025, 2015
-
MBJenkins
* Ian McEwen: Add consistent ordering for edits for subscriptions in Data::Edit and tests.
2015-06-29 18026, 2015
-
MBJenkins
* Michael Wiencek: Fix small typo
2015-06-29 18030, 2015
-
legoktm
:o
2015-06-29 18042, 2015
-
ianmcorvidae|alt
release day :)
2015-06-29 18009, 2015
-
bitmap was mildly amused at the random ratings test failure matching '100' in the git commit hash
2015-06-29 18031, 2015
-
ianmcorvidae
haha
2015-06-29 18033, 2015
-
ianmcorvidae
I was wondering what that was
2015-06-29 18045, 2015
-
ianmcorvidae
I assumed it was something like that though and just decided to figure it'd fix itself XD
2015-06-29 18011, 2015
-
xps2 joined the channel
2015-06-29 18015, 2015
-
xps2 joined the channel
2015-06-29 18002, 2015
-
ariscop joined the channel
2015-06-29 18013, 2015
-
MBJenkins
2015-06-29 18014, 2015
-
MBJenkins
Michael Wiencek: Fix small typo
2015-06-29 18018, 2015
-
mb-chat-logger
New post: blog: Server update, 2015-06-29 <http://blog.musicbrainz.org/2015/06/29/server-update-2015-06-29/>
