#musicbrainz-devel

so next release is on the 27th right?

Project musicbrainz-server_beta build #488: SUCCESS in 16 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

* Ulrich Klauer: Provide a dummy Editor with high editing privileges

* Ulrich Klauer: Add test for MBS-8234

Project musicbrainz-server_master build #131: SUCCESS in 16 min: http://ci.musicbrainz.org/job/musicbrainz-serve...

* Michael Wiencek: Merge duplicate release_labels when labels are merged (MBS-8163)

* Michael Wiencek: Also prevent duplicate EditReleaseLabel edits from applying

* Michael Wiencek: Move fullWidthConverter to the track parser

* Michael Wiencek: Move is_latin to the Autocomplete code

* Michael Wiencek: Move mergeDates to relationship-editor module

* Michael Wiencek: Move computedWith to release-editor utils

* Michael Wiencek: Move unformatTrackLength to the release-editor utils

* Michael Wiencek: Move iteratePromises to CoverArt.js

* Michael Wiencek: Move formatTrackLength to separate module

* Michael Wiencek: Unused import

* jesse: Factor out two more references to collection tables

* jesse: Add check for medium_id being undefined

* Michael Wiencek: Import filesize where it's used

* Michael Wiencek: Future-proof Edit::Label::Merge test

* Michael Wiencek: Bump react to 0.13.1

* Michael Wiencek: Bump reactify to 1.0

* Ulrich Klauer: MBS-8300: Display title "0" in "Add medium" edits

* Ulrich Klauer: Use a correct apostrophe in a string

* Ulrich Klauer: MBS-8234: Wait a minimum time before accepting edits

* Ulrich Klauer: Add test for MBS-8234

New post: blog: Server update, 2015-04-06 <http://blog.musicbrainz.org/2015/04/07/server-u...;

* Michael Wiencek: Replace browserify with yarb

* Michael Wiencek: Fix language bundles

* Ian McEwen: Add work_lastmod table to constants and an export group (private, for now)

* Michael Wiencek: Fix gulp watch

* Michael Wiencek: Use yarb method chaining where we can

* Michael Wiencek: Bump tape to 4.0.0

Is there a central mapping between entities and their translated names? i.e. so I can do %ENTITIES->{name} or something like that?

we have a format_entity_type_name macro in the templates, I don't think there's anything in the perl though

I'm doing this in the templates. I'll look for that macro.

I found the macro. That should probably be moved into Constants.pm ;-)

but it'll do for now, certainly.

yeah, it predates %ENTITIES by a while but that'd be saner to generate it from there

heh

nope; Release Group vs. Release group

and what about adding another word after the entity, like "Release Collections"...

I guess we'd need a sentence case thing in %ENTITIES too

Michael Wiencek: Don't lose FailedDependency refs that happen right in initialize

for stuff like '$entity Collections' you'd probably need a new macro, or just make the string general if you can

though I suppose it's for sections on a page or something

so a macro would make sense there

er, how do I *use* the macro in common-macros.tt?

it should be available everywhere?

hm

or do you mean how to pass the entity type to it?

I think that is my question, then yeah

hm

I'd have to see the template to know

solved it -- I just needed to remove $

ah

here's what I'm working on: https://bitbucket.org/metabrainz/musicbrainz-se...

hopefully that should make it clearer what I am asking about with regard to translated phrases...

ah

yeah...adding an entity_collections_name macro or similar is probably the easiest solution atm

I presume the solution I have there won't work...

?

nope, concatenating translated strings in general is a bad idea

sigh.

should be really easy to copy/paste format_entity_type_name and tweak it to suit your needs

yep

should I put it in common-macros, or the (single) file that uses it?

(presumably the 2nd)

second is fine

Michael Wiencek: Don't lose FailedDependency refs that happen right in initialize

bitmap: BTW, do you know why we use FOR in the templates, instead of FOREACH?

I'd guess either because it's shorter or because someone started using it and then everyone else followed :)

I can't find anywhere where it is documented as *existing*, though. which is what is confusing me... :-)

yeah, dunno. when I first started hacking on MB I just copied what the current templates were using

heh

g'night

thanks for the help

working internet connection FTW \ø/

it's overrated

just like oxygen?

overrated until you don't have it anymore?

like oxygen, everyone thinks they need it, but it isn't really /that/ important

sigh. accounting.

I double dog dare you to comment on this thread: https://github.com/arduino-org/Arduino/issues/2

github should really add some kind of "+1" button for issues

+1

(That's another thing that Bitbucket has over GitHub.)

(Not that that stops people from making "+1" comments…)

\ø/ finances for the last couple of months are done.

(and looking pretty good at that. :) )

can you check 3 pull requests for CB that were up for a long time?

ruaok: ^

I'll try and do that next

woot. it sounds like the blog post about our pgboucer/postgres resolution is helping people!

:)

Gentlecat: mineo's comment: > The minified Bootstrap in that folder is also MIT, as are the Glyphicons font files if they're used as part of Bootstrap (http://glyphicons.com/license/)

does the list that is in that PR include the things the pointed out?

its is hard to tell by looking at it.

yeah, first two entries

three actually

ok, approved. do I need to worry about any of the other PRs?

looks like duffer is still working on his PRs

another one is unfinished

k

* roman: Enforcing clarity with keyword-only arguments in Review model methods.

* roman: Added missing licensing information for jQuery and Less.

* roman: Added missing references.

alastairp: ping