luks, can i ask u something? the little helper plugins? is it ok if they get included in script.py? :)
2009-10-14 28716, 2009
luks
NXisGOD: which ones?
2009-10-14 28736, 2009
luks
I think I'd prefer to not include any plugins by default
2009-10-14 28753, 2009
luks
or if we include them, not make them enabled by default
2009-10-14 28724, 2009
NXisGOD
alphachar and initials are 2 plugins that add 2 the functions in script.py
2009-10-14 28735, 2009
NXisGOD
ive made my installer changes bundle plugins into installation itself, but it's disabled by default. it's useful for people who have no idea where to place plugins. plus my changes to the plugins page open the plugins folder, and open the web page to download plugins.
2009-10-14 28730, 2009
ijabz
luks, hi
2009-10-14 28702, 2009
luks
ijabz: hi
2009-10-14 28719, 2009
luks
NXisGOD: I'm not sure what is alphachar, but initials just add a script function
but if you want to replace it, be sure to go though old bug reports see if it can handle the characters
2009-10-14 28742, 2009
ijabz
Ok, Ill take a look (i passes the existing tests anyway)
2009-10-14 28702, 2009
nikki
heh, I'd be impressed if anyone actually tries to use that particular character
2009-10-14 28751, 2009
nikki
would you be able to take a list of characters and output what it converts them to?
2009-10-14 28755, 2009
nikki
I mean... I can easily generate lists of characters, but I don't know easy it would be to get that to output what it converts it to
2009-10-14 28703, 2009
ijabz
Its easily readable in the source code of ASCIIFoldingFilter
2009-10-14 28751, 2009
nikki wonders where the source is
2009-10-14 28716, 2009
luks
anyway, if you switch to ASCIIFoldingFilter I'll update the code to build the unaccent tables, so that we have identical functionality in the internal search
but it's cool if it can optimize a huge switch like that
2009-10-14 28744, 2009
nikki
I wonder if normalisation stuff is slow...
2009-10-14 28738, 2009
nikki
'cause my first instinct would be to use one of the D forms and then just remove all the combining accents, rather than having so many thingies in the switch
2009-10-14 28745, 2009
luks
that's what libunac does
2009-10-14 28702, 2009
ijabz
I'll run some tests on index building to get a comparison of the two approaches
2009-10-14 28703, 2009
luks
libunac (and UnaccentFilter) first tries to remove combining accents, then it does some text based replacements, and then has a hard-coded list of a few characters
2009-10-14 28742, 2009
luks
it should be easy to run a report over the whole unicode, and list codepoints which are handled differently
2009-10-14 28755, 2009
ijabz
Could do, I was thinking simple performance test first
2009-10-14 28736, 2009
luks
I think correctness is more important then performance :)
2009-10-14 28714, 2009
luks
both ways just replace characters based on a lookup table
2009-10-14 28729, 2009
luks
you can rewrite them to be equally efficient
2009-10-14 28716, 2009
ijabz
Performance was the issue a minute ago ... , could work out differences but doubt Id understand the results ;)
2009-10-14 28750, 2009
luks
no, I didn't mean it's a problem
2009-10-14 28702, 2009
luks
I was just wondering if JVM can really optimize stuff like that
2009-10-14 28735, 2009
ijabz
I don't know thats why I was just going to run a test.
2009-10-14 28720, 2009
nikki
ijabz: that's why you'd show us the results :P I'm sure one of us would understand them
the argument is that by fixing this bug picard could do better matching, which seems to be a number #1 request on uservoice.
2009-10-14 28714, 2009
ruaok
do you agree with that?
2009-10-14 28719, 2009
outsidecontext
mmh
2009-10-14 28746, 2009
ruaok
I thought the biggest problem was users attaching puids to non-album tracks.
2009-10-14 28753, 2009
ruaok
which then causes those tracks to be preferred.
2009-10-14 28707, 2009
outsidecontext
we could then maybe do a combined PUID / existing metadata search
2009-10-14 28719, 2009
ruaok
that makes sense.
2009-10-14 28752, 2009
ruaok
I'm trying to figure out if this should happen before NGS.
2009-10-14 28710, 2009
ruaok
unless this fix goes into 0.12 it doesn't really make sense.
2009-10-14 28718, 2009
ruaok
but I think 0.12 is too far along to get this fix in, no?
2009-10-14 28722, 2009
outsidecontext
it could improve those cases were a PUID is found on the wrong release (e.g. a compilation or different version). but we compare the metadata anyway on the results of the PUID query
2009-10-14 28742, 2009
outsidecontext
i'm not that sure it would improve much
2009-10-14 28744, 2009
ruaok nods
2009-10-14 28713, 2009
outsidecontext
i think we should get a 0.12 soon because 0.11 still has some annoying bugs
2009-10-14 28743, 2009
ruaok
I think the logic in picard should ALWAYS prefer album releases UNLESS the metadata matches perfectly for a non-album release.
2009-10-14 28745, 2009
outsidecontext
then we should be prepared to make an update together with the NGS release if something breaks in the webservice
2009-10-14 28711, 2009
outsidecontext
yes, i agree on that
2009-10-14 28711, 2009
ruaok
I think that makes tons of sense.
2009-10-14 28723, 2009
ruaok
ok, lets make a deal.
2009-10-14 28733, 2009
ruaok
you take care of my suggestion for improved matching in picard.
2009-10-14 28740, 2009
ruaok
I take care of the PUID filtering for NGS.
2009-10-14 28748, 2009
ruaok
sound ok?
2009-10-14 28751, 2009
outsidecontext
ok, deal
2009-10-14 28755, 2009
ruaok
:-)
2009-10-14 28726, 2009
outsidecontext
ruaok: will you be at the gsoc summit again this year?
2009-10-14 28730, 2009
ruaok
yes
2009-10-14 28701, 2009
outsidecontext
it's soon, right? end of this month?
2009-10-14 28708, 2009
ruaok
1.5 weeks.
2009-10-14 28744, 2009
outsidecontext
you should bring some chocolate for leslie and her team :)
2009-10-14 28743, 2009
ruaok
I'm bringing Leslie a burrito as usual and I'll certainly pick up chocolate for the rest of the team.
2009-10-14 28707, 2009
ruaok
Too bad its so $$$ to ship over. Otherwise it would be nice to have some better choco...
2009-10-14 28732, 2009
outsidecontext
yes. but wou can get some at the summit in november
2009-10-14 28757, 2009
ruaok
thats certainly the plan!
2009-10-14 28736, 2009
outsidecontext
i can bring you some more frey supreme if you want
2009-10-14 28749, 2009
ruaok
yes please!
2009-10-14 28704, 2009
ruaok
just a random collection this time please.
2009-10-14 28718, 2009
outsidecontext
ok. got enough of the vanilla?
2009-10-14 28730, 2009
ruaok
yes.
2009-10-14 28755, 2009
ruaok
another friend who also visited .ch brought a bunch over. I still have 6 or so...
2009-10-14 28728, 2009
outsidecontext
:)
2009-10-14 28730, 2009
outsidecontext
ok, i need some sleep. work is stealing all my time this week :(
