#musicbrainz-devel

/

      • dinog1 joined the channel
      • 2011-01-05 00540, 2011

      • ocharles
        ruaok: downloading now over night
      • 2011-01-05 00507, 2011

      • ruaok
        cool. looking forward to feedback.
      • 2011-01-05 00555, 2011

      • ocharles
      • 2011-01-05 00516, 2011

      • Muz
        The ftp server is a bit slow. 900kb/s :/
      • 2011-01-05 00526, 2011

      • Muz
        This connection can totally do 7 times that.
      • 2011-01-05 00521, 2011

      • ruaok joined the channel
      • 2011-01-05 00555, 2011

      • dinog joined the channel
      • 2011-01-05 00538, 2011

      • dinog1 joined the channel
      • 2011-01-05 00509, 2011

      • dinog joined the channel
      • 2011-01-05 00513, 2011

      • dinog1 joined the channel
      • 2011-01-05 00533, 2011

      • warp
        hello!
      • 2011-01-05 00503, 2011

      • djce joined the channel
      • 2011-01-05 00504, 2011

      • dinog1 has left the channel
      • 2011-01-05 00550, 2011

      • kurtjx joined the channel
      • 2011-01-05 00506, 2011

      • warp
        MusicBrainz::Server::Controller::Release->edits "Could not look up
      • 2011-01-05 00514, 2011

      • warp
        class for type 57 at /home/warp/code/mb/script/../lib/MusicBrainz/Server/Data/Edit.pm line
      • 2011-01-05 00517, 2011

      • warp
        41."
      • 2011-01-05 00533, 2011

      • ocharles
        I'm guessing you'll need to drop all rows of type 57 from your edit table
      • 2011-01-05 00537, 2011

      • ocharles
        as that edit type has been removed
      • 2011-01-05 00542, 2011

      • warp
        ah, right
      • 2011-01-05 00553, 2011

      • ocharles
        (assuming 57 is create/edit tracklist)
      • 2011-01-05 00505, 2011

      • warp
        yeah, I was assuming it was something to do with your tracklist changes.
      • 2011-01-05 00527, 2011

      • warp
        I'll nuke the whole thing when I import the new database dump this evening.
      • 2011-01-05 00536, 2011

      • hawke_ joined the channel
      • 2011-01-05 00519, 2011

      • ruaok joined the channel
      • 2011-01-05 00536, 2011

      • ppawel joined the channel
      • 2011-01-05 00528, 2011

      • ruaok joined the channel
      • 2011-01-05 00526, 2011

      • ruaok
        warp: prod
      • 2011-01-05 00505, 2011

      • alastairp
        mornning
      • 2011-01-05 00519, 2011

      • warp
        ruaok: hello
      • 2011-01-05 00529, 2011

      • ruaok
        hi alastairp, hi warp.
      • 2011-01-05 00541, 2011

      • ruaok
        you two up for another UX discusion in about an hour from now?
      • 2011-01-05 00548, 2011

      • ruaok
        and 7 minutes?
      • 2011-01-05 00509, 2011

      • warp
        ruaok: yes
      • 2011-01-05 00511, 2011

      • alastairp
        sorry, I got a class for next 3.5 hours'
      • 2011-01-05 00516, 2011

      • alastairp
        5pm eastern
      • 2011-01-05 00518, 2011

      • alastairp
        is fine for me
      • 2011-01-05 00529, 2011

      • ruaok
        alastairp: np. I think we nailed all your issues anyway.
      • 2011-01-05 00536, 2011

      • alastairp
        yeah,
      • 2011-01-05 00544, 2011

      • alastairp
        though - the ones I raised :)
      • 2011-01-05 00548, 2011

      • ruaok
        alastairp: sadly alisa has a limited amount of time left before going on vacation.
      • 2011-01-05 00552, 2011

      • alastairp
        I never finished getting through the RE
      • 2011-01-05 00559, 2011

      • alastairp
        yeah, fair enough, stick with warp's
      • 2011-01-05 00500, 2011

      • ruaok
        yeah, thats what we'll do today.
      • 2011-01-05 00505, 2011

      • ruaok
        but warp can do that with me.
      • 2011-01-05 00513, 2011

      • ruaok
        warp: I'll hail alisa and get things setup.
      • 2011-01-05 00517, 2011

      • alastairp
        I'll hang in channel
      • 2011-01-05 00539, 2011

      • pronik` joined the channel
      • 2011-01-05 00533, 2011

      • warp
        ruaok: ok
      • 2011-01-05 00520, 2011

      • warp
        :)
      • 2011-01-05 00536, 2011

      • ocharles
        can I sit in?
      • 2011-01-05 00544, 2011

      • ocharles
        i'll be super quiet dad, i promise
      • 2011-01-05 00509, 2011

      • ruaok
        sure!
      • 2011-01-05 00534, 2011

      • ruaok
        I keep laughing at this one: http://i.imgur.com/xpwyq.jpg
      • 2011-01-05 00506, 2011

      • ocharles
        haha, yea
      • 2011-01-05 00528, 2011

      • djce joined the channel
      • 2011-01-05 00532, 2011

      • ruaok
        'ello djce
      • 2011-01-05 00539, 2011

      • djce
        %t!
      • 2011-01-05 00504, 2011

      • ruaok
        :-)
      • 2011-01-05 00532, 2011

      • djce
        Which is apparently a tab....
      • 2011-01-05 00543, 2011

      • djce had to check the man page
      • 2011-01-05 00524, 2011

      • MBChatLogger
      • 2011-01-05 00524, 2011

      • djce
        ruaok: Remind me, who runs codereview .mb.org?
      • 2011-01-05 00554, 2011

      • ruaok
        pronik`:
      • 2011-01-05 00514, 2011

      • djce
        Meatspace name (in Jira)?
      • 2011-01-05 00528, 2011

      • djce sees it
      • 2011-01-05 00542, 2011

      • ruaok
        k
      • 2011-01-05 00514, 2011

      • djce
        Sorry, had a busy day, and in lazy offload-as-much-work-as-possible mode :-( my bad.
      • 2011-01-05 00504, 2011

      • nikki joined the channel
      • 2011-01-05 00533, 2011

      • warp
        djce :)
      • 2011-01-05 00537, 2011

      • warp
        nikki!
      • 2011-01-05 00529, 2011

      • nikki
        hi
      • 2011-01-05 00537, 2011

      • nikki is back in germany
      • 2011-01-05 00507, 2011

      • warp
        Herzlich Willkommen!
      • 2011-01-05 00538, 2011

      • ruaok
        in the land of milka and honey!
      • 2011-01-05 00504, 2011

      • riffm joined the channel
      • 2011-01-05 00521, 2011

      • pronik
        djce: I'm onto it
      • 2011-01-05 00515, 2011

      • pronik
        djce: is mail.musicbrainz.org the correct server for now?
      • 2011-01-05 00523, 2011

      • djce
        For what?
      • 2011-01-05 00550, 2011

      • djce
        There currently is no mb submission server, if that's what you're asking.
      • 2011-01-05 00534, 2011

      • pronik
        Rather mail relay
      • 2011-01-05 00514, 2011

      • pronik
        I've asked ruaok back then whether I could use that for codereview mails
      • 2011-01-05 00540, 2011

      • djce
        Ah. That service has temporarily gone away.
      • 2011-01-05 00516, 2011

      • djce
        As long as you're not using a return-path address in @musicbrainz.org, just use your usual ISP smarthost, or deliver direct.
      • 2011-01-05 00517, 2011

      • pronik
        since 26th december? That's probably when I've got my last mail
      • 2011-01-05 00527, 2011

      • riffm has left the channel
      • 2011-01-05 00519, 2011

      • djce
        Yes
      • 2011-01-05 00521, 2011

      • ruaok is guilty as charged
      • 2011-01-05 00504, 2011

      • djce
        I think I plan to bring back mail.mb in some form or other, but I'm not quite sure how. I wasn't aware that anyone was using it, of course.
      • 2011-01-05 00523, 2011

      • ruaok
        my bad. sorry
      • 2011-01-05 00525, 2011

      • djce
        my bad for not checking :-( but I needed to shift the services in a hurry.
      • 2011-01-05 00546, 2011

      • ruaok
        well, one option is to host CR on wiley.
      • 2011-01-05 00557, 2011

      • ruaok
        which kinda solves this problem and takes the hosting issue off pronik 's hands.
      • 2011-01-05 00556, 2011

      • pronik
        in the meantime I switched to direct delivery
      • 2011-01-05 00528, 2011

      • pronik
        FYI, that mail setup is in the admin UI of reviewboard, so anyone with admin right can do this -- at least ruaok should have it
      • 2011-01-05 00541, 2011

      • ruaok
        ah, good to know.
      • 2011-01-05 00542, 2011

      • pronik
        ruaok: I'll monitor my mail server for a while, since at least your mail server greylists my mails, I wonder whether postfix will try again...
      • 2011-01-05 00556, 2011

      • ruaok
        k
      • 2011-01-05 00531, 2011

      • djce
        I'll have a play with setting up a mail.mb again later.
      • 2011-01-05 00536, 2011

      • pronik
        ruaok: greylisting works
      • 2011-01-05 00545, 2011

      • ruaok
        :-)
      • 2011-01-05 00529, 2011

      • ruaok
        ocharles: branch mbs-1140-statistics is not in git on mb-core.
      • 2011-01-05 00533, 2011

      • ruaok
        can you please push it?
      • 2011-01-05 00516, 2011

      • ocharles
        oops, will do
      • 2011-01-05 00530, 2011

      • ocharles
        if you need it right now, you should be able to make your own branch out of next
      • 2011-01-05 00548, 2011

      • ruaok
        how do I do that?
      • 2011-01-05 00506, 2011

      • ocharles
        just finding the commit now
      • 2011-01-05 00523, 2011

      • ocharles
        ah, it's not in next either
      • 2011-01-05 00500, 2011

      • ruaok
        just log into your machine at the office and push it from there.
      • 2011-01-05 00505, 2011

      • ruaok waits for it
      • 2011-01-05 00543, 2011

      • ocharles
        if you want to test it I can give you a temporary branch from that patch
      • 2011-01-05 00549, 2011

      • ocharles
        because that's up to date
      • 2011-01-05 00501, 2011

      • ruaok
        sure
      • 2011-01-05 00523, 2011

      • ruaok looks at http://codereview.musicbrainz.org/r/1004/diff/#index_header
      • 2011-01-05 00537, 2011

      • ruaok
        so, to change a track, a tracklist needs to be added/remove?
      • 2011-01-05 00557, 2011

      • ocharles
        yea
      • 2011-01-05 00508, 2011

      • ocharles
        that's how the edits work now anyway
      • 2011-01-05 00511, 2011

      • ruaok
        that makes tracklist_index updates much easier. :)
      • 2011-01-05 00527, 2011

      • ocharles
        It needs some performance testing
      • 2011-01-05 00540, 2011

      • ocharles
        the find_or_insert query does a select with n joins, where n is the number of tracks
      • 2011-01-05 00545, 2011

      • ocharles
        whether or not that's a problem, I don't really know
      • 2011-01-05 00504, 2011

      • ruaok
        so inserting a 99 track tracklist it generates a 99-way join?
      • 2011-01-05 00531, 2011

      • ocharles
        yes
      • 2011-01-05 00556, 2011

      • ruaok
        uhm, ya. thats going to be a problem.
      • 2011-01-05 00559, 2011

      • ocharles
        that's how it determines if a tracklist exists or not for now
      • 2011-01-05 00518, 2011

      • ocharles
        it sounds like it would be a problem, I'm really curious if it actually is though
      • 2011-01-05 00532, 2011

      • ocharles
        the join condition always goes back to the same thing, so all joins hit an index
      • 2011-01-05 00558, 2011

      • ruaok
        yes, that needs to be tested.
      • 2011-01-05 00505, 2011

      • ocharles nods
      • 2011-01-05 00542, 2011

      • ruaok
      • 2011-01-05 00545, 2011

      • ruaok
        69 tracks.
      • 2011-01-05 00514, 2011

      • ocharles
        we have a 728 track release
      • 2011-01-05 00526, 2011

      • ocharles
        I couldn't even use that to test it, because the re crashes before I can submit it
      • 2011-01-05 00530, 2011

      • ruaok
        clearly not a CD. :-)
      • 2011-01-05 00541, 2011

      • ruaok
        do you have a bug open for this testing bit?
      • 2011-01-05 00552, 2011

      • ocharles
        does that mean it shouldn't be in the tracklist index?
      • 2011-01-05 00515, 2011

      • ruaok
        yeah.
      • 2011-01-05 00515, 2011

      • ocharles
        because I don't think we have any checks for what goes in there
      • 2011-01-05 00525, 2011

      • ruaok
        things with more than 99 tracks should not be in there.
      • 2011-01-05 00543, 2011

      • ocharles
        ok, then we don't have that conditional yet I don't think
      • 2011-01-05 00546, 2011

      • ruaok goes to open a bug.
      • 2011-01-05 00500, 2011

      • ocharles
        i'll open one for performance testing
      • 2011-01-05 00505, 2011

      • ruaok
        k
      • 2011-01-05 00521, 2011

      • ruaok
      • 2011-01-05 00512, 2011

      • ocharles
        stat-temp pushed
      • 2011-01-05 00517, 2011

      • ruaok
        thx
      • 2011-01-05 00531, 2011

      • ocharles
        pushing* :)
      • 2011-01-05 00506, 2011

      • ocharles
        ok, now it's done
      • 2011-01-05 00534, 2011

      • ruaok
        git branch -r doesn't show it.