#musicbrainz-devel

/

      • ruaok joined the channel
      • Muz joined the channel
      • lfranchi joined the channel
      • sampsyo joined the channel
      • warp joined the channel
      • sampsyo joined the channel
      • joojii joined the channel
      • dinog joined the channel
      • nikki
        ocharles: ah, I managed to get youtube to show up by adding it to Data/URL.pm, but the super() thing is still giving me empty strings
      • warp
        goodmorning!
      • nikki
        moin moin
      • warp makes ugly code
      • tsk tsk
      • ijabz joined the channel
      • ijabz
        ruaok: u there ?
      • ok sent email
      • ijabz_ joined the channel
      • ijabz joined the channel
      • ijabz joined the channel
      • ruaok
        ijabz: pong
      • I should be in bed, but I'm not a wise man
      • re-fetched head, built and its running again.
      • warp
        indeed
      • ruaok
        MAX_BUFFERED_DOCS = 5000
      • instead of 10k
      • %T warp
      • warp
        time-of-day ruaok :)
      • ruaok
        how are things in .nl land today?
      • warp
        sunny
      • ruaok
        very nice
      • warp just merged some shippits
      • warp moves on to the next ticket
      • djce joined the channel
      • hi djce
      • ok roobarb is busy, hopefully it will build the full index tomorrow.
      • bed time now.
      • nn
      • ijabz
        oh hi ruaok, maybe your like me, if Im on my own I cant get to bed until Im just about falling aslep
      • ah, missed him
      • djce
        doh, missed ruaok too
      • ijabz joined the channel
      • ijabz joined the channel
      • ijabz joined the channel
      • ijabz joined the channel
      • reosarevok joined the channel
      • ijabz joined the channel
      • ijabz_ joined the channel
      • ijabz joined the channel
      • ijabz joined the channel
      • ijabz_ joined the channel
      • ijabz joined the channel
      • ppawel joined the channel
      • ijabz joined the channel
      • ijabz_ joined the channel
      • zazi joined the channel
      • ppawel joined the channel
      • ijabz joined the channel
      • ijabz_ joined the channel
      • ijabz joined the channel
      • caller_6 joined the channel
      • ijabz joined the channel
      • ijabz joined the channel
      • ocharles
        warp: ping
      • alastairp
        pong
      • ocharles
        !
      • warp: s'ok now, I forgot how to validate the xml but remembered we use jing
      • warp
        ocharles: ok :)
      • ocharles
        ijabz: ping
      • well ijabz, warp: ws/1/release?inc=counts was failing the test as currently it adds a <track-list count="12" /> type element to the <release> element. /ws/1 does not currently do that, but it seems harmless to add it in (passes schema etc)
      • any objections?
      • alastairp
        hmm. surely the schema validation should fail if there's an element that isn't expected?
      • ocharles
        alastairp: <track-list> is a valid element for the <release> element
      • so schema validation passes. the xml tree comparison fails though, because the test doesn't expect to see it
      • alastairp
        right
      • ocharles
        something else needed it, and I guess it's too liberal adding it in, but I personally don't mind it being there
      • alastairp
        if it's backwards compatible (I don't see why it shouldn't be) then it can stay
      • ocharles
        I think it's because inc=count for artist gives you releases with a tracklist count, but inc=count for releases currently doesn't (which is a bit odd)
      • alastairp: right, all other tests pass, and it passes schema validation
      • alastairp
        I could maybe see a library not expecing it and exploding
      • ijabz
        ocharles, yeah leave it in
      • ocharles
        great
      • alastairp
        but if it's in an element where it could appear anyway, then that should be fine
      • ocharles nods
      • ijabz
        actually gotta go, speak to you later if need be
      • ocharles
        hopefully we'll be at 100% pass rate for master today
      • first time we'll see the green light on ci!
      • alastairp
        ncie
      • hawke_ joined the channel
      • warp
        ocharles: I agree with adjusting the test, not the /ws/1 output in this particular instance.
      • ocharles: also, looking forward to 100% pass on master :)
      • ocharles
        cool
      • warp
        ocharles: poke me if there's anything I broke and need to fix.
      • ocharles
        warp: well your qunit and selenium tests still fail on next
      • but nothing on master is your fault, that's all mine :)
      • warp
        I merged them into master today, they passed here (on master).
      • warp -> supermarket.
      • ocharles
        excellent
      • running CI on master now, lets see what we get!
      • alastairp
        how long does it take these days?
      • ocharles
        a good 10 minutes I think
      • boo, warps selenium test fails and gives 8% pass rate
      • and controllers.t still fails more than it does on my machine
      • warp
        ocharles: I'll have a look after dinner
      • ppawel joined the channel
      • ocharles: hm, the test is correct, something is broken.
      • ruaok joined the channel
      • ocharles: hm, a Schrödinbug. the offending line is from october 2010, from the reading code I am convinced it was broken since that time.
      • ijabz joined the channel
      • ocharles
        yet it passes on your machine?
      • warp
        no, it doesn't in master.
      • (it did this morning after I merged those branches though).
      • ocharles
        oh... odd
      • warp
        yes, very.
      • I could look into it further, I didn't delete those branches yet. but that doesn't seem like a productive way to spend my time, so I wasn't planning to.
      • still two out of twelve selenium tests breaking on master.
      • ruaok
        yay the recording index built!
      • ijabz joined the channel
      • I can work on getting ngs.mb. org setup
      • ijabz: just one second before you arrived I said the recording index bullt!
      • ocharles
        ruaok: awesome!
      • ruaok: will me and kuno have access to these machines?
      • ruaok
        maxdocs at 5000 made it work and it didn't seem much slower.
      • ocharles
        at least during testing period
      • ruaok
        maybe if you make a compelling argument. :)
      • ocharles
        well I need to tune postgres
      • i can do it through you, but it seems more efficient if I can have access to the postgres user myself
      • ruaok
        that one we should do together.
      • ijabz joined the channel
      • ocharles
        right, but I mean more than just general settings, I might need to alter statistics on certain tables (rawdata.edit comes to mind)
      • ruaok
        I can send you the config and you can send a tweaked one back.
      • ijabz
        ruaok: Good Morning
      • ocharles
        but I need to be able to do analyzed explains too. I don't really need root access to the machine, but being able to run those queries would be nice
      • ruaok
        I'll give you a shell account on astro, that lets you connect to the DB.
      • ocharles
        ok, that works for me
      • ruaok
        but postgresql.conf we work on collaboratively.
      • ocharles
        sure
      • ruaok
        k.
      • gonna be around for a bit?
      • ijabz joined the channel
      • if so, nudge me when I get to to the office.
      • ocharles
        yep, i'm back for the day now
      • meeting in an hour too
      • ruaok
        ok
      • ocharles
        2 even
      • ruaok
        yeah, I gotta get a move on.
      • 2?
      • ocharles
        i thought it was 21cet?
      • oh wait, that's an hour away
      • timezone fail
      • ruaok
        MBS-1599 is the only one I know of.