the labels are definitely changing. quite an interesting meeting.
2011-10-12 28525, 2011
ruaok
right-o. time to move on to my next meeting.
2011-10-12 28503, 2011
kepstin-webchat joined the channel
2011-10-12 28502, 2011
voiceinsideyou joined the channel
2011-10-12 28516, 2011
antgel joined the channel
2011-10-12 28515, 2011
reosarevok joined the channel
2011-10-12 28533, 2011
reosarevok joined the channel
2011-10-12 28510, 2011
ocharles
warp: Am I right in understanding that the when a page in the release editor is completed, we only serialize exactly what the user typed, and not the field values ($field->value)?
2011-10-12 28542, 2011
ocharles
Because I've tried changing some fields to use the MB text field which does trimming, and the trimming code runs, but the resulting value is lost
2011-10-12 28548, 2011
ocharles
nikki: ping
2011-10-12 28505, 2011
reosarevok joined the channel
2011-10-12 28504, 2011
warp
ocharles: that sounds likely.
2011-10-12 28518, 2011
ocharles
nikki: un-ping, sorry :)
2011-10-12 28531, 2011
warp
ocharles: most of the effort to make the release editor faster was to avoid creating all the FormHandler objects.
2011-10-12 28553, 2011
ocharles
right, but we serialize ->fif, not ->value
2011-10-12 28557, 2011
ocharles
that shouldn't change the speed
2011-10-12 28510, 2011
warp
no, the whole point is that there is no serializing.
2011-10-12 28531, 2011
warp
the data submitted in post is saved more or less directly to the session.
2011-10-12 28500, 2011
ocharles
oh...
2011-10-12 28505, 2011
warp
ofcourse the FormHandler objects for that page still need to do validation, but I think that's all they do.
2011-10-12 28543, 2011
ocharles
yes, the RE just makes the assumption that a sucessful submission means the data is OK
2011-10-12 28523, 2011
warp
any cleaning of the data happens when the data is used, e.g. to create the edits.
2011-10-12 28558, 2011
ocharles
which is not consistent with the way the rest of the forms work though
2011-10-12 28507, 2011
ocharles
hmm
2011-10-12 28513, 2011
warp
yes, I know, it's a big mess :)
2011-10-12 28532, 2011
warp
but FormHandler is just too slow here.
2011-10-12 28543, 2011
ocharles
where is the cleaning?
2011-10-12 28549, 2011
warp
if we want to clean that up, we need to replace FormHandler with something faster.
2011-10-12 28553, 2011
ocharles
if I want to trim the release name, where should I do that?
2011-10-12 28522, 2011
warp
ocharles: there currently is no clear place, it's a mess.
2011-10-12 28550, 2011
ocharles leans towards moving this specific trimming to the database
2011-10-12 28503, 2011
ocharles
but it means that you can never have a release name starting with a space. I don't know if that is or isn't a problem
2011-10-12 28552, 2011
warp
I'm generally unhappy with almost every aspect of the release editor by now.
2011-10-12 28533, 2011
ocharles
We have a week at yours, maybe we should move to actually addressing this
2011-10-12 28545, 2011
ocharles
in fact, we have 2 weeks together, almost
2011-10-12 28529, 2011
warp
yes
2011-10-12 28541, 2011
warp
second week is hopefully cover art though.
2011-10-12 28504, 2011
warp
anyway, I should commit some of my thoughts to paper
2011-10-12 28538, 2011
ocharles
I think a testable, stable, & fast release editor is more important than cover art, personally :)
2011-10-12 28547, 2011
warp
so we can discuss things in a more productive manner than just saying all of it sucks :)
2011-10-12 28552, 2011
ocharles
yes :)
2011-10-12 28502, 2011
ocharles
cover art is also something rob can probably tackle mostly himself with help from us, if we really decide to focus on the RE
2011-10-12 28540, 2011
kepstin-laptop joined the channel
2011-10-12 28555, 2011
CatCat
wow
2011-10-12 28552, 2011
CatCat
hey warp do you still have twilight princess?
2011-10-12 28513, 2011
CatCat
if i bring my save file can we paly past soem annoying arms?
2011-10-12 28539, 2011
warp
CatCat: I have the american gamecube version. probably best if you bring the disc as well.
2011-10-12 28557, 2011
CatCat
ok..
2011-10-12 28508, 2011
warp
(the american version won't run on my wii, and I don't know exactly where the gamecube is :)
2011-10-12 28522, 2011
warp
I'm not sure if the savegames are compatible between the two either.
2011-10-12 28522, 2011
CatCat
ok
2011-10-12 28540, 2011
CatCat
sadly i do not know how o get my pokemon ranch out of the wii, my wii has lost the ability to communicate. it wont talk to the internet OR the ds games.. so i am screwed and all the pokemon in the ranch are probably lost (and soem of these are raer and legitimate events etc)
