the labels are definitely changing. quite an interesting meeting.
right-o. time to move on to my next meeting.
kepstin-webchat joined the channel
voiceinsideyou joined the channel
antgel joined the channel
reosarevok joined the channel
reosarevok joined the channel
ocharles
warp: Am I right in understanding that the when a page in the release editor is completed, we only serialize exactly what the user typed, and not the field values ($field->value)?
Because I've tried changing some fields to use the MB text field which does trimming, and the trimming code runs, but the resulting value is lost
nikki: ping
reosarevok joined the channel
warp
ocharles: that sounds likely.
ocharles
nikki: un-ping, sorry :)
warp
ocharles: most of the effort to make the release editor faster was to avoid creating all the FormHandler objects.
ocharles
right, but we serialize ->fif, not ->value
that shouldn't change the speed
warp
no, the whole point is that there is no serializing.
the data submitted in post is saved more or less directly to the session.
ocharles
oh...
warp
ofcourse the FormHandler objects for that page still need to do validation, but I think that's all they do.
ocharles
yes, the RE just makes the assumption that a sucessful submission means the data is OK
warp
any cleaning of the data happens when the data is used, e.g. to create the edits.
ocharles
which is not consistent with the way the rest of the forms work though
hmm
warp
yes, I know, it's a big mess :)
but FormHandler is just too slow here.
ocharles
where is the cleaning?
warp
if we want to clean that up, we need to replace FormHandler with something faster.
ocharles
if I want to trim the release name, where should I do that?
warp
ocharles: there currently is no clear place, it's a mess.
ocharles leans towards moving this specific trimming to the database
ocharles
but it means that you can never have a release name starting with a space. I don't know if that is or isn't a problem
warp
I'm generally unhappy with almost every aspect of the release editor by now.
ocharles
We have a week at yours, maybe we should move to actually addressing this
in fact, we have 2 weeks together, almost
warp
yes
second week is hopefully cover art though.
anyway, I should commit some of my thoughts to paper
ocharles
I think a testable, stable, & fast release editor is more important than cover art, personally :)
warp
so we can discuss things in a more productive manner than just saying all of it sucks :)
ocharles
yes :)
cover art is also something rob can probably tackle mostly himself with help from us, if we really decide to focus on the RE
kepstin-laptop joined the channel
CatCat
wow
hey warp do you still have twilight princess?
if i bring my save file can we paly past soem annoying arms?
warp
CatCat: I have the american gamecube version. probably best if you bring the disc as well.
CatCat
ok..
warp
(the american version won't run on my wii, and I don't know exactly where the gamecube is :)
I'm not sure if the savegames are compatible between the two either.
CatCat
ok
sadly i do not know how o get my pokemon ranch out of the wii, my wii has lost the ability to communicate. it wont talk to the internet OR the ds games.. so i am screwed and all the pokemon in the ranch are probably lost (and soem of these are raer and legitimate events etc)
