ijabz: groan. fucking allergies are eating my brain alive. I can't think a single straight thought. :(
2011-05-24 14417, 2011
ijabz
12297 makes one chnage to serlvet code
2011-05-24 14437, 2011
ianmcorvidae
anyway, first step is probably getting a very basic timeline up (akin to the old timeline.html)
2011-05-24 14447, 2011
ruaok
indexes do or dont need to be rebuilt?
2011-05-24 14453, 2011
ijabz
I cant stop sneezing , having to accpet I have got hayfever and will need to get some tablets
2011-05-24 14457, 2011
ianmcorvidae
as a way of getting me used to how the data flows around through the system, etc.
2011-05-24 14402, 2011
ijabz
no need to build indexes
2011-05-24 14411, 2011
ruaok
ijabz: tablets dont work for me. :(
2011-05-24 14425, 2011
ruaok
I've been eating local honey which made the problem go 90% away.
2011-05-24 14430, 2011
ocharles
ianmcorvidae: indeed, I'm trying to think what the smallest starting point is
2011-05-24 14432, 2011
ijabz
I never tried them, I didnt have hayfever 2 years ago
2011-05-24 14436, 2011
ruaok
but we're in the final throes, and now its bugging me.
2011-05-24 14448, 2011
ianmcorvidae
then onward to improving that (leaving out/including different lines, zooming, rate of change graph, exact numbers on hover, musicbrainz events, and copyable URLs)
2011-05-24 14450, 2011
ruaok
ijabz: raw, unfiltered, local honey daily is the trick!
2011-05-24 14455, 2011
ruaok
LOCAL is important.
2011-05-24 14417, 2011
ruaok
ok, so a new servlet going out then. can do.
2011-05-24 14425, 2011
ocharles
ianmcorvidae: I'm not sure how you like to work, but giving you some tickets on JIRA might be a good way for us to stay on the same page
2011-05-24 14428, 2011
ruaok he hopes he wont stuff that up too
2011-05-24 14432, 2011
ijabz
Yeah, someone I recently got know gave me some honey he made in his gar den last week, but bit late for this year isnt it
2011-05-24 14444, 2011
ruaok
ijabz: its a long term play.
2011-05-24 14451, 2011
ianmcorvidae
ocharles: that seems like a reasonable way to work
2011-05-24 14459, 2011
ruaok
if you start eating it daily, you can be prepared for NEXT year.
2011-05-24 14406, 2011
ijabz
you have to take it in Winter, but I think its good stuff he doesnt strain it fully, so more pollen in it
2011-05-24 14407, 2011
ianmcorvidae
plus, it means I can put MBS-whatever in my codereview postings, which always looks better ;)
2011-05-24 14416, 2011
ocharles
ianmcorvidae: right :)
2011-05-24 14418, 2011
ruaok
ijabz: for sure
2011-05-24 14424, 2011
ocharles
ianmcorvidae: I think maybe we start with displaying a single statistic over time
2011-05-24 14431, 2011
ocharles
ie, graphing count.artist
2011-05-24 14432, 2011
ruaok gets to work and leaves the channel for real work
2011-05-24 14447, 2011
ianmcorvidae
that makes sense
2011-05-24 14400, 2011
ianmcorvidae
artist is something that hasn't changed names umpteen times, too, that's probably a good choice :)
2011-05-24 14404, 2011
ocharles
yea :)
2011-05-24 14426, 2011
ocharles
I think we start with displaying one statistic, then we look at fetching that data via AJAX, with a query like /ws/js/statistic/count.artist
2011-05-24 14445, 2011
ocharles
and then we magical expand to have graphs for all known statistics
2011-05-24 14416, 2011
ocharles
then we should probably meet again and see what looks like a good next logical task to work on
2011-05-24 14426, 2011
ianmcorvidae
presumably we want combined graphs, not multiple graphs, yeah?
2011-05-24 14444, 2011
ianmcorvidae
but other than that, yeah, sounds right
2011-05-24 14445, 2011
ocharles
ianmcorvidae: In the end yes, but I think we should start with multiple graphs so we can see what code they have that's similar
2011-05-24 14402, 2011
ianmcorvidae
okay :)
2011-05-24 14402, 2011
ocharles
so we'll start with /statistic/artist and /statistic/edit pages or something
so, orient me with respect to the code -- I've read through the Catalyst tutorial and some of the introductory TT stuff
2011-05-24 14456, 2011
ruaok
cartman is being dirty. :)
2011-05-24 14400, 2011
ruaok
seems very fitting
2011-05-24 14406, 2011
ianmcorvidae
haha
2011-05-24 14446, 2011
ianmcorvidae
I'm not sure how data flows through the whole shebang, mostly; what do I need to import/include/require, that sort of thing
2011-05-24 14400, 2011
ocharles
ianmcorvidae:
2011-05-24 14419, 2011
ocharles
ok, so the most important things for you are Data::Stastistic, Entity::Statistic and Controller::Statistic
2011-05-24 14424, 2011
ocharles
I imagine 90% of your work will go on there
2011-05-24 14450, 2011
ianmcorvidae
Statistics, you mean, or did you mean Statistic?
2011-05-24 14458, 2011
ocharles
for which?
2011-05-24 14403, 2011
ocharles
I probably meant Statistics
2011-05-24 14421, 2011
ianmcorvidae
any of them :) Statistics exists for all three, Statistic would be new
2011-05-24 14426, 2011
ocharles
oh, weird
2011-05-24 14432, 2011
ocharles
good work us at breaking that naming convention
2011-05-24 14432, 2011
ianmcorvidae
(currently m.o/statistics is the tabular data)
2011-05-24 14434, 2011
ocharles
never mind
2011-05-24 14445, 2011
ocharles
so yes, Statistics modules
2011-05-24 14450, 2011
ocharles
When a user visits /statistic/foo, they are probably going to end up calling the method in Controller::Statistic called 'foo' (hand waving a little here)
2011-05-24 14418, 2011
ocharles
"sub foo" in this controller will then collect various bits of from Data::Statistics, which is the interface from the web server to external data
2011-05-24 14432, 2011
ocharles
It will usually return something containing Entity::Statistic objects
2011-05-24 14430, 2011
ocharles
Entity::Statistics currently represents a collection of statistics for a certain time
2011-05-24 14434, 2011
ocharles
that may or may not make sense
2011-05-24 14452, 2011
ocharles
It should either represent a timeslice for a statistic, or all statistics for a certain time
2011-05-24 14413, 2011
ocharles
As we may want users to choose what to graph, the former might be better
2011-05-24 14431, 2011
ocharles
But coding will make that more apparent :)
2011-05-24 14440, 2011
ianmcorvidae
indeed
2011-05-24 14450, 2011
ocharles
So, 'sub foo' has called Data::Statistics, and collected some data
2011-05-24 14410, 2011
ocharles
Once it's done transforming it, it puts it in $c->stash, which is a dictionary that is present to templates
2011-05-24 14418, 2011
ocharles
(by default the template will be statistics/foo.tt)
2011-05-24 14440, 2011
ianmcorvidae
yeah
2011-05-24 14410, 2011
ocharles
So for graphing count.artist, I think you'll want to add a "artist" action to Controller::Statistics, and use Data::Statistics to collect the interesting information and put in $c->stash
2011-05-24 14413, 2011
ianmcorvidae
and then all the HTML/JS stuff goes in the template, yeah?
2011-05-24 14416, 2011
ocharles
yep
2011-05-24 14428, 2011
ocharles
and then in your template you can transform this into inline JS
2011-05-24 14438, 2011
ocharles
and then you should have something ready to review :)
2011-05-24 14446, 2011
ianmcorvidae
cool
2011-05-24 14404, 2011
ianmcorvidae
potentially unrelated: should I be using the admin/sql/updates scripts after I do git-pull, or should I not worry about it?
2011-05-24 14411, 2011
ocharles
mm, are you running a replicated db?
2011-05-24 14425, 2011
ianmcorvidae
nah, RT_STANDALONE
2011-05-24 14450, 2011
ocharles
it might be worth running them when we do server updates then
I see the ext string in the output now, so we should be good.
2011-05-24 14405, 2011
ijabz
oh fuck, there a mistake
2011-05-24 14418, 2011
ijabz
an extra ", sorry
2011-05-24 14437, 2011
ruaok
commit a fix, post haste, please.
2011-05-24 14444, 2011
ijabz
yep
2011-05-24 14435, 2011
ianmcorvidae
hm. looking at edits on an artist: "Caught exception in MusicBrainz::Server::Controller::Artist->edits "Can't use an undefined value as an ARRAY reference at /home/ianmcorvidae/Source/musicbrainz-server/script/../lib/MusicBrainz/Server/Edit/Historic/AddLink.pm line 18.""
2011-05-24 14425, 2011
ianmcorvidae
( that line being 'return @{ $self->data->{links} };')
2011-05-24 14411, 2011
ijabz
ruaok: done
2011-05-24 14423, 2011
ruaok gets moving
2011-05-24 14430, 2011
ruaok
ijabz: pushed.
2011-05-24 14412, 2011
ijabz
rigt, looks okay now
2011-05-24 14418, 2011
ruaok
cool
2011-05-24 14435, 2011
ijabz
hmm, pwrhaps I should always get it on test first ?
2011-05-24 14428, 2011
ruaok
yes, good idea.
2011-05-24 14405, 2011
ijabz
trouble is I cant do that myself, so bit of an effort getting it done
2011-05-24 14445, 2011
ruaok
well, soon we can hopefully stop doing hotfixes and take the time to properly do this.
2011-05-24 14454, 2011
ianmcorvidae
ruaok: would it be safe for me to dropdb and then reimport from 20110521-100351 ? (decided I wanted to update my data a bit)
2011-05-24 14406, 2011
ruaok
sure.
2011-05-24 14416, 2011
ianmcorvidae
cool
2011-05-24 14417, 2011
ocharles
ianmcorvidae: your data is waaay out of date
2011-05-24 14435, 2011
ianmcorvidae
ocharles: yeah, this is what I realized; I still have 4/27 data :)
2011-05-24 14439, 2011
ocharles
:)
2011-05-24 14454, 2011
ruaok
ocharles: i confirmed our AWS keys and they match with whats on the AWS key page.
2011-05-24 14414, 2011
ocharles
then I wonder if we've been blocked
2011-05-24 14417, 2011
ruaok
can you maybe add some debug output to the cover art script if the AWS auth goes wrong?
2011-05-24 14429, 2011
ocharles
yes, but tomorrow
2011-05-24 14447, 2011
ruaok
the key pairs are marked as active.
2011-05-24 14447, 2011
ianmcorvidae
ocharles: after I import 20110521-100351 should I also run upgrade.sh again, or?
2011-05-24 14409, 2011
ruaok
I just made a new access key. I'll try that.
2011-05-24 14434, 2011
ocharles
ianmcorvidae: yea, that looks a bit out of date
2011-05-24 14423, 2011
ianmcorvidae
okay, cool
2011-05-24 14429, 2011
ianmcorvidae
(it's latest on ftp.m.o :)
2011-05-24 14456, 2011
ocharles
there should be a new one out today or tomorrow, i think
2011-05-24 14407, 2011
ruaok
today
2011-05-24 14412, 2011
ruaok
will start in under 3 hours
2011-05-24 14403, 2011
ianmcorvidae
hm
2011-05-24 14408, 2011
ianmcorvidae
might wait then
2011-05-24 14416, 2011
ianmcorvidae
I think the statistic table isn't changed, so I can at least start on my work :)
2011-05-24 14422, 2011
ianmcorvidae
(shocking, I know)
2011-05-24 14437, 2011
ocharles
no, that hasn't changed
2011-05-24 14441, 2011
ocharles
it's mostly edit stuff that has
2011-05-24 14419, 2011
Batsy joined the channel
2011-05-24 14428, 2011
ijabz
ocharles would consider MBS-2281 shoud be a hotfix
2011-05-24 14445, 2011
ocharles
ok, move it over then
2011-05-24 14403, 2011
ijabz wishes all these people complaining about ws/1 now had help with a bit more testing at beta stage
2011-05-24 14444, 2011
ocharles
i'm sure warp feels the same about the RE
2011-05-24 14442, 2011
ruaok
ijabz: I'm with you on that.
2011-05-24 14409, 2011
ruaok
we've been talking about NGS for two years! it should not come as a surprise to anyone.
2011-05-24 14416, 2011
ruaok
yet everyone is surprised.
2011-05-24 14418, 2011
ruaok
wtf?
2011-05-24 14446, 2011
ijabz
Perhaps they didnt believe it was ever going to actually happpen ;)
2011-05-24 14451, 2011
nikki
haha
2011-05-24 14456, 2011
nikki
I was about to say something along the lines of that
