#musicbrainz-devel

/

      • reosarevok
        (in music)
      • (and to my plans to have a centralised spot to get CC-licensed Spanish hip hop, too :P )
      • warp
        reosarevok: they did show interest in archiving and making available more music (all music, not just cc licensed).
      • reosarevok
        Making available not cc-licensed music might be an issue though?
      • (archiving it is fine I guess)
      • warp
        there are many issues :)
      • reosarevok
        Sure, but I meant more like "an invitation for everyone to sue at the same time"
      • =
      • *)
      • reosarevok would love to use MB as a tool for that though, like we will do for the cover art
      • I think it makes a lot of sense too
      • ocharles
        ijabz: got a moment to talk about paypal ipn?
      • ijabz
        oh yeah okay
      • ocharles
        ijabz: ok, one mo, let me find the code I was working on
      • ijabz: are you doing it manually or using a library for it?
      • ijabz
        manually
      • ocharles
        https://gist.github.com/aa85d843f558f52d642a from what I understand is what you're meant to do - keep the parameters in order, append cmd=_notify_validate, and resend the request
      • it may well just be that it doesn't work against the sandbox or something
      • ijabz
        So this is the asynchronous IPN stuff
      • Did you get the PDT stuff working, or are you only doing the IPN
      • ocharles
        Only IPN I guess, I'm just trying to use the existing scripts
      • I haven't heard of PDT
      • ijabz
        to summarise, if making a payment from web send something to paypal, paypal sends something straight back to your request saying if payment appears ok, which you can verify
      • Then if you have IPN setup payola will asychnrously send something to your server when payment has actually gone through
      • So sometimes people only do the easier PDT , and not the IPN which seems the opposite to what you have
      • ocharles
        hmm
      • well, it's ipn for now, so I think I should probably stick with it
      • rob pretty much just wants a direct port
      • ijabz
        In my IPN code I use GET not POST , could that be the problem
      • ocharles
        ah, interesting
      • maybe that's it
      • ijabz
        ah, actually my comment maybe wrong, I think Im using Post
      • Ill paste a code extract
      • ocharles
        that'd be great
      • ijabz
        take me a ferw minutes to clean it up
      • Java Im afraid, this was done quite sometime ago, so not aufait with it
      • Note the problem I had with charsets, maybe that is your issue
      • ocharles
        np, I can read Java fine
      • certainly seems to match what I'm doing
      • ijabz
        so what happens when you send back to Paypal
      • ocharles
        I was just getting a HTML document back
      • but I've just made a proper paypal account now for myself
      • and I'm resending an IPN, so we'll see what happens
      • ijabz
        You are sending an IPN in response to receiving a request from Paypal aren't you ?
      • ocharles
        I make the payment through a form that submits to paypal, and I get confirmation and all that. Then I see an IPN message gets sent from the paypal control panel, which I'm meant to reply to
      • but that ipn isn't even getting to me, think that might be because the server is on port 3000, not 80
      • just changing that now and trying again
      • I just get a 301 response back when I try and verify
      • hmm
      • It's really annoying that Catalyst doesn't let you get to the raw request body
      • ijabz
        So you're receiving it now
      • ocharles
        I get something back, but verification fails
      • ijabz
        can u print out what parameters you get from the paypal request
      • ocharles
        response*
      • _content and _uri are the bits that are interesting in the request. the response is just a 301 :(
      • I guess I could try and follow that redirect
      • mmm, if I go to that I just end up at a page saying "You have requested an outdated version of PayPal. This error often results from the use of bookmarks."
      • warp
        fun
      • ocharles
        I've been putting this stuff off for 6 days now, figured I'd get it done :P
      • reosarevok
        :D
      • ijabz
        Sorry, don't really follow the output, not very web literate
      • reosarevok answers to a BBC editor who wrote a polite and useful mail to support
      • Is the 1st bit the request you get fro Paypal, or the request you send
      • ocharles
        that's the request I send
      • in response to an IPN request
      • ijabz
        I want to see the IPN request
      • ocharles
        https://gist.github.com/f8a8380b32bce4674a0e that's a copy and paste of what's in the IPN console on the paypal site
      • bleh, meant to [off] that, oh well :P
      • ijabz
        are you actually responding to the IPN request as you receive it, or just creating a new request based on that information
      • ocharles
        not sure I follow
      • I create a new request and copy the body into it, and add cmd=_notify_validate
      • ijabz
        I may have this wrong but it doesn't sound like you actually have a server running which paypal is connecting to, am I right ?
      • ocharles
        I do, paypal are sending me the request, I respond to it, and then they respond with a 301
      • and they should be responding with "success" or whatever
      • ijabz
        Right and you are constructing your response based on the parameters you actually receive, not just hardcoding the values in that last paste
      • ocharles
        right
      • i'll just keep tweaking it until something seems to work
      • I seem to understand what I'm meant to be doing, obviously just missing something simple
      • I think the problem is that catalyst doesn't give me the raw unprocessed request body, so I have to transform it back into just a string, and that's going wrong
      • ijabz
        it could be the iso8859, utf problem I encountered
      • ocharles
        think I could have something that's working now
      • ijabz
        ooh
      • ocharles
        I rewrote how I construct the body string (again), and now sending the ipn request manually to myself with curl seems to get further
      • (but crashes later, but that's my fault)
      • so once the crashes are fixed, I'll donate another $0.50 to myself :P
      • ok, cool. The only thing is I have "payment pending" atm
      • when you receive payments, do you have to manually accept them?
      • yep, ipn is working
      • thank fuck for that. what a mess
      • ijabz
        no i don't, maybe a setting
      • heh, yeah Google Checkout is much nicer
      • (now Google Wallet)
      • ocharles
        yea, I think we might support that soon
      • djce joined the channel
      • voiceinsideyou joined the channel
      • kepstin-netbook joined the channel
      • warp
        ocharles: just fixed another important breakage (regression) in the release editor. (MBS-3813)
      • ocharles
        yay
      • warp
        so I'm almost ready for a hotfix release. until what time are you available for that?
      • ocharles
        another 2 hours at least
      • warp
        ah, then we should get started on it soon :)
      • I'm still fixing the selenium tests. (i.e. I fixed them all in the IDE, but some are still broken when I run them with prove).
      • but I suggest we shouldn't wait for that.
      • kepstin-laptop joined the channel
      • ocharles
        i'd rather wait for that :)
      • give yourself another hour, see how it looks then
      • warp
        ok
      • ijabz joined the channel
      • ijabz joined the channel
      • ocharles
      • warp
        FFFUUUUUUUU
      • ocharles
        umad?
      • warp
        these tests really are more trouble than they are worth sometimes.
      • 13:04 warp [at 18-volt]:~/code/mb$ cat selenium.log | grep ^not
      • not ok 5 - t/selenium/bugfixes/mbs-1204-edit-associations.html
      • ocharles: I do not wish to work on this any further today.
      • ocharles
        warp: ok
      • warp logs into carl.
      • wait, have we got production setup?
      • have you hotfixed into that?
      • warp
        no, I just merged into master.
      • ocharles
        so what are we hotfixing? if you give me the commit shas of the merges, I will cherry pick them into production
      • warp
        ok, let's see
      • 8da8cdbe58d7ea4e86c409695892f6f48491ab6a remove placeholder next
      • f8779a6cf3cf61d89a44aa312ea1f1c2daee7483 broken guess case
      • bf159f5709b10f840eb1526f8f2eee37d8dfd26d broken seeded param
      • that's it I think.
      • from me anyway.
      • reosarevok
        Is the seeded param for the include work-level-rels thing?
      • Or something else?
      • warp
        no, it's MBS-3813
      • reosarevok
        (also, didn't you finish the hide/show credits while you're at it? 8) )
      • warp
        reosarevok: no, didn't finish.
      • ocharles
        warp: oh, just commits, no branches?
      • easy peasy
      • reosarevok
        Aww
      • Well, still, hotfix!
      • warp
        ocharles: f8779a6cf3cf61d89a44aa312ea1f1c2daee7483 was in a branch, I gave you the hash of the original commit, no the merge commit.
      • ocharles
        ok
      • you can cherry-pick merges
      • but if it's just a single commit that needs picking, I'll do that
      • ready to update
      • warp
        yeah, a single commit in that branch.
      • alright
      • ocharles: I have taken astro out.
      • ocharles pokes his vpn
      • ocharles
        warp: bring astro back in, my vpn is playingup
      • warp
        astro back.
      • ocharles
        typical, now it's all working