20:52 PM
ijabz_
so please if you have a minute to just check in that mmd change I could finish it off
2010-01-14 01431, 2010
20:52 PM
ruaok
nice, thats a good deal. :)
2010-01-14 01447, 2010
20:52 PM
ruaok
crap. I forgot to check that in. too damn sleepy last night.
2010-01-14 01459, 2010
20:52 PM
ijabz_
np
2010-01-14 01452, 2010
20:53 PM
ruaok
comitted.
2010-01-14 01430, 2010
20:55 PM
aCiD2
ruaok: ping
2010-01-14 01435, 2010
20:55 PM
ruaok
wail.
2010-01-14 01437, 2010
20:55 PM
aCiD2
:)
2010-01-14 01449, 2010
20:55 PM
aCiD2
do you want me to take some of the tasks you've got assigned to you for b1?
2010-01-14 01400, 2010
20:56 PM
ruaok goes to look
2010-01-14 01422, 2010
20:56 PM
aCiD2
I'm feeling fairly confident my remaining tasks might not take what the estimate is
2010-01-14 01438, 2010
20:56 PM
ruaok
the direct search is a task that I may not get to.
2010-01-14 01401, 2010
20:57 PM
ruaok
Cd stubs are also not going to happen for b1, but that is not a big deal.
2010-01-14 01403, 2010
20:57 PM
aCiD2
183?
2010-01-14 01413, 2010
20:57 PM
ruaok
no.
2010-01-14 01430, 2010
20:57 PM
aCiD2
oh, 204?
2010-01-14 01438, 2010
20:57 PM
ruaok
yes.
2010-01-14 01454, 2010
20:57 PM
aCiD2
cool, i'm going to give you a ship it on the external search then, and I'll take that issue
2010-01-14 01405, 2010
20:58 PM
ruaok
that involves changing Search.pm to load the data that indexed search provides.
2010-01-14 01414, 2010
20:58 PM
ruaok
perfect!
2010-01-14 01428, 2010
20:58 PM
aCiD2
seems doable :)
2010-01-14 01439, 2010
20:58 PM
ruaok
the biggest issue there is writing another query for finding releases that belong to recordings.
2010-01-14 01456, 2010
20:58 PM
ruaok
thanks, much appreciated.
2010-01-14 01411, 2010
20:59 PM
aCiD2
I need to spend an hour making sure error pages look a bit more presentable too
2010-01-14 01414, 2010
20:59 PM
aCiD2 makes a task
2010-01-14 01415, 2010
20:59 PM
ruaok
I'm glad that external search will go in. then I can focus on WS issues. :)
2010-01-14 01451, 2010
20:59 PM
ruaok
I'm making good progress on WS stuffs. The core is there, now its just time to pound out every last little nook and cranny.
2010-01-14 01451, 2010
20:59 PM
ijabz_
acid2 what is 'External Search' ?
2010-01-14 01457, 2010
20:59 PM
aCiD2
ijabz_: search.mb
2010-01-14 01400, 2010
21:00 PM
ruaok
ijabz_: what you and I have been working on.
2010-01-14 01406, 2010
21:00 PM
ruaok
indexed search.
2010-01-14 01414, 2010
21:00 PM
ruaok
we should actually do a nomenclature fix on that.
2010-01-14 01418, 2010
21:00 PM
aCiD2
yea sorry, I need to stop calling it external
2010-01-14 01419, 2010
21:00 PM
ruaok
it should be indexed not direct.
2010-01-14 01426, 2010
21:00 PM
aCiD2
s/direct/external/
2010-01-14 01436, 2010
21:00 PM
ijabz_
oh
2010-01-14 01421, 2010
21:02 PM
ruaok
2010-01-14 01436, 2010
21:02 PM
aCiD2
that was quick!
2010-01-14 01402, 2010
21:03 PM
ruaok
I nearly have all the base data of the core entities returning. search is esp quick. it ported real nice from the old version.
2010-01-14 01417, 2010
21:03 PM
ruaok
that hard part will be getting all the supporting information for these basic requests.
2010-01-14 01426, 2010
21:04 PM
ruaok
aCiD2: wrt to the minor ramifications, feel free to fix them outright when you work on direct search. or, send me mail and I'll clean up after b1
2010-01-14 01435, 2010
21:04 PM
aCiD2
sure thing
2010-01-14 01421, 2010
21:05 PM
ijabz_
nice to see the webservice working !
2010-01-14 01437, 2010
21:05 PM
ruaok nods
2010-01-14 01409, 2010
21:06 PM
ruaok
all the core entities but work are working. search and mbid access.
2010-01-14 01437, 2010
21:06 PM
ruaok
oh, and what is cool about this is that the table that defines all of the possible values for each call type can be used to automatically generate the core docs for the WS. :)
2010-01-14 01445, 2010
21:06 PM
aCiD2
neat!
2010-01-14 01436, 2010
21:08 PM
ruaok
2010-01-14 01441, 2010
21:08 PM
ruaok
see the num column.
2010-01-14 01449, 2010
21:08 PM
ruaok
the first value is the track number.
2010-01-14 01455, 2010
21:08 PM
ruaok
the value after the / is the medium number.
2010-01-14 01410, 2010
21:09 PM
ruaok
how do we best represent this in a sensical mannger.
2010-01-14 01425, 2010
21:09 PM
ruaok thinks navap or nikki might also have valuable feedback on this.
2010-01-14 01434, 2010
21:09 PM
aCiD2
do we need to present it?
2010-01-14 01438, 2010
21:09 PM
aCiD2
at all?
2010-01-14 01447, 2010
21:09 PM
nikki
hi
2010-01-14 01452, 2010
21:09 PM
ruaok
x / y is clearly unintutive.
2010-01-14 01455, 2010
21:09 PM
ruaok
hi nikki
2010-01-14 01401, 2010
21:10 PM
aCiD2 would think just pointing to the release is enough
2010-01-14 01411, 2010
21:10 PM
nikki
<- kaputt
2010-01-14 01424, 2010
21:10 PM
ruaok
nikki: bed time or are you damaged goods?
2010-01-14 01439, 2010
21:10 PM
nikki
long day with lots of train delays and cancellations
2010-01-14 01449, 2010
21:10 PM
ruaok
aCiD2: I think giving an indication as to what medium we're talking about is nice.
2010-01-14 01453, 2010
21:10 PM
ruaok
and we have the data at the ready.
2010-01-14 01401, 2010
21:11 PM
ruaok
nikki: where did you go?
2010-01-14 01406, 2010
21:11 PM
aCiD2
ah, the medium number is interesting, true
2010-01-14 01408, 2010
21:11 PM
ruaok
is the snow still gripping .de?
2010-01-14 01415, 2010
21:11 PM
aCiD2
i'm not sure you need to go any further than that
2010-01-14 01428, 2010
21:11 PM
ruaok
aCiD2: "track x on medium y" would be best.
2010-01-14 01431, 2010
21:11 PM
navap
aCiD2: Oh..lol that's what it is.
2010-01-14 01439, 2010
21:11 PM
navap
I've been trying to figure out what "5 / 1" mkeans.
2010-01-14 01441, 2010
21:11 PM
nikki
I'm back at mum's, it's her birthday in a few days
2010-01-14 01446, 2010
21:11 PM
ruaok
another thought is to leave out medium number when its 1.
2010-01-14 01450, 2010
21:11 PM
nikki
at my mum's, even
2010-01-14 01453, 2010
21:11 PM
ruaok
and only display when its non 1.
2010-01-14 01455, 2010
21:11 PM
aCiD2
ruaok: right, but you don't have space for that
2010-01-14 01459, 2010
21:11 PM
ruaok
nikki: ah.
2010-01-14 01404, 2010
21:12 PM
ruaok
aCiD2: right.
2010-01-14 01408, 2010
21:12 PM
ruaok
so, now what. :)
2010-01-14 01419, 2010
21:12 PM
ruaok
and navap proves that this is a problem.
2010-01-14 01422, 2010
21:12 PM
aCiD2
Personally, I think the clearest way to present it is to have a "Medium #" column, and just use the medium position value
2010-01-14 01432, 2010
21:12 PM
ruaok
oh duh.
2010-01-14 01434, 2010
21:12 PM
ijabz_
acid2, agreed
2010-01-14 01434, 2010
21:12 PM
aCiD2
readable, gives me enough information to make a decision 99% of the time
2010-01-14 01439, 2010
21:12 PM
ruaok
ok, done.
2010-01-14 01442, 2010
21:12 PM
aCiD2
:)
2010-01-14 01446, 2010
21:13 PM
ruaok
2010-01-14 01455, 2010
21:13 PM
navap
Is the number of releases a recording is on important information?
2010-01-14 01405, 2010
21:14 PM
aCiD2
no, I'd lose the Num and Tracks columns
2010-01-14 01430, 2010
21:14 PM
aCiD2
this is just me though
2010-01-14 01431, 2010
21:14 PM
ruaok
navap: not in this context I think.
2010-01-14 01456, 2010
21:14 PM
ruaok
the tracks column is critical for tagging.
2010-01-14 01426, 2010
21:15 PM
aCiD2
does it show the same recording multiple times for each release then?
2010-01-14 01429, 2010
21:15 PM
ruaok
and the medium is really handy for letting the user pinpoint the track on the release view.
2010-01-14 01437, 2010
21:15 PM
ruaok
yes
2010-01-14 01440, 2010
21:15 PM
aCiD2
Ok, in that case I'd do this:
2010-01-14 01447, 2010
21:15 PM
aCiD2
Medium # | Track columns
2010-01-14 01447, 2010
21:15 PM
ruaok
2010-01-14 01451, 2010
21:15 PM
aCiD2
and have x | y/z
2010-01-14 01402, 2010
21:16 PM
aCiD2
x = medium number, y/z track number/total tracks on medium
2010-01-14 01412, 2010
21:16 PM
ruaok
that sounds fine to me.
2010-01-14 01417, 2010
21:16 PM
ruaok
navap, ijabz_?
2010-01-14 01432, 2010
21:16 PM
navap
I like condensing the number and tracks columns.
2010-01-14 01437, 2010
21:16 PM
ruaok
though I would swap the order of the two columns.
2010-01-14 01448, 2010
21:16 PM
navap
+1 on swap
2010-01-14 01458, 2010
21:16 PM
aCiD2
i'm happy either way, swap away!
2010-01-14 01448, 2010
21:17 PM
ruaok
2010-01-14 01406, 2010
21:18 PM
aCiD2
s/Tracks/Track/
2010-01-14 01419, 2010
21:18 PM
ruaok
refresh
2010-01-14 01429, 2010
21:18 PM
aCiD2
perfect!
2010-01-14 01430, 2010
21:18 PM
ijabz_
SO youre losing total tracks on release then
2010-01-14 01431, 2010
21:18 PM
navap
Can we switch from displaying a score out of 100 to a score out of 10?
2010-01-14 01447, 2010
21:18 PM
navap
And round to whole number.
2010-01-14 01454, 2010
21:18 PM
ruaok
ijabz_: we never had that, did we?
2010-01-14 01457, 2010
21:18 PM
ijabz_
navap, the score is calculated out of 100
2010-01-14 01403, 2010
21:19 PM
ruaok
navap: we;ve been using 100.
2010-01-14 01411, 2010
21:19 PM
ruaok
acid should match the direct search to use 100 as well.
2010-01-14 01413, 2010
21:19 PM
navap
Sort using the 100 calulation, but display using an integer from 1-10
2010-01-14 01421, 2010
21:19 PM
aCiD2
I don't think I ever know how many tracks on my releases, only mediums
2010-01-14 01432, 2010
21:19 PM
ruaok
navap: I'd like to keep 100.
2010-01-14 01445, 2010
21:19 PM
ijabz_
But total was intended to be release total wasn;t it, i it just wasnt
2010-01-14 01446, 2010
21:19 PM
ruaok
ok, I'm happy.
2010-01-14 01451, 2010
21:19 PM
navap
ruaok: Okay.
2010-01-14 01408, 2010
21:20 PM
ruaok
I'm ready to commit this and return to WS work.
2010-01-14 01424, 2010
21:20 PM
aCiD2
\º/
2010-01-14 01434, 2010
21:20 PM
ruaok goes to make it so
2010-01-14 01401, 2010
21:21 PM
ruaok crosses his fingers after doing an svn up
2010-01-14 01404, 2010
21:21 PM
navap
ruaok: Can you do something about the alignment of the tracks column?
2010-01-14 01419, 2010
21:21 PM
ruaok
do what?
2010-01-14 01423, 2010
21:21 PM
navap
1/4 and 13/15 end up aligned very differently.
2010-01-14 01433, 2010
21:21 PM
navap
Can you align the first number to the left and the second number to the right?
2010-01-14 01443, 2010
21:21 PM
navap
That will make it easier to read the numbers at a glance.
2010-01-14 01451, 2010
21:21 PM
aCiD2
that's hell to do
2010-01-14 01404, 2010
21:22 PM
ruaok
if you give me the CSS/HTML, I'll do it.
2010-01-14 01406, 2010
21:22 PM
aCiD2
well, not hell, but too much effort
2010-01-14 01408, 2010
21:22 PM
aCiD2
:)
2010-01-14 01422, 2010
21:22 PM
navap
heh okay, let me see what I can do.
2010-01-14 01431, 2010
21:22 PM
ruaok
but sadly, I must return to the WS if I want to have a snowball's chance in hell to fix it by tomorrow afternoon.
2010-01-14 01437, 2010
21:22 PM
ijabz_
Column needs to be wide enough to fit in xx/yy at least in one line
2010-01-14 01439, 2010
21:22 PM
aCiD2
ruaok: get it pushed and then navap can patch it and I'll merge it back in :)
2010-01-14 01447, 2010
21:22 PM
ruaok
aCiD2: good plan
2010-01-14 01448, 2010
21:24 PM
navap
Yeah the track column needs to be at least 45px wide, maybe 46px.
2010-01-14 01459, 2010
21:24 PM
navap
To fix the xx/yy values.
2010-01-14 01409, 2010
21:27 PM
ruaok
code is committed.
2010-01-14 01418, 2010
21:27 PM
aCiD2
woohoo
2010-01-14 01401, 2010
21:29 PM
ruaok got this sudden sense of accomplishment
2010-01-14 01441, 2010
21:29 PM
ruaok
/home/robert/musicbrainz/mb_server-ngs-svn/script/../lib/MusicBrainz/Server/Controller/Search.pm line 107
2010-01-14 01451, 2010
21:29 PM
ruaok
I used your suggestion in the codereview, aCiD2
2010-01-14 01435, 2010
21:30 PM
aCiD2
We don't have Model::Search.pm
2010-01-14 01442, 2010
21:30 PM
ruaok
yep
