#musicbrainz-devel

/

      • dinog joined the channel
      • 2010-07-08 18958, 2010

      • pronik` joined the channel
      • 2010-07-08 18916, 2010

      • navap
        ruaok: Can you give me some controller help? I've changed the profile path to /user/navap/profile, but what I'm having trouble figuring out how to do is get /user/navap to redirect to /user/navap/profile.
      • 2010-07-08 18933, 2010

      • navap
      • 2010-07-08 18939, 2010

      • navap
        I've tried sticking `$c->detach('/user/profile/view', [ $user_name ]);` into the sub base of Controller::User, but it's still giving a 404.
      • 2010-07-08 18942, 2010

      • warp
        why should /user/navap redirect to profile?
      • 2010-07-08 18959, 2010

      • navap
        It should just return a 404?
      • 2010-07-08 18916, 2010

      • warp
        no, it should display the profile :)
      • 2010-07-08 18929, 2010

      • ruaok nods
      • 2010-07-08 18937, 2010

      • warp
        it should 200 OK, not 3xx redirect.
      • 2010-07-08 18951, 2010

      • navap
        Oh so you mean get rid of the /profile path?
      • 2010-07-08 18909, 2010

      • warp
        navap: yes, though you _may_ want to use that internally.
      • 2010-07-08 18958, 2010

      • navap
        Right, I'll go try some stuff then.
      • 2010-07-08 18907, 2010

      • warp
        ok :)
      • 2010-07-08 18918, 2010

      • warp
        yay, comments in code review.
      • 2010-07-08 18928, 2010

      • ruaok
        the ws/1 codereview looks meaty. :-)
      • 2010-07-08 18915, 2010

      • navap
        Wow that was incredibly easy. I removed the word 'profile' in one spot and everything magically works!
      • 2010-07-08 18919, 2010

      • warp
        ruaok: it's a lot of files, but not all that much code in them.
      • 2010-07-08 18936, 2010

      • ruaok
        yeah. too much for my current state of mind.
      • 2010-07-08 18902, 2010

      • warp
        :)
      • 2010-07-08 18915, 2010

      • pronik` joined the channel
      • 2010-07-08 18923, 2010

      • ijabz joined the channel
      • 2010-07-08 18952, 2010

      • warp tries to come up with an introductory blurb for http://test.musicbrainz.org/editors
      • 2010-07-08 18949, 2010

      • zazi joined the channel
      • 2010-07-08 18942, 2010

      • zazi joined the channel
      • 2010-07-08 18931, 2010

      • ijabz joined the channel
      • 2010-07-08 18953, 2010

      • dinog joined the channel
      • 2010-07-08 18908, 2010

      • zazi joined the channel
      • 2010-07-08 18906, 2010

      • dzan joined the channel
      • 2010-07-08 18906, 2010

      • pronik` joined the channel
      • 2010-07-08 18916, 2010

      • dzan has left the channel
      • 2010-07-08 18930, 2010

      • nikki joined the channel
      • 2010-07-08 18914, 2010

      • jensl joined the channel
      • 2010-07-08 18941, 2010

      • jdamcd joined the channel
      • 2010-07-08 18955, 2010

      • warp
      • 2010-07-08 18906, 2010

      • navap
      • 2010-07-08 18935, 2010

      • navap
      • 2010-07-08 18938, 2010

      • warp
        strange!
      • 2010-07-08 18920, 2010

      • navap
        Have you seen all of our "rock" tags?
      • 2010-07-08 18911, 2010

      • navap
        Like "rock_pop rock_rock_pop rock_rock_pop rock_rock" (that's one tag)
      • 2010-07-08 18952, 2010

      • warp
        :(
      • 2010-07-08 18913, 2010

      • nikki wants to fix tags like that :/
      • 2010-07-08 18943, 2010

      • nikki
        there's also things like "r b" because if you use "r&b" it removes the & because it's not worthy of being included :P
      • 2010-07-08 18913, 2010

      • luks
        maybe we can have a "Remove Tag" edit type?
      • 2010-07-08 18925, 2010

      • luks
        it could require more than the usual 3 votes
      • 2010-07-08 18913, 2010

      • warp
        that's not how tags are supposed to work.
      • 2010-07-08 18932, 2010

      • nikki
        hey luks
      • 2010-07-08 18944, 2010

      • navap
        Is that wise given that tags are supposed to be free form? I imagine last.fm would respond to something like that by saying "if enough other people add 'correct' tags the 'bad' tag will shrink away".
      • 2010-07-08 18931, 2010

      • luks
        but we don't have enough other people :)
      • 2010-07-08 18909, 2010

      • navap
        I'm not saying I like those tags, but beig able to remove tags seems to go against their purpose. (Unless they've got profanity or something like that)
      • 2010-07-08 18935, 2010

      • luks
        I didn't mean it as a regular operation
      • 2010-07-08 18943, 2010

      • nikki
        some of them are clearly mistakes (e.g. the ones which are webservice urls...) so it'd be nice if *someone* could remove them sometimes
      • 2010-07-08 18925, 2010

      • navap
        So have a "Tag editor" user flag? :p
      • 2010-07-08 18906, 2010

      • warp
      • 2010-07-08 18924, 2010

      • nikki
        hehe, hello project is still here
      • 2010-07-08 18925, 2010

      • nikki
        there
      • 2010-07-08 18916, 2010

      • nikki
        it should probably say "top tags" or something though
      • 2010-07-08 18959, 2010

      • warp
        silly git.
      • 2010-07-08 18923, 2010

      • nikki always forgets we have those clouds though
      • 2010-07-08 18932, 2010

      • nikki
        aaaages ago I added something in my user css to make them lists
      • 2010-07-08 18937, 2010

      • jensl joined the channel
      • 2010-07-08 18934, 2010

      • navap
        The size differences isn't very visible though :/ It's not very visible on the live server either.
      • 2010-07-08 18915, 2010

      • navap
        Instead of starting at a size of 100, maybe you should start with a much smaller size.
      • 2010-07-08 18926, 2010

      • navap
        Crap. I tried to checkout warp/mbs171 and it didn't work too well, now I've got a heads/warp/mbs171 branch that I can't delete because it was "not found" and I can't checkout a new mbs171 because it "already exists".
      • 2010-07-08 18956, 2010

      • pronik joined the channel
      • 2010-07-08 18916, 2010

      • warp
        navap: hm, interesting.
      • 2010-07-08 18932, 2010

      • warp
        navap: do you have me as a remote?
      • 2010-07-08 18955, 2010

      • warp
        navap: in that case you can always do git checkout warp/mbs171 -b my-local-copy-of-warps-mbs171
      • 2010-07-08 18955, 2010

      • navap
        I do, I ended up fixing it by using `branch -d -r` instead of just `branch -d`.
      • 2010-07-08 18927, 2010

      • navap
        Once I cleaned up the messed up branch I was able to checkout a new copy of warp/mbs171
      • 2010-07-08 18933, 2010

      • warp
        ok
      • 2010-07-08 18943, 2010

      • jensl
        warp: do you got 10min to talk about the UI?
      • 2010-07-08 18952, 2010

      • warp
        jensl: yes, certainly.
      • 2010-07-08 18948, 2010

      • jensl
        please get the latest version and navigate to the release detail page
      • 2010-07-08 18937, 2010

      • warp gets the macbook.
      • 2010-07-08 18932, 2010

      • pronik
        warp, navap: I'd like to upgrade reviewboard to 1.5rc1, would it be ok with you?
      • 2010-07-08 18953, 2010

      • warp
        pronik: does it give us sparkly new bits?
      • 2010-07-08 18913, 2010

      • pronik
        yes, move detection, proper display of removed files etc.
      • 2010-07-08 18920, 2010

      • warp
        ah, cool.
      • 2010-07-08 18920, 2010

      • pronik
      • 2010-07-08 18926, 2010

      • pronik
        added support for iPhone ;)
      • 2010-07-08 18934, 2010

      • warp
        pronik: go ahead
      • 2010-07-08 18948, 2010

      • pronik
        ok, wish me luck ;)
      • 2010-07-08 18949, 2010

      • warp
        jensl: I have to mess with the project file a bit to get things to run on iOS4 SDK
      • 2010-07-08 18902, 2010

      • jensl
        mmh
      • 2010-07-08 18939, 2010

      • jensl
        warp: i will get the latest version now and take care that this will work without messing project file in the future
      • 2010-07-08 18935, 2010

      • warp
        jensl: it's only one setting, it's not a big problem. Just forget where it was exactly.
      • 2010-07-08 18918, 2010

      • warp
        for future reference: Project -> Edit Project Settings -> Base SDK for All Configurations -> iPhone Device 4.0
      • 2010-07-08 18944, 2010

      • warp
        jensl: ArtistController.* are missing
      • 2010-07-08 18958, 2010

      • warp
        and a few other files.
      • 2010-07-08 18928, 2010

      • jensl
        pull again...
      • 2010-07-08 18953, 2010

      • pronik
        warp, navap: done, have fun. Ping me if something goes wrong (also per mail)
      • 2010-07-08 18959, 2010

      • jensl
        warp: just recognized some strange UI glitches, will fix them later and does not matter for the current discussion
      • 2010-07-08 18904, 2010

      • warp
        jensl: two warnings.
      • 2010-07-08 18941, 2010

      • warp
        jensl: ok, it's running on the ipod.
      • 2010-07-08 18937, 2010

      • jensl
        i do not like the current release detail page, it is just not looking "cool"
      • 2010-07-08 18905, 2010

      • jensl
        therefore I was thinking about redesigning the arrangement of the information
      • 2010-07-08 18929, 2010

      • jensl
        i pretty much like the way IMDB solved it with their iphone app
      • 2010-07-08 18944, 2010

      • jensl
        working with table views again...
      • 2010-07-08 18956, 2010

      • warp
        heh, the interface is still a bit glitchy indeed
      • 2010-07-08 18914, 2010

      • jensl
        yes
      • 2010-07-08 18952, 2010

      • jensl
        so I would put all details in the common tables, this would also improve navigation because a tap on the artist row would navigate to the artist details page
      • 2010-07-08 18910, 2010

      • warp
        jensl: I think you shouldn't spend too much time on the layout at this stage, get everything working properly first.
      • 2010-07-08 18945, 2010

      • jensl
        warp: ok then I will leave the layout out for now
      • 2010-07-08 18922, 2010

      • jensl
        I will finish the artist and label details page today and insert navigation between them
      • 2010-07-08 18949, 2010

      • jensl
        then the base functionality for text search is finished
      • 2010-07-08 18936, 2010

      • warp
        jensl: once things are working, read apple's "iPhone Human Interface Guidelines"
      • 2010-07-08 18941, 2010

      • jensl
        are the webservices for adding / retrieving collection are already finished
      • 2010-07-08 18944, 2010

      • jensl
        warp: ok
      • 2010-07-08 18937, 2010

      • warp
        I see strange results when using the artist search.
      • 2010-07-08 18938, 2010

      • warp
        jensl: when I search for 'Morning musume' after starting up the app, the results seems quite strang.
      • 2010-07-08 18941, 2010

      • warp
        e
      • 2010-07-08 18901, 2010

      • warp
        I first get a list of 8 identical entries, "country-jp"
      • 2010-07-08 18941, 2010

      • jensl is checking the web service call and xml parsing
      • 2010-07-08 18917, 2010

      • warp
        what is the query you're using there?
      • 2010-07-08 18929, 2010

      • jensl
      • 2010-07-08 18942, 2010

      • warp
        looks like you're including the folksonomy tags
      • 2010-07-08 18907, 2010

      • warp
        are you doing an xpath query for //name perhaps?
      • 2010-07-08 18927, 2010

      • warp
        (which would also match tag-list/tag/name)
      • 2010-07-08 18949, 2010

      • jensl
        no i only take the xml node <name>
      • 2010-07-08 18900, 2010

      • jensl
        the problem are the chinese characters
      • 2010-07-08 18925, 2010

      • warp
        japanese :P
      • 2010-07-08 18926, 2010

      • jensl
        have to check, how to display these
      • 2010-07-08 18933, 2010

      • jensl
        ok japenese :D
      • 2010-07-08 18947, 2010

      • warp
        odd.
      • 2010-07-08 18923, 2010

      • jensl
        got no clue why the apple xml parser is converting them into country-jp, but will examine how to solve that issue
      • 2010-07-08 18926, 2010

      • warp
        jensl: if you click 'hello project' in the search results you get some japanese which is display correctly.
      • 2010-07-08 18945, 2010

      • jensl
        strange
      • 2010-07-08 18953, 2010

      • warp
        jensl: well, there is a <name>country-jp</name> in the <tag>s
      • 2010-07-08 18903, 2010

      • jensl
        :D
      • 2010-07-08 18931, 2010

      • warp
        jensl: so I still think you're including those <name>s, when you should only include the <name> directly under <artist>.
      • 2010-07-08 18943, 2010

      • jensl
        yes that's the problem
      • 2010-07-08 18913, 2010

      • warp
        ok :)
      • 2010-07-08 18901, 2010

      • jensl
        noted on the bugs list :)
      • 2010-07-08 18941, 2010

      • jensl
        warp: do you roughly know when rating, tagging and the collection stuff will be implemented in ws2?
      • 2010-07-08 18925, 2010

      • warp
        leftmost is doing collection stuff, I'm not sure if he plans on doing anything with the webservice
      • 2010-07-08 18948, 2010

      • warp
        but there is enouh other stuff for me to do that I'm not currently touching the collection stuff in the webservice
      • 2010-07-08 18913, 2010

      • jensl
        ok
      • 2010-07-08 18917, 2010

      • warp
        I will probably work on tags and ratings soon, I'm waiting on some reviews on my /ws/2 code.
      • 2010-07-08 18951, 2010

      • warp
        tags and ratings are reasonably seperate, so I don't _have_ to wait on those reviews... but it's just easier with merging branches and whatnot if that code has been reviewed and merged into master.
      • 2010-07-08 18923, 2010

      • jensl
        of course
      • 2010-07-08 18926, 2010

      • jensl
        I put that back, finish release pages and include the paypal library
      • 2010-07-08 18904, 2010

      • jensl
        would like to at least completely finish those features until mid-term eval
      • 2010-07-08 18934, 2010

      • warp nod.s
      • 2010-07-08 18901, 2010

      • jensl
        do you got any other questions?
      • 2010-07-08 18944, 2010

      • hawke_ joined the channel
      • 2010-07-08 18947, 2010

      • hawke_
        Hey all…potentially interesting/relevant music fingerprinting blog post: http://notes.variogr.am/post/544559482/the-echo-n…
      • 2010-07-08 18905, 2010

      • warp
        hawke_: yeah, we're aware of it. (I was at music hack day in amsterdam).
      • 2010-07-08 18918, 2010

      • warp
        hawke_: it could be quite interesting for musicbrainz.
      • 2010-07-08 18950, 2010

      • hawke_
        Ah, cool.