faith merged three different Fabulous recordings on different HSM releases, then changed the artist for the recording from Ashley Tisdale & Lucas Grabeel to [Disney] ( see http://test.musicbrainz.org/recording/abedc027-6d… )
2010-09-23 26624, 2010
brianfreud
The recording shows [Disney] correctly. However, the releases themselves still list Ashley/etc as the track artist (not an AC to [Disney], as far as I can tell), and there seems no apparent way to change the artist for those tracks (instances of that recording)
2010-09-23 26631, 2010
navap
Isn't that correct?
2010-09-23 26639, 2010
nikki
you change them in the release editor
2010-09-23 26656, 2010
brianfreud
the recording's artist was changed, rather than change the artist 1xper each instance on a release.
2010-09-23 26605, 2010
navap
This lets a release and it's tracks accurately store what's on the liner, while the recording has the normalized version.
2010-09-23 26618, 2010
brianfreud
so shouldn't that artist change on the tracks be consistent with the recording?
2010-09-23 26621, 2010
navap
It does make it a pain to change the track artists though.
2010-09-23 26651, 2010
brianfreud
right - so I'd expect, at most, Ashley/etc to become an AC to [Disney], not the track and the recording to each now have an entirely different artist
2010-09-23 26651, 2010
nikki
and there's a ticket in jira already for being able to update artist credits when merging
2010-09-23 26628, 2010
navap
I've got to run, be back in 30 min or so.
2010-09-23 26638, 2010
nikki
I think you should probably be asking acid2 actually. he's the one who did the merging edits as far as I know
2010-09-23 26618, 2010
brianfreud
makes sense to me --> Foo is a recording by Bar, Foo1234 is a track by Bar which is an instance of the recording Foo
2010-09-23 26650, 2010
nikki
although I just woke up again, so I can't really think right now
2010-09-23 26652, 2010
brianfreud
still makes sense to me --> Foo is a recording by Bar, Foo1234 is a track by Bar (playing as Zip) which is an instance of the recording Foo
2010-09-23 26606, 2010
brianfreud
doesn't make sense to me --> Foo is a recording by Bar, Foo1234 is a track by SomeoneElse which is an instance of the recording Foo
2010-09-23 26620, 2010
navap
Think of that Quee & David Bowie song that is credited to different people on different releases.
2010-09-23 26643, 2010
brianfreud
So it's intentional? Doesn't that mean that, rather than simplifying artist changes by centralizing them all to a single recording, we're actually multiplying them, as now there's the change on the recording, plus a change on each and every release (which means potentially far more releases to be edited, with the new definition for a release)?
2010-09-23 26617, 2010
brianfreud
I'd think of the Queen and David Bowie case as being recording: "Queen" & "David Bowie", track1 "Queen" & "David Bowie" (as AC "Queen"), track2 "Queen" & "David Bowie" (as AC "David Bowie")
2010-09-23 26644, 2010
nikki
you can't link an artist in an artist credit and not include any text
2010-09-23 26629, 2010
nikki
as far as I can tell, there's a bug in the edit recording stuff because all http://test.musicbrainz.org/edit/12710294 did was edit the name, not the actual linked artist
2010-09-23 26625, 2010
brianfreud
so b/c of the bug, the recording is still linked to Ashley/etc, just with the AC for that artist being [Disney] on that recording?
2010-09-23 26641, 2010
nikki
I remember a similar bug where you couldn't change the first artist of an artist credit, only the credited text, so it should be somewhere in jira
2010-09-23 26610, 2010
nikki
maybe, it's hard to tell because there was no change to the actual artist that was linked
2010-09-23 26613, 2010
brianfreud
hmmm, yes, it's still the same artist MBID, just w/a new name... wierd
2010-09-23 26642, 2010
brianfreud
and that [Disney], whereever it appears for that recording, still links to Ashley/etc
that one mentions track artists, but back when that ticket was created, changing track artists used the same artist credit editor as the edit recording stuff does now
2010-09-23 26647, 2010
nikki
hmm...
2010-09-23 26658, 2010
nikki notices that the lyrics relationship isn't on http://wiki.musicbrainz.org/Next_Generation_Schema/Release_Relationships_Conversion
2010-09-23 26622, 2010
ianmcorvidae
it was on one of the versions, I thought
2010-09-23 26624, 2010
ianmcorvidae
hm
2010-09-23 26633, 2010
ianmcorvidae
oh wait release relationships
2010-09-23 26633, 2010
nikki
probably the track one you were working on ;)
2010-09-23 26635, 2010
ianmcorvidae
never mind :)
2010-09-23 26644, 2010
ianmcorvidae
yyyeah I may be a bit tired
2010-09-23 26649, 2010
nikki
it should probably be a release group one anyway
2010-09-23 26659, 2010
dinog joined the channel
2010-09-23 26643, 2010
dinog1 joined the channel
2010-09-23 26633, 2010
djce joined the channel
2010-09-23 26644, 2010
ijabz joined the channel
2010-09-23 26650, 2010
aCiD2 joined the channel
2010-09-23 26610, 2010
dinog joined the channel
2010-09-23 26630, 2010
aCiD2 pings murdos
2010-09-23 26638, 2010
aCiD2
luks too
2010-09-23 26648, 2010
luks
hi
2010-09-23 26607, 2010
aCiD2
hey, are you free for a brief chat? it's about editing tracks and separating tracklists between releases
2010-09-23 26615, 2010
aCiD2
I've written up a document that explains the problem, just finishing that now
it's a problem of track ids changing in edits, see the scenarious in that document
2010-09-23 26642, 2010
luks
the only realistic solution I was able to come up is to ask the user what to do
2010-09-23 26655, 2010
luks
track IDs are not important
2010-09-23 26600, 2010
luks
they are not shown anywhere
2010-09-23 26623, 2010
luks
tracks itself are not important
2010-09-23 26626, 2010
luks
tracklists are
2010-09-23 26630, 2010
aCiD2
but they are needed for the edits to know which track they are editing
2010-09-23 26605, 2010
aCiD2
Say I'm renaming a track, and I don't want it to affect other tracks. The edit needs to know somehow which track I'm refering to, and the track id seems the only safe identifier
2010-09-23 26637, 2010
luks
ah, I think I can't help much with that
2010-09-23 26627, 2010
aCiD2
as in you're stumped too? :) or you wouldn't get into this situation?
2010-09-23 26648, 2010
luks
as in I always wanted to avoid this because there is no good solution
2010-09-23 26619, 2010
aCiD2
ok, I'm all for avoiding it too then
2010-09-23 26624, 2010
luks
I said many times that I'd prefer to not release NGS with the current structure of edits
2010-09-23 26630, 2010
aCiD2
we heard you
2010-09-23 26641, 2010
aCiD2
but we're running rapidly out of time
2010-09-23 26645, 2010
luks
the only alternative I had on my mind was to have Edit Tracklist as the lowest edit type
2010-09-23 26609, 2010
aCiD2
Meaning that if I rename 2 tracks, we only get 1 edit?
2010-09-23 26620, 2010
luks
yes
2010-09-23 26636, 2010
aCiD2
yea, me and Kuno discussed that, but that doesn't seem good - it's not at all granular
2010-09-23 26640, 2010
aCiD2
but maybe that's the best we can do for now
2010-09-23 26614, 2010
warp
the problem there is that someone else cannot e.g. vote no one of the renames and yes on the other one.
2010-09-23 26634, 2010
warp
but perhaps that's not that much of an issue.
2010-09-23 26624, 2010
luks
no matter how you do it, using this kind of edit structure for NGS is a hack
2010-09-23 26636, 2010
luks
so I guess it's always only temporary solution
2010-09-23 26648, 2010
aCiD2
I think the fastest way to get this out the door is with an edit tracklist edit
2010-09-23 26602, 2010
nikki
fewer edits to vote on \o/
2010-09-23 26605, 2010
nikki isn't helpful
2010-09-23 26633, 2010
warp
nikki :D
2010-09-23 26640, 2010
navap wonders why we have the "login only from this IP address" option.
2010-09-23 26602, 2010
navap
I mean who added it originally and why? Was it requested?
2010-09-23 26630, 2010
navap
It seems like an odd setting, I've never seen any other sites except banks ask that kind of question.
2010-09-23 26643, 2010
nikki
I'm sure I've seen it a few times
2010-09-23 26607, 2010
navap
Okay fine, banks and a few other random sites. But do we really need it?
2010-09-23 26625, 2010
nikki
my guess would be that djce added it because he's all security-conscious or something, but I can't be sure
2010-09-23 26641, 2010
nikki
I can't remember *not* having it, which would suggest it was still djce mostly coding when it was added
2010-09-23 26641, 2010
djce
+1
2010-09-23 26657, 2010
nikki
so it was you?
2010-09-23 26604, 2010
djce
Sounds like me.
2010-09-23 26608, 2010
nikki
hehe
2010-09-23 26640, 2010
aCiD2
heh
2010-09-23 26647, 2010
navap
djce: Would you object to not including it in NGS?
2010-09-23 26600, 2010
aCiD2
It's also nice and difficult for me to test it actually works :)
2010-09-23 26600, 2010
djce
Fine by me.
2010-09-23 26650, 2010
djce
One way to test it would be to log in, dick with the nginx config so that the REMOTE_ADDR is fake, then see if your cookie still works.
2010-09-23 26655, 2010
djce
Then revert nginx conf. :-)
2010-09-23 26628, 2010
aCiD2
Yea, or use my server as a SOCKS proxy
2010-09-23 26631, 2010
nikki would just use ssh
2010-09-23 26637, 2010
nikki
yeah :P
2010-09-23 26638, 2010
navap
aCiD2: Can you remove the single_ip code from r848 please (should I remind you on the review?)
2010-09-23 26646, 2010
aCiD2
navap: please remind me on the review
2010-09-23 26657, 2010
aCiD2
When I finish this branch I'll ship/amend those reviews you've commented on
Can't remember really. I didn't spend much time on it; IIRC it didn't work straight away, and I probably put it down and didn't go back to it.
2010-09-23 26657, 2010
djce
The short (ish) answer is,
2010-09-23 26604, 2010
djce
if we can take a few hours of wiki downtime,
2010-09-23 26608, 2010
djce
it becomes a lot easier.
2010-09-23 26622, 2010
djce
Trying to make this change with the wiki still up is hard.
2010-09-23 26632, 2010
djce
Not having a staging wiki and all.
2010-09-23 26653, 2010
nikki
I'm sure people will survive if we do take it down
2010-09-23 26607, 2010
djce
Yeah, might just have to do that one day.
2010-09-23 26607, 2010
navap
I say go for it, would it be possible to put up a temporary index.htm saying "the wiki will be back soon" or something?
2010-09-23 26613, 2010
djce
Affects the live site too, of course.
2010-09-23 26616, 2010
djce
wikidocs etc.
2010-09-23 26623, 2010
nikki
yeah, I was about to say
2010-09-23 26627, 2010
navap
Ah right, /doc won't work.
2010-09-23 26633, 2010
nikki
I wonder if it'll behave nicely or just go splat
2010-09-23 26650, 2010
navap
Getting the api working is pretty important. We can't wait till NGS is being released to take the wiki down and figure this out because we need to make sure there are no issues with my wikidoc code.
2010-09-23 26607, 2010
navap
djce: I'd appreciate it if you take a harder look and figure this out :)
2010-09-23 26621, 2010
djce
Of, that I have no doubt :-)
2010-09-23 26625, 2010
nikki wonders if we'll still have the similar release thing now that each release event is its own release
2010-09-23 26600, 2010
navap
We'll need something like it to be able to "clone" a release from within the release editor.
2010-09-23 26613, 2010
nikki
hmm?
2010-09-23 26652, 2010
navap
How will a user add a new release event? If they do it through the release editor they should be able to specify that they want to reuse an existing tracklist.
2010-09-23 26635, 2010
nikki
I'm not talking about that (and we don't have any duplicate-this-release functionality to keep)
2010-09-23 26659, 2010
nikki
I mean the thing which says something along the lines of "this release is similar to these releases, are you sure you want to enter a new release?"
2010-09-23 26639, 2010
nikki
the number of times I've seen that bloody screen in the last few days >_<
2010-09-23 26622, 2010
ruaok joined the channel
2010-09-23 26624, 2010
warp
hello ruaok
2010-09-23 26637, 2010
ruaok
hi warp.
2010-09-23 26641, 2010
ruaok
you guys being productive?
2010-09-23 26648, 2010
djce hopes the "Proper Job" has worn off now
2010-09-23 26659, 2010
warp
reasonably
2010-09-23 26622, 2010
ruaok hopes the drive was worth it
2010-09-23 26635, 2010
ruaok
djce: yes, that seemed to have been the right amount of great beer. :)
2010-09-23 26655, 2010
ruaok
I just met with the Radiotuna guys from Brighton. more beer. yum.
2010-09-23 26629, 2010
warp
ruaok: aCiD2 is going to have a look at my release editor branch now.
