there are some greasemonkey scripts here and there which let auto-editors tick a box on the edit search page to approve an edit
2010-03-03 06239, 2010
nikki
but there are clashes with the improved voting stuff we have now, and it only works in ff
2010-03-03 06244, 2010
ruaok
my brain hurts.
2010-03-03 06202, 2010
ruaok
I've been working and staring at a computer all day. and the visual processing area in my brain is pissy.
2010-03-03 06208, 2010
ruaok
so very odd a sensation.
2010-03-03 06230, 2010
ruaok
I'd be willing to give a handful of people the magic approve button.
2010-03-03 06247, 2010
ruaok
like everyone in this channel, for instance.
2010-03-03 06255, 2010
ruaok
ok, I have to rest my eyes.
2010-03-03 06256, 2010
ruaok
bbiab.
2010-03-03 06257, 2010
navap
Even if just autoeditors were able to batch approve, that would certainly speed things up.
2010-03-03 06210, 2010
nikki
I'm sure we can talk about it another time :)
2010-03-03 06226, 2010
nikki
navap: yeah, that's what I mean
2010-03-03 06242, 2010
nikki
eheh... matched 90% of these urls now...
2010-03-03 06221, 2010
navap
alastairp: I've commited my change and pushed it to github. So now how would one of the devs get at my change?
2010-03-03 06251, 2010
alastairp
they would add you gh as a remote
2010-03-03 06217, 2010
navap
And then pull/merge me into a branch on their end?
2010-03-03 06234, 2010
alastairp
yep
2010-03-03 06238, 2010
alastairp
but it's no different to someone having a repo on git.mb by that stage
2010-03-03 06256, 2010
alastairp
all the rest is workflow
2010-03-03 06222, 2010
navap
So all the *.gits on git.mb are like different users on github?
2010-03-03 06242, 2010
alastairp
different repositories
2010-03-03 06247, 2010
alastairp
but yeah
2010-03-03 06239, 2010
djce joined the channel
2010-03-03 06210, 2010
aCiD2
Someone needs to work a way to bring a role like system to HTML templates
2010-03-03 06244, 2010
aCiD2
nikki: prod
2010-03-03 06217, 2010
aCiD2
hah "en-scouse"
2010-03-03 06218, 2010
aCiD2
awesome
2010-03-03 06201, 2010
stereohead joined the channel
2010-03-03 06259, 2010
brianfreud
p track of bug for the MusicBrainz server now. Please do not enter bugs for Beta 1 into the old (trac) bug tracker!"
2010-03-03 06227, 2010
brianfreud
That's seeming to say "anything for the MusicBrainz server" and "only NGS Beta 1" at the same time
2010-03-03 06223, 2010
brianfreud
Side note, on jira and the bugs list; since jira sends me everything directly anyhow, I wish it didn't get included in the bugs list stuff... All the jira stuff, including time estimating, etc, is making it very hard to find the few trac-ticket related things in the bug lists, as well as the jira-in-bugs-list being 100% redundant to the every-single-jira-ticket-sent-directly-to-me
2010-03-03 06248, 2010
aCiD2
Anyone know how to get a list of locales (I need language and territory) in Perl?
2010-03-03 06204, 2010
aCiD2
I can't figure it out after an hour of browsing modules -_-'
2010-03-03 06227, 2010
aCiD2
I18N::LangTags::List doesn't actually list them, Locales is useless because it just gives all territories, regardless of the language
2010-03-03 06242, 2010
aCiD2
and Locale::Codes doesn't seem to have territory support
Hmph, still doesn't have the mapping between language and territory either
2010-03-03 06213, 2010
warp
brianfreud: oh, if you cannot (re-)assign jira tickets, we should probably open that up.
2010-03-03 06224, 2010
warp
aCiD2: hello! :)
2010-03-03 06213, 2010
aCiD2
morning warp :)
2010-03-03 06214, 2010
aCiD2
urr
2010-03-03 06216, 2010
aCiD2
afternoon*
2010-03-03 06217, 2010
aCiD2
:)
2010-03-03 06256, 2010
warp wonders what the purpose is for the language + territory combination.
2010-03-03 06218, 2010
aCiD2
warp: Someone said on the mailing list that aliases might be in a certain languange, but only for a certain territory
2010-03-03 06241, 2010
aCiD2
I (obviously) can't think of an example, but i was trying to cater to that. I think for now, i'm going to just provide languages
2010-03-03 06215, 2010
warp
aCiD2: ah, right
2010-03-03 06222, 2010
aCiD2
how did the UX stuff go, warp?
2010-03-03 06226, 2010
brianfreud
warp: yeah; I cannot touch the assignee - I think only you, luks, acid2, and ruoak can
2010-03-03 06239, 2010
warp
aCiD2: can you open that up for brianfreud?
2010-03-03 06244, 2010
warp
aCiD2: or just in general?
2010-03-03 06251, 2010
aCiD2
yea, I'll look into that now
2010-03-03 06220, 2010
warp
regarding UX, we discussed that a bit.. but this hardcore data entry stuff is just hard.
2010-03-03 06229, 2010
aCiD2
Heh, amen to that
2010-03-03 06239, 2010
warp
he basically said what I already knew, make the common things easy to do with both keyboard and mouse
2010-03-03 06256, 2010
warp
and for anything else it's ok if that's a little more effort.
2010-03-03 06226, 2010
aCiD2
brianfreud: you should be able to reassign...
2010-03-03 06236, 2010
brianfreud
also, on the other point I made ^^, that blog post was rather unclear...
2010-03-03 06259, 2010
warp
considering collaborations are less common than just single artists, it's ok if keyboard users have to either click something with the mouse or learn a complicated keyboard shortcut.
2010-03-03 06200, 2010
aCiD2
The only thing you can't do is scheduling, changing the reporter, deleting issues and changing the security level
2010-03-03 06212, 2010
brianfreud
if jira is only for NGS, that wasn't my takeaway from the post. But if jira is to be for all mb server, there's no way to assign something as a mason issue, such as adding an AR
2010-03-03 06214, 2010
warp
er.. to open the artist credit editor.
2010-03-03 06230, 2010
aCiD2
warp: right, that does seem acceptable
2010-03-03 06236, 2010
warp
aCiD2: switching topics, on your feedback on MBS-424.
2010-03-03 06252, 2010
warp
aCiD2: I couldn't figure out a clean way to get stuff into <head>
2010-03-03 06257, 2010
warp
aCiD2: I wasn't sure how to append to layout_head, and didn't want to overwrite it. and it's outside the [% UNLESS no_javascript %]
2010-03-03 06259, 2010
aCiD2
you just do [% BLOCK layout_head %] in the templates that need to change it
2010-03-03 06209, 2010
warp
preferably it's only included when rating_stars() is called on a page, but there doesn't seem to be a way write a template that way.
2010-03-03 06211, 2010
aCiD2
but yea... the latter is more of an issue I think
2010-03-03 06243, 2010
aCiD2
This is why with scripts/text.js at least we get to cache all the translations
2010-03-03 06247, 2010
warp
aCiD2: wouldn't just [% BLOCK layout_head %] overwrite any existing layout_head?
2010-03-03 06254, 2010
aCiD2
it would, but that's the point of it
2010-03-03 06211, 2010
warp
aCiD2: what if some other piece of code also wants to include stuff in the <head>?
2010-03-03 06212, 2010
aCiD2
I mean in root/artist/index.tt you'd override layout_head
2010-03-03 06218, 2010
aCiD2
then you append to that bit of code
2010-03-03 06254, 2010
aCiD2
sadly, I haven't found a nice way to specialize what javascript is on which page yet
2010-03-03 06259, 2010
aCiD2
after trying numerous solutions
2010-03-03 06207, 2010
warp
aCiD2: well, there can be a few layers of [% WRAPPER %]s
2010-03-03 06229, 2010
aCiD2
The plan was that the low level templates wouldn't tocuh layout_head - only the actual page templates
2010-03-03 06237, 2010
brianfreud
aCiD2: What didn't work with the way I did it? That was working well for page/etc js specialization
2010-03-03 06244, 2010
warp
aCiD2: anyway, even then, the code I want to include in <head> is stuff which should be near the other rating macros, because it's already duplicated... and if it's not right next to eachother you'll forget to change one if you change the other.
2010-03-03 06222, 2010
aCiD2
brianfreud: and what was that way?
2010-03-03 06236, 2010
aCiD2
the page_js array?
2010-03-03 06256, 2010
warp
I'm not too fussed about including unused javascript on a page, that just means we can later on minimize it all together in a one or a few big .js files and make sure the browser caches it.
2010-03-03 06255, 2010
brianfreud
yeah
2010-03-03 06237, 2010
brianfreud
warp: Oh god, please no!
2010-03-03 06241, 2010
aCiD2
warp: then could we move it to text.js?
2010-03-03 06219, 2010
aCiD2
If we want to bung it all together for now and come back to it later that's fine, but it'd be nice if we could at least to do that in something other than the html
2010-03-03 06242, 2010
warp
aCiD2: "git ls-files | grep text.js" returns nothing, which file are you referring to?
2010-03-03 06244, 2010
brianfreud
cached js: good. "one big .js file(s)": a thousand times no! :D
2010-03-03 06205, 2010
aCiD2
root/script/text_strings.tt
2010-03-03 06225, 2010
warp
aCiD2: ah, I didn't know that files. that does seem perfect for the strings I have, yes.
2010-03-03 06233, 2010
aCiD2
:)
2010-03-03 06241, 2010
aCiD2
help if I called it by the correct name
2010-03-03 06246, 2010
warp
brianfreud: in general, tools like google page speed and yahoo's YSlow recommend combining .js files into one file.
2010-03-03 06209, 2010
brianfreud
no, they recommend combining js *per page* into one...
2010-03-03 06222, 2010
warp
brianfreud: yes, sure
2010-03-03 06222, 2010
brianfreud
Unless I misunderstood what you meant?
2010-03-03 06248, 2010
brianfreud
I just don't want to see the same as on mason, where the entire site got dumped into one massive js file that got loaded on every page
2010-03-03 06249, 2010
warp
brianfreud: but we don't have many different page types.
2010-03-03 06220, 2010
brianfreud
There's no reason RE js should be parsed into the browser on any page but a RE page
2010-03-03 06224, 2010
aCiD2
general purpose JS and RE seem fine to me
2010-03-03 06229, 2010
aCiD2
that's a good enough separation
2010-03-03 06241, 2010
warp
aCiD2: yeah, that's what I was thinking too.
2010-03-03 06249, 2010
brianfreud
the others are all tiny, so no big deal, but the RE/GC is a big resource hog if you have mult MB tabs open
2010-03-03 06203, 2010
brianfreud
(no matter how efficient you make it :P)
2010-03-03 06204, 2010
aCiD2
brianfreud: no one is suggesting that
2010-03-03 06217, 2010
brianfreud
ok, just making sure :D
2010-03-03 06232, 2010
aCiD2
i know we generally said "lump it together" but we're not going to be that careless - it's just not worth the effort to get it perfect (same with CSS)
2010-03-03 06234, 2010
brianfreud
the mason-way, with all in one, is just so fugly :D
2010-03-03 06225, 2010
warp
I can also imagine not loading the RE/GC code on page load at all
2010-03-03 06218, 2010
warp
or, I mean, some components could perhaps be loaded on demand.
2010-03-03 06200, 2010
aCiD2
brian tried that with mixed success
2010-03-03 06223, 2010
warp
yeah, now that I think about it.. most is probably needed when you actually edit stuff.
2010-03-03 06228, 2010
brianfreud
well full success, but luks hated it,
2010-03-03 06236, 2010
warp
:)
2010-03-03 06217, 2010
warp
brianfreud: if there are components which are likely to go unused by a considerable amount of users on a particular page, I will definitely consider that approach.
2010-03-03 06223, 2010
aCiD2
I didn't like it either, it was too slow to load
2010-03-03 06233, 2010
aCiD2
i think it's cause we went all-or-nothing
2010-03-03 06259, 2010
aCiD2
but yea, if we just load the track parser or something on demand, that seems more sensible
2010-03-03 06205, 2010
brianfreud
what mainly drives me nuts is that GM doesn't start to load until *all* page js parses and loads. When you're trying to do a lot of tiny things quickly, across a lot of tabs, waiting for that big js file to parse/load on mason often means GM takes me 5-15 seconds before anything GM is useable on any tab
2010-03-03 06234, 2010
warp
yes, it doesn't have to be on-demand.
2010-03-03 06257, 2010
warp
it can also be on-demand or 2 seconds after the page has finished loading, whichever occurs first.
2010-03-03 06215, 2010
brianfreud
aCiD2: I don't think it even needs to be that much; the only RE module-specific js that should really be largish is GC, and you almost never need GC right at page load
2010-03-03 06217, 2010
warp
I'm just brainstorming though, I have never tried such approaches :)
2010-03-03 06256, 2010
warp notes guess case is used on many pages, not just the relaese editor.
2010-03-03 06228, 2010
warp
anyway, I'm going to fix MBS-424, afk.
2010-03-03 06209, 2010
warp
(well, not really away from keyboard... would be hard for me to hack js without a keyboard)
2010-03-03 06229, 2010
brianfreud
warp: from my experiences, if you lazy load the RE at all, I'd suggest either RE (page) + GC (lazy), or, if/when there's time to optimize page load for the RE, bare minimum to have basic form functionality (page) + RE (lazy 1st) + GC (lazy last)
2010-03-03 06203, 2010
brianfreud
anything more than that the overhead makes it not worth doing
2010-03-03 06215, 2010
stereohead joined the channel
2010-03-03 06226, 2010
warp
aCiD2: hm, what do you think of making just the rating text strings themselves macros?
2010-03-03 06248, 2010
warp
aCiD2: which I could call in text_strings.tt, I really don't want the same string to appear in two different files.
2010-03-03 06249, 2010
aCiD2
Why would it appear anywhere other than in text_strings.tt? Is this because you want all the rating stuff together?
2010-03-03 06220, 2010
warp
aCiD2: because the same string is needed both from javascript and in the html
2010-03-03 06231, 2010
aCiD2
ah, ok
2010-03-03 06241, 2010
warp
aCiD2: the javascript needs to swap out "Remove your rating" for "Rate: 5 stars", etc..
2010-03-03 06244, 2010
aCiD2
So how are you planning to define the strings?
2010-03-03 06233, 2010
aCiD2
How about: root/components/ratings.tt which is included from common-macros.tt so we have all the rating stuff together. Text_strings.tt can make use of the stuff too then
2010-03-03 06207, 2010
warp
aCiD2: ah, I can just [% INCLUDE 'component/rating-macros.tt' %] in common-macros.tt?
2010-03-03 06224, 2010
aCiD2
yea
2010-03-03 06227, 2010
warp
(there is already a components/ratings.tt which does something else)
2010-03-03 06256, 2010
aCiD2
Hrm, so there is
2010-03-03 06223, 2010
aCiD2
that could be stuffed into a MACRO as a BLOCK and called as [% display_ratings(ratings) %] ?
2010-03-03 06242, 2010
aCiD2
meh
2010-03-03 06248, 2010
aCiD2
stick it in common-macros for now
2010-03-03 06256, 2010
warp
aCiD2: for the strings, I was thinking something ugly like [% MACRO rating_tooltip_set (star) BLOCK; l("foo"); END %] or something.
