16:40 PM
ruaok
understood.
2014-10-09 28259, 2014
16:40 PM
alastairp
single string
2014-10-09 28202, 2014
16:41 PM
ruaok
k
2014-10-09 28251, 2014
16:41 PM
ruaok
finalmente...
2014-10-09 28204, 2014
16:42 PM
ruaok
metadata : audio_properties : bit_rate ?
2014-10-09 28245, 2014
16:44 PM
alastairp
sure
2014-10-09 28249, 2014
16:44 PM
alastairp
codec there too?
2014-10-09 28203, 2014
16:45 PM
alastairp
I still don't know if bit_rate will be a string or a number
2014-10-09 28214, 2014
16:45 PM
alastairp
I'll try and make it a number
2014-10-09 28239, 2014
16:45 PM
ruaok
yes on all counts
2014-10-09 28242, 2014
16:46 PM
kepstin-laptop
hmm, I suppse the dsd_* codecs should probably be considered lossless as well
2014-10-09 28247, 2014
16:47 PM
ruaok
alastairp: all the key checking is implemented and deployed.
2014-10-09 28252, 2014
16:47 PM
ruaok
and DB purged.
2014-10-09 28209, 2014
16:48 PM
ruaok
so, you'll be the first one to have a working client, so submit floyd again.
2014-10-09 28221, 2014
16:49 PM
kepstin-laptop
will I have to update my essentia build, or only the acousticbrainz client?
2014-10-09 28247, 2014
16:49 PM
ruaok
essentia
2014-10-09 28246, 2014
16:50 PM
alastairp
ruaok: do you know when dmitry will be back? because I can commit something to a branch, but I don't know if he'll want to accept it :)
2014-10-09 28203, 2014
16:51 PM
alastairp
so we won't have a "final" until he merges everything
2014-10-09 28206, 2014
16:51 PM
ruaok
not soon, but he says he will be online.
2014-10-09 28210, 2014
16:51 PM
alastairp
ok
2014-10-09 28218, 2014
16:51 PM
ruaok
give us a branch to work off for now.
2014-10-09 28226, 2014
16:51 PM
ruaok
we can pester him to merge this asap.
2014-10-09 28228, 2014
16:51 PM
alastairp
I think I'll have the patches done in an hour or so.
2014-10-09 28232, 2014
16:51 PM
alastairp
(hah!)
2014-10-09 28202, 2014
16:52 PM
ruaok
i trust he doesn't merge on a timely basis then?
2014-10-09 28216, 2014
16:53 PM
alastairp
nah, he's pretty good at fixing stuff
2014-10-09 28206, 2014
17:05 PM
alastairp
2014-10-09 28211, 2014
17:06 PM
ruaok
filename vs file_name?
2014-10-09 28220, 2014
17:06 PM
ruaok
but that looks freaking great.
2014-10-09 28247, 2014
17:06 PM
alastairp
can never please some people
2014-10-09 28255, 2014
17:06 PM
alastairp
yeah, and I need to strip dirname too
2014-10-09 28257, 2014
17:06 PM
ruaok
I can change it on my end.
2014-10-09 28202, 2014
17:07 PM
alastairp
nah, no problem
2014-10-09 28205, 2014
17:07 PM
ruaok
k
2014-10-09 28245, 2014
17:21 PM
ruaok
ok, the home page now has a track count on it.
2014-10-09 28217, 2014
17:23 PM
alastairp
is it 0?
2014-10-09 28236, 2014
17:23 PM
ruaok
1
2014-10-09 28250, 2014
17:23 PM
ruaok
me test case.
2014-10-09 28254, 2014
17:23 PM
ruaok
which is your old test case.
2014-10-09 28259, 2014
17:23 PM
ruaok
let me nuke the db again
2014-10-09 28225, 2014
17:24 PM
ruaok
reset.
2014-10-09 28232, 2014
17:24 PM
ruaok
ready for your submission. :)
2014-10-09 28231, 2014
17:37 PM
ruaok
gonna run off and grab dinner.
2014-10-09 28250, 2014
17:37 PM
ruaok
back to rescue my linux VM and get analyzing my music after that
2014-10-09 28229, 2014
17:42 PM
alastairp
ruaok: trying to submit but I see nothing in the db
2014-10-09 28244, 2014
17:42 PM
alastairp
and requests isn't throwing an error, so I guess you're returning 200 anwyay
2014-10-09 28242, 2014
17:47 PM
nikki
hmm
2014-10-09 28229, 2014
17:48 PM
nikki
if I use this virtualenv thing, will those commands only install it within the directory I say?
2014-10-09 28227, 2014
17:49 PM
alastairp
yes
2014-10-09 28238, 2014
17:49 PM
alastairp
oh. I had filename in properties, not tags
2014-10-09 28244, 2014
17:52 PM
alastairp
http500!
2014-10-09 28252, 2014
17:58 PM
alastairp
ok. we're waiting on rob to fix the server now, but after that it'll work
2014-10-09 28258, 2014
17:58 PM
alastairp
from the new branch I posted
2014-10-09 28259, 2014
18:03 PM
CallerNo6 joined the channel
2014-10-09 28206, 2014
18:21 PM
nikki
nikki has changed the topic to: Freeze week | Agenda: general discussion, making more edit types autoedits + mbs-3462 (nikki), ie8 (nikki)
2014-10-09 28255, 2014
19:03 PM
Freso
ruaok: So we can go crazy with the AB client now?
2014-10-09 28249, 2014
19:09 PM
ruaok
Freso: net quite yet.
2014-10-09 28252, 2014
19:09 PM
ruaok
alastairp: lemme see.
2014-10-09 28219, 2014
19:11 PM
ruaok
alastairp: ping
2014-10-09 28233, 2014
19:11 PM
alastairp
hi
2014-10-09 28254, 2014
19:11 PM
ruaok
does the key lossless only get submitted for lossless files?
2014-10-09 28255, 2014
19:11 PM
alastairp
so, I had a few bugs in my doc, but I think I fixed them
2014-10-09 28258, 2014
19:11 PM
alastairp
oh
2014-10-09 28204, 2014
19:12 PM
alastairp
no. maybe I'm not submitting it...?
2014-10-09 28212, 2014
19:12 PM
ruaok
I'm using it but not requiring it.
2014-10-09 28218, 2014
19:12 PM
alastairp
ah
2014-10-09 28218, 2014
19:12 PM
ruaok
you're not.
2014-10-09 28221, 2014
19:12 PM
alastairp
:)
2014-10-09 28232, 2014
19:12 PM
ruaok
should I fix my code or do you want to fix your side?
2014-10-09 28239, 2014
19:12 PM
ruaok
read: should it be required or optional?
2014-10-09 28216, 2014
19:13 PM
alastairp
I'll fix it
2014-10-09 28218, 2014
19:13 PM
alastairp
it should be required
2014-10-09 28221, 2014
19:13 PM
ruaok
k
2014-10-09 28239, 2014
19:13 PM
ruaok
fixed and deployed.
2014-10-09 28246, 2014
19:13 PM
alastairp
features["metadata"]["audio_properties"]["lossless"] = lossless
2014-10-09 28247, 2014
19:13 PM
ruaok
it should not properly complain
2014-10-09 28257, 2014
19:13 PM
alastairp
I /am/ adding it
2014-10-09 28202, 2014
19:14 PM
alastairp
your error messages are in html
2014-10-09 28208, 2014
19:14 PM
alastairp
not sure if that's something you want to keep
2014-10-09 28224, 2014
19:14 PM
ruaok
yeah, I hate this setup. :(
2014-10-09 28230, 2014
19:14 PM
ruaok
in a sense I feel I should return no text.
2014-10-09 28232, 2014
19:14 PM
ruaok
empty doc.
2014-10-09 28245, 2014
19:14 PM
ruaok
but that is not nice to api users.
2014-10-09 28251, 2014
19:14 PM
ruaok
but I hate returning json.
2014-10-09 28254, 2014
19:14 PM
ruaok
for errors.
2014-10-09 28206, 2014
19:15 PM
alastairp
ah
2014-10-09 28229, 2014
19:15 PM
alastairp
your call
2014-10-09 28232, 2014
19:15 PM
ruaok
its a battle. on one side I want the data I return to be modeled properly.
2014-10-09 28238, 2014
19:15 PM
alastairp
where are you looking for lossless? because I add it
2014-10-09 28239, 2014
19:15 PM
ruaok
on the other side I want useful errors.
2014-10-09 28206, 2014
19:16 PM
ianmcorvidae
you can return HTTP error codes and *also* return a JSON body
2014-10-09 28207, 2014
19:16 PM
ruaok
data['metadata']['audio_properties']['lossless']
2014-10-09 28220, 2014
19:16 PM
ruaok
I dislike that, but I'll do it.
2014-10-09 28221, 2014
19:16 PM
ianmcorvidae
which would seem to be the correct approach here
2014-10-09 28239, 2014
19:16 PM
ruaok
anyone have suggesttion for the format of the json?
2014-10-09 28252, 2014
19:16 PM
ianmcorvidae
do you dislike it for a reason? I'm trying to figure out what the issue is you're trying to get past XD
2014-10-09 28213, 2014
19:17 PM
kepstin-laptop
if you have some api arrors which aren't programming errors on the client, you really should return them in some way that can be parsed by the client and displayed to the user in a reasonable fashion.
2014-10-09 28218, 2014
19:17 PM
ruaok
I dislike putting error messages into JSON.
2014-10-09 28245, 2014
19:17 PM
ruaok
it conflates the data model with OOB error nonsense.
2014-10-09 28204, 2014
19:18 PM
ruaok
but really, this isn't about my preferences. I need to STFU and return json.
2014-10-09 28214, 2014
19:18 PM
ruaok
{ error : "You fucked up." }
2014-10-09 28217, 2014
19:18 PM
ruaok
that enough?
2014-10-09 28219, 2014
19:18 PM
kepstin-laptop
If that means you return an http error code and a text/plain body with messages on errors, then so be it, just document that.
2014-10-09 28236, 2014
19:19 PM
ianmcorvidae
that's generally the approach I've seen, having { error: whatever }. and I guess I've mostly just assumed the data model doesn't apply for non-200 responses, it's just also-JSON so it doesn't require clients to have multiple parsers
2014-10-09 28243, 2014
19:19 PM
alastairp
ruaok: I've seen {status: {result: ok/bad, details: blah}, response: {........ }} before
2014-10-09 28257, 2014
19:19 PM
alastairp
so that errors and real messages have the same format
2014-10-09 28215, 2014
19:21 PM
alastairp
2014-10-09 28235, 2014
19:21 PM
ruaok
wow. :)
2014-10-09 28224, 2014
19:22 PM
ruaok
I could bike home with 4 interchanges. :)
2014-10-09 28237, 2014
19:22 PM
alastairp
2014-10-09 28229, 2014
19:24 PM
ruaok bookmarks the site and returns to json error messages.
2014-10-09 28247, 2014
19:24 PM
ruaok
so, are you sure the the lossless key is in your data?
2014-10-09 28257, 2014
19:24 PM
ruaok
I'm requiring it now if you want to try again
2014-10-09 28204, 2014
19:25 PM
alastairp
yeah, sorry. I was just cleaning out tabs in order to open more
2014-10-09 28206, 2014
19:25 PM
alastairp
oh, actually
2014-10-09 28216, 2014
19:25 PM
alastairp
in the sample I set, no
2014-10-09 28235, 2014
19:25 PM
alastairp
I just realised, I was dumping the result directly from essentia and didn't add everything in
2014-10-09 28259, 2014
19:29 PM
alastairp
2014-10-09 28206, 2014
19:30 PM
ruaok
:-)
2014-10-09 28239, 2014
19:30 PM
ruaok
looks good to me/
2014-10-09 28216, 2014
19:31 PM
alastairp
ok, trying again client
2014-10-09 28248, 2014
19:31 PM
alastairp
yep, client works
2014-10-09 28253, 2014
19:31 PM
ruaok
:-D
2014-10-09 28257, 2014
19:32 PM
alastairp
and have at it
2014-10-09 28254, 2014
19:33 PM
ruaok
sigh.
2014-10-09 28202, 2014
19:34 PM
ruaok
*flask* returns an HTML erorr.
2014-10-09 28237, 2014
19:34 PM
ruaok
if you send bad JSON, you get an HTML error before I ever get to handle the request.
2014-10-09 28254, 2014
19:34 PM
ruaok
not much I can do about that.
2014-10-09 28202, 2014
19:37 PM
ruaok
ok, fuck it.
2014-10-09 28209, 2014
19:37 PM
ruaok
returning HTML error messages for now.
2014-10-09 28250, 2014
19:37 PM
alastairp
yeah, no problem
2014-10-09 28227, 2014
19:38 PM
ruaok
can you sumit a file so I can check something?
2014-10-09 28251, 2014
19:38 PM
alastairp
no, because my submitter won't resubmit my test album because it's already been sent ;)
2014-10-09 28259, 2014
19:38 PM
alastairp
nah, give me a sec
2014-10-09 28206, 2014
19:39 PM
ruaok
moar stuff!
2014-10-09 28228, 2014
19:39 PM
kepstin-laptop
alastairp: you can just delete the log file to resubmit stuff, right?
2014-10-09 28242, 2014
19:39 PM
alastairp
kepstin-laptop: yep
2014-10-09 28252, 2014
19:39 PM
alastairp
ruaok: submitting
2014-10-09 28218, 2014
19:40 PM
alastairp
requests.exceptions.HTTPError: 400 Client Error: BAD REQUEST
2014-10-09 28250, 2014
19:40 PM
ruaok
can you see the error message that was sent?
2014-10-09 28206, 2014
19:41 PM
alastairp
let me work out how to do that
2014-10-09 28254, 2014
19:43 PM
alastairp
<p>key 'metadata : tags : musicbrainz_recordingid' was not found in submitted data.</p>
2014-10-09 28206, 2014
19:45 PM
ruaok
ok, my bad.
2014-10-09 28212, 2014
19:45 PM
ruaok
hang on
2014-10-09 28256, 2014
19:45 PM
ruaok
try again
2014-10-09 28217, 2014
19:48 PM
alastairp
Mineo: good patch. you beat me to it :)
2014-10-09 28251, 2014
19:48 PM
alastairp
ruaok: da39a905-7b84-4e2a-bbcf-74de3d6ebd03 just submitted
2014-10-09 28223, 2014
19:49 PM
ruaok
confirmed
2014-10-09 28235, 2014
19:49 PM
alastairp
Mineo: can you make it pass os.path.abspath to process_file? because we write it to the log file
2014-10-09 28214, 2014
19:50 PM
alastairp
statistics haven't updated :(
