zas: i mean are you not able to reproduce this error?
2014-10-28 30110, 2014
zas
kartikgupta0909: i cannot reproduce it here, i added a comment, so i want to know if you are able to (and what is your env)
2014-10-28 30102, 2014
kartikgupta0909
zas: i use ubuntu 13.04 , i havent tried reproducing it
2014-10-28 30116, 2014
kartikgupta0909
zas: lemme try it then
2014-10-28 30141, 2014
zas
then please try to reproduce it, it will be hard to fix without being able to reproduce it imho (python/unicode/env mess)
2014-10-28 30110, 2014
kartikgupta0909
zas: do you know for what kind of bad names does this happen?
2014-10-28 30141, 2014
zas
it is described, check original comment from Freso
2014-10-28 30149, 2014
kartikgupta0909
should (03, 04, 05, 07, 08).mp3 give me an error? am i getting it correct?
2014-10-28 30158, 2014
kartikgupta0909
zas: should (03, 04, 05, 07, 08).mp3 give me an error? am i getting it correct?
2014-10-28 30133, 2014
zas
yes, check Freso's description, it is clear enough for me
2014-10-28 30142, 2014
kartikgupta0909
zas: i cant reproduce it on ubuntu
2014-10-28 30100, 2014
zas
Freso: ^^^
2014-10-28 30135, 2014
zas
kartikgupta0909: please add a comment about that in the tracker
2014-10-28 30141, 2014
kartikgupta0909
zas: one thing i noticed just now is that when only one file is added and you click on cluster it does nothing
2014-10-28 30158, 2014
yeeeargh joined the channel
2014-10-28 30159, 2014
kartikgupta0909
zas: dont you think that track should be added to already existing clusters or at least the user should be informed that he needs to add more than one track
2014-10-28 30112, 2014
Freso
kartikgupta0909: There's no "(03, 04, 05, 07, 08).mp3" in the download...
2014-10-28 30110, 2014
kartikgupta0909
Freso: i think i misunderstood the bug, what i did was in my picard on my machine, i tried to add a file named "(03, 04, 05, 07, 08).mp3"
Anyway, I commented with some more thoughts and included sprunge link.
2014-10-28 30147, 2014
Freso
kartikgupta0909: Those files are the ones that error for me.
2014-10-28 30106, 2014
Freso
Ie., {03,04,05,07,08}*.mp3 in the archive.
2014-10-28 30122, 2014
kartikgupta0909
Freso: oh okay
2014-10-28 30128, 2014
Freso
(If you're not using a *nix, that glob won't do you much good.)
2014-10-28 30130, 2014
zas
Freso: your filesystem encoding is utf8 ?
2014-10-28 30134, 2014
xram joined the channel
2014-10-28 30137, 2014
Freso
Read the entire issue, please. The very first sentence tells you where you can get the problem files, though it shouldn't be too difficult to create some of your own.
2014-10-28 30141, 2014
Freso
zas: Yep.
2014-10-28 30152, 2014
Freso
Everything is.
2014-10-28 30157, 2014
zas
really weird i cannot reproduce it
2014-10-28 30118, 2014
zas
Python 2.7.6 here
2014-10-28 30140, 2014
Freso
I don't think it depends on Python version.
2014-10-28 30145, 2014
Freso
As per my last comment on the ticket.
2014-10-28 30132, 2014
zas
Freso: can you reproduce in debug mode and post the log ? also, can you check the output of sys.getfilesystemencoding() ?
Mineo or JonnyJD would have the same unzip version as me.
2014-10-28 30153, 2014
zas
one concerns encodings
2014-10-28 30114, 2014
JonnyJD
Freso: yeah, reading and I will test that bug
2014-10-28 30128, 2014
Freso
Indeed.
2014-10-28 30152, 2014
Freso
zas: But it also looks like it's a patch imported from ArchLinux, meaning that it would be in my version as well.
2014-10-28 30141, 2014
Freso
Anyway, I have no idea how to check the patches. I've never learned to navigate launchpad well, and I'm not very familiar with Ubuntu's structure, so I don't know what the various names mean.
2014-10-28 30112, 2014
zas
well, picard is still bugging so the issue isn't really the unzip command ;)
2014-10-28 30128, 2014
zas
but it explains why i cannot reproduce it somehow
2014-10-28 30107, 2014
zas
those python2/unicode issues suck (i hope moving to python 3 will help ....)
and I can't find that patch on debian (possibly ubuntu only or because I can find the -9 on debian because it is not included in any release)
2014-10-28 30131, 2014
Freso
zas: That should actually be "Misforstå", and yes, "å" is in 8859-1.
2014-10-28 30135, 2014
zas
interesting, on my system it unzips as "08 MisforstЖ mig ret.mp3" with "Ж" not "å"
2014-10-28 30135, 2014
JonnyJD
the å looks fine on my system, but 4 and 5 look weird
2014-10-28 30123, 2014
JonnyJD
oh, no, that is only in the unzip output. On system I do have "?" for both
2014-10-28 30122, 2014
JonnyJD
but yeah, in unzip output 04 Dilemma - Bær mig væk.mp3, that only looked really weird the font I am using. Unzip output looks fine, but ? with "ls"
2014-10-28 30141, 2014
JonnyJD
(and having that stacktrace in Picard when opening)
2014-10-28 30151, 2014
zas
so basically we have badly encoded characters in the filenames and Picard fails to handle them
2014-10-28 30139, 2014
JonnyJD
yep
2014-10-28 30103, 2014
JonnyJD
zas: and you have a patch with this subject in your unzip: Subject: unzip files encoded with non-latin, non-unicode file names
2014-10-28 30112, 2014
JonnyJD
basically just not making this happen
2014-10-28 30109, 2014
zas
yes i have it apparently
2014-10-28 30108, 2014
JonnyJD
I might make this problem go away on Arch with including that patch, but that is not what we want. We want to fix Picard so these are ignored, right? something like "replace" somewhere
2014-10-28 30149, 2014
zas
imho we should test unicode conversion, and handle exception
2014-10-28 30154, 2014
JonnyJD
kartikgupta0909: you could reproduce this problem, right?
2014-10-28 30152, 2014
kartikgupta0909
JonnyJd: my net is working slow, so it was not able to download, once it downloads i ll check that.
2014-10-28 30106, 2014
JonnyJD
kartikgupta0909: what OS are you on?
2014-10-28 30122, 2014
kartikgupta0909
JonnyJd: ubuntu 13.04
2014-10-28 30109, 2014
zas
Freso, JonnyJD : can you try "unzip -l Dynamikken_MensviventerEP.zip | python -c 'import sys; print sys.stdin.read(2000)'"
2014-10-28 30112, 2014
JonnyJD
kartikgupta0909: in case you can't reproduce that due to a patch in your unzip: I'll create a tar.gz from my unzip and upload that somewhere
2014-10-28 30124, 2014
Freso
JonnyJD: Ideally, the scenario with the bad encoding mixup would never happen, but Picard should handle it more gracefully. Ideally actually loading the files, but at the least it should give a (more) helpful error message.
yes, because it had other problems and was actively rejected upstream. This is probably also the reason why it was also removed (later) on Debian/Ubuntu)
2014-10-28 30144, 2014
JonnyJD
p7zip should be used is said
2014-10-28 30135, 2014
Freso
Well, `7z x` also "works". Using `convmv` also works.
2014-10-28 30102, 2014
Freso
The issue is not so much getting the files to behave, as to get Picard to behave when given badly formatted filenames.
2014-10-28 30110, 2014
JonnyJD
sure, but now I know we don't have to open a bug for unzip on Arch ;-)
