#musicbrainz-devel

/

      • chirlu`
        The right button is the one with the cloud.
      • 2014-10-15 28809, 2014

      • rochusw
        ok, i'll never use THAT service again, most of the links ask me to download an .exe
      • 2014-10-15 28839, 2014

      • kepstin-laptop
        [all] all are tracks less than 7 minutes long, musical, and took >2minutes to process (hit my timeout)
      • 2014-10-15 28844, 2014

      • hawke1
        rochusw: dropbox always seems to be pretty reasonable
      • 2014-10-15 28857, 2014

      • alastairp
        hmm
      • 2014-10-15 28808, 2014

      • alastairp
        so, ruaok's and rochusw's tracks work here
      • 2014-10-15 28833, 2014

      • alastairp
        can you please run with https://www.dropbox.com/s/ck89u66biy9z5ed/streami… this extractor
      • 2014-10-15 28843, 2014

      • alastairp
        and see if you get the same error
      • 2014-10-15 28851, 2014

      • chirlu` has left the channel
      • 2014-10-15 28811, 2014

      • kepstin-laptop
        lol 59mb binary
      • 2014-10-15 28859, 2014

      • kepstin-laptop
        annoyingly difficult to download from dropbox to a headless server :/
      • 2014-10-15 28834, 2014

      • kepstin-laptop
        alastairp: that binary isn't compatible with my abzsubmit, but it appears to not hang on my example files
      • 2014-10-15 28802, 2014

      • kepstin-laptop
        (it's not returning the codec info, which is why it's not working with abzsubmit)
      • 2014-10-15 28805, 2014

      • dom96 joined the channel
      • 2014-10-15 28811, 2014

      • rochusw
        i have my linux running on an older system, can't run the 64 bit binary there (the newer system is running windows for games)
      • 2014-10-15 28838, 2014

      • rochusw
        the jenkins build doesn't hang with this file, too
      • 2014-10-15 28842, 2014

      • zas_
        buffer size error is fixed in master branch, do i miss smt or it wasn't (yet) merged in audioloader-codec branch ?
      • 2014-10-15 28842, 2014

      • kepstin-laptop
        man, working with waf is kind of annoying :/
      • 2014-10-15 28808, 2014

      • zas_
        Wife Acceptance Factor was always hard to work with ;)
      • 2014-10-15 28809, 2014

      • alastairp
        kepstin-laptop: yes, I don't care about submitting, we just want to try the extractor
      • 2014-10-15 28825, 2014

      • kepstin-laptop
        alastairp: yeah, that particular build of the extractor doesn't hang on my test files.
      • 2014-10-15 28835, 2014

      • kepstin-laptop
        how can i attempt to reproduce that build?
      • 2014-10-15 28843, 2014

      • kepstin-laptop
        what git rev should I be building?
      • 2014-10-15 28850, 2014

      • alastairp
        Master
      • 2014-10-15 28823, 2014

      • kepstin-laptop tries a completely clean build of master with his local gcc 4.8
      • 2014-10-15 28843, 2014

      • alastairp
        rochusw: ah, Jenkins is OK? Interesting
      • 2014-10-15 28801, 2014

      • alastairp
        rochusw: I think there is a 32 bit build. Let me see
      • 2014-10-15 28858, 2014

      • rochusw
        yes, the 32 bit build was not hanging with the file
      • 2014-10-15 28852, 2014

      • kepstin-laptop
        hmm, yeah, I'm still hitting the same thing with a clean build of master on my system
      • 2014-10-15 28804, 2014

      • kepstin-laptop
        ... how do I tell waf to build with debug info?
      • 2014-10-15 28817, 2014

      • rochusw
        I'm currently running that extractor through all of my failed files (not all of them hanging)
      • 2014-10-15 28837, 2014

      • kepstin-laptop
        I kinda wish this was using a less uncommon build system :/
      • 2014-10-15 28852, 2014

      • kepstin-laptop
        ah, has to be passed as env variables to configure
      • 2014-10-15 28858, 2014

      • alastairp
        kepstin-laptop: --mode=debug also works
      • 2014-10-15 28803, 2014

      • alastairp
        kepstin-laptop: ffmeg or libav?
      • 2014-10-15 28839, 2014

      • tungol joined the channel
      • 2014-10-15 28803, 2014

      • kepstin-laptop__ joined the channel
      • 2014-10-15 28852, 2014

      • ardoRic joined the channel
      • 2014-10-15 28848, 2014

      • adhawkins joined the channel
      • 2014-10-15 28822, 2014

      • misterswag joined the channel
      • 2014-10-15 28821, 2014

      • sc0 joined the channel
      • 2014-10-15 28825, 2014

      • kepstin-laptop__
        hmm. that peakdetection loop is a bit odd
      • 2014-10-15 28819, 2014

      • MBJenkins
        Ulrich Klauer: MBS-7928: Follow change of search server response format
      • 2014-10-15 28853, 2014

      • ruaok
        alastairp: I can try that in a minute. gotta finish dinner first
      • 2014-10-15 28801, 2014

      • kepstin-laptop__
        ... 'i' is a signed int ... but that should only be an issue after 811 minutes of audio at 44.1kHz
      • 2014-10-15 28801, 2014

      • kepstin-laptop__
        but yeah, looks like an infinite loop in the peak detection to me :/
      • 2014-10-15 28842, 2014

      • kepstin-laptop__
        I wonder if the code is hitting one of the undefined behaviour on signed integer overflow issues
      • 2014-10-15 28854, 2014

      • kepstin-laptop__
        that could result in different behaviour with different compilers
      • 2014-10-15 28833, 2014

      • kepstin-laptop__
        ... that's exactly it
      • 2014-10-15 28806, 2014

      • kepstin-laptop__
        I think.
      • 2014-10-15 28808, 2014

      • kepstin-laptop__
        hmm.
      • 2014-10-15 28815, 2014

      • kepstin-laptop__ would have to look at the disassembly to be sure
      • 2014-10-15 28824, 2014

      • kepstin-laptop__
        I think that the compiler is assuming that i+1 < size-1 is always true
      • 2014-10-15 28824, 2014

      • alastairp
        Yeah, compilers. Sigh
      • 2014-10-15 28835, 2014

      • alastairp
        What's your setup?
      • 2014-10-15 28843, 2014

      • kepstin-laptop__
        or no
      • 2014-10-15 28846, 2014

      • kepstin-laptop__
        always false
      • 2014-10-15 28846, 2014

      • alastairp
        Os, compiler?
      • 2014-10-15 28853, 2014

      • kepstin-laptop__
        linux, gcc 4.8
      • 2014-10-15 28825, 2014

      • kepstin-laptop__
        if the i+1 < size-1 is always false, then the other part of the array condition is never checked and the loop is never entered
      • 2014-10-15 28850, 2014

      • kepstin-laptop__
        but that makes no sense, hmm.
      • 2014-10-15 28809, 2014

      • kepstin-laptop__
        because i is 0 and size is 1025 in this loop iteration i'm in right now
      • 2014-10-15 28855, 2014

      • D4RK-PH0ENiX joined the channel
      • 2014-10-15 28856, 2014

      • kepstin-laptop__
        but it looks like the compiler has completely optimized out the array accesses in this loop
      • 2014-10-15 28817, 2014

      • ruaok
        maybe compile the code with opts off and see if that improves?
      • 2014-10-15 28802, 2014

      • ruaok
      • 2014-10-15 28809, 2014

      • ruaok
        not, uhm, clear what is going on.
      • 2014-10-15 28817, 2014

      • kepstin-laptop__
        if the code runs with optimizations off but not with them on, that generally means that the code is not correct.
      • 2014-10-15 28821, 2014

      • ruaok
        but it didn't hang on the same track.
      • 2014-10-15 28823, 2014

      • kepstin-laptop__
        but might point out the issue yeah
      • 2014-10-15 28850, 2014

      • ruaok
        the new build is giving me these worrisome errors:
      • 2014-10-15 28851, 2014

      • ruaok
        "[ WARNING ] AudioLoader: Error reading frame: Input/output error"
      • 2014-10-15 28853, 2014

      • ruaok
        :(
      • 2014-10-15 28852, 2014

      • alastairp
        I don't think that's a problem
      • 2014-10-15 28859, 2014

      • alastairp
        dima didn't say anything when it happened when we ran it
      • 2014-10-15 28803, 2014

      • alastairp
        but that version works...
      • 2014-10-15 28804, 2014

      • alastairp
        this is weird
      • 2014-10-15 28831, 2014

      • ruaok
        k.
      • 2014-10-15 28841, 2014

      • ruaok
        I'm re-running my test collection with this new binary
      • 2014-10-15 28853, 2014

      • kepstin-laptop__
        hmm. now that i'm looking at the assembly, it is definitely loading values from the array
      • 2014-10-15 28808, 2014

      • ruaok
        thanks for being hardcore kepstin-laptop__
      • 2014-10-15 28809, 2014

      • alastairp
        ruaok: this is the original binary
      • 2014-10-15 28810, 2014

      • kepstin-laptop__
        also, wow, that's not an array, that's an stl vector
      • 2014-10-15 28829, 2014

      • ruaok
        ah, regardless, I'm running my test set.
      • 2014-10-15 28830, 2014

      • kepstin-laptop__
        needs a function call every time it loads values, lol
      • 2014-10-15 28830, 2014

      • alastairp
        ruaok: that is, there's no bitrate or codec
      • 2014-10-15 28843, 2014

      • alastairp
        and so won't submit
      • 2014-10-15 28846, 2014

      • ruaok
        no matter, all the data has already been submitted.
      • 2014-10-15 28846, 2014

      • alastairp
        kepstin-laptop__: mmmm, c++
      • 2014-10-15 28800, 2014

      • alastairp
        ruaok: ok, no problem, just making sure you're aware :)
      • 2014-10-15 28810, 2014

      • ruaok
        understood, thanks.
      • 2014-10-15 28822, 2014

      • ruaok
        anything else I can do to help?
      • 2014-10-15 28827, 2014

      • ruaok
        save reading assembly?
      • 2014-10-15 28820, 2014

      • ruaok leaves that to the entrepid canadians who deal with much worse on a daily basis
      • 2014-10-15 28831, 2014

      • ruaok
        moose > assembly, no?
      • 2014-10-15 28810, 2014

      • kepstin-laptop__
        ah, no wonder i'm confused, gdb isn't picking up the fact that the 'i' variable is only stored in a register and not in ram in this function
      • 2014-10-15 28830, 2014

      • kepstin-laptop__
        looks like it is getting ingremented at some point.
      • 2014-10-15 28832, 2014

      • kepstin-laptop__
        hmm.
      • 2014-10-15 28854, 2014

      • ruaok
        alastairp: the original binary does not seen to lock up
      • 2014-10-15 28830, 2014

      • alastairp
        well, let's wait for kepstin to disassemble both binaries and work out what's happening :)
      • 2014-10-15 28853, 2014

      • ruaok
        heh. :)
      • 2014-10-15 28808, 2014

      • luks
        alastairp: replying to an old question, I'll probably add windows binaries at some point, but os x is just not possible with the setup I have
      • 2014-10-15 28844, 2014

      • alastairp
        luks: OK, great
      • 2014-10-15 28846, 2014

      • luks
        I support 10.4 for acoustid and compiling c++11 code in the mac mini would need me to update xcode, which would mess up the whole setup
      • 2014-10-15 28806, 2014

      • alastairp
        just letting you know that we already have a bit of the infrasture there
      • 2014-10-15 28811, 2014

      • alastairp
        right, that's fair enough
      • 2014-10-15 28803, 2014

      • luks
        if you want to go for easy deployment, it would be great to replace fftw/resample with ffmpeg and not depend on taglib in abzsubmit
      • 2014-10-15 28829, 2014

      • luks
        given that essentia already depends on taglib, I guess you could add all the tag reading code there
      • 2014-10-15 28813, 2014

      • kepstin-laptop__
        yeah, I wondered about that.
      • 2014-10-15 28841, 2014

      • alastairp
        right, the only reason it's out of the extractor is that I want to check for an mbid before we run the extractor
      • 2014-10-15 28850, 2014

      • alastairp
        but of course we could add a check to the extractor to exit early if there's no tag
      • 2014-10-15 28842, 2014

      • luks
        and it would be also great to stop using that giant hack in RogueVector :)
      • 2014-10-15 28847, 2014

      • kepstin-laptop__
        so it looks like the compiler's optimized out the check on line 132, resultPos > _maxPos
      • 2014-10-15 28800, 2014

      • kepstin-laptop__
        and it's basically looping forever with i=j=0
      • 2014-10-15 28807, 2014

      • alastairp
        luks: yeah, everyone wants to fix rougevector
      • 2014-10-15 28810, 2014

      • alastairp
        after the million other things
      • 2014-10-15 28832, 2014

      • MBJenkins
        * nikki: Order releases table on /cdtoc/ pages like on other pages which list releases
      • 2014-10-15 28833, 2014

      • MBJenkins
        * Ulrich Klauer: Implement some core entity model methods via %ENTITIES
      • 2014-10-15 28834, 2014

      • MBJenkins
        * Ulrich Klauer: Use entity property mbid/multiple for statistics
      • 2014-10-15 28835, 2014

      • MBJenkins
        * Ulrich Klauer: Don't create entities that are then not used
      • 2014-10-15 28835, 2014

      • kepstin-laptop__
        but it's not running the peaks.push_back line either as far as I can tell.
      • 2014-10-15 28836, 2014

      • MBJenkins
        * Ulrich Klauer: Remove some unnecessary imports
      • 2014-10-15 28837, 2014

      • MBJenkins
        * nikki: Escape the no AcoustIDs message on the fingerprint tab (MBS-7927)
      • 2014-10-15 28838, 2014

      • MBJenkins
        * Ulrich Klauer: MBS-7928: Follow change of search server response format
      • 2014-10-15 28843, 2014

      • kepstin-laptop__
        or else I'm still horribly confued
      • 2014-10-15 28855, 2014

      • kepstin-laptop__
        I should try compiling it without optimization, i guess.
      • 2014-10-15 28825, 2014

      • ruaok
        naw, without opts is for wimps
      • 2014-10-15 28837, 2014

      • alastairp
        -->out. keep up the good work all
      • 2014-10-15 28802, 2014

      • kepstin-laptop__
        well, looks like it still hangs with optimization disabled. so that's something.
      • 2014-10-15 28823, 2014

      • kepstin-laptop__
        hmm, never mind
      • 2014-10-15 28830, 2014

      • kepstin-laptop__
        it's just really really slow
      • 2014-10-15 28832, 2014

      • kepstin-laptop__
        and it does not fail
      • 2014-10-15 28846, 2014

      • LordSputnik joined the channel
      • 2014-10-15 28836, 2014

      • LordSputnik
        any particular reason you guys chose pytaglib over mutagen for abz client?
      • 2014-10-15 28851, 2014

      • luks
        you can't use mutagen in a gpl3 application
      • 2014-10-15 28810, 2014

      • luks
        I don't know if that was the reason, but it's a reason
      • 2014-10-15 28812, 2014

      • alastairp
        LordSputnik: no
      • 2014-10-15 28814, 2014

      • alastairp
        And honestly, I would have preferred a mit-ish license, but the department prefers GPL and I didn't see the taglib license before I used it
      • 2014-10-15 28802, 2014

      • alastairp
        As I've alluded to before, this use of taglib is a hack anyway, and we should replace it with something that doesn't require an additional dependency
      • 2014-10-15 28831, 2014

      • LordSputnik
        I see... anyway, I'm pretty sure I should be submitting stuff now, the client is certainly making the right noises
      • 2014-10-15 28803, 2014

      • LordSputnik
        Does it keep a list of already processed paths somewhere?
      • 2014-10-15 28818, 2014

      • rochusw
        <wa
      • 2014-10-15 28823, 2014

      • rochusw
        yes
      • 2014-10-15 28829, 2014

      • alastairp
        In an SQL db in .abzsubmit
      • 2014-10-15 28803, 2014

      • rochusw
        which debian package contains this parallel-util?
      • 2014-10-15 28856, 2014

      • kepstin-laptop__
        rochusw: looks like it's in 'moreutils'
      • 2014-10-15 28811, 2014

      • kepstin-laptop__
        what a horrible package name.
      • 2014-10-15 28833, 2014

      • kepstin-laptop__
        there's a gnu version too, but I dunno which debian versions have it
      • 2014-10-15 28838, 2014

      • kepstin-laptop__
        package name of that is just 'parallel'
      • 2014-10-15 28800, 2014

      • kepstin-laptop__
        if you have a new enough debian to run the acousticbrainz stuff, you probably have gnu parallel