I think I understand what it's doing, but the problem is in the two "update" statements in that routine.
2004-03-01 06156, 2004
djce
The two "updates" hit two different tables, using the same "id=$id" value.
2004-03-01 06116, 2004
djce
but AFAICT the PKs of those tables don't match up - there's no reason why they would really.
2004-03-01 06136, 2004
ruaok
I see your point.
2004-03-01 06142, 2004
djce
or, to put it another way: you might /hope/ they match up, but they don't.
2004-03-01 06145, 2004
ruaok
And I wonder if this code still gets called...
2004-03-01 06101, 2004
djce
it's further up in this module, yes
2004-03-01 06114, 2004
djce
but as to whether it actually /really/ gets invoked, I don't know.
2004-03-01 06123, 2004
ruaok
the idea is that if we import a partial freedb id, it would go and fill it out with the right leadout/id.
2004-03-01 06129, 2004
ruaok
agreed.
2004-03-01 06140, 2004
djce
I tried this: select count(*) from discid d, toc t where d.disc=t.discid and d.album!=t.album;
2004-03-01 06146, 2004
djce
that gets 0 rows, which sounds good.
2004-03-01 06119, 2004
djce
so I'm suspecting that the aforementioned bug has fortunately not bitten us.
2004-03-01 06141, 2004
djce
does that sound convincing?
2004-03-01 06150, 2004
ruaok
not reassuring.
2004-03-01 06152, 2004
ruaok
:-)
2004-03-01 06115, 2004
ruaok
I guess the question is this: do we still import freedb data TOCs that are incomplete?
2004-03-01 06125, 2004
ruaok
If not, then the updates can go away.
2004-03-01 06135, 2004
djce
yes, I think we do, for sure. don't we?
2004-03-01 06135, 2004
ruaok
If so, we need to make the updates more robust.
2004-03-01 06154, 2004
ruaok
I'm not sure anymore....
2004-03-01 06156, 2004
djce
I'll give it a try.
2004-03-01 06158, 2004
ruaok
ok
2004-03-01 06106, 2004
djce tests it...
2004-03-01 06151, 2004
soccos
I had an interesting chat with this guy on a chairlift over the weekend
2004-03-01 06108, 2004
soccos
he was bitching over how his old company had to pay Gracenote license fees
2004-03-01 06120, 2004
ruaok
ahahahahahah.
2004-03-01 06154, 2004
soccos
they do a hard-drive MP3 car stereo thingy
2004-03-01 06104, 2004
soccos
I forget their name, 'fat' something
2004-03-01 06113, 2004
ruaok
phatnoise/phatbox.
2004-03-01 06121, 2004
ruaok
I spoke to one of their engineers last weekend.
2004-03-01 06122, 2004
soccos
that sounds right
2004-03-01 06128, 2004
ruaok
passed on a bunch of my cards. :-)
2004-03-01 06101, 2004
soccos
they got a cease and desist when they were looking to move elsewhere (freedby perhaps)
2004-03-01 06122, 2004
ruaok
standard operating procedure.
2004-03-01 06146, 2004
soccos
they caved in due to potential legal costs and conservative clients/backers(?)
2004-03-01 06117, 2004
ruaok
no surprise.
2004-03-01 06143, 2004
soccos
they're still one of Gracenote's bitches fttb
2004-03-01 06159, 2004
soccos
what's the upcoming suit that Gracenote are in?
2004-03-01 06108, 2004
djce
ruaok: A "freedb import" sets the track durations, but doesn't touch the discid/toc tables.
2004-03-01 06119, 2004
ruaok
ahh.
2004-03-01 06129, 2004
ruaok
no wonder we haven't gotten bitten by that bug. :-)
2004-03-01 06157, 2004
djce
so can that logic be removed completely for good? Or does it need to be fixed ?
2004-03-01 06157, 2004
ruaok
lets nuke it.
2004-03-01 06113, 2004
ruaok
I'm hoping to find someone who wants to work with us on CD lookup stuff.
2004-03-01 06116, 2004
Maxxxxx
... dunno if this is related but importing from freedb is such a pain sometimes cos artist /tracks sometimes get imported other way round and to cut paste and fix name :P takes ages
2004-03-01 06120, 2004
djce
ok, will do.
2004-03-01 06145, 2004
ruaok
Someone who can help us pay for a patent lawyer to look at exactly what we need to do to circum vent GN's patents.
2004-03-01 06107, 2004
ruaok
If they are willing to do that, then I'd we willing to revamp our id system to be GN safe.
2004-03-01 06117, 2004
ruaok
Until that time, lets leave things be.
2004-03-01 06111, 2004
soccos
I thought there was a case coming up that was going to test their patents?
2004-03-01 06132, 2004
djce
Maxxxxx: there's a "swap" button to swap over the track/artist names. It should take that long.
2004-03-01 06140, 2004
ruaok
There is, but I don't think its about the patent unfortunately.
2004-03-01 06129, 2004
soccos
how many patents do they hold?
2004-03-01 06144, 2004
ruaok
google: gracenote patents [i'm feeling lucky]
2004-03-01 06141, 2004
soccos
that'll be 'more than one' then ;-)
2004-03-01 06112, 2004
ruaok
bout a dozen or so.
2004-03-01 06125, 2004
real
real is now known as real|afk
2004-03-01 06133, 2004
soccos
can you be issued a patent if you buy the IP that was the prior art?
2004-03-01 06147, 2004
ruaok
I would not think so.
2004-03-01 06157, 2004
ruaok
*I* have written prior art code at CD Index.
2004-03-01 06118, 2004
soccos
wasn't CDDB itself the prior art?
2004-03-01 06122, 2004
ruaok
Our original CD Index code is prior art and was checked in befor they filed the patent.
2004-03-01 06127, 2004
ruaok
that tool
2004-03-01 06138, 2004
ruaok
it was public and therefore should be considered prior art.
2004-03-01 06123, 2004
soccos
bizarre, they got a patent for which a large part of their application must have described the prior art that meant it sholdn't have been issued
2004-03-01 06155, 2004
ruaok
yup./
2004-03-01 06152, 2004
ruaok is away: lunch
2004-03-01 06104, 2004
yalaforge is back (gone 01:31:03)
2004-03-01 06122, 2004
djce is away: but will be back
2004-03-01 06110, 2004
lgonze_ joined the channel
2004-03-01 06147, 2004
yalaforge
hi
2004-03-01 06156, 2004
lgonze_
hey mattias
2004-03-01 06102, 2004
lgonze_
how is your monday coming along?
2004-03-01 06119, 2004
yalaforge
oh, I started with some exam preparations, but that's done
2004-03-01 06124, 2004
lgonze_
nice
2004-03-01 06131, 2004
yalaforge
I'm currently reading the mailing list
2004-03-01 06141, 2004
lgonze_
lots of stuff there
2004-03-01 06142, 2004
yalaforge
how's your still young monday?
2004-03-01 06101, 2004
lgonze_
I went and did webjay evangelism to a netlabel
2004-03-01 06110, 2004
lgonze_
got a really good reception, so I'm feeling good.
2004-03-01 06127, 2004
lgonze_
...experimenting with explicit evangelism to try to get the ball rolling.
2004-03-01 06155, 2004
lgonze_
webjay is still very immature and buggy, but there should have been more uptake than there has been.
