brianfreud: I wouldn't mind having presets, but I doubt most users would save much since they're not nearly as efficient as people in here
2009-04-05 09529, 2009
Wizzcat
personally I think I could save a truckload more time from inline editing, but god knows that's never happening :p
2009-04-05 09540, 2009
Wizzcat
(unless I grease it myself)
2009-04-05 09528, 2009
luks
I think that's happening this summer
2009-04-05 09514, 2009
VxJasonxV^Q joined the channel
2009-04-05 09517, 2009
pronik
luks: do we have your word on it? ;)
2009-04-05 09557, 2009
luks
yes
2009-04-05 09510, 2009
brianfreud
Wizzcat: I'd put in an option for it, but then we start to have options again.
2009-04-05 09514, 2009
brianfreud throws out all that code
2009-04-05 09503, 2009
brianfreud
sorr, but I admit, I am getting frustrated.
2009-04-05 09508, 2009
brianfreud
*sorry
2009-04-05 09527, 2009
kurros has quit
2009-04-05 09515, 2009
aCiD2
don't throw it out, it should be on a branch of it's own, so just incubate
2009-04-05 09535, 2009
brianfreud
To be honest, why bother? It'd become a branch like the flags branch - code that just rots, as there's seemingly no support for even trying it on a playground.
2009-04-05 09502, 2009
brianfreud
Which reminds me, I need to move all the image resizer code out from the flags branch.
2009-04-05 09553, 2009
aCiD2
code in git doesn't rot
2009-04-05 09555, 2009
aCiD2
just rebase it
2009-04-05 09505, 2009
aCiD2
maybe it will never get accepted then throw it away...
2009-04-05 09509, 2009
aCiD2
I personally don't throw stuff away though
2009-04-05 09514, 2009
brianfreud
Ok, I'll toss it in a text file somewhere.
2009-04-05 09520, 2009
czaanja has quit
2009-04-05 09522, 2009
czaanja1 joined the channel
2009-04-05 09524, 2009
brianfreud
I'm just getting frustrated.
2009-04-05 09550, 2009
aCiD2
maybe you should take a break then
2009-04-05 09502, 2009
aCiD2
i step away when I get frustrated :)
2009-04-05 09512, 2009
outsidecontext has quit
2009-04-05 09516, 2009
brianfreud
I'm not frustrated with the project. I'm frustrated that there seems to be no openness to trying anything new.
2009-04-05 09506, 2009
pronik
brianfreud: I am a big friend of new stuff, but sorry, presets is more hassle than it's worth.
2009-04-05 09512, 2009
pronik
Don't mean to discourage you though
2009-04-05 09544, 2009
brianfreud
well, if anyone has ideas for things they think might actually not be met with dislike, put in a ticket. Right now, there's next to no js enhancement reqs: http://bugs.musicbrainz.org/query?status=new&…
2009-04-05 09554, 2009
brianfreud
(but a ton of server ones)
2009-04-05 09525, 2009
kurros joined the channel
2009-04-05 09540, 2009
brianfreud has quit
2009-04-05 09508, 2009
brianfreud joined the channel
2009-04-05 09555, 2009
Wizzcat would love flags in REs :(
2009-04-05 09530, 2009
brianfreud
unfortunately, it didn't seem most agreed
2009-04-05 09526, 2009
Wizzcat
well there's the whole flags for disputed territories thing, but beyond that
2009-04-05 09528, 2009
luks
it didn't?
2009-04-05 09507, 2009
Om joined the channel
2009-04-05 09513, 2009
brianfreud
that was the sense I got, whether it was done my way (or better) your way
2009-04-05 09537, 2009
navap really liked the flags, it added a slight bit of colour to an otherwise purple and orange site. ;)
2009-04-05 09539, 2009
brianfreud
if it does actually have support, I'd happily change that branch to do it your way luks
2009-04-05 09547, 2009
navap isn't saying purple/orange is bad, just that little flags are good. o/
2009-04-05 09527, 2009
aCiD2 puts the ban hammer down
2009-04-05 09531, 2009
aCiD2
close navap, close
2009-04-05 09533, 2009
aCiD2
:P
2009-04-05 09517, 2009
nikki
navap: are you colour-blind? the site is rainbow! :P
2009-04-05 09504, 2009
navap
Well, if you're wearing a funky pair of 3d goggles, where one eye is purple, and the other eye is orange - then yeah! It's a rainbow :p
2009-04-05 09554, 2009
nikki
there's yellow and blue and pink and beige and brown and green and red!
2009-04-05 09532, 2009
pronik
I actually liked the flags, but I remember the Debian Taiwan controversy all too good....
2009-04-05 09543, 2009
nikki
oh?
2009-04-05 09547, 2009
pronik
and the case with a nazi flag is also an issue, but otherwise...
personally, I would still want to see it, on applicable releases, for trivia reasons, but I can very easily understand why not to show it.
2009-04-05 09539, 2009
pronik
just don't make it an option ;)
2009-04-05 09549, 2009
Wizzcat
hide disputed flags, done :)
2009-04-05 09533, 2009
brianfreud
aCiD2: I know you were merging the ES branch - let me know when that's done, so I can close all the relevant tickets?
2009-04-05 09553, 2009
aCiD2
I have merged it, but I was waiting on that missing js, guess that's all done?
2009-04-05 09501, 2009
aCiD2
if so, I'll merge, push a branch out to test, and you can make sure everything looks good
2009-04-05 09502, 2009
aCiD2
sound ok?
2009-04-05 09523, 2009
brianfreud
yes, it's merged, as is a tiny 1 line fix to remove the name attr issue you caught
2009-04-05 09533, 2009
aCiD2
and I was missing bgiframe or whatever
2009-04-05 09538, 2009
brianfreud
*pushed, I mean
2009-04-05 09506, 2009
brianfreud
yup, both should be on github.
2009-04-05 09526, 2009
aCiD2
great
2009-04-05 09509, 2009
pronik
brianfreud: could you raise the flag problem once again on the ML so we can actually decide on that one? We already call Taiwan a country (just like Debian) so I guess we'll have to live with that...
2009-04-05 09501, 2009
VxJasonxV^Q has quit
2009-04-05 09501, 2009
brianfreud
yeah
2009-04-05 09504, 2009
nikki idly notes that google is happy to use the taiwanese flag for their link to google.com.tw :P
2009-04-05 09504, 2009
pronik
aCiD2: so tomorrow it's all on test? nice :)
2009-04-05 09511, 2009
aCiD2
or tonight :)
2009-04-05 09518, 2009
pronik
I'll be in bed soon
2009-04-05 09525, 2009
aCiD2
I'm just putting the final touches to all the edit/add release templates and then will merge
2009-04-05 09526, 2009
aCiD2
ah, ok
2009-04-05 09555, 2009
nikki
and apparently mainland china complained when taiwan was thinking about changing their flag o_O
2009-04-05 09556, 2009
kurros
no yuo!
2009-04-05 09535, 2009
aCiD2
I have /only/ just worked out that was a typo of you
2009-04-05 09542, 2009
aCiD2
slow day is slow
2009-04-05 09535, 2009
czaanja1 has quit
2009-04-05 09537, 2009
Sargun joined the channel
2009-04-05 09510, 2009
pbryan has quit
2009-04-05 09504, 2009
brianfreud
aCiD2: Is there any way Add URL AR pages could give a hint as to which type of URL-foo page it is?
2009-04-05 09516, 2009
aCiD2
as in what foo is?
2009-04-05 09520, 2009
brianfreud
yes
2009-04-05 09537, 2009
pbryan joined the channel
2009-04-05 09537, 2009
brianfreud
the old code worked just by matching on URL AR text in the <option> to pick the right AR
2009-04-05 09553, 2009
brianfreud
that works for, say, ASIN, or Discogs, but "has cover art at" would break in i18n
2009-04-05 09559, 2009
aCiD2
Hrm, relate to url shows the artist header
2009-04-05 09505, 2009
aCiD2
so can't you just check for entity.entity_type?
2009-04-05 09518, 2009
brianfreud
better to hard code the value #'s, rather than match on text in the type descriptions
2009-04-05 09528, 2009
aCiD2
or have I misunderstood you
2009-04-05 09541, 2009
brianfreud
I can't check entity.anything in the js - that's on the perl end
2009-04-05 09549, 2009
aCiD2
oh, right
2009-04-05 09554, 2009
aCiD2
where do you want it?
2009-04-05 09509, 2009
brianfreud
but even just a <!-- entitytype --> comment hidden somewhere would help
nikki: no, right now, it's the same identical form (save for the select's options/value) I think
2009-04-05 09514, 2009
brianfreud
aCiD2: sure, though you don't even have to bloat the code by that many bytes if you don't want
2009-04-05 09527, 2009
brianfreud
I can read in an html comment, if that's smaller for you
2009-04-05 09530, 2009
aCiD2
i'd rather be clear and verbose than hacky
2009-04-05 09542, 2009
brianfreud
sure, however you want :)
2009-04-05 09548, 2009
aCiD2
you need it now?
2009-04-05 09511, 2009
brianfreud
soonish, but doesn't have to be right this minute
2009-04-05 09540, 2009
brianfreud
would be nicer if ASIN (or whatever the AR is) was always the same value, no matter the foo type, but I know that's not the case
2009-04-05 09533, 2009
aCiD2
pushed
2009-04-05 09544, 2009
aCiD2
yea, that's not possibly saddly
2009-04-05 09555, 2009
brianfreud
thanks :)
2009-04-05 09520, 2009
brianfreud
hmm, think that'd be something worth doing, long term, in the schema-change branch?
2009-04-05 09540, 2009
aCiD2
I don't think it has any real implications for server side code
2009-04-05 09542, 2009
aCiD2
as is
2009-04-05 09532, 2009
brianfreud
well, the implication would be the different codebase having new values for AR values - it would have to happen at a time we didn't have both old and new code working on the same dataset
2009-04-05 09526, 2009
pbryan has quit
2009-04-05 09534, 2009
brianfreud
cool, this'll work :)
2009-04-05 09513, 2009
pbryan joined the channel
2009-04-05 09528, 2009
Kerensky97 has left the channel
2009-04-05 09519, 2009
brianfreud
Anyone know where URL AR values are stored? The new three haven't made it in to the tt code yet
2009-04-05 09501, 2009
nikki
hm?
2009-04-05 09522, 2009
nikki
the link text and stuff?
2009-04-05 09547, 2009
brianfreud
the definition itself
2009-04-05 09504, 2009
nikki
lt_album_url, lt_track_url, etc
2009-04-05 09506, 2009
aCiD2
I thought that was all in the database
2009-04-05 09512, 2009
nikki
yeah
2009-04-05 09526, 2009
brianfreud
YouTube, IoBDb, and IBdb aren't in the list atm, on tt
2009-04-05 09534, 2009
nikki
then the database is out of date
2009-04-05 09540, 2009
brianfreud
unless it's my dump missing them, and not something hard-coded?
2009-04-05 09552, 2009
nikki
it's not hardcoded, there are edits for them
2009-04-05 09558, 2009
brianfreud
ah
2009-04-05 09508, 2009
nikki
so your dump is from before those edits were made
2009-04-05 09524, 2009
brianfreud
didn't realize they were edited in
2009-04-05 09543, 2009
brianfreud
aCiD2: Is not showing the AR descriptions, or the AR target, on purpose?
