#musicbrainz

/

      • luks
        but not, really, MusicDNS will be around at least for a few years
      • 2011-08-02 21407, 2011

      • luks
        there are paying contracts that will keep it live
      • 2011-08-02 21406, 2011

      • luks
        it would be stupid to shut it down if it produces money
      • 2011-08-02 21444, 2011

      • hrglgrmpf
        not bad at all, leaves enough time to test alternatives
      • 2011-08-02 21433, 2011

      • reosarevokphone
        does it being live imply MB can still use it for free?
      • 2011-08-02 21449, 2011

      • luks
        yes, because nobody cares about it
      • 2011-08-02 21420, 2011

      • hrglgrmpf
        too little traffic?
      • 2011-08-02 21435, 2011

      • luks
        probably not, but as long as it's not only MB, it's probably worth it to keep it alive
      • 2011-08-02 21405, 2011

      • luks
        note that MusicDNS itself has not been sold, only the IP
      • 2011-08-02 21442, 2011

      • intgr
        Weren't they supposed to pay $10k or some amount to MusicBrainz when they stop the service?
      • 2011-08-02 21457, 2011

      • luks
        that's complicated, MB would get the code, but wouldn't be able to run it because of the patents :)
      • 2011-08-02 21400, 2011

      • luks
        I started thinking of a way to make PUIDs useful ever after MusicDNS is dead
      • 2011-08-02 21420, 2011

      • luks
        I'm going to try to map as many PUIDs as possible to Acoustid fingerprints
      • 2011-08-02 21449, 2011

      • intgr
      • 2011-08-02 21450, 2011

      • intgr
        "$10,000 held in escrow for MusicBrainz, plus contractual commitment to supply hardware resources should MusicIP exit the fingerprinting business. This is designed to allow us to continue the service should they decide to stop providing the service."
      • 2011-08-02 21443, 2011

      • intgr
        So is this still in effect?
      • 2011-08-02 21416, 2011

      • luks
        yes
      • 2011-08-02 21419, 2011

      • cparker joined the channel
      • 2011-08-02 21432, 2011

      • luks
        technically
      • 2011-08-02 21449, 2011

      • intgr
        :/
      • 2011-08-02 21403, 2011

      • gnu_andrew joined the channel
      • 2011-08-02 21414, 2011

      • gnu_andrew joined the channel
      • 2011-08-02 21423, 2011

      • adhawkins joined the channel
      • 2011-08-02 21438, 2011

      • cparker joined the channel
      • 2011-08-02 21443, 2011

      • cparker joined the channel
      • 2011-08-02 21452, 2011

      • reosarevokphone
        why just technically?
      • 2011-08-02 21442, 2011

      • luks
        because it's not sure what will really happen
      • 2011-08-02 21401, 2011

      • hrglgrmpf
        maybe because we don't have lawyers...
      • 2011-08-02 21407, 2011

      • suriv joined the channel
      • 2011-08-02 21421, 2011

      • nikki
        oh, hi hrglgrmpf
      • 2011-08-02 21458, 2011

      • hrglgrmpf
        nikki: hi :-)
      • 2011-08-02 21420, 2011

      • nikki owes you some edit notes :/
      • 2011-08-02 21442, 2011

      • hrglgrmpf
        really? what exactly?
      • 2011-08-02 21410, 2011

      • nikki
        good question :P probably recording comments
      • 2011-08-02 21434, 2011

      • hrglgrmpf
        ah yes, I will change them once they are applied
      • 2011-08-02 21400, 2011

      • hrglgrmpf
        if something is unfinished, I put it in my "TODO" collection, so I won't forget it :-)
      • 2011-08-02 21419, 2011

      • nikki
        I mark the emails as unread even though I've read them, but I'm usually slow at replying to emails or edit notes
      • 2011-08-02 21430, 2011

      • nikki doesn't really know why
      • 2011-08-02 21457, 2011

      • ruaok joined the channel
      • 2011-08-02 21432, 2011

      • hrglgrmpf
        nikki: what do you think about server-side URL cleanup?
      • 2011-08-02 21411, 2011

      • hrglgrmpf
        since you are very active cleaning them up, you must have a profound opinion of it...
      • 2011-08-02 21445, 2011

      • nikki
        hmm... I'm actually more curious about why some urls don't get cleaned up even though the user has js on
      • 2011-08-02 21417, 2011

      • hrglgrmpf
        I have to use ctrl-v (not the mouse), otherwise the JS isn't triggered
      • 2011-08-02 21430, 2011

      • nikki
        I don't really have much of an opinion about doing it server side though, for the most part it's things that aren't even being done in js
      • 2011-08-02 21441, 2011

      • nikki
        or fixing things that are hard to do programmatically, like fixing or removing wikipedia's damned 404s
      • 2011-08-02 21450, 2011

      • hrglgrmpf
        I'm talking about the server-side validation ticket... I always thought the MB approach is: better the user enters a malformed URL, than nothing, it can be cleaned up later
      • 2011-08-02 21416, 2011

      • nikki nods
      • 2011-08-02 21422, 2011

      • hrglgrmpf
        that would mean the ticket should be closed as invalid probably...
      • 2011-08-02 21449, 2011

      • hrglgrmpf
        but server-side cleanup for e.g. ASINs, allmusic etc. would be very simple and effective
      • 2011-08-02 21446, 2011

      • nikki
        I have to wonder if there are that many urls which slip through that we should spend time adding it in the server too though
      • 2011-08-02 21450, 2011

      • nikki
        btw, if you know how to reproduce it not working with the mouse, please do report it
      • 2011-08-02 21450, 2011

      • ianmcorvidae
        possibly we should just run the JS callback thing on more things
      • 2011-08-02 21453, 2011

      • hrglgrmpf
        probably not...
      • 2011-08-02 21456, 2011

      • nikki
        I guess we're not checking for everything
      • 2011-08-02 21458, 2011

      • ianmcorvidae
        it currently runs on change and keyup
      • 2011-08-02 21419, 2011

      • hrglgrmpf
        ianmcorvidae: yes
      • 2011-08-02 21422, 2011

      • ianmcorvidae
        well, or, after we set the value we should do .blur() or something, I forget how that works
      • 2011-08-02 21439, 2011

      • nikki
        .blur()?
      • 2011-08-02 21455, 2011

      • ianmcorvidae
        blur is triggered when something loses focus
      • 2011-08-02 21418, 2011

      • ianmcorvidae
        and I know that for me the value of the field doesn't actually change until I click into the edit note field
      • 2011-08-02 21421, 2011

      • ianmcorvidae
        i.e. when a blur event is fired :)
      • 2011-08-02 21444, 2011

      • ianmcorvidae
        so possibly triggering a blur event would make it work more correctly
      • 2011-08-02 21445, 2011

      • nikki
        ah, so it doesn't make it blur it
      • 2011-08-02 21454, 2011

      • ianmcorvidae
        yeah
      • 2011-08-02 21403, 2011

      • ianmcorvidae
        it does 'self.urlControl.val(clean)'
      • 2011-08-02 21413, 2011

      • djce joined the channel
      • 2011-08-02 21413, 2011

      • hrglgrmpf
        nikki: I think I was wrong... if I paste with the mouse, the link doesn't get corrected, but clicking "Enter edit" (or return) afterwards does... so I don't have a explanation...
      • 2011-08-02 21414, 2011

      • ianmcorvidae
        something like self.urlControl.val(clean).blur(); might fix it
      • 2011-08-02 21433, 2011

      • ianmcorvidae
        hrglgrmpf: if you paste in and then click into the edit note field, what happens?
      • 2011-08-02 21444, 2011

      • nikki would go insane if it kept unfocusing the field. the release editor does that to her in the basic editor and she wants to throw things at the screen when it happens
      • 2011-08-02 21449, 2011

      • hrglgrmpf
        ianmcorvidae: nothing
      • 2011-08-02 21457, 2011

      • hrglgrmpf
        ianmcorvidae: no correction
      • 2011-08-02 21403, 2011

      • ianmcorvidae
        oh, it doesn't unfocus it, it just triggers the event that unfocusing would trigger
      • 2011-08-02 21409, 2011

      • ianmcorvidae
        if that makes sense
      • 2011-08-02 21415, 2011

      • nikki
        yeah, just saying :)
      • 2011-08-02 21417, 2011

      • ianmcorvidae
        it triggers a blur event without you actually having to unfocus it
      • 2011-08-02 21432, 2011

      • nikki prods kepstin
      • 2011-08-02 21438, 2011

      • hrglgrmpf
        ianmcorvidae: argh, sorry, I misread: clicking in the "Edit note" field cleans up the URL, but clicking in the URL field doesn't
      • 2011-08-02 21445, 2011

      • ianmcorvidae
        okay, cool
      • 2011-08-02 21454, 2011

      • ianmcorvidae
        I think triggering a blur may fix hrglgrmpf's problem too then
      • 2011-08-02 21400, 2011

      • nikki
        but it cleans it up when you press enter/return?
      • 2011-08-02 21435, 2011

      • ianmcorvidae
        hitting enter selects the "enter edit" button, deselecting the url field, triggering a blur event :)
      • 2011-08-02 21427, 2011

      • nikki
        something's not working somewhere at some point though
      • 2011-08-02 21459, 2011

      • nikki
        and I seem to have seen more urls needing cleaning up since ngs came out
      • 2011-08-02 21409, 2011

      • ianmcorvidae
        hm
      • 2011-08-02 21412, 2011

      • nikki
        and kepstin managed to enter an amazon url twice that didn't get cleaned up
      • 2011-08-02 21418, 2011

      • nikki
        (and when he asked, he said he has js on)
      • 2011-08-02 21407, 2011

      • ianmcorvidae
        hm
      • 2011-08-02 21420, 2011

      • Tecfan__ joined the channel
      • 2011-08-02 21421, 2011

      • ianmcorvidae
        I'm having trouble figuring out what exactly happens when http:// isn't included
      • 2011-08-02 21433, 2011

      • ianmcorvidae
        it looks like maybe it doesn't run cleanup when that's not there?
      • 2011-08-02 21400, 2011

      • nikki
        I thought it wouldn't accept it without that
      • 2011-08-02 21403, 2011

      • nikki
        at least on the live server
      • 2011-08-02 21427, 2011

      • ianmcorvidae
        well, yeah
      • 2011-08-02 21400, 2011

      • ianmcorvidae
        so the urlChanged trigger checks, first: url.match(/^\w+\./)
      • 2011-08-02 21416, 2011

      • ianmcorvidae
        if that hits (i.e. there's no http, although it's a convoluted way of saying it)
      • 2011-08-02 21429, 2011

      • ianmcorvidae
        then it adds http:// to the front of the url in the value and returns
      • 2011-08-02 21442, 2011

      • nikki
        that was added recently though
      • 2011-08-02 21443, 2011

      • ianmcorvidae
        if that _doesn't_ match then it goes on and uses the cleaned value, if applicable
      • 2011-08-02 21436, 2011

      • nikki wonders if hrglgrmpf saw what she said
      • 2011-08-02 21437, 2011

      • ianmcorvidae
        so what I'm not sure is if the self.urlControl.val('http://' + url) would trigger a change event, and thus cause urlChanged to get run a second time
      • 2011-08-02 21405, 2011

      • nikki
        I tried on test and it added the http:// immediately, then fixed the url when I submitted it
      • 2011-08-02 21418, 2011

      • nikki
        but that doesn't really explain why it happened before that was added
      • 2011-08-02 21423, 2011

      • ianmcorvidae
        yeah
      • 2011-08-02 21435, 2011

      • HumHumXX has left the channel
      • 2011-08-02 21444, 2011

      • ianmcorvidae
        perhaps compile a list of un-corrected URLs and we can see if there's a pattern there?
      • 2011-08-02 21449, 2011

      • nikki
        :o
      • 2011-08-02 21450, 2011

      • nikki
      • 2011-08-02 21452, 2011

      • nikki
        I did it!
      • 2011-08-02 21407, 2011

      • ianmcorvidae
        ooh
      • 2011-08-02 21408, 2011

      • ianmcorvidae
        how?
      • 2011-08-02 21423, 2011

      • nikki
        *and* I finally got that fly that's been annoying me for hours
      • 2011-08-02 21430, 2011

      • nikki is having a lucky minute it seems
      • 2011-08-02 21446, 2011

      • ruaok bows down before nikki
      • 2011-08-02 21430, 2011

      • nikki
        I used cmd-v to paste www.amazon.co.jp/dp/tracks/B0000AFOPB/ref=dp_trac… and hit enter really quickly
      • 2011-08-02 21400, 2011

      • ianmcorvidae
        if you hit enter more slowly does it correct it, or?
      • 2011-08-02 21407, 2011

      • nikki
        it seems so
      • 2011-08-02 21439, 2011

      • nikki
        hm, no
      • 2011-08-02 21429, 2011

      • nikki
        it seems I just need to click in the field, paste, press enter, and most of the time the page submits before the js finishes
      • 2011-08-02 21443, 2011

      • ianmcorvidae
        hm
      • 2011-08-02 21453, 2011

      • ianmcorvidae
        that suggests that hitting submit should fire the url cleanup thing
      • 2011-08-02 21455, 2011

      • ianmcorvidae
        or something like that
      • 2011-08-02 21457, 2011

      • nikki
      • 2011-08-02 21404, 2011

      • nikki
        it does
      • 2011-08-02 21417, 2011

      • nikki
        but it finishes submitting before the field updates
      • 2011-08-02 21427, 2011

      • ianmcorvidae
        oh I think I see what's going on
      • 2011-08-02 21436, 2011

      • ianmcorvidae
        without the http:// the urlChanged thing has to fire twice
      • 2011-08-02 21447, 2011

      • ianmcorvidae
        so it fires once, and then your submit fires before it can hit it a second time
      • 2011-08-02 21448, 2011

      • nikki
        yeah
      • 2011-08-02 21458, 2011

      • ianmcorvidae
        whereas if the http is there it only has to fire once, so it happens before the submit
      • 2011-08-02 21408, 2011

      • nikki
        bwahaha
      • 2011-08-02 21410, 2011

      • ianmcorvidae
        what this says to me is
      • 2011-08-02 21428, 2011

      • ianmcorvidae
        instead of changing the value and returning, it should change the url within the function and then clean
      • 2011-08-02 21441, 2011

      • ianmcorvidae
        i.e. don't have two different paths by which it sets the value
      • 2011-08-02 21423, 2011

      • nikki
        I can reproduce it with http:// if I use the mouse to drag selected text into the box and then hit enter
      • 2011-08-02 21446, 2011

      • ianmcorvidae
        hm
      • 2011-08-02 21451, 2011

      • ianmcorvidae
        that's even with the http:// there?
      • 2011-08-02 21459, 2011

      • nikki
        which I suppose is the closest I can get to middle-click paste without opening my vm
      • 2011-08-02 21406, 2011

      • nikki
        yep
      • 2011-08-02 21406, 2011

      • nikki
        oh, it is open
      • 2011-08-02 21408, 2011

      • nikki
        that's handy
      • 2011-08-02 21401, 2011

      • JoeLlama joined the channel
      • 2011-08-02 21435, 2011

      • ianmcorvidae
        hm
      • 2011-08-02 21432, 2011

      • ianmcorvidae
        potentially you should litter your root/static/scripts/edit/MB/Control/URLCleanup.js with console.log to see what's getting fired when
      • 2011-08-02 21423, 2011

      • ianmcorvidae
        (well, and how many times, with what URLs, etc)
      • 2011-08-02 21439, 2011

      • ianmcorvidae
        er, opera doesn't have console.log, it has something else
      • 2011-08-02 21440, 2011

      • ianmcorvidae
        but still
      • 2011-08-02 21435, 2011

      • nikki
        yay!
      • 2011-08-02 21436, 2011

      • nikki
      • 2011-08-02 21401, 2011

      • nikki
        middle click paste + enter