#musicbrainz

/

      • Munger
        Boooo!
      • 2012-01-07 00742, 2012

      • Munger
        "
      • 2012-01-07 00754, 2012

      • nikki
        trying to run the server?
      • 2012-01-07 00757, 2012

      • Munger
        Yes
      • 2012-01-07 00718, 2012

      • nikki
        you need to either run some script to generate the js/css files, or change lib/DBDefs.pm to say it's a development server
      • 2012-01-07 00730, 2012

      • Munger
        I was trying to run a slave initially
      • 2012-01-07 00731, 2012

      • voiceinsideyou joined the channel
      • 2012-01-07 00732, 2012

      • nikki
        I do the latter, so I have no idea where the script is if you want to do the former
      • 2012-01-07 00707, 2012

      • Munger
        How do I exit the damned thing?
      • 2012-01-07 00719, 2012

      • nikki uses ctrl-c
      • 2012-01-07 00720, 2012

      • Munger
        ctrl-c seems brutal
      • 2012-01-07 00736, 2012

      • reosarevok
        Nothing wrong with brvtal
      • 2012-01-07 00738, 2012

      • nikki
        ah, the thingy in dbdefs is DEVELOPMENT_SERVER
      • 2012-01-07 00752, 2012

      • reosarevok plays some brvtal kvlt black metal stuff
      • 2012-01-07 00756, 2012

      • Munger
        I changed that to SLAVE
      • 2012-01-07 00725, 2012

      • Munger
        RT_SLAVE
      • 2012-01-07 00744, 2012

      • nikki
        are you thinking of REPLICATION_TYPE?
      • 2012-01-07 00706, 2012

      • Munger
        YEs
      • 2012-01-07 00706, 2012

      • nikki
        (that's the one with RT_SLAVE or RT_STANDALONE)
      • 2012-01-07 00729, 2012

      • nikki
        if you search for DEVELOPMENT_SERVER then, you'll find something you can change to 1 instead of 0
      • 2012-01-07 00754, 2012

      • jesus2099 joined the channel
      • 2012-01-07 00745, 2012

      • jesus2099
        luks: on normal vote buttons, I think also but only in edit page (and it submits note at the same time). keeping radio buttons in edit search is a must as we can vote all of them at once (but we miss the cancel radio button IMO)
      • 2012-01-07 00758, 2012

      • jesus2099
        nikki: Hae you seen my patched version of pastadate?
      • 2012-01-07 00701, 2012

      • Munger
        nikki, Does the same thing
      • 2012-01-07 00709, 2012

      • jesus2099
        which could be merged before you release your next version maybe? :)
      • 2012-01-07 00753, 2012

      • luks
        I don't think voting on all edits at once is a particularly good feature
      • 2012-01-07 00730, 2012

      • jesus2099
        it is
      • 2012-01-07 00742, 2012

      • jesus2099
        I can check ABSTAIN ALL then review and check yes on some or no on others
      • 2012-01-07 00757, 2012

      • luks
        ok, abstain is useful
      • 2012-01-07 00702, 2012

      • luks
        but not yes/no
      • 2012-01-07 00722, 2012

      • jesus2099
        I can make a custom search to abstain block of recs blind merges from within my subscription before beginning to think and review the what I consider more "serious" edits
      • 2012-01-07 00753, 2012

      • jesus2099
        yes/no is useful on a particular edit search that is made for yes/no voting with some exceptions in it
      • 2012-01-07 00755, 2012

      • nikki
        you could just add a button at the bottom for "abstain on all edits"
      • 2012-01-07 00708, 2012

      • nikki
        then you don't need radio buttons for every edit
      • 2012-01-07 00710, 2012

      • jesus2099
        that would not cover my aabove need
      • 2012-01-07 00723, 2012

      • jesus2099
        I n"eed radio because I want to abstain ALL except some
      • 2012-01-07 00739, 2012

      • jesus2099
        and it's faster to check all and uncheck some than you knwo
      • 2012-01-07 00702, 2012

      • luks
        you can as easily vote YES on those edits
      • 2012-01-07 00709, 2012

      • luks
        and then abstain on the remaining ones
      • 2012-01-07 00717, 2012

      • voiceinsideyou joined the channel
      • 2012-01-07 00753, 2012

      • nikki
        jesus2099: I haven't looked yet, I will do though
      • 2012-01-07 00739, 2012

      • jesus2099
        btw nikki http://pastie.org/pastes/3137486 what has changed is 1. removed the faulty innerHTML 2. added an IF at the end, without it we had errors on many pages (only in the console) 3. removed prototype but it’s really up to you as I know have protected my usrejs, you can kleep it if you like it like that) 4. added cursor=pointer on A without HREF so that we get this nice mouse cursor
      • 2012-01-07 00714, 2012

      • reosarevok
        luks, yes-no is useful :p
      • 2012-01-07 00721, 2012

      • reosarevok votes on all removals
      • 2012-01-07 00734, 2012

      • reosarevok defaults to yes, changes to no-abstain only if they are doubtful
      • 2012-01-07 00738, 2012

      • reosarevok
        (90% of them are legit)
      • 2012-01-07 00742, 2012

      • voiceinsideyou joined the channel
      • 2012-01-07 00749, 2012

      • jesus2099
        luks: you see!
      • 2012-01-07 00719, 2012

      • jesus2099
        of course it's useful... imagine someone had to click 25 times in each edit searfch page? it would be kind of crazey
      • 2012-01-07 00750, 2012

      • jesus2099
        unproductive
      • 2012-01-07 00720, 2012

      • igndenok joined the channel
      • 2012-01-07 00752, 2012

      • jesus2099
        nikki: it applies to your current public version, thanks for reviewing and release when you have time, as it is really a useful userjs omg
      • 2012-01-07 00700, 2012

      • luks doesn't know what to with the buttons then :/
      • 2012-01-07 00720, 2012

      • nikki
        put them at the bottom
      • 2012-01-07 00727, 2012

      • jesus2099
        what buttons?
      • 2012-01-07 00743, 2012

      • jesus2099
        in the edit page they would fit well and would submit the edit note at the same time
      • 2012-01-07 00751, 2012

      • nikki
        mark anything that's already been voted on and only submit votes for the unvoted ones
      • 2012-01-07 00706, 2012

      • reosarevok
        Hmm, yeah, luks: that would be a good start for voting
      • 2012-01-07 00715, 2012

      • reosarevok
        Make Enter vote send the edit note too :p
      • 2012-01-07 00735, 2012

      • nikki longs for the submit edit note buttons to show up next to the edit note again
      • 2012-01-07 00737, 2012

      • reosarevok
        That's much more annoying even than the button thing
      • 2012-01-07 00756, 2012

      • reosarevok
        (although I can see how voting being a button would be cool)
      • 2012-01-07 00715, 2012

      • reosarevok
        (in general - it'd just mess with my current way)
      • 2012-01-07 00716, 2012

      • luks
        I have to open every single edit on a new tab, because I can't use the edit listing page
      • 2012-01-07 00721, 2012

      • jesus2099
        nikki: taht's already done
      • 2012-01-07 00727, 2012

      • voiceinsideyou joined the channel
      • 2012-01-07 00727, 2012

      • luks
        edit note is the same, of course
      • 2012-01-07 00727, 2012

      • reosarevok
        luks, why? :/
      • 2012-01-07 00734, 2012

      • nikki
        jesus2099: where?
      • 2012-01-07 00746, 2012

      • jesus2099
        nikki: when we vote all edits in the page I mean
      • 2012-01-07 00749, 2012

      • luks
        reosarevok: I can't vote on 25 edits at once, I lose context
      • 2012-01-07 00749, 2012

      • nikki
        luks: I tend to do that too
      • 2012-01-07 00702, 2012

      • jesus2099
        ah but with the ++script
      • 2012-01-07 00722, 2012

      • reosarevok checks them one by one, and just sends vote after all are done
      • 2012-01-07 00727, 2012

      • reosarevok
        (or all I want to check)
      • 2012-01-07 00737, 2012

      • luks
        I forget to send the votes
      • 2012-01-07 00740, 2012

      • jesus2099
        luks: 25 edits in a page usually contain about 10 or 15 related edits on the same release or stuff like that, it's chronological anyway
      • 2012-01-07 00740, 2012

      • reosarevok
        Oh
      • 2012-01-07 00743, 2012

      • reosarevok
        That can be a problem :p
      • 2012-01-07 00752, 2012

      • jesus2099
        and we often make edit searches or review one artist edits
      • 2012-01-07 00754, 2012

      • reosarevok
        Hmm
      • 2012-01-07 00706, 2012

      • luks
        I have 15 other tabs open, so closing that one is easy
      • 2012-01-07 00714, 2012

      • reosarevok
        Radio things, but with a "submit vote" button per edit?
      • 2012-01-07 00716, 2012

      • luks
        I'd like to vote on one edits and be done with it
      • 2012-01-07 00718, 2012

      • jesus2099
        luks nikki I think I don't really understand what buttons are being discussed in the end
      • 2012-01-07 00734, 2012

      • luks
        -s
      • 2012-01-07 00737, 2012

      • jesus2099
        luks AH!
      • 2012-01-07 00757, 2012

      • jesus2099
        then catch dblclick on radio to submit vote with its edit note ... I think it's in my script already
      • 2012-01-07 00718, 2012

      • reosarevok
        Double click is a bit too hidden for general use IMO
      • 2012-01-07 00721, 2012

      • reosarevok
        (cool for a script though)
      • 2012-01-07 00729, 2012

      • luks
        that submits the whole page
      • 2012-01-07 00738, 2012

      • luks
        I don't want that
      • 2012-01-07 00740, 2012

      • jesus2099
      • 2012-01-07 00751, 2012

      • jesus2099
        no only one script
      • 2012-01-07 00755, 2012

      • jesus2099
        one vote :/
      • 2012-01-07 00759, 2012

      • jesus2099
        not the whole page
      • 2012-01-07 00703, 2012

      • reosarevok
        It does say "Double click radio to vote single edit" at least
      • 2012-01-07 00707, 2012

      • jesus2099
        ah you mean you want ajax submit
      • 2012-01-07 00707, 2012

      • reosarevok
        :)
      • 2012-01-07 00720, 2012

      • jesus2099
        luks ajax submit?
      • 2012-01-07 00724, 2012

      • luks
        of course
      • 2012-01-07 00741, 2012

      • jesus2099
        luks then hide this vote line after a small timeout?
      • 2012-01-07 00748, 2012

      • jesus2099
        or not
      • 2012-01-07 00755, 2012

      • luks
        double-clicking is bad UI
      • 2012-01-07 00756, 2012

      • reosarevok thinks a "Submit vote" button per edit is the easiest option
      • 2012-01-07 00700, 2012

      • luks
        because that normally submits the form
      • 2012-01-07 00715, 2012

      • luks
        (the whole form)
      • 2012-01-07 00715, 2012

      • jesus2099
        I don't double click the submit button i doucle blick the radio
      • 2012-01-07 00717, 2012

      • reosarevok
        (and relatively clean too)
      • 2012-01-07 00731, 2012

      • luks
        yes, double clicking the ratio button normally submits the form
      • 2012-01-07 00739, 2012

      • jesus2099
        normally?
      • 2012-01-07 00756, 2012

      • luks
        I seem to remember that in firefox
      • 2012-01-07 00756, 2012

      • jesus2099
        in standard HTML you mean? or it used to be normally in MB before NGS?
      • 2012-01-07 00756, 2012

      • reosarevok
        Really?
      • 2012-01-07 00759, 2012

      • reosarevok didn't know
      • 2012-01-07 00702, 2012

      • luks
        I thought it's standard behavior
      • 2012-01-07 00712, 2012

      • jesus2099
        luks: I don't think this is standard at all
      • 2012-01-07 00730, 2012

      • reosarevok
        That sounds... too easy to do wrong
      • 2012-01-07 00738, 2012

      • reosarevok wouldn't like that to be enabled at all in MB
      • 2012-01-07 00749, 2012

      • jesus2099
        maybe you had 1. a userjs to do that 2. were using MB which did that IIRC
      • 2012-01-07 00754, 2012

      • jesus2099
        luks ^^
      • 2012-01-07 00759, 2012

      • nikki
        we used to do it in mason and it became quite natural to me :/
      • 2012-01-07 00708, 2012

      • nikki
        but I don't think it was ever a standard anywhere
      • 2012-01-07 00718, 2012

      • jesus2099
        luks: if you are looking for a way to add a direct vote button in search, I thought it about some time then decided of this dblclick on radio thing
      • 2012-01-07 00730, 2012

      • jesus2099
        and implemented this, I didn't find better yet
      • 2012-01-07 00737, 2012

      • jesus2099
        nikki: hopefully
      • 2012-01-07 00747, 2012

      • luks
        oh
      • 2012-01-07 00748, 2012

      • jesus2099
        but good idea for MB imo
      • 2012-01-07 00708, 2012

      • reosarevok
        nikki, it does sound as a too easy way for someone who doesn't know it works like that to submit wrong votes
      • 2012-01-07 00718, 2012

      • reosarevok
        Or half-written notes, or whatever
      • 2012-01-07 00726, 2012

      • nikki
        reosarevok: I mean in general, not specifically for edit notes
      • 2012-01-07 00728, 2012

      • jesus2099
        with a “double-click to vote this single edit” tool tip
      • 2012-01-07 00732, 2012

      • luks
        regarding the buttons, what about having an option to switch the buttons to radios?
      • 2012-01-07 00737, 2012

      • luks
        e.g. at the bottom of the list
      • 2012-01-07 00743, 2012

      • luks
        but display the buttons by default
      • 2012-01-07 00703, 2012

      • jesus2099
        I've heard some people don't like settings
      • 2012-01-07 00731, 2012

      • _5moufl has left the channel
      • 2012-01-07 00734, 2012

      • jesus2099
        but wyh not, if the setting is remembered of course
      • 2012-01-07 00750, 2012

      • luks
        not settings
      • 2012-01-07 00753, 2012

      • jesus2099
        _5moufl: Adieu
      • 2012-01-07 00707, 2012

      • luks
        but you have an option to vote on all edits there
      • 2012-01-07 00709, 2012

      • jesus2099
        option or whatever you call it :)
      • 2012-01-07 00722, 2012

      • luks
        so another option would change the buttons to radios
      • 2012-01-07 00739, 2012

      • jesus2099
        luks I wouldn't want to vote all edits with a single button because I ALWAYS want to exclude some edits from this ALL thing
      • 2012-01-07 00740, 2012

      • luks
        it's not configuration, it's one time action
      • 2012-01-07 00756, 2012

      • luks is not clear enough and gives up
      • 2012-01-07 00709, 2012

      • nikki
        luks: only the auto-editors and people with user scripts have the vote on all edits thing :P
      • 2012-01-07 00719, 2012

      • luks
        ah, another thing I didn't know
      • 2012-01-07 00723, 2012

      • murdos
        nikki: could you make my bot auto-edit too? so it can submit link to french wikipedia for release-group as autoedit? I agree with luks, I've no seen any errors on this one
      • 2012-01-07 00726, 2012

      • jesus2099
        that wold mean my userjs should immediately click "transform into radio buttons" option at each page then - it would be better to remember but maybe niot