#musicbrainz

/

      • brianfreud
        <img src="/static/images/release_editor/edit-off.gif" class="hidden switchable" title="Set" alt="Set" />

        • 2009-02-04 03504, 2009

      • aCiD2
        oh, yea - those too then, heh

        • 2009-02-04 03506, 2009

      • brianfreud
        :P

        • 2009-02-04 03512, 2009

      • brianfreud was confused :D

        • 2009-02-04 03519, 2009

      • aCiD2
        basically, everything but the row wrapper, the main label, and the errors template

        • 2009-02-04 03522, 2009

      • aCiD2
        generic/row.tt will handle those

        • 2009-02-04 03538, 2009

      • brianfreud
        ok, you will also need to be able to pass object, too, to row.tt

        • 2009-02-04 03545, 2009

      • brianfreud
        else you have no intelligence

        • 2009-02-04 03516, 2009

      • brianfreud
        so [%- INCLUDE 'forms/generic/row.tt' field=form.field('artist_$i')label=l('Artist') object="artist_$i" type='switchable' %]

        • 2009-02-04 03523, 2009

      • aCiD2
        that's no problem, that will cascade down just fine

        • 2009-02-04 03528, 2009

      • aCiD2
        doesn't need any changes

        • 2009-02-04 03507, 2009

      • the_p has quit

        • 2009-02-04 03542, 2009

      • brianfreud
        ok, moved that bit to widget/switch.tt, and changed tracks.tt to ^^

        • 2009-02-04 03552, 2009

      • brianfreud
        how now does row.tt know to use switch.tt ?

        • 2009-02-04 03510, 2009

      • aCiD2
        pass type='switch'

        • 2009-02-04 03549, 2009

      • aCiD2
        but, as switch.tt includes some input.tt templates, those will also need a type given, or you'll end recursivly creating switch.tt's

        • 2009-02-04 03524, 2009

      • aCiD2
        you already do that on the checkbox, but line 13 needs type='text' on it

        • 2009-02-04 03514, 2009

      • aCiD2 goes to make dinner

        • 2009-02-04 03518, 2009

      • outsidecontext joined the channel

        • 2009-02-04 03536, 2009

      • ruaok returns with brekky

        • 2009-02-04 03552, 2009

      • brianfreud enjoys pre-work coffee

        • 2009-02-04 03524, 2009

      • outsidecontext enjoys an after-work whyskey

        • 2009-02-04 03517, 2009

      • ruaok
        amazing how we're never on the same page, but still get shit done. :)

        • 2009-02-04 03536, 2009

      • ruaok
        some of us are always drunk while the others are toiling at work. so odd.

        • 2009-02-04 03543, 2009

      • brianfreud
        ruaok: btw, having learned from our experiences in the past, btw, every single bit of js I write is getting documented as to exactly how to use / implement it :)

        • 2009-02-04 03558, 2009

      • brianfreud
        stubs was just to much a pita to make work :P

        • 2009-02-04 03514, 2009

      • Muz
        ruaok: always drunk you say? I'll get right on it!

        • 2009-02-04 03520, 2009

      • Muz packs up from work and heads to the pub.

        • 2009-02-04 03550, 2009

      • outsidecontext
        Muz, good plan

        • 2009-02-04 03529, 2009

      • ruaok
        Muz: thanks for picking up the slack.

        • 2009-02-04 03545, 2009

      • ruaok
        brianfreud: I'm glad that experience helped. :-)

        • 2009-02-04 03558, 2009

      • nikki sips tea

        • 2009-02-04 03522, 2009

      • ruaok
        WTF @ the last three comments: http://blog.musicbrainz.org/?p=369

        • 2009-02-04 03530, 2009

      • ruaok
        she sounds like my ex. :-(

        • 2009-02-04 03551, 2009

      • navap
        haha

        • 2009-02-04 03556, 2009

      • brianfreud
        looks like blog spam to me :P

        • 2009-02-04 03515, 2009

      • navap
        ruaok: The "Annual Report" link, links to 2006 - maybe that should be taken down, or renamed?

        • 2009-02-04 03543, 2009

      • navap
        On MetaBrainz.org

        • 2009-02-04 03548, 2009

      • luks
        brianfreud: http://bugs.musicbrainz.org/browser/mb_server/bra… is a better version of the JS lookup code

        • 2009-02-04 03549, 2009

      • ruaok
        I suppose.

        • 2009-02-04 03526, 2009

      • brianfreud
        luks: thanks. Even though it's called ArtistSelect(), does it also now do the label lookup?

        • 2009-02-04 03559, 2009

      • luks
        yeah

        • 2009-02-04 03506, 2009

      • brianfreud
        k

        • 2009-02-04 03536, 2009

      • luks
        it will need the server side to be written, too

        • 2009-02-04 03505, 2009

      • brianfreud
        the JSON server?

        • 2009-02-04 03505, 2009

      • luks
        this script uses a different format than the current one, but since it doesn't exist in TT yet it shouldn't be a problem

        • 2009-02-04 03523, 2009

      • luks
        yeah, the script that gives you search results in json

        • 2009-02-04 03515, 2009

      • brianfreud
        k. We actually have another need for data to be fed out with JSON too. I don't really know anything about the server end for JSON, not sure if both can be fed out from the same server, or if "server" is even really the right terminology.

        • 2009-02-04 03548, 2009

      • luks
        it's just a regular page, but instead of html it will return json

        • 2009-02-04 03501, 2009

      • brianfreud
        ah, like the languages list page?

        • 2009-02-04 03547, 2009

      • brianfreud
        hmm, wonder if a JSON page can be templated then?

        • 2009-02-04 03526, 2009

      • brianfreud
        gettext for javascript uses JSON results to pass l() translations to js code

        • 2009-02-04 03527, 2009

      • luks
        no, there are modules to generate JSON for you from a perl object

        • 2009-02-04 03552, 2009

      • luks
        you can use templates for that, but I don't see why

        • 2009-02-04 03530, 2009

      • brianfreud
        like I say, I know nothing (yet) about the server side for JSON - only that gettext and your lookup both need JSON results to be fed in for them towork

        • 2009-02-04 03531, 2009

      • luks
        hm, right, translating JS will be more fun

        • 2009-02-04 03546, 2009

      • brianfreud
        there's a JQuery plugin for it, made sure of that a week ago.

        • 2009-02-04 03506, 2009

      • brianfreud
        http://plugins.jquery.com/project/gettext

        • 2009-02-04 03514, 2009

      • luks
        that should work

        • 2009-02-04 03516, 2009

      • brianfreud
        The .js client end seems straightforward enough. Now I just need to spend the next couple of days reading up on the server end of JSON

        • 2009-02-04 03517, 2009

      • luks
        we will need a separate .po files for JS and the rest

        • 2009-02-04 03524, 2009

      • brianfreud
        why?

        • 2009-02-04 03543, 2009

      • luks
        because there will be a lot of translations, but only few of them used in JS

        • 2009-02-04 03558, 2009

      • luks
        sending all of them doesn't seem like a good idea

        • 2009-02-04 03511, 2009

      • brianfreud
        ah, not a technical thing, but rather, for faster response

        • 2009-02-04 03536, 2009

      • brianfreud
        if it's a webservice, though, rather than a hard-coded page, shouldn't it just be sending back only the requested string(s)?

        • 2009-02-04 03505, 2009

      • navap
        Maybe Im crazy, but shouldn't this be set to "Interview" as per its last edit? http://musicbrainz.org/release/0775f70b-c750-4717…

        • 2009-02-04 03515, 2009

      • luks
        brianfreud: that would be slooooow :)

        • 2009-02-04 03531, 2009

      • luks
        <link href="path/to/translation.json" lang="ro" rel="gettext"/>

        • 2009-02-04 03554, 2009

      • navap
        And why are the release events not sorted the same as on http://musicbrainz.org/release/26b95b5c-e6c7-4eb6…

        • 2009-02-04 03509, 2009

      • luks
        our "path/to/translation.json" will return all trasnlations in one request

        • 2009-02-04 03521, 2009

      • brianfreud
        for every language?

        • 2009-02-04 03531, 2009

      • luks
        just the currently selected one

        • 2009-02-04 03535, 2009

      • brianfreud
        k

        • 2009-02-04 03553, 2009

      • nikki
        navap: hmm, well, it changed it from album to interview, but then the album one was cancelled...

        • 2009-02-04 03509, 2009

      • navap
        But kot the Interview..

        • 2009-02-04 03512, 2009

      • navap
        not*

        • 2009-02-04 03512, 2009

      • nikki
        so I guess it was something to do with the two edits cancelling each other or whatever

        • 2009-02-04 03513, 2009

      • brianfreud
        I will likely have to work with you a bit in figuring out how to pull off the server end of things for both JSON needs

        • 2009-02-04 03538, 2009

      • luks
        I can do the server part if you want

        • 2009-02-04 03505, 2009

      • nikki
        yes, but when the spokenword->album one was cancelled, I presume it thought it was reverting the edit, changing interview to spokenword

        • 2009-02-04 03518, 2009

      • brianfreud
        well, to paraphrase ruaok, lol, first I'd at least like to learn how, even if you end up doing it in the long run :)

        • 2009-02-04 03516, 2009

      • brianfreud
        I am guessing, though, that that means writing a .pm over in /lib?

        • 2009-02-04 03535, 2009

      • luks
        in lib/MusicBrainz/Server/Controller to be more specific

        • 2009-02-04 03551, 2009

      • navap
        hm, I see..the edits should actually be in a different order.

        • 2009-02-04 03555, 2009

      • Kerensky97 has left the channel

        • 2009-02-04 03509, 2009

      • brianfreud
        do you recall what file held the old JSON server's code?

        • 2009-02-04 03542, 2009

      • nikki
        so it should be interview, but a glitch in the way the edits are handled broke it :P

        • 2009-02-04 03557, 2009

      • luks
        http://bugs.musicbrainz.org/browser/mb_server/tru…

        • 2009-02-04 03510, 2009

      • luks
        but the new version should be simpler

        • 2009-02-04 03513, 2009

      • aCiD2
        wth are those comments rob :P

        • 2009-02-04 03528, 2009

      • ruaok
        spam or psycho hose beast.

        • 2009-02-04 03532, 2009

      • ruaok shrugs

        • 2009-02-04 03545, 2009

      • brianfreud
        hmmm, looks straightforward enough

        • 2009-02-04 03513, 2009

      • brianfreud
        ok, scary... perl has begun to be comprehensible :P

        • 2009-02-04 03559, 2009

      • luks
        depends on who's perl code are you reading :)

        • 2009-02-04 03526, 2009

      • brianfreud
        luks: more from a speed of code point of view, did you worry about eval() protections, or are we safe using it without too much concern, do you think?

        • 2009-02-04 03542, 2009

      • luks
        eval() used where?

        • 2009-02-04 03507, 2009

      • brianfreud
        for anything fed to the client specifically by the two JSON feeds we're talknig about

        • 2009-02-04 03522, 2009

      • FauxFaux
        eval(posted_vars[1])

        • 2009-02-04 03523, 2009

      • luks
        what do you have json for?

        • 2009-02-04 03523, 2009

      • brianfreud
        notice you didn

        • 2009-02-04 03531, 2009

      • luks
        er, jquery for

        • 2009-02-04 03502, 2009

      • brianfreud
        well, yes - and that plugin uses it

        • 2009-02-04 03524, 2009

      • brianfreud
        var messages = eval('(' + data + ')'); /// var fn = eval('(function(' + v + ') {return ' + expr + ';})');

        • 2009-02-04 03525, 2009

      • ruaok
        LOL http://xkcd.org/

        • 2009-02-04 03535, 2009

      • navap
        Indeed

        • 2009-02-04 03548, 2009

      • luks
        :(

        • 2009-02-04 03512, 2009

      • brianfreud
        but I notice you didn't in your code

        • 2009-02-04 03523, 2009

      • ruaok
        I need to find a GF like that. I'd be proud to be her BF.

        • 2009-02-04 03527, 2009

      • luks
        brianfreud: my code uses $.getJSON

        • 2009-02-04 03546, 2009

      • luks
        I'll take a look what does the gettext plusin uses eval instead

        • 2009-02-04 03525, 2009

      • brianfreud considers messing with the gettext plugin to de-eval it

        • 2009-02-04 03522, 2009

      • brianfreud
        too bad such a useful function has to be so dangerous, by nature

        • 2009-02-04 03543, 2009

      • luks
        I don't find it useful :)

        • 2009-02-04 03532, 2009

      • luks
        in fact, I was never in a situation when I needed to use eval in any language

        • 2009-02-04 03547, 2009

      • luks
        hm, actually that's a lie, I used it once in python:)

        • 2009-02-04 03556, 2009

      • brianfreud
        I've managed in a non-framework manner to avoid using it before, but you can end up doing cartwheels (I did, at least) trying to do what you need, and only what you need, for JSON feeds that tend to send WAY too much info back

        • 2009-02-04 03557, 2009

      • ruaok
        how about DB transactions in perl?

        • 2009-02-04 03507, 2009

      • ruaok
        pretty much need to use eval for that...

        • 2009-02-04 03523, 2009

      • luks
        well, I mean different kind of eval

        • 2009-02-04 03532, 2009

      • luks
        eval { } is the only way to catch errors in perl

        • 2009-02-04 03539, 2009

      • ruaok
        ok

        • 2009-02-04 03544, 2009

      • luks
        I meant eval with a string variable

        • 2009-02-04 03551, 2009

      • ruaok nods

        • 2009-02-04 03536, 2009

      • brianfreud specifically thinking of the early JSON implementation for FreeBase

        • 2009-02-04 03508, 2009

      • brianfreud
        oh fun, more snow coming down hard again

        • 2009-02-04 03548, 2009

      • brianfreud
        hmm, ok, a script file with a comment like this must be high on the list to port: /* TODO: remove this function */ :D

        • 2009-02-04 03538, 2009

      • aCiD2
        brianfreud: gonna merge now, that sound good?

        • 2009-02-04 03548, 2009

      • luks
        such TODO usually means the function can't be simply removed, because other code depends on it :)

        • 2009-02-04 03557, 2009

      • brianfreud
        sure - you merging pronik's patches from yesterday too?

        • 2009-02-04 03558, 2009

      • aCiD2
        brianfreud: somewhere in the perl it says "Delete this when we use a real database" that makes me chuckle

        • 2009-02-04 03510, 2009

      • aCiD2
        brianfreud: if you've merged them into your branch, then yes, probably :P

        • 2009-02-04 03532, 2009

      • brianfreud
        luks: yes... hence why, whenever possible, I'm throwing out old stuff, as a lot of it just fixed things other things broke.

        • 2009-02-04 03558, 2009

      • brianfreud
        in this particular case, movefocus.js fixed one thing... and broke Opera anyhow

        • 2009-02-04 03512, 2009

      • chefkoch joined the channel

        • 2009-02-04 03546, 2009

      • Kerensky97 joined the channel

        • 2009-02-04 03516, 2009

      • brianfreud
        YAY! :)

        • 2009-02-04 03558, 2009

      • aCiD2
        what's the yay about?

        • 2009-02-04 03521, 2009

      • brianfreud
        Been talking with Neil via email... he just did a quick code audit and relicensed Diff Match and Patch as LGPL 2.1 (as opposed to Diff_Match_Patch, which is identical, but remains Apache 2.0)

        • 2009-02-04 03524, 2009

      • CatCat totally wants to see top contributors and cost per hit/ws hit type spot, that was really interesting

        • 2009-02-04 03538, 2009

      • CatCat
        brianfreud: huh?

        • 2009-02-04 03541, 2009

      • CatCat
        neil who?

        • 2009-02-04 03550, 2009

      • brianfreud
        Fraser - the guy who now works for Google, and who wrote the js diff engine that's a ton better (and faster) than the one by John Resig which we were using

        • 2009-02-04 03557, 2009

      • aCiD2
        I don't think git is really working out how it should be because of git-svn :(

        • 2009-02-04 03511, 2009

      • aCiD2
        i just tried to merge your branch, and even bits where there's no conflict, git thinks are conflicts

        • 2009-02-04 03503, 2009

      • ruaok
        common problem from what I've read aCiD2

        • 2009-02-04 03513, 2009

      • aCiD2
        :(

        • 2009-02-04 03527, 2009

      • ruaok
        is it safe to call the situation a mess yet?

        • 2009-02-04 03530, 2009

      • ruaok ducks