#musicbrainz

/

      • MightyJay has quit
      • 2009-05-31 15132, 2009

      • v6lur joined the channel
      • 2009-05-31 15138, 2009

      • cameel joined the channel
      • 2009-05-31 15122, 2009

      • cameel has left the channel
      • 2009-05-31 15129, 2009

      • Knio has quit
      • 2009-05-31 15104, 2009

      • futilius joined the channel
      • 2009-05-31 15137, 2009

      • Knio joined the channel
      • 2009-05-31 15118, 2009

      • toxickore joined the channel
      • 2009-05-31 15134, 2009

      • VxJasonxV
        ... I think my install of picard isn't threaded or something
      • 2009-05-31 15149, 2009

      • VxJasonxV
        the interface is clobbering when other operations are taking place (metadata lookup, clustering, etc.)
      • 2009-05-31 15107, 2009

      • VxJasonxV
        or perhaps python itself isn''t threaded
      • 2009-05-31 15146, 2009

      • cyberpea1 joined the channel
      • 2009-05-31 15139, 2009

      • cyberpear has quit
      • 2009-05-31 15130, 2009

      • sosdiode joined the channel
      • 2009-05-31 15139, 2009

      • sosdiode
        hi all
      • 2009-05-31 15144, 2009

      • sosdiode
        how ae we doing
      • 2009-05-31 15100, 2009

      • sosdiode
        hey check my music on triple j australia
      • 2009-05-31 15102, 2009

      • sosdiode
      • 2009-05-31 15109, 2009

      • sosdiode
        T with milk
      • 2009-05-31 15110, 2009

      • sosdiode
      • 2009-05-31 15151, 2009

      • sosdiode has quit
      • 2009-05-31 15145, 2009

      • rfzero has quit
      • 2009-05-31 15150, 2009

      • toxickore has quit
      • 2009-05-31 15115, 2009

      • Alan_New joined the channel
      • 2009-05-31 15131, 2009

      • sonium joined the channel
      • 2009-05-31 15137, 2009

      • Jormangeud has quit
      • 2009-05-31 15141, 2009

      • MightyJay joined the channel
      • 2009-05-31 15146, 2009

      • Om joined the channel
      • 2009-05-31 15111, 2009

      • sonium1 joined the channel
      • 2009-05-31 15156, 2009

      • RifRaf joined the channel
      • 2009-05-31 15143, 2009

      • sonium has quit
      • 2009-05-31 15100, 2009

      • xlotlu
        there's gonna be a new instrument needed soon :) http://news.bbc.co.uk/2/hi/science/nature/8075223…
      • 2009-05-31 15137, 2009

      • xlotlu
        that thing sounds disturbing
      • 2009-05-31 15148, 2009

      • chefkoch_ joined the channel
      • 2009-05-31 15159, 2009

      • chefkoch_
        chefkoch_ is now known as chefkoch
      • 2009-05-31 15109, 2009

      • _drtroll
        _drtroll is now known as drtroll
      • 2009-05-31 15112, 2009

      • lancerocke
        is there anyone i can speak to about using this image? http://www.last.fm/music/%5Bunknown%5D/+images/29…
      • 2009-05-31 15104, 2009

      • FauxFaux
        lancerocke: What?
      • 2009-05-31 15127, 2009

      • lancerocke
        FauxFaux: as the official image for unknown
      • 2009-05-31 15146, 2009

      • lancerocke
        FauxFaux: it says any attempt to upload another will 'blah blah blah'
      • 2009-05-31 15106, 2009

      • FauxFaux
        On last.fm..?
      • 2009-05-31 15121, 2009

      • lancerocke
        FauxFaux: so i uploaded that one and i wanna ask whoever about using that instead of the pixelized one thats up now
      • 2009-05-31 15126, 2009

      • lancerocke
        FauxFaux: yeah on last.fm
      • 2009-05-31 15113, 2009

      • FauxFaux doesn't know how last.fm works. :)
      • 2009-05-31 15136, 2009

      • lancerocke
        i see
      • 2009-05-31 15157, 2009

      • Alan_New has quit
      • 2009-05-31 15101, 2009

      • nikki_ joined the channel
      • 2009-05-31 15152, 2009

      • nikki has quit
      • 2009-05-31 15124, 2009

      • lancerocke has quit
      • 2009-05-31 15115, 2009

      • lancerocke joined the channel
      • 2009-05-31 15110, 2009

      • nikki_
        nikki_ is now known as nikki
      • 2009-05-31 15126, 2009

      • FauxFaux
        http://musicbrainz.org/search/textsearch.html?typ… errors in Chrome, and gets ?'d in Opera and IE.
      • 2009-05-31 15146, 2009

      • FauxFaux
      • 2009-05-31 15152, 2009

      • v6lur has quit
      • 2009-05-31 15158, 2009

      • aCiD2 joined the channel
      • 2009-05-31 15107, 2009

      • aCiD2
        luks: wb :)
      • 2009-05-31 15130, 2009

      • luks
        hi
      • 2009-05-31 15111, 2009

      • ramoz has left the channel
      • 2009-05-31 15102, 2009

      • aCiD2
        I've got some other patches done, but haven't submitted them
      • 2009-05-31 15114, 2009

      • aCiD2
        create/update/insert for labels and releases, very similar to the artist one
      • 2009-05-31 15126, 2009

      • aCiD2
        does that look like it's along the right lines?
      • 2009-05-31 15153, 2009

      • luks
        yes, the artist one looks great
      • 2009-05-31 15116, 2009

      • aCiD2
        cool, I had a play around with some different ways of doing it, but I figured the simple approach like this is best
      • 2009-05-31 15145, 2009

      • aCiD2
        I'd like to move AnnotationRole to Role::Annotation and use MooseX::Parameterized too
      • 2009-05-31 15140, 2009

      • luks
        I can't say I like having a global module for roles
      • 2009-05-31 15150, 2009

      • luks
        here is a reason: which AnnotationRole?
      • 2009-05-31 15111, 2009

      • luks
        we have two
      • 2009-05-31 15142, 2009

      • luks
        but +1 on using MooseX::Parameterized
      • 2009-05-31 15118, 2009

      • cyberpear joined the channel
      • 2009-05-31 15111, 2009

      • aCiD2
        what do you mean which annotationrole?
      • 2009-05-31 15129, 2009

      • aCiD2
        I mean the data one
      • 2009-05-31 15122, 2009

      • luks
        yeah, but what about the other one?
      • 2009-05-31 15135, 2009

      • cyberpea1 has quit
      • 2009-05-31 15139, 2009

      • aCiD2
        I'm not sure, I'd like to put that in Entity::Role::* as well
      • 2009-05-31 15102, 2009

      • luks
        I don't know, to me being role is an implementation detail
      • 2009-05-31 15110, 2009

      • luks
        and I prefer grouping code by functionality
      • 2009-05-31 15154, 2009

      • aCiD2
        I use the separation because that's what people seem to do on CPAN, and also because you can't instantiate a role
      • 2009-05-31 15158, 2009

      • aCiD2
        but we can leave it for now
      • 2009-05-31 15140, 2009

      • luks
        you know what I generally think about most people on CPAN, so I'm biased :)
      • 2009-05-31 15139, 2009

      • aCiD2
        hehe
      • 2009-05-31 15144, 2009

      • aCiD2
        it's minor anyway :)
      • 2009-05-31 15104, 2009

      • aCiD2
        so I'm not sure how to submit these patches to review board
      • 2009-05-31 15112, 2009

      • luks
        which ones?
      • 2009-05-31 15116, 2009

      • aCiD2
        It seems RB doesn't like patches made between branches
      • 2009-05-31 15129, 2009

      • aCiD2
        (ie, my labels branch is off my find_or_insert_names branch)
      • 2009-05-31 15134, 2009

      • aCiD2
        so the diff doesn't show up
      • 2009-05-31 15146, 2009

      • aCiD2
        I can submit them all against trunk, if you don't mind going through some duplication between patches
      • 2009-05-31 15120, 2009

      • aCiD2
        or I can try manually connecting to the server hosting code review, and fetch my remote branches - that might also fix it...
      • 2009-05-31 15121, 2009

      • luks
        you can submit one big patch containing all the code
      • 2009-05-31 15126, 2009

      • aCiD2
        you're ok with that?
      • 2009-05-31 15137, 2009

      • aCiD2
        it's not a huge amount I guess
      • 2009-05-31 15138, 2009

      • luks
        I think it's better than duplication
      • 2009-05-31 15151, 2009

      • luks
        or the inconsistency we have on RB right now
      • 2009-05-31 15151, 2009

      • aCiD2 nods
      • 2009-05-31 15153, 2009

      • aCiD2
        heh
      • 2009-05-31 15101, 2009

      • aCiD2
        I'll do that now and probably discard the other patches
      • 2009-05-31 15139, 2009

      • aCiD2_ joined the channel
      • 2009-05-31 15151, 2009

      • aCiD2_
        ok, submitted
      • 2009-05-31 15101, 2009

      • aCiD2_
        I'll update the patch as I add support for works, release groups and labels too
      • 2009-05-31 15123, 2009

      • luks
        aCiD2: do you know how can I get the value of $MB::S::Constants::FOO indirectly using $name="FOO"?
      • 2009-05-31 15108, 2009

      • aCiD2 has quit
      • 2009-05-31 15112, 2009

      • aCiD2_
        not sure I quite follow
      • 2009-05-31 15129, 2009

      • aCiD2_
        oh, you want to get the value of a constant from a variable name?
      • 2009-05-31 15141, 2009

      • aCiD2_
        like MB::S::Constants::$name ?
      • 2009-05-31 15104, 2009

      • luks
        that doesn't seem to work
      • 2009-05-31 15131, 2009

      • aCiD2_
        hrm
      • 2009-05-31 15139, 2009

      • aCiD2_
        but that's what you want to do, right?
      • 2009-05-31 15154, 2009

      • luks
        yes
      • 2009-05-31 15156, 2009

      • aCiD2_
        I think you might have to use globs, but I'm not quite sure how
      • 2009-05-31 15158, 2009

      • aCiD2_
        I'll have a play
      • 2009-05-31 15111, 2009

      • luks
        byt every solution I can think of assumes a function, not a variable
      • 2009-05-31 15149, 2009

      • luks
        the obvious ugly eval trick works, but I guess there must be a better way :(
      • 2009-05-31 15124, 2009

      • aCiD2_
        heh, as I figured asking in #perl just gets "you don't want to do that"
      • 2009-05-31 15156, 2009

      • pronik``` has quit
      • 2009-05-31 15146, 2009

      • luks
        that's the standard answer you would get in any irc channel :)
      • 2009-05-31 15140, 2009

      • aCiD2_
        well it is pretty weird, is this really the best way to do whatever you're doing?
      • 2009-05-31 15145, 2009

      • aCiD2_
        screams php to me :)
      • 2009-05-31 15149, 2009

      • luks
        this is for edits
      • 2009-05-31 15103, 2009

      • aCiD2_
        right, but where?
      • 2009-05-31 15104, 2009

      • luks
        everything seems better decentralized in edit classes
      • 2009-05-31 15116, 2009

      • luks
        but the edit ID should be probably defined globally
      • 2009-05-31 15131, 2009

      • luks
        er, I mean edit type ID
      • 2009-05-31 15132, 2009

      • aCiD2_
        can you paste the relevent function where you're trying to do it (even if it doesn't compile)
      • 2009-05-31 15104, 2009

      • luks
        equivalent of Moderation::Type
      • 2009-05-31 15119, 2009

      • luks
      • 2009-05-31 15119, 2009

      • aCiD2_
        ok
      • 2009-05-31 15137, 2009

      • aCiD2_
        ah I see...
      • 2009-05-31 15148, 2009

      • aCiD2_
        I dunno, I think the type ID is a property of a type itself
      • 2009-05-31 15102, 2009

      • aCiD2_
        but then there's no guarantee of uniqueness
      • 2009-05-31 15111, 2009

      • luks
        I would agree, but it's harder to manage
      • 2009-05-31 15115, 2009

      • aCiD2_
        also, do we really have to have the same naming system...
      • 2009-05-31 15119, 2009

      • aCiD2_
        EDIT_ARTIST_NAME was ugly as hell
      • 2009-05-31 15129, 2009

      • aCiD2_
        why can't we just have Edit::Artist::Create, Edit::Artist::Update
      • 2009-05-31 15133, 2009

      • Infinito has quit
      • 2009-05-31 15157, 2009

      • luks
        I don't know, I think of them as IDs, not class names
      • 2009-05-31 15124, 2009

      • aCiD2_
        They are still objects though
      • 2009-05-31 15153, 2009

      • luks
        they are, but you have an unique way to refer to them
      • 2009-05-31 15128, 2009

      • aCiD2_
        When I did edits in my rewrite, I had edits layed out as I said, and a factory to create them from ID
      • 2009-05-31 15155, 2009

      • luks
        is the code somewhere I can see it?
      • 2009-05-31 15159, 2009

      • aCiD2_
        The ID was defined in the edit type, but you could still easily lookup a type with an ID
      • 2009-05-31 15103, 2009

      • aCiD2_
        yea, let me find it
      • 2009-05-31 15112, 2009

      • aCiD2_
        at least, that's what I wanted to do, I'm pretty sure I actually did it :P
      • 2009-05-31 15113, 2009

      • luks
        the thing is, I'd like to only rewrite as little as possible for now
      • 2009-05-31 15152, 2009

      • luks
        we agreed that the edit system needs a major rewrite
      • 2009-05-31 15108, 2009

      • luks
        in which we will break the current model
      • 2009-05-31 15139, 2009

      • aCiD2_
        Hmm, seems I didn't get round to writing the factory
      • 2009-05-31 15104, 2009

      • aCiD2_
        We'd rewrite it, but it would still use the same schema, no?
      • 2009-05-31 15129, 2009

      • aCiD2_
        I dunno, I think I'd still like to do the major rewrite now - seeing as we're majorly rewriting other stuff
      • 2009-05-31 15131, 2009

      • luks
        which rewrite you mean now?
      • 2009-05-31 15140, 2009

      • aCiD2_
        rewriting the edit system code