#musicbrainz

/

      • ruaok
        What??

        • 2005-04-05 09530, 2005

      • djce
        http://test.musicbrainz.org/mod/search/results.ht…

        • 2005-04-05 09537, 2005

      • ruaok
        Grrr.

        • 2005-04-05 09500, 2005

      • ruaok
        Lemme find the spot.

        • 2005-04-05 09501, 2005

      • djce wonders if it's another CVS fsck-up

        • 2005-04-05 09503, 2005

      • djce
        k

        • 2005-04-05 09548, 2005

      • ruaok
        comp/entermods line 13

        • 2005-04-05 09503, 2005

      • ruaok
        I wonder if there are mods that don't use comp/entermods

        • 2005-04-05 09559, 2005

      • ruaok
        nope, that uses it.

        • 2005-04-05 09518, 2005

      • ruaok
        did you see the nag message about entering your email addy before you added the mod?

        • 2005-04-05 09546, 2005

      • djce
        The problem is that "email_nag" is false for new accounts.

        • 2005-04-05 09556, 2005

      • djce
        At least, that's what I'm seeing.

        • 2005-04-05 09520, 2005

      • ruaok
        that would cause this problem, yes.

        • 2005-04-05 09517, 2005

      • djce
        Why not just use if (User->Current->GetEmail) (or something)

        • 2005-04-05 09523, 2005

      • djce
        instead of testing email_nag?

        • 2005-04-05 09501, 2005

      • ruaok
        the no-email warning was keyed off that, so I followed suit.

        • 2005-04-05 09502, 2005

      • djce
        i.e.

        • 2005-04-05 09504, 2005

      • ruaok
        should we change to that?

        • 2005-04-05 09514, 2005

      • djce
        I think so.

        • 2005-04-05 09521, 2005

      • djce
        Lemme hack it together.

        • 2005-04-05 09500, 2005

      • ruaok
        sweet, thanks.

        • 2005-04-05 09532, 2005

      • somniloquy
        somniloquy is now known as somnolent

        • 2005-04-05 09536, 2005

      • djce
        You know, I think the answer is to simply ditch the "email_nag" field altogether.

        • 2005-04-05 09556, 2005

      • ruaok
        ok

        • 2005-04-05 09500, 2005

      • djce
        My "fix" started out as adding a "has_confirmed_email" flag, which is just a cache of:

        • 2005-04-05 09506, 2005

      • djce
        ($user->GetEmail ? 1 : 0)

        • 2005-04-05 09524, 2005

      • djce
        then I noticed that once I'd done that, email_nag was now totally unused!

        • 2005-04-05 09543, 2005

      • djce
        So the only change is this:

        • 2005-04-05 09503, 2005

      • djce
        previously, if you entered an email address (but the verification was pending), you didn't get nagged.

        • 2005-04-05 09511, 2005

      • djce
        So I'm proposing that you do get nagged.

        • 2005-04-05 09516, 2005

      • djce
        until the verification arrives.

        • 2005-04-05 09521, 2005

      • djce
        Does that sound OK?

        • 2005-04-05 09513, 2005

      • ruaok
        yes

        • 2005-04-05 09554, 2005

      • djce
        ok, almost ready then

        • 2005-04-05 09526, 2005

      • djce
        ok, all done

        • 2005-04-05 09540, 2005

      • Russss has left the channel

        • 2005-04-05 09548, 2005

      • ruaok
        awesome.

        • 2005-04-05 09554, 2005

      • djce
        ok, I'm all done with the release notes now. I've updated grunt.

        • 2005-04-05 09504, 2005

      • ruaok goes to read

        • 2005-04-05 09543, 2005

      • djce
        http://cvs.musicbrainz.org/cvs/mb_server/htdocs/n…

        • 2005-04-05 09511, 2005

      • ruaok
        its really taking shape now...

        • 2005-04-05 09522, 2005

      • djce
        yeah - exciting :-)

        • 2005-04-05 09522, 2005

      • ruaok
        I'll go fix your artist edit related issues later tonight

        • 2005-04-05 09530, 2005

      • djce
        it's looking promising for a release at the weekend.

        • 2005-04-05 09538, 2005

      • ruaok is elated to hear that

        • 2005-04-05 09550, 2005

      • djce
        "never" approaches! :-D

        • 2005-04-05 09554, 2005

      • ruaok
        lol

        • 2005-04-05 09556, 2005

      • ruaok
        indeed!

        • 2005-04-05 09503, 2005

      • ruaok
        Hell is feeling a bit... chilly!

        • 2005-04-05 09538, 2005

      • ruaok
        So, it looks like I will be in the UK again.

        • 2005-04-05 09543, 2005

      • ruaok
        May 4th - 9th.

        • 2005-04-05 09508, 2005

      • ruaok
        I'm wondering if I should gather the brainzers back to Old Thamesside.

        • 2005-04-05 09517, 2005

      • ruaok
        'twas a good evening.

        • 2005-04-05 09539, 2005

      • djce
        Agreed !

        • 2005-04-05 09555, 2005

      • djce
        g'night all

        • 2005-04-05 09502, 2005

      • djce has quit

        • 2005-04-05 09544, 2005

      • Pipian joined the channel

        • 2005-04-05 09524, 2005

      • tro joined the channel

        • 2005-04-05 09547, 2005

      • rjmunro has left the channel

        • 2005-04-05 09501, 2005

      • inhouseuk_ joined the channel

        • 2005-04-05 09502, 2005

      • inhouseuk has quit

        • 2005-04-05 09510, 2005

      • Coeus has quit