just have to fix the tagger a bit, so i can list only "recognized" songs
hmm... the trm fingerprint can actually be an obstacle now :\
cikkolata
hmm?
canidae
well, my mods really just pays more attention to metadata, and compares it with the results mb gives it, but if the trm match another song (which many do) then tp may not get those "sane" results it should have
lgonze has quit
wohohoho :D
i think i like this alot =)
cikkolata
:)
canidae
aswell as it would be good to pick out the "correct" album if it looks up a song on a va-cd :)
i'm running it on the archive where tp haven't found a match earlier... so far 10% of the songs gets a match =)
and all those i've checked out are tagged correct!
cikkolata
cool :)
if it were me, it would just have segfaulted a lot :P
canidae
haha
:)
look at this: 233: Recognized, 40%: /export/musikk/usortert/Mp3/!!!O-ZONE - Dragostea Din Tei.mp3
40% trm similarity
atm my threshold is 80%. the method i implement adds max 64 to the trm, so theoretically it can find a trm match on 16%, and still figure out which song it is :)
Knio
Knio is now known as Knio-dinner
canidae
i changed the algorithm a bit... made it pay even more attention to the metadata... it should get even more hits now, let's see if it gets the right songs...
ruaok
canidae: I accepted your patch just now.
canidae
great :)
i'm hoping to get the stuff i'm working on now even better, and if i succeed, you'll have a patch that'll be _much_ more useful than that last one :)
ruaok
ok...
ruaok is curious
sysrq has quit
sysrq joined the channel
cikkolata
gah
I hate random nose bleeds
ruaok
drink more water.
canidae
i think that's hillarious :)
cikkolata
if I drink more water I'll really need to piss
and if I make too much noise perl will shift herself off my pillow and refuse to be cute when I want to sleep.
on good days she'll sleep next to me all the time I'm asleep :)
canidae
woha... that little changed increased the hitrate to somewhere between 25-30% =)
cikkolata
cool
canidae
now i gotta check those files if they got sane tags aswell...
yeah, looks good :)
ruaok: i'm thinking of removing the "filelookup"-thread. imho it's not really necessary as you can do a "filelookup" in the "lookup"-thread if the trm-lookup don't find a match... any thoughts on this?
ruaok
I'm confused. These threads exist:
defs.h:#define TP_THREAD_ANALYZER 0x0010
which one do you want to nuke?
canidae
TP_THREAD_LOOKUPFILE
Knio-dinner
Knio-dinner is now known as Knio
ruaok
so what happens if the TRM for a file is not found?
canidae
well, the thread does some important stuff, but why does it have to be an own thread? why can't that be done in TP_THREAD_LOOKUPTRM (and rather rename it TP_THREAD_LOOKUP)?
ruaok
you're saying to combine LOOKUP and LOOKUPTRM ?
canidae
yes
ruaok
yes, its possible to do that.
but why do you want to do it>?
wait, no.
Picard, uses lookup, but not lookuptrm
keeping them seperate makes sense to me.
I don't want tie libtp to TRM only
canidae
it's not to "tie" tp to trm only, it's rather getting rid of a thread. those two threads do the same thing, but use different methods and those threads doesn't even really run simultanuosly (argh, hard word). i don't see what you'll lose by merging those two
ruaok
independence and cleanliness of design is what we loose.
plus your concept violates an important rule of mine: don't fuck with debugged code
:-)
canidae
heh
cikkolata giggles
ruaok
but, your thinking is not all wrong.
if threads were indeed expensive, you might really have a good argument.
canidae
it's not the cost i worry about. it's rather the locking of tracks that is a problem. aswell as i've been taught not to use threads unless it's absolutely necessary. however, give me enough time and i will convince you! :)
(right now i'm actually not using that thread at all, and i got more hits aswell as run less queries against mb) :)
709: Recognized, 25%: /export/musikk/usortert/gammel_soci_musikk_2/90-talls/Marilyn Manson - Rock Is Dead.mp3
:D
canidae giggles madly
ruaok
ok, what am I looking at?
canidae
heh. that's the output of tp-tagger
only using trmlookup, and parsing the result i get from that, that's what the modified tunepimp guess is the right tracks
ruaok
ok.
canidae
ooh, think i finally found one track that was tagged wrong...
but that's not really my mods fault... the trm similarity was 78%
rwilco joined the channel
rwilco has left the channel
sandeen__ joined the channel
sandeen__
is there yet any unix-y app to query and/or seed musicbrainz w/ TRM?
hm, although since all my metadata came from allmusic.com I suppose I should not help seed....
canidae
sandeen__: hey... i'm afraid i'm heading to bed now, but there's an example program you can check out. it's called "tp-tagger" and comes with libtunepimp
it let's you do some basic stuff like matching tracks using trm/metadata aswell as it gives you the oppertunity to upload trm's. it's not very userfriendly, though
right then, i'm supposed to get up again in a bit more than 4 hours, so i really have to go. i hope this helps a bit, though :)
sandeen__
ok, thanks - also found the "picard" tagger, didnt' see that last time I was looking around
sandeen__ has quit
lgonze joined the channel
Knio
Knio is now known as Knio-sleep
orogor joined the channel
rj_ joined the channel
cikkolata sighs
cikkolata
I knew I subscribed to all those turkish artists for a reason
I wonder if that would work on half of my stuff though :P
canidae
depends on your metadata/filename
i don't know how well it works on utf-8 :p
cikkolata
you need a comparison of what it gets right/wrong before and afterward :P
hmm... afterwards.
BalthCat has quit
Planar joined the channel
PlanarPlatypus has quit
somnolent
somnolent is now known as somniloquy
dupuy joined the channel
DJKC
mmm, sometimes I wonder if I shouldn't have been a lawyer. I show a talent at persuading people to see my point of view by interpreting the styleguidelines so that things get left the way I want them -_-;;;
cikkolata
oh?
Sen joined the channel
DJKC
cikkolata: don't have the mod numbers handy, look at namie's mods page for the discussion
Sen
whats going on, everyone
alrighty
cikkolata
not a lot
as always
Sen
indeed
DJKC
pretty much.
I'm just contemplating lunch and listening to half a soundtrack that I'm starting to obsess over
Sen
wanna help me figure out how to fix an album i listed?