the annotations stuff is pretty isolated from the rest of the code
2004-06-07 15922, 2004
djce
tma: did your CVS access work?
2004-06-07 15945, 2004
djce
andyg: hi
2004-06-07 15948, 2004
tma
yalaforge: could you perhaps show the last three edit notes, and date them? and have the "show history" link down there as well, as a "show more history" or something. Also, if that lower section could have a header to clearly say that it's the edit history..
2004-06-07 15910, 2004
tma
djce: I haven't tried it yet. I'll let you know.
2004-06-07 15913, 2004
djce
ok
2004-06-07 15904, 2004
yalaforge
having dates on the notes is not possible, I'm afraid. our notes system doesn't store creation dates :-(
2004-06-07 15916, 2004
tma
hmm
2004-06-07 15925, 2004
andyg
djce : hey
2004-06-07 15930, 2004
tma
can you embed the date in the note at creation time?
2004-06-07 15959, 2004
djce
hi andyg. By any chance, have you got multiple versions of "Match.pl" as it progressed through your changes?
2004-06-07 15906, 2004
yalaforge
yes, but then they'd show up in the moderation history which would break things
2004-06-07 15925, 2004
yalaforge
the problem is that the notes are just ordinary moderation notes
2004-06-07 15926, 2004
andyg
I have one other version, right before I went to do the VA matching stuff
2004-06-07 15931, 2004
tma
sucky
2004-06-07 15935, 2004
yalaforge
yup
2004-06-07 15937, 2004
tma
moderation notes should have a timestamp
2004-06-07 15947, 2004
djce
andyg: ok, that sounds useful. Could you send it through? or a patch?
2004-06-07 15947, 2004
yalaforge
right.
2004-06-07 15901, 2004
andyg
you don't like the VA code? :)
2004-06-07 15902, 2004
yalaforge
tma: you could file an RFE
2004-06-07 15915, 2004
tma
yalaforge: yes, I could. would you like me to? :)
2004-06-07 15919, 2004
yalaforge
as soon as it is implemented, annotation notes have the timestamps automatically
2004-06-07 15927, 2004
yalaforge
tma: yup
2004-06-07 15928, 2004
djce
It's not that I don't like it. But your patch file includes changes to many parts of the script, for many reasons.
2004-06-07 15949, 2004
djce
Ideally there would have been one patch file per change, making it possible to understand what's going on.
2004-06-07 15959, 2004
tma
djce: oh, did you have a chance to see if sourceforge stuff can be assigned to me?
2004-06-07 15915, 2004
djce
tma: no. let me go look now.
2004-06-07 15920, 2004
djce
user "melange", right?
2004-06-07 15927, 2004
tma
'tma'
2004-06-07 15929, 2004
djce
ok
2004-06-07 15934, 2004
tma
oh
2004-06-07 15936, 2004
tma
hang on
2004-06-07 15940, 2004
tma
bzzt
2004-06-07 15945, 2004
tma
brain not working
2004-06-07 15957, 2004
tma
"tarragon_allen" or "tarragonallen"
2004-06-07 15908, 2004
tma
gimme a sec and I'll confirm
2004-06-07 15940, 2004
andyg
ah, sorry, I guess I should really run my own CVS server for development
2004-06-07 15948, 2004
andyg
I'll send you a patch from this version
2004-06-07 15952, 2004
djce
underscore it is.
2004-06-07 15958, 2004
djce
andyg: thanks
2004-06-07 15901, 2004
yalaforge
ok, now we have 'add comment' links
2004-06-07 15934, 2004
tma
comment is much better, as the annotation is already a note .. it's confusing having an annotation and a note. :)
2004-06-07 15945, 2004
yalaforge
yup :-)
2004-06-07 15904, 2004
yalaforge
we need the great renaming. some day
2004-06-07 15931, 2004
tma
Musicbrainz 3: The Great Renaming. In cinemas now. Rated PG.
2004-06-07 15936, 2004
yalaforge
lol
2004-06-07 15914, 2004
yalaforge
that is going to suck. changing only the website will leave the code with the old terminology
2004-06-07 15939, 2004
yalaforge
but, fortunately, we don't have the terminology ready, so no danger *eg*
2004-06-07 15902, 2004
andyg
djce: sent
2004-06-07 15903, 2004
tma
as long as we all know what we mean
2004-06-07 15917, 2004
djce
tma: you're now a member of the MB SF project. bugs etc can be assigned to you.
2004-06-07 15934, 2004
tma
djce: excellent. :)
2004-06-07 15936, 2004
tma
thanks
2004-06-07 15938, 2004
djce
I don't understand SF's permissions, so I erred on the side of giving you too many :-)
2004-06-07 15938, 2004
yalaforge
hehe. hope you enjoy it ;->
2004-06-07 15952, 2004
tma
probably another RFE: "send email" and "show profile" icons to be displayed next to the users name rather than having seperate links all over the place
2004-06-07 15904, 2004
yalaforge
you mean in the moderation view?
2004-06-07 15906, 2004
tma
yalaforge: the annotation system looks good, I'd place some of the links a little differently but otherwise it looks good and works well
2004-06-07 15917, 2004
yalaforge
tma: thanks
2004-06-07 15930, 2004
tma
yalaforge: I mean pretty much anywhere that has a profile link already..
2004-06-07 15930, 2004
yalaforge
where do you want the links to go?
2004-06-07 15958, 2004
tma
I think "show history" and "add comment" should be at the bottom, with the comments
2004-06-07 15926, 2004
yalaforge
below the comments or above?
2004-06-07 15929, 2004
tma
the "send email" should be next to the Editor's name, (last edited by <Editor>) but that's what prompted the Icon idea
2004-06-07 15913, 2004
yalaforge
what about the edit button? leave it at the top line?
2004-06-07 15916, 2004
tma
above is probably better, and if you can show, say, the last three comments, that would give an idea of history
2004-06-07 15901, 2004
tma
I'm guessing it wouldn't be easy to get those links at the same level as the comment itself
2004-06-07 15910, 2004
tma
ie:
2004-06-07 15901, 2004
tma
"melange: fixed some typos [Add comment] [Show History]
2004-06-07 15953, 2004
yalaforge
hm. don't know
2004-06-07 15914, 2004
yalaforge
djce: what do you think?
2004-06-07 15929, 2004
djce
how far back should I read?
2004-06-07 15931, 2004
yalaforge
move 'Send Email' next to the moderators name?
2004-06-07 15938, 2004
tma
maybe only Add Comment needs to be there. Edit and Show History might be better together..
yalaforge: is the add comment really required at all?
2004-06-07 15952, 2004
yalaforge
tma: nope
2004-06-07 15910, 2004
djce looks: ok I see it.
2004-06-07 15916, 2004
tma
yalaforge: it might be better to scrap it, as it is rather confusing, and of limited value I think
2004-06-07 15943, 2004
yalaforge
removed
2004-06-07 15926, 2004
tma
and maybe, just to reduce clutter, the edit notes should only be displayed in the Show History page. someone casually looking at the album doesn't really need to see the revision history right there
2004-06-07 15940, 2004
djce
I have an idea about the "send email" links, in case you're up for a challenge :-)
2004-06-07 15959, 2004
yalaforge
uh, do tell
2004-06-07 15915, 2004
djce
ok. It involves funky Javascript and DHTML stuff
2004-06-07 15921, 2004
yalaforge
nooo
2004-06-07 15928, 2004
djce
but those without just have to click a couple of extra times.
2004-06-07 15937, 2004
djce
which I think is fine, personally.
2004-06-07 15901, 2004
djce
Such technologies should be used to enhance the user experience,
2004-06-07 15915, 2004
tma
is it like a menu-popup thing?
2004-06-07 15917, 2004
djce
but it should always be possible to achieve the same ends without them.
2004-06-07 15919, 2004
djce
Exactly.
2004-06-07 15922, 2004
djce
here's the plan:
2004-06-07 15932, 2004
tma needs coffee, brb
2004-06-07 15932, 2004
djce
write your HTML like this:
2004-06-07 15904, 2004
djce
<a href="...." class="ModeratorLink">djce</a>
2004-06-07 15916, 2004
djce
so without JS, it's just a link to their profile page.
2004-06-07 15937, 2004
djce
then in each document load dofunkystuff.js
2004-06-07 15938, 2004
yalaforge
ok
2004-06-07 15959, 2004
djce
when dofunkystuff.js loads, it uses DOM to find tags with class=ModeratorLink
2004-06-07 15919, 2004
djce
and inserts an <img> after <a> but before "djce".
2004-06-07 15935, 2004
djce
hmm.. or maybe before the <a> or something.
2004-06-07 15950, 2004
djce
anyway, clicking on that icon then brings up a popup DHTML thing
2004-06-07 15958, 2004
djce
kind of a context menu for a moderator.
2004-06-07 15904, 2004
djce
Profile, Send Email, etc.
2004-06-07 15922, 2004
djce
Clearly, the same can be applied to artists, albums, tracks, whatever.
2004-06-07 15923, 2004
yalaforge
hm, and why do I need DHTML or javascript for that?
2004-06-07 15937, 2004
yalaforge
I can always open a new browser window, like it is done with the style guide
2004-06-07 15914, 2004
djce
True.... I was thinking more like a pseudo-popup, so the context menu is part of the same window.
2004-06-07 15939, 2004
yalaforge
well, if you want to do some experiments ...
2004-06-07 15941, 2004
djce
the advantage of DHTML/JS is that the HTML can remain lightweight.
2004-06-07 15953, 2004
yalaforge isn't eager to struggle with DHTML or JS
2004-06-07 15901, 2004
djce
instead of all the links including "onclick" and "target" etc.
2004-06-07 15905, 2004
yalaforge
perl is bad enough
2004-06-07 15923, 2004
djce
Well, if anyone reads this and fancies a challenge in that area, there it is :-)
2004-06-07 15925, 2004
ruaok
groan.
2004-06-07 15929, 2004
ruaok
morning kids.
2004-06-07 15932, 2004
yalaforge
someone could implement a framework for that
2004-06-07 15938, 2004
tma
morning rob
2004-06-07 15940, 2004
djce
hey ruaok. groan?
2004-06-07 15942, 2004
yalaforge
hi
2004-06-07 15944, 2004
ruaok hada long weekend that required an emergency mid-day nap
