still a bit of a work in progress, it doesn't deal well with plugins that change the metadata right now, I think
2014-07-15 19643, 2014
kepstin-laptop
or rather, with anything that edits the metadata after the info is downloaded
2014-07-15 19606, 2014
kepstin-laptop
I added some ui code to keep the ui in sync, but that just makes it obvious when the changes get lost :)
2014-07-15 19611, 2014
kepstin-laptop
basically, every time a file is associated or dissociated with a track, it has to reset the metadata on the track to the 'original' state, merge file metadata iff a file is associated, and re-run taggerscript
2014-07-15 19622, 2014
kepstin-laptop
and edits are done after the tagger script is run
2014-07-15 19650, 2014
pinnerup joined the channel
2014-07-15 19606, 2014
kepstin-laptop
to make edis somewhat persistant, I need to add an additional layer of saved info, which is basically a record of manual/plugin edits made, so they can be re-applied after associating/dissociating a file.
2014-07-15 19622, 2014
hawke
So…what does it do? Let you access file metadata instead of just MB metadata?
2014-07-15 19605, 2014
chirlu` joined the channel
2014-07-15 19616, 2014
kepstin-laptop
yes. it allows you to use the existing values of metadata read from a file in tagger script
2014-07-15 19640, 2014
hawke
Seems good.
2014-07-15 19644, 2014
Clint joined the channel
2014-07-15 19645, 2014
Clint joined the channel
2014-07-15 19649, 2014
kepstin-laptop
(including stuff like extension, filename, etc.)
2014-07-15 19656, 2014
nioncode joined the channel
2014-07-15 19605, 2014
hawke
Shouldn’t that just be a matter of dropping the 'new' metadata?
2014-07-15 19617, 2014
hawke
I mean, it *displays* the old metadata anyway.
2014-07-15 19656, 2014
kepstin-laptop
in the current picard, tagger script is run when the info is downloaded from musicbrainz, well before any files are associated
2014-07-15 19633, 2014
kepstin-laptop
so there's no file metadata for it to see, so naturally you can't use metadata from the file in tagger script
2014-07-15 19646, 2014
kepstin-laptop
my patches change up the whole order of when tagger script is run
2014-07-15 19613, 2014
kepstin-laptop
the initial patch only moved it to run during file save time, which worked great - except that tagger script changes no longer appeared in the preview
2014-07-15 19659, 2014
kepstin-laptop
so now to make the preview work, I have to run it a bit earlier - and to make various other things work, that meant keeping a shadow copy of the original metadata so I could undo the tagger script.
2014-07-15 19641, 2014
kepstin-laptop
but when you make manual edits to tags, that's done using the post-tagger script metadata as a starting point, and does futher edits on top of that.
2014-07-15 19648, 2014
hawke
I just feel liek that shadow copy should be there anyway for display in the 'original data' section. *shrug*
2014-07-15 19605, 2014
kepstin-laptop
original data section is the data currently in the file
2014-07-15 19608, 2014
kepstin-laptop
no extra copy needed
2014-07-15 19616, 2014
Rovastar joined the channel
2014-07-15 19601, 2014
kepstin-laptop
hmm, actually it does store file original data.
2014-07-15 19608, 2014
kepstin-laptop
ok, in current picard there's three copies of data
2014-07-15 19625, 2014
kepstin-laptop
file original data, musicbrainz original data, and file updated data
2014-07-15 19650, 2014
hawke
I was gonna say…it wouldn’t make much sense to re-read the file metadata each time you looked at it or whatever.
2014-07-15 19617, 2014
kepstin-laptop
actually - that's not quite right
2014-07-15 19635, 2014
kepstin-laptop
it actually stores file original data, musicbrainz data with tagger script and plugin modifications, and file updated data
2014-07-15 19605, 2014
kepstin-laptop
process of associating a file is simply taking the file original data, merging the musicbrainz data on top, and saving that as the file updated data
2014-07-15 19627, 2014
kepstin-laptop
it gets way more complicated with my patch :/
2014-07-15 19604, 2014
kepstin-laptop
since I want to run the tagger script after associating the file, that means that I can't run it before associating the file
2014-07-15 19628, 2014
kepstin-laptop
but if I don't run it before associating the file, then the tagger script isn't reflected in the UI for tracks that don't have files associated
2014-07-15 19650, 2014
kepstin-laptop
so I had to add a fourth copy of metadata, which is the musicbrainz data prior to tagger script running.
2014-07-15 19616, 2014
kepstin-laptop
the new file associating path is to take the file original data, merge the musicbrainz original data, run tagger script, then save as file updated data
2014-07-15 19607, 2014
kepstin-laptop
if you made manual edits before associating a file, those were made to the "musicbrainz data with tagger script" copy which is for display only, and your edits won't be copied to the file on association
2014-07-15 19629, 2014
hawke
Makes sense — it "feels" more complicated than it needs to be, but maybe it does.
2014-07-15 19610, 2014
kepstin-laptop
(if you make manual edits after a file is associated, it edits the "file updated data" directly, which works fine)
2014-07-15 19627, 2014
kepstin-laptop
normal metadata plugins work fine, too, since the hook for those is still on data load, and their changes get saved into the "musicbrainz original data"
2014-07-15 19646, 2014
kepstin-laptop
(metadata plugins have the same issue as old tagger script - they can't see any information from the files)
2014-07-15 19657, 2014
JoeLlama joined the channel
2014-07-15 19657, 2014
hawke
Does it bother anyone else that Picard has the menu item “options→options”?
2014-07-15 19623, 2014
reosarevok_
haha
2014-07-15 19628, 2014
reosarevok_
Bother is a bit strong
2014-07-15 19640, 2014
reosarevok_
But it's a bit weird
2014-07-15 19623, 2014
hawke
Heh, I can’t think of a similar word that is less strong for me. :-)
2014-07-15 19644, 2014
hawke
annoy, irritate, bug…those all feel stronger.
2014-07-15 19657, 2014
reosarevok_
Heh
2014-07-15 19607, 2014
reosarevok_
I'd say it surprises me, except that it does not, not anymore :p
2014-07-15 19615, 2014
reosarevok_
Yeah, dunno what I'd use :D
2014-07-15 19651, 2014
hawke
It usually gets me when I’m trying to explain it to someone else
2014-07-15 19609, 2014
hawke
'go into options, now into options…'
2014-07-15 19610, 2014
hawke
I feel like it should maybe be Edit→Preferences
2014-07-15 19642, 2014
hawke
but at the same time, having an 'options' top-level menu means that it's the only good place to put it
2014-07-15 19644, 2014
djpretzel joined the channel
2014-07-15 19658, 2014
hawke
and the other items in the options menu feel like they belong there.
Hi! I just added a Turkish compilation. But I don't speak Turkish and I don't know any of the artists. Can one of you help with spelling, capitalization, etc.?http://musicbrainz.org/release/f20003b1-8c8a…
