#musicbrainz

JoanW: odd, though I'm not sure reinstalling will fix anything if your key is somehow invalid

yeah, I'd read somewhere or other that the WGA code gives a false reading of piracy like 15 to 20% of the time, for legit codes

you can actually generate valid keys, it's quite easy

I have the CDs that I got with the computer plus a CD for Service Pack 2. When I got the laptop it didn't have anything installed at all and I had to do the complete installation.

How can you generate valid keys?

with a keygenerator, though it's not precisely legal :p

The strange thing is that even though they have sent me this message and it is permanently showing at the bottom of the screen, everything still works fine

Anyway, I have copied the programs I want to keep, plus everything that is in the My Documents section on to a disc, so they can be reinstalled if I go ahead with the complete reinstallation.

how long has it been since you last installed Windows?

March 2008

well, you could probably get yours working with a "legit" keycode - but if it's been 10+ months, like that, you've probably got so much bork cluttering up Windows, you might get a slighty more responsive (ie, non-loaded with bork) Windows by simply doing the reinstall

I am inclined to agree with you - I have kept all that I want and having to do this at least makes you clear out the clutter

Ruaok - why are the Edits for Subscribed artist notifications coming through 12 hours later than they normally do

Nor a link to just edit the release attributes/status at the bottom of the release page.

brianfreud: Can I include minor/trivial text formatting, like including a comma or colon in the same ticket as the capitalization fixes?

do your best to atomize bug tickets, whereever you can

(within reason)

Sorry, not sure what you mean by that :s

I can think of two explainations, but they're completely opposite :p

break them down into the smallest reasonable bits - if /foo/bar.html has comma and spelling issues, all on one ticket is fine; but don't give "comma is missing here on foo/bar, here on foo/baz, and here on foo/smegh" as a single ticket

otherwise it's hard to close that ticket without fixing all three totally different files, rather than just the one

Ok, so keep things ticketed by page?

The capitalization fixes are for the release page and the artist page, as would the comma/colon fixes.

by page & type of issue - keep typos separated from missing fields, for example

I don't know if they would be in the same file though.

file = page, for the most part

when in doubt, separate them :)

easier to close two with one patch, than to not close one because it needs two patches

Okay, I think I get it.

thanks for your help - off to bed. Natta

On a side note, are Disc IDs supposed to link to a /cdtoc/#### page?

natta JoanW

navap: last I heard, the entire cdtoc part of tt was still a WIP

Okay

Have we ever considered displaying the Disc ID in caps?

Eeeeeeeeeeeew.

FauxFaux: Spot a mouse or something?

Maybe a big spider? :p

If I wanted to submit a patch, how would I go about doing it?

It's one file I want to edit, and I know which/where the file is.

Make a ticket, explain what the patch does, attach the .diff

If it's sane, someone with SVN access will apply it and say so within the ticket

How would I create the patch in the first place though :s

"svn diff" in the root of your working copy.

svn diff > lolcocks.diff

Then upload lolcocks.diff

lolcocks isn't just an example here, it actually has to be called lolcocks.diff or it won't get applied.

So I have to get a local copy of the source before I can create the patch?

FauxFaux: I maybe be stupid at time, but I'm not that stupid..jeez

Of the directory containing the file you want to edit, yeah.

I'm sure someone out there would fall for that though hahaha

How else do you expect to edit the file you want to?

< navap> It's one file I want to edit, and I know which/where the file is. # Heh.

Thats how I know which/where it is.

What's wrong with it, anyway?

I could just edit and check it straight in heh

But if I tell you, you'll go and edit it, and I won't get a chance to figure all this out :(

svn co http://svn.musicbrainz.org/mb_server/branches/T...; edit the file and save it; svn diff

As you now go start disecting it word by word :p

Clearly link to the right bit of the wiki.

The English is shit? Must be acid2 that wrote it originally. ¬_¬

Written in North.

"the page ur lookin for like is nae ere. nae fuck off fore i glass ye, ye bastid."

So should I use something like ToroiseSVN?

Noes. D:

I'm on Windows, what would you recommend?

TortoiseSVN, unless your machine hates shell extensions. ¬_¬_¬_¬_¬

Something that will run on Cygwin instead?

The official windows binaries of subversion are fine, no need for cygwin, but tortoise is good.

Cygwin has subversion, if you already have cygwin grab that.

Otherwise, grab the Windows binaries, just promise that you'll use it from the command line though.

I'm on a fresh install of Windows, so I have to install Cygwin anyway, might as well do it that way.

TortoiseSVN is sooo much more pro. ¬_¬

Lies.

There are a couple different versions with different bindings, perl, python, ruby.

Plain old subversion is fine.

A cat is fine too..

A tasty cat./

That's some delicious cat anus.

Such fail. Just tried to pick up and answer my phone whilst wearing my headphones.

Jelico cats?

aCiD2: ping?

3am UK. :P

It's closer to 4, than it is 3. \o/

lol, but tis aCiD2 :P

He's not pro enough to be awake at pro-hour.

Indeed he is not.

Muz: you have svn access, right?

brianfreud: yes

been trying for 2 hours to figure why the js I was working on wasn't working... then I looked at the generated HTML

Tell me, do you see the difference between the patch I submitted here and the commit aCiD2 actually did? ...and why the missing bits *might* break something :P

http://bugs.musicbrainz.org/changeset/11070 http://bugs.musicbrainz.org/attachment/ticket/4...

yeah

I'd ask aCiD2, I'm sure he can explain what crack he was on. :)

hello muz and brianfreud

subbing line 13 for his line 17, ok, but here's the difference in his output vs mine with the other changes

Hey Yllona.

hi Yllona

mine: <script type="text/javascript" src="/static/scripts/jquery/aqCookie.js"></script><script type="text/javascript" src="/static/scripts/jquery/sidebar.js"></script>

his: <script type="text/javascript" src="/static/scripts/jquery/aqCookie.js sidebar.js"></script>

His isn't loading the other JS file...

his isn't actually loading either - it's trying to load "<script type="aqCookie.js sidebar.js:" as a single file :P

TT fail, heh.

is this kind of mess better for me to repatch and resubmit, or to just... fudge on the server somehow?

I hear hitting aCiD2 round the back of the head works well.

lol

/msg memoserv msg aCiD2 U FAIL

If it's a 5 line fix or less, I'll commit it now.

Hi, I'm CPAN and I'm going to be SHITSLOW.

s/SHITSLOW/CPAN/

Muz: not quite 5 lines, but still smallish, but important :P http://bugs.musicbrainz.org/ticket/4458 <--acid2.patch :D

Argh, I wish trac would link into the repo.

ah wait, he changed one other thing, lemme fix the patch :P

ok, done :)

brianfreud: gimme an example page plz

example of it broken atm?

Want to test it on my server first before committing.

Yes.

ah

home page works - that file is loaded on every single page of the site

(main bootstrap layout and loader file)

What about one that has an extra JS file?

toss [% extra_js = [ "jquery/aqCookie.js sidebar.js" ] %] into the top of /root/layout/sidebar.tt

(the js code just went in yesterday, this would be the first time actually using that code)

That doesn't look right, it's meant to be an array right?

The line that was supposed to be put into sidebar.tt heh.