#musicbrainz

/

      • Enverex
        Am I missing something or is there no "STOP" option in Picard?
      • brianfreud
        there is no STOP option in Picard ;
      • navap
        Theres a little X somewhere on the top right I think :p
      • Enverex
        Well it's currently scanning 5000 files I hand-picked from other locations, I need it to stop, I can't afford to start again
      • CStan joined the channel
      • navap
        5000 files...why..
      • xlotlu
        because it never said "are you sure you want to fingerprint 5000 files? this will take hours"
      • Enverex
        Actually it's not that, I think it's bugged out, it's scanning files but nothing is changing in the right hand window
      • CStan has left the channel
      • xlotlu
        Enverex: then rejoice. you can afford to start again..
      • Enverex
        Your comment doesn't make sense
      • chefkoch has quit
      • navap
        If something has bugged out, you have to start over anyway. So rejoice, it doesn't matter.
      • brianfreud
        ok, fixed now
      • Enverex
        Why would I rejoice? That's like saying "Hey, you've got aids, rejoice!".
      • It seems to be fingerprinting files but not actually looking them up. Anyone seen that behaviour before?
      • navap
        Not at all, it's like saying that you found out you have aids while laying in bed with a terminal illness, but lets not dwell on this subject.
      • nikki
        are you sure it's not that it just can't find any matches?
      • navap
        Maybe this is related to that 10 in 11 seconds..or 11 in 10 seconds thing.
      • Enverex
        No, I lost network connection part the way through and since reconnecting it's just not trying. I've seen it happen before
      • the_p has quit
      • gioele joined the channel
      • Freso has quit
      • futilius joined the channel
      • RifRaf
        outsidecontext you about? still having no luck trying to use an original year tag in scripting
      • the tag does show up in details when checking a recognised track and can use it for filenaming ok
      • outsidecontext
        rifraf: sorry, i did not look at it today :)
      • :(
      • you tagger script looked good on a quick look. i wanted to take a look at your plugin.
      • RifRaf
        no worries, am thinkin maybe just to let picard do the taggin and use mp3tag for the manipulation afterwards
      • sure, if you wanna try the plugin will help get it setup for you so you can test some files
      • Enverex has quit
      • outsidecontext
        it shoul be easy enough
      • what local time do you have right now?
      • RifRaf
        9:18am
      • its Australia Day , \o/
      • gioele has quit
      • outsidecontext
        :) oh, you are from tomorrow
      • RifRaf
        yep
      • you have a link for the modified plugin still?
      • outsidecontext
      • RifRaf
        yeah, the zipfile link is probly easier than copying the code from the webpage
      • outsidecontext
        it's all in the modified last.fm plugin, right?
      • RifRaf
        yep replace the existing files if you already had it installed
      • outsidecontext
        already have it installed :)
      • but i think i know what's the problem
      • RifRaf
        ok, so overwrite, and when you open picard you should see all the new options, defaults should work
      • ceu joined the channel
      • outsidecontext
        you are loading data from last.fm and based on that you set the originalyear
      • RifRaf
        yep
      • its amazing how accurate it is in most cases
      • creature
        Wait, you're using Last.fm's data on when the original release year was?
      • RifRaf
        yes
      • creature
        I would not trust that data further than I would frisbee a walrus.
      • RifRaf
        test some files
      • ceu
        hi
      • creature
        It is getting better, but it is still far from accurate.
      • outsidecontext
        just a guess: the data loading is run asynchronously, so it's possibly not available when the tagger script is executed
      • RifRaf
        creature sorting chronologically is so much better than using the release date
      • its gives a weighted date based on years found for all tracks on album
      • creature
        RifRaf: I haven't been following the details of what you're doing, but a lot of the Last.fm 'release date' data is based on when the album was uploaded, rather than when it was actually released. So you may be getting duff data.
      • ceu
        is there a way to precompile the new release form with the titles of a bunch of mp3 files?
      • (I would like to have that when the release isn't available in freedb)
      • outsidecontext
        rifraf: yes, that's it. the variables are not yet available when the script is run :(
      • RifRaf
        outsidecontext hrm i thought it may be that, only the main picard tags are available but not plugin tags?
      • outsidecontext
        depends on the plugin
      • RifRaf
        ok let me try with genre
      • outsidecontext
        a simple plugin setting some variable from locally available data will work as expected
      • but if the plugin does some http lookup, which is normally run asynchronously, you can't rely on the data being available in the script
      • couldn't you do everything you try to do with tagger script do inside your plugin?
      • RifRaf
        yep. something like $copy(subtitle,date) does work but even $copy(subtitle,genre) will not work :(
      • outsidecontext yep guess will have to try do that
      • outsidecontext
        as expected
      • you should be able to set the date tag to the earlier date inside the plugin
      • RifRaf
        it didn't seem to like being changed when i tryed earlier
      • its ok, mp3tag does the job pretty quickly and lets me see what files have no date or original year tag in bulk
      • and then at least the plugin does not mess with any of picard tags such as the correct release date
      • outsidecontext
        rifraf: i just noticed that date is a special case, you can't easily change it from inside the plugin or the tagger script
      • RifRaf
        heh, kinda wat i discovered :)
      • outsidecontext
        that is tagger script should work in the latest picard release. just for the fun of it you could try switching the release event from the context menu bonce the album is loaded
      • that should trigger your tagger script again, this time with the variables set
      • RifRaf
        by right clicking album and going to Releases? i see just the one release ticked
      • outsidecontext
        rifraf: that would of course only work for albums with more then one event
      • RifRaf
        oh more on some, never even noticed this before
      • outsidecontext
        bu sorry. that was not in the last release, will be in the next
      • RifRaf
        k, it loading the album again when i change it
      • outsidecontext
        problem is, that applying the release event will always overwrite your changes to the date tag
      • that's whats happens and why you have no chance of changing the date
      • RifRaf
        could an original year tag be put into a future version of picard so that its just there?
      • outsidecontext
        i'll have to ask luks about that
      • wait, inside the plugin you should be able to change the release events :)
      • in your _tags_finalize you get the album object
      • RifRaf
        am writting it as ~id3:TXXX:ORIGYEAR am is seen properly in other programs that support original year
      • outsidecontext
        there should be an array album.release_events. try changing the date there
      • RifRaf
        not sure it its the ~ or what but do not see that tag in details even though it is written to the mp3 files
      • outsidecontext
        yes, it's the ~. those tags are hidden in the UI
      • RifRaf
        but without it the tag does not show up in other programs, just stumbled on that yesterday from some other plugin in the forum
      • symphonick has quit
      • outsidecontext
        rifraf: yes, it's the only way to get the tag straight into id3 tags without changing something in picard :)
      • can you open a feature request for this on http://bugs.musicbrainz.org/ ?
      • RifRaf
        ok
      • outsidecontext
        rifraf: something like http://pastebin.ca/1318006 should work in your plugin. just set something usefull as the date
      • Tykling has left the channel
      • RifRaf
        outsidecontext did you try the plugin out on some files yet? interested to see what others think of the tags its adding
      • outsidecontext
        no, i did not really try it. just looked at the relevant parts for the problem
      • but it has quite some functionality
      • RifRaf
        yep chops and dices lasts.fms tags up and then sorts them pretty well
      • outsidecontext
        you win the "Picard plugin with the most functionality" price
      • yes, the tags can be pretty useless sometimes
      • RifRaf
        lol, i am not responsible for it all, was a team effort
      • outsidecontext
        i personally completely switched to the tagging of MB. there i can set the tags i want and because there are not yet many tags nobody interferes :)
      • CatCat
        natta!
      • outsidecontext
        natta catcat
      • ok rifraf, i'm off for today. have a nice day and good luck with the plugin
      • RifRaf
        ok cheers, thanks for the help, stops me beating my head against a brick wall
      • outsidecontext
        glad to hear :) cu
      • outsidecontext has quit
      • aCiD2
        ruaok: do you have any objects to me writing some basic unit tests?
      • i want to write some that do things like $artist->create, just to make sure thye don't blow up when given valid data
      • ceu has left the channel
      • xlotlu has quit
      • Star_Fruit has quit
      • xlotlu joined the channel
      • alastairp
        aCiD2: and it blows up correctly when given invalid data?
      • nikki
        I should it doesn't blow up at all :P
      • +hope
      • aCiD2
        alastairp: I just want the valid data tests for now, but ideally, yes :)
      • xlotlu has quit
      • ruaok
        aCiD2: no, not at all.
      • aCiD2
        cool
      • xlotlu joined the channel
      • ah gay
      • our Sqlobject won't let me do a nested transaction
      • ruaok
        does postgres allow that?
      • aCiD2
        no
      • but with dbix::class, it doesn't die if you try it, it's just a noop on begin, and one rollback kills everything
      • so I was doing my unit tests by surrounding everything in a transaction, and rolling back at the end of the test
      • never mind!