#musicbrainz

/

      • luks
        mb_release_type/status, I think
      • nikki
        ah! thanks :)
      • Wizzcat
        brianfreud: I wouldn't mind having presets, but I doubt most users would save much since they're not nearly as efficient as people in here
      • personally I think I could save a truckload more time from inline editing, but god knows that's never happening :p
      • (unless I grease it myself)
      • luks
        I think that's happening this summer
      • VxJasonxV^Q joined the channel
      • pronik
        luks: do we have your word on it? ;)
      • luks
        yes
      • brianfreud
        Wizzcat: I'd put in an option for it, but then we start to have options again.
      • brianfreud throws out all that code
      • sorr, but I admit, I am getting frustrated.
      • *sorry
      • kurros has quit
      • aCiD2
        don't throw it out, it should be on a branch of it's own, so just incubate
      • brianfreud
        To be honest, why bother? It'd become a branch like the flags branch - code that just rots, as there's seemingly no support for even trying it on a playground.
      • Which reminds me, I need to move all the image resizer code out from the flags branch.
      • aCiD2
        code in git doesn't rot
      • just rebase it
      • maybe it will never get accepted then throw it away...
      • I personally don't throw stuff away though
      • brianfreud
        Ok, I'll toss it in a text file somewhere.
      • czaanja has quit
      • czaanja1 joined the channel
      • I'm just getting frustrated.
      • aCiD2
        maybe you should take a break then
      • i step away when I get frustrated :)
      • outsidecontext has quit
      • brianfreud
        I'm not frustrated with the project. I'm frustrated that there seems to be no openness to trying anything new.
      • pronik
        brianfreud: I am a big friend of new stuff, but sorry, presets is more hassle than it's worth.
      • Don't mean to discourage you though
      • brianfreud
        well, if anyone has ideas for things they think might actually not be met with dislike, put in a ticket. Right now, there's next to no js enhancement reqs: http://bugs.musicbrainz.org/query?status=new&am...
      • (but a ton of server ones)
      • kurros joined the channel
      • brianfreud has quit
      • brianfreud joined the channel
      • Wizzcat would love flags in REs :(
      • unfortunately, it didn't seem most agreed
      • Wizzcat
        well there's the whole flags for disputed territories thing, but beyond that
      • luks
        it didn't?
      • Om joined the channel
      • brianfreud
        that was the sense I got, whether it was done my way (or better) your way
      • navap really liked the flags, it added a slight bit of colour to an otherwise purple and orange site. ;)
      • if it does actually have support, I'd happily change that branch to do it your way luks
      • navap isn't saying purple/orange is bad, just that little flags are good. o/
      • aCiD2 puts the ban hammer down
      • aCiD2
        close navap, close
      • :P
      • nikki
        navap: are you colour-blind? the site is rainbow! :P
      • navap
        Well, if you're wearing a funky pair of 3d goggles, where one eye is purple, and the other eye is orange - then yeah! It's a rainbow :p
      • nikki
        there's yellow and blue and pink and beige and brown and green and red!
      • pronik
        I actually liked the flags, but I remember the Debian Taiwan controversy all too good....
      • nikki
        oh?
      • pronik
        and the case with a nazi flag is also an issue, but otherwise...
      • brianfreud
        the nzai flag was removed early on
      • *nazi
      • pronik
      • brianfreud
        personally, I would still want to see it, on applicable releases, for trivia reasons, but I can very easily understand why not to show it.
      • pronik
        just don't make it an option ;)
      • Wizzcat
        hide disputed flags, done :)
      • brianfreud
        aCiD2: I know you were merging the ES branch - let me know when that's done, so I can close all the relevant tickets?
      • aCiD2
        I have merged it, but I was waiting on that missing js, guess that's all done?
      • if so, I'll merge, push a branch out to test, and you can make sure everything looks good
      • sound ok?
      • brianfreud
        yes, it's merged, as is a tiny 1 line fix to remove the name attr issue you caught
      • aCiD2
        and I was missing bgiframe or whatever
      • brianfreud
        *pushed, I mean
      • yup, both should be on github.
      • aCiD2
        great
      • pronik
        brianfreud: could you raise the flag problem once again on the ML so we can actually decide on that one? We already call Taiwan a country (just like Debian) so I guess we'll have to live with that...
      • VxJasonxV^Q has quit
      • brianfreud
        yeah
      • nikki idly notes that google is happy to use the taiwanese flag for their link to google.com.tw :P
      • pronik
        aCiD2: so tomorrow it's all on test? nice :)
      • aCiD2
        or tonight :)
      • pronik
        I'll be in bed soon
      • aCiD2
        I'm just putting the final touches to all the edit/add release templates and then will merge
      • ah, ok
      • nikki
        and apparently mainland china complained when taiwan was thinking about changing their flag o_O
      • kurros
        no yuo!
      • aCiD2
        I have /only/ just worked out that was a typo of you
      • slow day is slow
      • czaanja1 has quit
      • Sargun joined the channel
      • pbryan has quit
      • brianfreud
        aCiD2: Is there any way Add URL AR pages could give a hint as to which type of URL-foo page it is?
      • aCiD2
        as in what foo is?
      • brianfreud
        yes
      • pbryan joined the channel
      • the old code worked just by matching on URL AR text in the <option> to pick the right AR
      • that works for, say, ASIN, or Discogs, but "has cover art at" would break in i18n
      • aCiD2
        Hrm, relate to url shows the artist header
      • so can't you just check for entity.entity_type?
      • brianfreud
        better to hard code the value #'s, rather than match on text in the type descriptions
      • aCiD2
        or have I misunderstood you
      • brianfreud
        I can't check entity.anything in the js - that's on the perl end
      • aCiD2
        oh, right
      • where do you want it?
      • brianfreud
        but even just a <!-- entitytype --> comment hidden somewhere would help
      • aCiD2
        hidden input?
      • nikki
        doesn't the form have the ids in it?
      • brianfreud
        however you want
      • aCiD2
        <input type="hidden" name="source-type" value="artist" /> sound ok?
      • brianfreud
        nikki: no, right now, it's the same identical form (save for the select's options/value) I think
      • aCiD2: sure, though you don't even have to bloat the code by that many bytes if you don't want
      • I can read in an html comment, if that's smaller for you
      • aCiD2
        i'd rather be clear and verbose than hacky
      • brianfreud
        sure, however you want :)
      • aCiD2
        you need it now?
      • brianfreud
        soonish, but doesn't have to be right this minute
      • would be nicer if ASIN (or whatever the AR is) was always the same value, no matter the foo type, but I know that's not the case
      • aCiD2
        pushed
      • yea, that's not possibly saddly
      • brianfreud
        thanks :)
      • hmm, think that'd be something worth doing, long term, in the schema-change branch?
      • aCiD2
        I don't think it has any real implications for server side code
      • as is
      • brianfreud
        well, the implication would be the different codebase having new values for AR values - it would have to happen at a time we didn't have both old and new code working on the same dataset
      • pbryan has quit
      • cool, this'll work :)
      • pbryan joined the channel
      • Kerensky97 has left the channel
      • Anyone know where URL AR values are stored? The new three haven't made it in to the tt code yet
      • nikki
        hm?
      • the link text and stuff?
      • brianfreud
        the definition itself
      • nikki
        lt_album_url, lt_track_url, etc
      • aCiD2
        I thought that was all in the database
      • nikki
        yeah
      • brianfreud
        YouTube, IoBDb, and IBdb aren't in the list atm, on tt
      • nikki
        then the database is out of date
      • brianfreud
        unless it's my dump missing them, and not something hard-coded?
      • nikki
        it's not hardcoded, there are edits for them
      • brianfreud
        ah
      • nikki
        so your dump is from before those edits were made
      • brianfreud
        didn't realize they were edited in
      • aCiD2: Is not showing the AR descriptions, or the AR target, on purpose?
      • aCiD2
        just cause I didn't do it
      • brianfreud
        ah
      • aCiD2
        so far
      • brianfreud
        want a task?
      • aCiD2
        hrm
      • no, I'll try and do it tomorrow
      • brianfreud
        k