#musicbrainz

MBS-9834: Make converting "･･･" to "⋯" an autoedit

Do people think that seems sensible? It seems to me, but then, I've never entered or seen "･･･"

We need one to make converting "’" to "'" an autofailededit.

hmm, maybe ok, but imo there's no real reason for that to be an autoedit? normal edit seems fine. Note that in a japanese fixed-width font the two are easily distinguishable, the first is 3 glyphs wide, the second is a single glyph wide, and there's sometimes stylistic reasons to choose one over the other.

kepstin: the main question is "is it equivalent to an ellipsis and as such should it be trivial to switch among them"

my answer is "not always, and imo fewer things should be trivial to switch between"

･･･ is sometimes extended to do not-multiples-of-3 as well, see https://musicbrainz.org/search?query=%EF%BD%A5%...

although multiples of 3 are usual

but yeah, 「何とか・・・」 vs 「何とか⋯」 hmm…

(i threw them in with some japanese text there so hopefully you'll get the correct glyph widths in fonts)

That's wide :D

(the first, the second shows non-wide, dunno if it's meant to be)

second is the single glyph, it's supposed to the same width as a japanese glyph

the first should be the same width as 3 japanese glyphs

Oh, ok. That seems right then

the separate middle-dots almost feel like you're pausing for a beat for each dot, rather than just trailing off (and if they're in the middle of text, that's more or less how they'd be read)

[20:03] <kepstin> (I'd also like to be able to turn off the default automatic join phrase thing that adds "," and "&" too, fwiw) this

I like the idea to have a checkbox for automatic/not adding for spaces around join phrases like kepstin suggested

one tricky thing with that is that you don't want it adding extra spaces when editing existing artist credits that were purposefully made ignoring the automatic spacing rules.

good point!

very good

it should only triggerr upon pressing the "+" whne adding new

so you'd have to do something like on loading the artist credit: do all join phrases match the spacing rules? if yes, then enable automatic spacing by default, if no then disable automatic spacing by default to avoid adding extra spaces.

do all existing join phrases*

I'd figure automatic spacing would noyl trigger one you create a new joinphrase, like when adding a new person to an artist credit

ore whne adding a new release

(so all AC are new)

the problem we're having is when someone edits a join phrase, e.g. they change a " & " to "feat." and forget the spaces

I'd never except it to actually interact with already-excisting-artist-credits

yes

which can happen on existing credits, not just new ones

well to me i have the problem that it's a pita to remember to add those spaces yes

hm

Perhaps a "preview" of what the AC will look like?

That should make it easy to spot things like missing spaces.

Similar to the way Picard provides a preview to your file naming script.

there already is a preview

(at the top, so when editing a long AC you have to scroll back up, but it's visible in most cases)

That is something I've never noticed before. Oops... ;-)

yeah, making it more prominent could help. i dunno how you'd do that - make it bigger? put a box around it? :/

that's also the only place where you can click an artist link to check if you have the correct artist selected

Could it be attached to the individual line being edited, either showing up just above or just below the editing section for that track?

I don't know whether that would be worth the effort.

this only applies to the pop-out artist credit editor, if you're using the inline field then you can only do a single artist, so there's no need to preview spacing

having it stand out wouldn maybe be a good idea actually

I use it as kepstin to chekc the correct artist

It's kind of an education thing. Now that I know about it, I will notice it every time.

exactly

New auto-editor election: https://musicbrainz.org/election/320 Thread: https://community.metabrainz.org/t/521393

https://www.kepstin.ca/dump/Screenshot_2021-02-... ? :)

make the preview bigger, move the help text to the bottom so it's not visual noise together with the preview

That actually makes it clearer for me. I think I was mentally dismissing it because it showed the track title, and the artist seemed to be of lesser importance. Then again, maybe I'm just trying to rationalize why I missed it in the first place. ;-)

chaban: yay, more work for me! :p jk, mails on their way

Huh… so it looks like iq500 added some stuff, then tried to delete or modify it. The open edits may not be as bad as they seem…

Probably one of those "I want to get rid of anything I ever added" users. Not wrong per se, but certainly not by overwriting it with weird stuff :)

Or maybe the original adds were spurious, just messing around… unclear.

https://musicbrainz.org/artist/d72ed96f-a339-4d... Looks like fantasy

chaban: yeah, it seems to be totally made up

'Windows All-Stars is group made of released Windows versions.'

WTF: https://musicbrainz.org/edit/77621229

... indeed

reosarevok: "feat." is not kanji, so spaces are fine around it

though in fullwidth world the space will be only in front of the "f" because punctuation is already a delimiter. like, " feat."

reosarevok: 2nd seconder found :)