It's almost as if OGG Vorbis is a terrible terrible terrible file format.
2011-08-21 23351, 2011
kepstin
vorbis is fine, it's just the ogg ;)
2011-08-21 23321, 2011
kepstin
I guess they just didn't bother to put support for padding into the format?
2011-08-21 23348, 2011
kepstin
huh, it looks like there are some patches to some tools to use padding in the comments.
2011-08-21 23334, 2011
kepstin
there's an annoying thing with the flac tag writer in picard - if it thinks there's /too much/ padding for the comments in a flac file, it'll rewrite the flac file to reduce the padding.
2011-08-21 23359, 2011
kepstin
and the amount of padding that the flac encoder includes by default is above the limit that picard has :/
2011-08-21 23314, 2011
kepstin
so picard completely rewrites every freshly encoded flac I tag with it :(
2011-08-21 23332, 2011
nikki
enter a ticket then :P
2011-08-21 23358, 2011
kepstin should probably file a bug for that, but it's more likely a mutagen issue than in picard directly?
2011-08-21 23332, 2011
nikki
bitmap would probably know
2011-08-21 23343, 2011
nikki
or luks, but he's probably asleep
2011-08-21 23307, 2011
jacobbrett joined the channel
2011-08-21 23333, 2011
jacobbrett joined the channel
2011-08-21 23349, 2011
jacobbrett joined the channel
2011-08-21 23313, 2011
ianmcorvidae
kepstin-laptop: perhaps http://mutagen.sourcearchive.com/documentation/1.… or so is to blame? It's not supposed to change the size of PADDING blocks but perhaps the way picard's writing tags results in multiple blocks that then must be merged?
2011-08-21 23335, 2011
kepstin-laptop
ianmcorvidae: I dunno, but the flac encoder writes 8kb of padding by default, and mutagen always reduces that to 1kb or less padding (after tag writing)
I thought that _load maybe wasn't reading in padding but I was wrong
2011-08-21 23316, 2011
ianmcorvidae
meh, probably better to just ask luks/bitmap later, I don't know this codebase :)
2011-08-21 23309, 2011
kepstin-laptop
heh
2011-08-21 23320, 2011
kepstin-laptop has been looking at it, but nothing's jumping out
2011-08-21 23357, 2011
kepstin-laptop
it looks like there shouldn't ever be a case where it makes the header section smaller, there simply isn't code to do that
2011-08-21 23338, 2011
kepstin-laptop
it has code to handle the existing space in the header being too small, that's what the call to insert_bytes on line 674 is for.
2011-08-21 23352, 2011
kepstin-laptop
so the code path should be, given a simple example of "old vorbiscomment=1kb old padding=7kb", doing an update that causes new vorbiscomment=2kb, it should add 1kb padding to the end, giving 2kb comment + 8kb padding, notice that that's over the available space, and cut the padding down to 6kb.
2011-08-21 23349, 2011
ianmcorvidae
yeah :/\
2011-08-21 23304, 2011
ianmcorvidae
possibly would be worth going through this at the python command-line with mutagen
2011-08-21 23320, 2011
kepstin-laptop
yeah.
2011-08-21 23338, 2011
kepstin-laptop
there is literally no place in flac.py that could cause the flac file to get smaller
2011-08-21 23339, 2011
ianmcorvidae
at least isolate the problem to mutagen vs. picard, since we've been assuming mutagen but it looks like mutagen is clean
2011-08-21 23304, 2011
kepstin-laptop
the insert_bytes() function will give an assertion failure if passed a negative number, and there's no call to delete_bytes
Could an auto-editor expediate this process somehow? Either by first accepting the merge before the track list change, or by accepting the track list change before the merge?
2011-08-21 23301, 2011
nikki
auto-editors can only accept things they can auto-edit themselves, so not merges
2011-08-21 23321, 2011
nikki
the latter should work though
2011-08-21 23339, 2011
cosares
I'll give it a go, and post the edit here
2011-08-21 23309, 2011
nikki
they should probably be fixed first anyway, since otherwise merging will merge the wrong recordings
2011-08-21 23320, 2011
cosares
Do I have to rename the tracks (and swap recordings) or is there a re-order tracks option?
2011-08-21 23359, 2011
reosarevok
cosares, in the advanced traclist, just change the track numbers
