#musicbrainz

the latter being the most common approach, and the one used by cpan modules etc

I'd like to keep the types in MusicBrainz::Entity::Types, since they won't cover other classes

MusicBrainz::Entity::Types then, heh

hmm, what do I need to do to be able to use 'subtype'

just 'use Moose' doesn't seem enough

have you used Moose::Util::TypeConstraints?

that's where subtype and class_type are

thanks

heh, now the types are short, I'm tempted to put the has commands back to a single line

Heh, did you know you can have multiple attributes to one has?

has [qw/foo bar/] => ( ... )

if we're sure we won't need to put extra constraints on attributes like traits, metaclasses, whatever - then just stick them on one line

I've seen it in your example from the mail first time

I just expand them from personal prepreference

prepreference? preference*

the only reason I like them on one line is because I can see more of them

I'm spoilt by a huge screen and good eye sight :)

heh

that and I use folding

hmm

would be nice if the Collection::Array metaclass, when using provides => { push => 'add_stuff' }, automatically called the item class constructor if I pass it just a plain hash

What do you mean, pass it a hash?

$artist_credit->add_name(MusicBrainz::Server::Entity::ArtistCreditName->new(name => 'Artist 1', join_phrase => ', '));

vs

$artist_credit->add_name(name => 'Artist 1', join_phrase => ', ');

Ah

it knows the item has to be MusicBrainz::Server::Entity::ArtistCreditName

You could use coercion to get that

corce 'Whatever' => from 'HashRef' => via { Foo->new{$_) }

yeah, but the metaclass could handle that automatically

yea

i agree

but I think add can take a list, so it wouldn't know whether you give it a hash or a list of items

oh, right

aCiD2: do you know where is Catalyst::Plugin::Cache used?

No, ruaok added that

I'd guess somewhere in the web service

but I'm not sure where

ok, time to read diffs then

:)

from what I can see, it isn't used anywhere

Nope, I can't find any references to $c->cache either

do you want to remove it?

I don't know yet, I'd like to not make cache dependant on catalyst

yea, i agree with that

but if the plugin does somethign useful, we might want to keep it

what I wanted was to make some kind of Context object, with access to the database and cache, which can by used by tests and console scripts

something that maintains handles?

and MusicBrainz::Server would inherit this, to make it available to the catalyst context too

yes

mmm, I can't see any other way to do, and to get testing working easily too

luks: for completion (and mainly as an exercise for myself :)) I tried writing what I meant by using roles and traits for caching: http://gist.github.com/98016

like I said, just there for completeness sake, was fun to write :)

damnit, why is emacs using tabs >.>

aCiD2: one problem with the code is that it's not easily testable

aCiD2: unit testing should test the simplest possible units

aCiD2: so you should have tests for loading from the database, loading from the cache, serialization/deserialization

and all these should be independant

Is this Jive or Zomba? http://trhosking.com/~tim/albumart/00_Untagged/...

I'd say Jive

That's what I thought, but I saw the existing RE on http://musicbrainz.org/release/bf594062-27f5-45... and suspect that should be changed as well. Barcode seems to concur

luks: hrm, actually i'd argue it is *more* testable. If you want to make sure the right cache keys are set, make a mock using 'with CacheAccessor' and a mock cache implementation (provide from/to_cache)

but I haven't tried, so I'm most likely talking nonsense :)

aCiD2: how are you going to test the path of Artist::load which is loading directly from the database?

Give a mock cache implementation that returns undef, so it won't use the cache?

how do you give it a mock cache implementation?

oh right, heh

how do you do it in yours?

it's easier to have Artist class which only works with the database

no cache involved

Oh, well I wasn't sure where you added the caching layer

then you have a subclass, which caches te requests

*the

So we have 2 storage classes and an entity class for every entity?

no, not every entity is cacheable

ah, right

and the second caching wrappers will look like: package CachedEntity; extends 'Entity'; with 'CacheMixing';

-g

Well it would be pretty easy to take the caching out of artist, seeing as it is all in a role anyway. but I need to do revision instead, bah

chefkoch is now known as chefkoch_AW

good morning MB :)

everyone sleeping?

no

hi nikki!

hey

I'm doing a cool project on cd sales projections

and was hoping to get some suggestions from the MB folks :)

what sort of suggestions?

I'm looking for interesting factors which we think do or don't affect CD sales

the exchange rate

for me at least :P

:)

well I'm comparing things to Canadian CD sales... so I could do the US exchange rate

So far, I've got per capita income, iTunes sales, Mininova downloads

will be adding in Other Format sales (substitutes)

I wonder how places like amazon deal with the exchange rates for usa/canada... I mean, for british people they're not going to go look at .fr or .de for something cheaper 'cause they're not in english, and .com would involve quite slow/expensive shipping in comparison to .uk

How do I get a list of albums? I tried using this query, but then I got a list that includes singles

SELECT DISTINCT name FROM album WHERE artist IN(SELECT id FROM artist WHERE name='Britney Spears');

There's a table which stores whether it's an album or a single.

fuppp: you'll probably want to add a condition for what type of album you want (I assume the ALBUM table is actually the table for all "releases

WHERE 1 = ANY(attributes[2:4]) AND artist IN (...)

hey luks!

hi

I was wondering about my question yesterday (selecting just one release event per album)... you mentioned doing subquery in the select or something... do you have any examples of those?

ah thanks, seems like that works :)

select (select date from release_events where album_id = album.album_id limit 1) as pony, album_id from album?

hmm

FauxFaux: what, PHPpgadmin?

+ ORDER BY releasedate

but yes, that's the one

Muz: s/php// yes. :p

Haha

I've written some kind of aggregate function, where you can do SELECT id, min_2(releasedate, barcode), min_2(releasedate, label) FROM album, release GROUP BY album.id

but I couldn't make it work with any data type

:o

it works :D

thanks luks and FauxFaux :D

Ooops

hm, what are the guidelines to add a compiltioan track with "artist1 presents artist2"? It is not like feature and it is not a collaboration ...