#musicbrainz

but a product that works and is engineered well

which is more important than an over optomized product

and is much larger/slower/more bandwidth consuming than need be

pros of clean code outweigh the cost of ott optomization

i'm not getting into this discussion now

some optimizations, sure. But something like hard coding, rather than using the tag that's designed for exactly what you're hard coding around... that's just over-engineering around a non-problem

it's not hard coding

it's using what the tools are designed to do

and for catalyst, that means you use c.uri_for, c.req.uri_with, and friends

it's adding a macro function to convert all relative links into absolute links, rather than using the XHTML tag that does the exact same thing, but smaller, without any function calls, and with more flexibility for the end user who saves it locally.

file a ticket

all i have left to say

sigh...

but doing things like this now when we have so much more pressing issues is wasting my time

to put it bluntly

yes, they are important, the sites functionality is far more though

I didn't say you should change it. I asked why you did it that way. There's a difference. :)

Sure, and I said because that's how Catalyst does it

and then you sighed when I said file a ticket :P

Ticket is filed. But towards your point, Catalyst is only doing it because we've got it written in the templates to do it that way.

I agree - premature optimizations = problems. The JS, apart from JQuery, you'll note, isn't compressed yet, it's raw source.

But there's premature optimizations, and optimizations that simply happen due to design decisions. I just am keeping my eyes open for the latter type.

ok, I've applied all the changes I'm going to from capscon branch

so you can delete that when you wnt

I'll wait til I compare with what got merged, same for the others :)

now what then is the best way to do this? ie, make a clean master from yours, then compare the checkouts with it?

yup, you'll have to

git fetch acid2

then `git checkout -b new-master acid2/master`

I believe

but I haven't pushed yet

so don't do that :P

heh, sorry

doh, just did :P

git checkout master

git branch -d new-master

:)

then do it when I push, should be after this svn commit

k

and I gotta head to bed now, so no add release for another day

sigh

np

pushed new master out

just looking through, I don't think you actually got the last of CapsConsistency - seeing some mid-point changes, not final

l('Auto-Editor'), not l('AutoEditor'), etc

oh, looking at the wrong commit of the two

can I get the releaseDate from a release-list ?

yup

the default release-list return returns release-event-lists for each release

RFC: YouTubeRelationshipType wiki page http://lists.musicbrainz.org/pipermail/musicbra...

voiceinsideyou: i'm not seeing it: http://musicbrainz.org/ws/1/artist/66c662b6-6e2...

anyone know how i should use this? http://bugs.musicbrainz.org/attachment/ticket/4...

RifRaf: just execute it.

chovy: that's because you're using an artist query rather than a release collection query. For artist query, you need to tell it to include them specifically (+release-events)

RifRaf: i.e. ensure you have Python installed, then "python filesystem_encoding.py"

chovy in windows, voiceinsideyou so its independant of picard, and no mp3 filename needs to be given?

gonna try on linux box, will likely just work then

no, all it does is print out your file system's default encoding, it would seem

ah ok, so doing it on another box would defeat the purpose

voiceinsideyou: thanks

RifRaf: yes :D

k, at least on the linux box i get ISO-8859-1 as a result

hrm i get mbcs on the windows xp machine

seems to be normal, others are the same

yay! Just got that second bit of code converted from an Apache license to GPL MIT dual :)

RifRaf: yep, it seems fine

do you have specific examples of the problem files?

Does it actually say somewhere in the docs, that an ASIN is for matching the same album? All I maeout is that the sole purpose of ASIN ARs is to display coverart.

makeout*

Although the parent doc on AffiliateRelationshipClass does state, "Each record in the MusicBrainz database should be linked to the corresponding record in the other database." but I still don't see anything definitive.

I find it annoying if a "deluxe edition" points to the non-deluxe ASIN or the other way around, e.g.

do it's not just for coverart

if there are multiple releases i'd rather the ASIN be to the correct one even if it doesnt have cover art or something, but thats me.

s/do/so/

Well, I totally agree, I belive an ASIN should be the matching release, and I usually match via barcode.

but if its just one result with no track listing to verify or whatever, i'm fine with that

But, how do vote down an edit if I don't have any "proof" :p

dunno how other voters are

barcode should be proof enough as you can search by barcode on amazon

From what I can make out, http://musicbrainz.org/show/release/?releaseid=... should NOT be linked to http://www.amazon.co.uk/gp/product/B0000FJRZO because the 13th track (Let Go) is missing. Track 13-15 on Amazon is actually the dvd listing.

But since it is (I think) the correct cover art, how would I backup my no vote.

That ASIN, I think, should belong to a different mb listing. But should it be linked to both? :/

"Not the same track listing, voting no."

Where does it say that it has to be the same track listing?

I just did.

;)

As fas as the guidelines say, ASINs are for cover art purposes.

http://www.amazon.com/gp/product/B0000FJRZO has only one extra track

err, one track less

In reality, it's a link to Amazon. Even if we use it for cover art, I think it's not altogether far-fetched for the user to think you can actually purchase the linked release from that URL.

Yes, as I said track 13-15 on co.uk are actually the dvds listing.

navap: if you explained that in the edit, I think the edit is fine

"This relationship type can be used to link a MusicBrainz release to the equivalent entry in Amazon." not same tracklist --> not "equivalent entry"

if you can purchase that exact mb release under that ASIN...

the track listing is often wrong anyway

voiceinsideyou: Yes, but it's not very clear, as the kext line says "This allows users to link to the Amazon pages to show the right cover art"

I agree it's not very clear. Submit an RFC :p

And it's up to the editor who makes the AR to prove that the track listing in Amazon is wrong.

If I see an ASIN AR that has different track listing to the MB release and nothing explaining that, I'll vote no. It's as simple as that.

Yes, as would I, but I actually thought about it this time..and wondered what basis I was voting no for.

If the AR is meant only for cover art, it should link to art, not the product page.

Well, one could argue that the more info the better. If mb can link to the art - why not also inclde the product info and earn a little money from Amazon at the same time.

MB does earn money off the little "Buy" links.

currently people don't base their vote on the cover art issue but check the track listing. So the guidelines don't match practice and should be changed imo

One could argue just about anything, true. But "more info" would imply there's actually some related info. And if the Amazon link isn't to the same release, that doesn't apply.

Well, all the Amazon links point to the same thing actually.

So what you're suggesting is that either the explanation of why we link to Amazon should be cleared up, or we should just link to the cover art like we would a normal Cover Art AR.

Or, well, I guess I'm suggesting it :p

Yeah. The reality is that Amazon AR supports multiple functions, so it should be more accurate than just having the same cover.

after all, the relationship says that the album has a particular asin, not that the album has the same cover as the album the asin belongs to ;)

I'm slowly writing an email to the ML about it, getting sidetracked a lot though :p

navap: quick, that tracklist tool I have for artists, go ensure your favourite artists all have consistant track names!

heh

creature_ is now known as creature

Muz: where is that anyway?

creature: you're a Guardian reader, when you get your copy, check out the back cover.

There's a Last.fm icon and small ad on a hooooge iPhone.

nikki: http://muz.goatse.co.uk/musicbrainz/artisttrack...

bah