#musicbrainz

What??

Grrr.

Lemme find the spot.

k

comp/entermods line 13

I wonder if there are mods that don't use comp/entermods

nope, that uses it.

did you see the nag message about entering your email addy before you added the mod?

The problem is that "email_nag" is false for new accounts.

At least, that's what I'm seeing.

that would cause this problem, yes.

Why not just use if (User->Current->GetEmail) (or something)

instead of testing email_nag?

the no-email warning was keyed off that, so I followed suit.

i.e.

should we change to that?

I think so.

Lemme hack it together.

sweet, thanks.

somniloquy is now known as somnolent

You know, I think the answer is to simply ditch the "email_nag" field altogether.

ok

My "fix" started out as adding a "has_confirmed_email" flag, which is just a cache of:

($user->GetEmail ? 1 : 0)

then I noticed that once I'd done that, email_nag was now totally unused!

So the only change is this:

previously, if you entered an email address (but the verification was pending), you didn't get nagged.

So I'm proposing that you do get nagged.

until the verification arrives.

Does that sound OK?

yes

ok, almost ready then

ok, all done

awesome.

ok, I'm all done with the release notes now. I've updated grunt.

its really taking shape now...

yeah - exciting :-)

I'll go fix your artist edit related issues later tonight

it's looking promising for a release at the weekend.

"never" approaches! :-D

lol

indeed!

Hell is feeling a bit... chilly!

So, it looks like I will be in the UK again.

May 4th - 9th.

I'm wondering if I should gather the brainzers back to Old Thamesside.

'twas a good evening.

Agreed !

g'night all