#musicbrainz

Let's hope the nag does its job. :-)

quickie comment re SetSession: either pass in $session (and do "tie %$session"), or don't pass it in (and substitute $session for $HTML::Mason::Commands::session)

also, why does it untie at the end? Surely that's your problem?

(Shirley)

No, its not...

The hash needs to get untied before the script ends so that apache can write the session back to disk.

Well (a) there's probably a "sync" call for that, and (b) Mason (at least) does the "untie" anyway when the request ends.

I don't get your quickie comment -- I am passing in session.

please elaborate.

$session is always going to be == \%HTML::Mason::Commands::Session, I think.

In fact, if it's not, the method won't work.

cos you tie() to one and write into the other.

ok, taking the tie out makes it work.

Its probably getting to be bed time...

Oh, maybe you need "tie if not already tied" ? One for later, perhaps.

I think all is well now.

Lemme check it in and put it on test.

Ok, its live on test.mb.org

looks good so far...

check your mail.

hacking perl is fun.

:-)

Got it. nice!

:-)

Now all I have to do is the note notification.

Cool.

One more thing: we should enforce a sane regex for moderator names

Do you think there is any chance you can warm up to releasing this tomorrow?

especially important since they're now being pasted into e-mail headers.

Yeha.

What regexp do you have in mind?

releasing this as in the e-mail stuff?

ya

something like /^\w+$/ but a bit looser. Allow _ . - etc.

Maybe. I dunno.

You've just got to be really careful if they're being pasted into headers, that's all.

e.g. having a mod name containing " < > @ could be bad.

:-)

if in doubt, be too strict.

I'll just look up the spec of allowable email name characters and go with that.

But that will have to wait until the am.

I'm beat.

Mmmm, not sure that's goint to help much.

The spec is really quite unreadable;

Urn.

but good luck, and good night anyway.

:-)

I'll just with what you said above. a-z0-9 . - _

Nite!

ruaok is now known as ruaok|sleep

Actually, here's the easy way:

just s/\W/?/ before pasting in.

ruaok|sleep is now known as ruaok

Cheating!

:-)

night!

ruaok is now known as ruaok|zzz

eikeon (~eikeon@jungle.ne.client2.attbi.com) has joined #musicbrainz

icepick-away is now known as icepick

icepick is now known as icepick-away

RJ (~RJj@host213-123-118-56.in-addr.btopenworld.com) has joined #musicbrainz

icepick-away is now known as icepick

wow, so I seriously recommend mp3check for anyone having 'TRM generation failed' or all 0's TRMs.

took the cases of TRM failure from 140 to 1 in a group of 1500

and that 1 is so small it might not be recognizable as mp3

djce (~davide@195.60.9.122) has joined #musicbrainz

maybe I'll build that tool in to my script.

I was hoping that one of the mp3 check programs would be LGPL

so that I could include that in HIP, my playback lib

but I don't think any of them are

?

what's LGPL?

mp3guessenc is LGPL... it guesses what encoder was used

LGPL vs. GPL I should ask

Library GPL, meaning you can make non-free programs that link to the library

oic

but if you change the library you have to release the changes

you should email the mp3check author - maybe he'd be interested

yes I think I'll try that

djce (~davide@195.60.9.122) has joined #musicbrainz

ruaok|zzz is now known as ruoak

Wow. over 20 emails in mb-user overnight.

Bust busy busy

(oh, so close! s/t/y)

btw be sure to "cvs update" your copy of UserStuff.pm before you do more work on it

time to do some voting... haven't done any for a while.

ok, I've updated UserStuff

Did you see Gavin's (?) suggestion that the new automod's old mods should be pushed through without voting?

I haven't looked yet, but sounds reasonable.

I was just about to do that by manually adding 10 to moderation.yes for each one, or something.

That sound ok?

sure. :-)

(easier than changing code :-)

damn near 1,000,000 tracks too...

Oh, I need to make sure ModBot doesn't show up in the top 10 moderators...

OK, automod's mods updated. And the modbot is /just/ about to run.

Couldn't have timed it better :-)

and is now. :-)

SPEW SPEW SPEW ERROR ERROR WHO'S BEEN DIDDLING MY DATA?????? :-)

that took over 1000 mods out...

indeed.

Presumably you fixed last night's (i.e. about 22 hours ago) ModBot error?

yup.

What was it this time?

artistalias_fk

deleted artist?

I don't recall, sorry...

Maybe whenever one (any?) of us steps in to relieve the ModBot of its pain, we should mail root@zim (so we all get it) to say what was wrong and how we fixed it.

ok, can do.

Presumably one can address root@musicbrainz.org from the outside world?

testing... hello?

yes

hello!

sure? OK, I won't test it then.

(sorry, that "testing" was me pretending to test mail to root@zim)

not sure, just pretty certain. :-)

(you ruined the joke by telling me it worked :-)

btw I think you need to "/nick ruaok" :-)

ruoak is now known as ruaok

So was it today - soon - we said we'd update zim?

Or do you want to put it off until your branch is more ready? i.e. ready?

1:45 from now was the agreed time.

I can go either way.

Are you planning on doing any more work in the next 1.45 ?

i.e. on the branch?

Depends.

What do you think was still to do?

If we want to push the email stuff out, I will go polish what necessary.

on the mail branch we need to at least do email notification when a mod gets a note posted.

half hour of work.

OTOH, we could release the trunk as it is now, and maybe release the mail branch early next week. Sunday even.

Or I could tinker with a few web service things needed for libtunepimp to work better than mb_tagger

That sounds pretty good, really.

Whenever. No particular reason not to do two releases close together.

Agreed. Let's go with your branch first, and then I will finish tinkering with the emailand webservice stuff later today

ok

or tomorrow and we'll plan a release sun/mon

what's the web service stuff btw?

taglookup needs to be smarter about looking for complications.

Oh, so changes to QS.pm etc?

yes.